Huh. Learn something new every day. I'm still scratching my head that the build I was using a few days ago, which wasn't changed all that much with regard to the Resurrection() function, worked for me, and now I'm with you guys -- except that I have to fix it. Seems I will be delaying Beta 1.01 for a short while until the addon behaves again.
I'm sorry for flagging a Beta that isn't working, whether or not it was working a few days ago. I will endeavour to do more testing.
I'm using the latest Beta of SmartRes2 and if I use the Auto-Res-Key to ressurect a groupmember there is only a chat message that everybody is alive and nothing happens. Am I missing something? There is no other error or something like that. I'm playing with the german client as a resto-druid or a holy paladin. The errorr happens on both chars.
Would adding version checking across party/raid be a useful or worthwhile feature? If yes, I would love to limit it to LibResComm-1.0 presence, but I don't think that can be done; it would have to limited to SmartRes2.
...
Or just trust in users' judgment for appropriate modern addons.
Again i don't think we need it. You shouldnt nail down people to use one specific addon, or even a rescomm compatible thing at all. A lot of Addons are compatible with ctra resmessage , vuhdo, healbot, ora gridresstatus and so on.
Its better to fix your stuff if theres something to fix instead of an unnecessary feature like this ;)
OK, this is based off Morgalm's code. http://pastey.net/133234 For Morgalm, please note my change on lines 1003/1004 because I'm guessing you had the sender and collisionsender backward.
I am not posting this as an Alpha yet, and would like some feedback and testing. The optimizations were mostly regarding the res bars options; I moved a lot of that into the user options section in the OnInit() because they were previously in at least two places. The original code is commented out so if something doesn't work, it can easily be switched back.
Just download the code from the pastey and overwrite SmartRes2.lua and post back results, please.
Several items were fixed in the latest Alpha. Still to do: Rebirth checking, fix colourization of test bars' collision (actual casts should work), and verifying my dry code of adding Whisper to chat output works.
I've run out of game time for the next few weeks, so dry coding is all I can do.
if ResComm:IsUnitBeingRessed(unit) then unitBeingRessed = true return nil end
The idea being that if the unit is being ressed, then don't try to res that unit again. The relevant code for the LibResComm-1.0 API reads
--[[ IsUnitBeingRessed(unit)
Description: Checks if a unit is being ressurected at that moment.
Input: Name of a friendly player
Output: Boolean. True when unit is being ressed. False when not.
]]--
function lib:IsUnitBeingRessed(unit)
for resser, ressed in pairs(activeRes) do
if unit == ressed then
return true, resser
end
end
return false
end
So it is a true/false return on the API, and you can get the resser associated with the unit. In my code, I'm only checking against the unit, as I don't care about the resser at this time. However, my unitBeingRessed local variable is being told to return nil if a unit is found to be in the process of being ressed. Should I be returning nil, nil since the lib returns two values? Oh the joys of no active game account. /sarcasm
Yes indeed. I got to raid test it tonight. Right after I post here, I'm upping Beta 1.01 which has a couple of tweaks over the last Alpha (see the test bars for an example).
I translated the zhCN form google-translation-machine to correct localization 1 hour ago.
Thank you. I'll propagate an update after work tomorrow, unless someone beats me to it.
General interest feedback question: what are people's opinion of SmartRes2? You can say anything you like, but remember constructive feedback is more useful than "it sux" or "i like it". IE, what sucks, what do you like?
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Forum ModeratorI'm sorry for flagging a Beta that isn't working, whether or not it was working a few days ago. I will endeavour to do more testing.
I'm using the latest Beta of SmartRes2 and if I use the Auto-Res-Key to ressurect a groupmember there is only a chat message that everybody is alive and nothing happens. Am I missing something? There is no other error or something like that. I'm playing with the german client as a resto-druid or a holy paladin. The errorr happens on both chars.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Forum Moderator-
View User Profile
-
View Posts
-
Send Message
Forum Moderator...
Or just trust in users' judgment for appropriate modern addons.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIts better to fix your stuff if theres something to fix instead of an unnecessary feature like this ;)
-
View User Profile
-
View Posts
-
Send Message
Forum Moderator-
View User Profile
-
View Posts
-
Send Message
Forum ModeratorI am not posting this as an Alpha yet, and would like some feedback and testing. The optimizations were mostly regarding the res bars options; I moved a lot of that into the user options section in the OnInit() because they were previously in at least two places. The original code is commented out so if something doesn't work, it can easily be switched back.
Just download the code from the pastey and overwrite SmartRes2.lua and post back results, please.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI had a typo on line 737 of that code as well should be:
local oldsender = self:CheckResTarget(target, sender)
-
View User Profile
-
View Posts
-
Send Message
Forum Moderator-
View User Profile
-
View Posts
-
Send Message
Forum ModeratorI've run out of game time for the next few weeks, so dry coding is all I can do.
1x SmartRes2-Alpha 0.86\SmartRes2.lua:936: attempt to index field '?' (a nil value) SmartRes2-Alpha 0.86\SmartRes2.lua:579: in function <SmartRes2\SmartRes2.lua:579> Locals: self = <table> { NewBarFromPrototype = <function> @ SmartRes2\Libs\LibBars-1.0\LibBars-1.0.lua:251: SetDefaultModuleLibraries = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:381: GetBarGroup = <function> @ SmartRes2\Libs\LibBars-1.0\LibBars-1.0.lua:395: ReleaseBar = <function> @ SmartRes2\Libs\LibBars-1.0\LibBars-1.0.lua:284: EnableModule = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:346: modules = <table> {} baseName = "SmartRes2" IterateEmbeds = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:456: DeleteResBar = <function> @ SmartRes2\SmartRes2.lua:991: ResAnchorMoved = <function> @ SmartRes2\SmartRes2.lua:818: CreateResBar = <function> @ SmartRes2\SmartRes2.lua:962: StartTestBars = <function> @ SmartRes2\SmartRes2.lua:1025: Printf = <function> @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:69: PLAYER_REGEN_DISABLED = <function> @ SmartRes2\SmartRes2.lua:772: launcher = <table> {} FadeFinished = <function> @ SmartRes2\SmartRes2.lua:760: defaultModuleState = true IsEnabled = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:465: DisableModule = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:364: Resurrection = <function> @ SmartRes2\SmartRes2.lua:911: EnableSmartRes2 = <function> @ SmartRes2\SmartRes2.lua:618: RegisterMessage = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:118: GetArgs = <function> @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:144: resSpellIcons = <table> {} db = <table> {} SetEnabledState = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:438: enabledState = true RegisterEvent = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:118: SlashHandler = <function> @ SmartRes2\SmartRes2.lua:606: IterateModules = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:451: GetBars = <function> @ SmartRes2\Libs\LibBars-1.0\LibBars-1.0.lua:218: NewCounterBar = <function> @ SmartRes2\Libs\LibBars-1.0\LibBars-1.0.lua:276: Enable = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:313: UnregisterAllEvents = <function> @ Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:202: BindKeys = <function> @ SmartRes2\SmartRes2.lua:805: GetModule = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:230: DisableSmartRes2 = <function> @ SmartRes2\SmartRes2.lua:642: defaultModuleLibraries = <table> {} optionsFrame = <unnamed> {} UnregisterChatCommand = <function> @ Ace3\AceConsole-3.0\AceConsole-3.0.lua:111: UpdateMedia = <function> @ SmartRes2\SmartRes2.lua:662: OnProfileChanged = <function> @ SmartRes2\SmartRes2.lua:657: GetName = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:298: GetBarGroups = <function> @ SmartRes2\Libs\LibBars-1.0\LibBars-1.0.lua:391: name = "SmartRes2" playerClass = "PRIEST" CheckResTarget = <function> @ SmartRes2\SmartRes2.lua:726: AddCollisionBars = <function> @ SmartRes2\SmartRes2.lua:998: Disable = <function> @ Ace3\AceAddon-3.0\AceAddon-3.0.lua:328: ResComm_ResEnd = <function> @ SmartRes2\SmartRes2.lua:734: GetBar = <function> @ SmartRes2\Libs\LibBars-1.0\LibBars-1.0.lua:214: OnInitialize = <function> @ SmartRes2\SmartRes2.lua:155: NewTimerBar = <function> defined @SmartRes2\Libs\LibBa ----
View User Profile
-
View Posts
-
Send Message
Forum ModeratorThe idea being that if the unit is being ressed, then don't try to res that unit again. The relevant code for the LibResComm-1.0 API reads
--[[ IsUnitBeingRessed(unit) Description: Checks if a unit is being ressurected at that moment. Input: Name of a friendly player Output: Boolean. True when unit is being ressed. False when not. ]]-- function lib:IsUnitBeingRessed(unit) for resser, ressed in pairs(activeRes) do if unit == ressed then return true, resser end end return false endSo it is a true/false return on the API, and you can get the resser associated with the unit. In my code, I'm only checking against the unit, as I don't care about the resser at this time. However, my unitBeingRessed local variable is being told to return nil if a unit is found to be in the process of being ressed. Should I be returning nil, nil since the lib returns two values? Oh the joys of no active game account. /sarcasm-
View User Profile
-
View Posts
-
Send Message
Curse PremiumwaitingForAccept[unit] = { target = unit, sender = Player, endTime = doingRessing[sender].endTime }
And is causing an error because doingRessing[sender] is undefined at that point in the code. Change it to:
waitingForAccept[unit] = { target = unit, sender = Player, endTime = GetTime() + 10 }
as a temporary fix.
-
View User Profile
-
View Posts
-
Send Message
Forum ModeratorYes indeed. I got to raid test it tonight. Right after I post here, I'm upping Beta 1.01 which has a couple of tweaks over the last Alpha (see the test bars for an example).
-
View User Profile
-
View Posts
-
Send Message
Forum ModeratorThank you. I'll propagate an update after work tomorrow, unless someone beats me to it.
General interest feedback question: what are people's opinion of SmartRes2? You can say anything you like, but remember constructive feedback is more useful than "it sux" or "i like it". IE, what sucks, what do you like?