I have the "Big Blizzard Bear" mount(the blizzcon mount bind on account) if
the item is in inventory or in bank instead of using the spell it try to learn the item. I think that in case you have a spell and an item with the same name you need to append the name with a () to use the spell.
Hrm... this looks like a regression, I already have fixed it once.
It may not be a regression, this happened with the item in bank. I've not checked with the item in bag.
local function GetSpellCastString(id)
-- Appending '()' to the name enforces the macro code to handle it as a
-- spell cast even if an item with the same name exists
local name = id and GetSpellName(id)
if name and GetItemCount(name) > 0 then
return name and (name..'()')
else
return name
end
end
This is the function you use to tell if you should append a () to the item, you do a GetItemCount(name) I think that you should do a GetItemCount(name, true); the true flag will include the bank so this should solve the problem (not tested I'm at work :p)
but just a question, wouldn't it be just easier to append a () in every case?
I did initially and people QQ'ed the macro was too long...
It was too long, and it wasn't working because my mount names were being truncated. :p
Any word on the issues I reported in tickets #17 and #18? Both are still occuring as of r76; I am at work, so I haven't gotten r78 yet, but I don't see anything in the commit notes about either issue.
spell id #65641, name: "Great Golden Kodo"
spell id #65646, name: "Swift Burgundy Wolf"
spell id #65644, name: "Swift Purple Raptor"
spell id #65639, name: "Swift Red Hawkstrider"
spell id #65645, name: "White Skeletal Warhorse"
This is probably out of scope, but perhaps there is another addon i can combine with squire to achieve it.. Anyway, is it possible to stop squire from selecting oversize mounts in certain zones? More specifically, mammoth mounts suck in Dalaran and Stormwind.
So now, I haven't updated Squire in some time because, hey, it just works... but I've had this thought recently... Dalaran is still a pain. Why? Flying in vs flying out. Coming in on a flight path, the first thing I want to do is mount up and run into town, but what do I get? Yup, flying mount. So here's the logic I propose: if the player was in dalaran and enters Krasus' Landing (sp?), then make the macro give flying. If the player was on a flight path or flying mount when he enters Krasus' Landing (sp?), have the macro offer up land mount (and maybe flying on a modifier?)... otherwise offer up the normal flying (i.e. the player was in town and ran to the landing to fly out).
*edit* installed the latest and this is still the case. Oh and the second row of tabs looks kinda icky, why not two groups, one land one flying, with two tabs each? Added bonus if you automatically show the tab appropriate to the player's level.
Eh, I'd get annoyed by something like that. Let's say I ride up to Krasus' Landing and dismount, then realize I forgot to grab something out of the guild bank, and go to mount back up. By your logic, I'd be mounted on a flying mount, when that's not what I need. I'd much rather stick with the consistent "use flying mount in flyable areas unless I'm holding <modifier>" behavior. :p
But that example is the same as it currently behaves. The difference is arriving in Dalaran you'd be offered a ground mount, because the majority of the time that's what you'd want. Departing Dalaran is no change from the current behavior.
But that example is the same as it currently behaves. The difference is arriving in Dalaran you'd be offered a ground mount, because the majority of the time that's what you'd want. Departing Dalaran is no change from the current behavior.
Eh, I just don't want it ever trying to guess what I "probably" want. I'll stick with the consistent "flying mount in flying area or if modifier is pressed, ground mount otherwise" behavior. I've been using a modifier key to use a ground mount in flyable areas since [flyable] was introduced... I don't need more logic trying to prevent me from ever having to press my Shift key, when if it gets in my way even one time it's more of a hassle than just doing what's already second nature for me. :p
First of all, flyable flag in Krasus' landing is screwed up half the time. Even with a simple flying mount put in an action button, I have to go back in the non-flying area and then enter KL again to have the client properly lights on the flying mount.
Moreover, though I understand the idea, it will require adding more complexity in a code that is already pretty complex for a little added value. In other words : set up a ground modifier and use it !
For the tabs thing, I could merge the same kind of tabs with each other (e.g. slow/fast ground mounts => ground mounts and slow/fast flying mounts => flying mounts) and simply disable the slow mounts by default when you have at least one fast mount.
BTW, I'm considering adding a special case for aquatic mount, only the sea turtle so far. But I could not be arsed to do it until now.
For the tabs thing, I could merge the same kind of tabs with each other (e.g. slow/fast ground mounts => ground mounts and slow/fast flying mounts => flying mounts) and simply disable the slow mounts by default when you have at least one fast mount.
If the slow/fast mounts were separated from each other in some way (for example, a blank row between them) that would be fine. I have about 70 different mounts, and tend to go through once a week or so and set up a different set of 3-5 mounts from each category (ground/flying) to pick from. Having to pick through mixed slow and fast mounts would be annoying. :(
I've swapped to Squire over a few other mount mods that I had been trying & really like it overall.
However, I am seeing a problem with one mount, Headless Horseman's Mount. Whenever this gets used as a random mount, I can't re-click the macro to dismount (get the old error message 'you are already mounted').
The macro seems to update to use another mount as soon as I'm mounted. I have the option "Dismount if already mounted" checked.
I just loaded up Squire in an attempt to move away from other mods and I wanted to give some feedback. I like that the UI is really simple to just turn on and off whichever mounts you want to include and as I have been working on the 100 mount achievement, being able to manage long lists of mounts is valuable.
I like the modifier option but I was wondering if this could be expanded upon? As a tauren raider there are two things that stand out for me when it comes to mounts: The first is that there are times we want to use specific "short" mounts to be able to get through doorways (like going down to the sewers in Dalaran) and the second is that I purchased the vendor mount and would like to be able to access it specifically when people need to buy reagents or repair during a raid.
Right now I have my mount bound to my X key. What I would ideally like to happen is have the default action of the mount macro occur when I hit X (randomly select from my lists a flyable mount in flyable areas and ground mount in non-flyable areas). If I hit Shift+X I need to pick a specific mount, my "short" mount to be able to go through doorways and when I hit Ctrl+X I would like to get my Traveler's Tundra Mammoth. When I get the Sea Turtle it would be nice to either have the default macro be smart enough to use the turtle when in water or bind the third key modifier, Alt+X, to the turtle.
I'm wondering if this kind of thing could be handled by keybindings. E.g. Squire provides, say, 3 keybindings and let the user select a mount for each binding.
I'm wondering if this kind of thing could be handled by keybindings. E.g. Squire provides, say, 3 keybindings and let the user select a mount for each binding.
That would work for me. I was thinking about this more last night as I was running around with my mounts trying to figure out the "ideal" features I would want out of a mount mod. These are the things I was considering:
- I'm collecting a lot of mounts which makes it a pain to navigate through the default Blizzard UI to find a specific mount.
- As a cow I need to use specific smaller mounts to fit through doorways in Dalaran, Undercity or in a battleground like Warsong Gultch.
- I need to be able to access my Traveler's Tundra Mammoth for the vendors but do not want to use it any other time
- I have a 310% flying mount that I use in the majority of situations
- When I get a Sea Turtle I'll want to be able to access it quickly in swimming situations
- It would be nice to have a separate keybind for pulling out a random mount when I am not looking for one of my specific ones listed above.
Having multiple keybinds like you suggested would allow me to have most, if not all, of that functionality with a single mod. Ideally for me, I would want to bind all of my different mount keybinds to the X key using the modifiers.
I also think that the notion of "I would rather use my fast ground mount (100%) over my slow flying mount (60%)" is going to disappear with the next content patch that changes the slow flying mount from 60% to 150%.
Any word on ticket #17? I am now able to consistently reproduce the issue, and can do testing as requested to help you figure out what's causing the problem. It's very frustrating to be unable to dismount when logging in mounted half the time without right-clicking off the buff. :(
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumthe item is in inventory or in bank instead of using the spell it try to learn the item. I think that in case you have a spell and an item with the same name you need to append the name with a () to use the spell.
please can you fix it.
I'll also fill a ticket for it.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIt may not be a regression, this happened with the item in bank. I've not checked with the item in bag.
local function GetSpellCastString(id) -- Appending '()' to the name enforces the macro code to handle it as a -- spell cast even if an item with the same name exists local name = id and GetSpellName(id) if name and GetItemCount(name) > 0 then return name and (name..'()') else return name end endThis is the function you use to tell if you should append a () to the item, you do a GetItemCount(name) I think that you should do a GetItemCount(name, true); the true flag will include the bank so this should solve the problem (not tested I'm at work :p)but just a question, wouldn't it be just easier to append a () in every case?
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI did initially and people QQ'ed the macro was too long...
Edit: added the second parameter to GetItemCount in latest alpha, please check if it fixes it.
It was too long, and it wasn't working because my mount names were being truncated. :p
Any word on the issues I reported in tickets #17 and #18? Both are still occuring as of r76; I am at work, so I haven't gotten r78 yet, but I don't see anything in the commit notes about either issue.
spell id #65641, name: "Great Golden Kodo"
spell id #65646, name: "Swift Burgundy Wolf"
spell id #65644, name: "Swift Purple Raptor"
spell id #65639, name: "Swift Red Hawkstrider"
spell id #65645, name: "White Skeletal Warhorse"
*edit* installed the latest and this is still the case. Oh and the second row of tabs looks kinda icky, why not two groups, one land one flying, with two tabs each? Added bonus if you automatically show the tab appropriate to the player's level.
Eh, I just don't want it ever trying to guess what I "probably" want. I'll stick with the consistent "flying mount in flying area or if modifier is pressed, ground mount otherwise" behavior. I've been using a modifier key to use a ground mount in flyable areas since [flyable] was introduced... I don't need more logic trying to prevent me from ever having to press my Shift key, when if it gets in my way even one time it's more of a hassle than just doing what's already second nature for me. :p
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumMoreover, though I understand the idea, it will require adding more complexity in a code that is already pretty complex for a little added value. In other words : set up a ground modifier and use it !
For the tabs thing, I could merge the same kind of tabs with each other (e.g. slow/fast ground mounts => ground mounts and slow/fast flying mounts => flying mounts) and simply disable the slow mounts by default when you have at least one fast mount.
BTW, I'm considering adding a special case for aquatic mount, only the sea turtle so far. But I could not be arsed to do it until now.
If the slow/fast mounts were separated from each other in some way (for example, a blank row between them) that would be fine. I have about 70 different mounts, and tend to go through once a week or so and set up a different set of 3-5 mounts from each category (ground/flying) to pick from. Having to pick through mixed slow and fast mounts would be annoying. :(
However, I am seeing a problem with one mount, Headless Horseman's Mount. Whenever this gets used as a random mount, I can't re-click the macro to dismount (get the old error message 'you are already mounted').
The macro seems to update to use another mount as soon as I'm mounted. I have the option "Dismount if already mounted" checked.
I like the modifier option but I was wondering if this could be expanded upon? As a tauren raider there are two things that stand out for me when it comes to mounts: The first is that there are times we want to use specific "short" mounts to be able to get through doorways (like going down to the sewers in Dalaran) and the second is that I purchased the vendor mount and would like to be able to access it specifically when people need to buy reagents or repair during a raid.
Right now I have my mount bound to my X key. What I would ideally like to happen is have the default action of the mount macro occur when I hit X (randomly select from my lists a flyable mount in flyable areas and ground mount in non-flyable areas). If I hit Shift+X I need to pick a specific mount, my "short" mount to be able to go through doorways and when I hit Ctrl+X I would like to get my Traveler's Tundra Mammoth. When I get the Sea Turtle it would be nice to either have the default macro be smart enough to use the turtle when in water or bind the third key modifier, Alt+X, to the turtle.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThat would work for me. I was thinking about this more last night as I was running around with my mounts trying to figure out the "ideal" features I would want out of a mount mod. These are the things I was considering:
- I'm collecting a lot of mounts which makes it a pain to navigate through the default Blizzard UI to find a specific mount.
- As a cow I need to use specific smaller mounts to fit through doorways in Dalaran, Undercity or in a battleground like Warsong Gultch.
- I need to be able to access my Traveler's Tundra Mammoth for the vendors but do not want to use it any other time
- I have a 310% flying mount that I use in the majority of situations
- When I get a Sea Turtle I'll want to be able to access it quickly in swimming situations
- It would be nice to have a separate keybind for pulling out a random mount when I am not looking for one of my specific ones listed above.
Having multiple keybinds like you suggested would allow me to have most, if not all, of that functionality with a single mod. Ideally for me, I would want to bind all of my different mount keybinds to the X key using the modifiers.
I also think that the notion of "I would rather use my fast ground mount (100%) over my slow flying mount (60%)" is going to disappear with the next content patch that changes the slow flying mount from 60% to 150%.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumAny word on ticket #17? I am now able to consistently reproduce the issue, and can do testing as requested to help you figure out what's causing the problem. It's very frustrating to be unable to dismount when logging in mounted half the time without right-clicking off the buff. :(
-
View User Profile
-
View Posts
-
Send Message
Curse Premium