Those line numbers in nivBuffs don't match up to r20. As far as I know, none of the functions LBF uses are protected, but I'll try to see if I can reproduce the error when I get time.
They do, GitHub messes them up.
And the one protected function BF uses is SetFrameLevel(). It's protected in my case because the icons of the SecureAuraHeader are protected frames.
hi i dont know if its been mentioned already but i got hit by a wall of txt so thought id ask :) but im using BF with BF_simpleskin and Bison buff frames. since patch 4.0.3 the individual buff icons keep randomly changing size and this causes an overlap. ive tried tweaking settings on both BF and bison and done some digging and no one else seems to relate to the problem. i have routed the problem to be linked to BF. im not any good with coding so havnt got a clue where to start and i dont get any errors from any of the mentioned addons its just really reallly annoying and wud love if someone cud try to help or atleast point me in the right direction :D thanks in advance :D
You should be using the appropriate Blizzard button templates to get those layers to work. Both the cooldown and autocast are animation frames. Take a look at the default action buttons and pet action buttons to see how they're put together.
I have a small problem since one of a last updates of ButtonFacade, maybe anyone of you had seen this behavior before and could tell me how to fix it.
I am using Raven as my buff addon, which is skinned with ButtonFacade. It works well, except of a glow effect, which appears on each buff. You can see this quite well in this screenshot:
The first 2 rows are from Raven, the last 2 from Satrinas Buff Frames. Both addons are skinned with the Blizzard skin of ButtonFacade and both of the show this white glowing on the buffs.
I am using Dominos to skin my action buttons an there is no such glowing, if I don't actually cast something.
Skinning with a different skin doesn't solve the issue, Caith is showing a much brighter border on the buffs, but not on the action buttons, so the base issue seems to exist with Caith also. It's like the buffs are highlighted, but I've no idea why they should be...
Sorry, didn't work. I've installed the newest alpha of BF, Caith and Raven on a fresh WoW installation with no other addons and no old settings. The glow effect is still there.
I'll try a couple of other buff addons and see, if all of them are affected...
Thank you,
enjaxx
Edit: OK, PhanxBuffs ist working like intended, no glow effect. It looks like SBF and Raven are doing something wrong... I'll look deeper into the BF code in Raven...
You also have reset the profile for the affected mods. It may just be a case where Raven is putting borders on buttons that shouldn't have borders (IE Buffs), in which case you'll have to go over there. When I get a few minutes, I'll look at it and see if I can find the issue.
Raven ButtonFacade support was changed a while back to try to make border coloring work with more skins. It currently uses two methods (setting the border vertex color and setting the normal texture vertex color), primarily in response to people wanting their favorite skin to work even if the skin was not updated lately. In the near future I plan to make the methods optional (i.e., you'll be able to select either or both of them) with border vertex color only as the default. If you can check this code, StormFX, I'd appreciate any recommendations (look in Nest.lua, search for LBF, border coloring is done around line 830).
First of all, the "Normal" texture is the graphic that appears over the icon. This should not be colored except by the skin or user. The "Border" is an accenting texture for the "Normal" layer that's also used by Blizzard to indicate an equipped item or debuff color. It's very important that you don't mix those two up.
By default, no "Buff" button has a "Border" layer. Only Debuffs should have a "Border" layer. In addition, if you're simply trying to allow changes to the border color, you should simply use :SetVertexColor on the "Border" layer. Since LBF doesn't do anything with the colors, any changes you made will simply work.
Actually, it seems the issue is within Raven. If I leave it alone, Raven adds the "outline" on the corresponding buff/debuffs button on the action bar(s). However, it does not work for a custom-created "buff frame". Butf if I manually enter values (say 0,0,1,1) in lines 830 and 832, it works for both. Somehow the values aren't getting passed correctly for the "buff frame" i created.
Actually, it seems the issue is within Raven. If I leave it alone, Raven adds the "outline" on the corresponding buff/debuffs button on the action bar(s). However, it does not work for a custom-created "buff frame". Butf if I manually enter values (say 0,0,1,1) in lines 830 and 832, it works for both. Somehow the values aren't getting passed correctly for the "buff frame" i created.
Update: I need to spend more time looking at how BF and skins are implemented in order to get the desired effect for my custom-created "buff frames". I find that setting the border color (line 830) works by itself for Renaitre's skins but setting the normal texture color (line 832) is necessary for Adorn: Light Square and many other skins. To be precise, when I say "works" I mean that setting a custom border color in Raven's bar group appearance options changes the icon's outer border to that color. Not working can mean that there is a faint glow of the desired color or a too-thin colored stripe inset from the border or no detectable added color at all--different skins act very differently.
This is because of the dimensions of the buttons and the size of the colored area of the border texture. For example, with Apathy the border layer's colored area is only two pixels wide. So the smaller the button, the harder it is to see.
How you implement it is up to you. If you want to color the "Normal" texture as well, go for it. That's on you. :p I think PhanxBuffs does something similar. Just keep in mind that scale plays a big factor in how the buttons look.
But as far as the layers not being colored goes, what I was trying to say is that the values being passed seem to be nil, so for the normal layer LBF is defaulting to white because it's not receiving values. If you manually pass the color, it works fine.
Edit: For the record, if you are setting the vertex color of the normal texture, you'll have to reset it after adding it to LBF since LBF actually uses the skin settings to color that particular texture when the button's skinned. If you don't, it'll retain the color specified in the skin or white if no color is specified.
I have added options in the newest release of Raven for selecting the coloring method for icon borders with ButtonFacade. The user can now either apply color to the normal texture or the border texture or both. I have tested this with a lot of different skins and some combination works well with each one. Thank you for your help, StormFX. And, enjaxx, that glow effect can probably be disabled in Raven now by turning off border texture coloring (Defaults tab, at the bottom), depending of course on which skin you are using.
Having a weird issue. Last night I installed ElvUI. I didn't like it, so I went back to my old set up.
However, now whenever ButtonFacade is enabled, my action bar font WILL NOT change. It only changes when I disable ButtonFacade.
I'm tried uninstalling, reinstalling, previous versions, etc etc. Nothing works. It's weird and I don't get it, so I'm crying out for a little forum help.
Thanks!
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
They do, GitHub messes them up.
And the one protected function BF uses is SetFrameLevel(). It's protected in my case because the icons of the SecureAuraHeader are protected frames.
**edit: I fixed it.
Look around in the lua/xml files for action buttons.
I have a small problem since one of a last updates of ButtonFacade, maybe anyone of you had seen this behavior before and could tell me how to fix it.
I am using Raven as my buff addon, which is skinned with ButtonFacade. It works well, except of a glow effect, which appears on each buff. You can see this quite well in this screenshot:
http://img546.imageshack.us/i/wowscrnshot012411005658.jpg/
The first 2 rows are from Raven, the last 2 from Satrinas Buff Frames. Both addons are skinned with the Blizzard skin of ButtonFacade and both of the show this white glowing on the buffs.
I am using Dominos to skin my action buttons an there is no such glowing, if I don't actually cast something.
Skinning with a different skin doesn't solve the issue, Caith is showing a much brighter border on the buffs, but not on the action buttons, so the base issue seems to exist with Caith also. It's like the buffs are highlighted, but I've no idea why they should be...
Thank you,
enjaxx
Sorry, didn't work. I've installed the newest alpha of BF, Caith and Raven on a fresh WoW installation with no other addons and no old settings. The glow effect is still there.
I'll try a couple of other buff addons and see, if all of them are affected...
Thank you,
enjaxx
Edit: OK, PhanxBuffs ist working like intended, no glow effect. It looks like SBF and Raven are doing something wrong... I'll look deeper into the BF code in Raven...
By default, no "Buff" button has a "Border" layer. Only Debuffs should have a "Border" layer. In addition, if you're simply trying to allow changes to the border color, you should simply use :SetVertexColor on the "Border" layer. Since LBF doesn't do anything with the colors, any changes you made will simply work.
Update: I need to spend more time looking at how BF and skins are implemented in order to get the desired effect for my custom-created "buff frames". I find that setting the border color (line 830) works by itself for Renaitre's skins but setting the normal texture color (line 832) is necessary for Adorn: Light Square and many other skins. To be precise, when I say "works" I mean that setting a custom border color in Raven's bar group appearance options changes the icon's outer border to that color. Not working can mean that there is a faint glow of the desired color or a too-thin colored stripe inset from the border or no detectable added color at all--different skins act very differently.
How you implement it is up to you. If you want to color the "Normal" texture as well, go for it. That's on you. :p I think PhanxBuffs does something similar. Just keep in mind that scale plays a big factor in how the buttons look.
But as far as the layers not being colored goes, what I was trying to say is that the values being passed seem to be nil, so for the normal layer LBF is defaulting to white because it's not receiving values. If you manually pass the color, it works fine.
Edit: For the record, if you are setting the vertex color of the normal texture, you'll have to reset it after adding it to LBF since LBF actually uses the skin settings to color that particular texture when the button's skinned. If you don't, it'll retain the color specified in the skin or white if no color is specified.
However, now whenever ButtonFacade is enabled, my action bar font WILL NOT change. It only changes when I disable ButtonFacade.
I'm tried uninstalling, reinstalling, previous versions, etc etc. Nothing works. It's weird and I don't get it, so I'm crying out for a little forum help.
Thanks!