Authors CurseForge

Hrm, good question. Are you running it with embeds or no?

Either way, an option to turn off scanning during combat is a good idea, I'll add that.

I run without, automatic dependency download with JWowUpdater. There is no memory increase out of combat, but it's quite heavy during. Might wanna test it with a performance tool like Expo/optionhouse etc.

With r78905 it no longer checks for missing buffs even out of combat, i have to manually leftclick on the window to check.

Edit: Seems to update fine when i start getting buffed, just did not update until i got buffed.

Hrm, everything appears to be in working order from my end. Can you try to describe a specific scenario where the check didn't happen correctly?

Note that BuffEnough only does checks when events happen that would prompt it to check (things like having a buff cast on you, pulling a pet out, swapping a piece of equipment, etc). It doesn't continuously check on its own.

Yeah, it wasn't anything wrong, it's updating correctly when someone starts casting buffs on me. Also the memory growth seems to be fixed when disabling ''check in combat'', so good work.

Thanks. I'd still like to know why the memory growth is happening during combat, though. BuffEnough doesn't really store much, so I'm not sure why that would happen. You mentioned a couple of tools, Expo (which I see in the SVN repo) and optionhouse (which I don't). Anyone else have any recommendations for debugging memory issues? What's the standard procedure for that sort of thing in WoW's Lua environment? I also so tekkub's tekSupport in the Developer Tools section of the SVN, could that be applicable?

You can find optionhouse on WoWI
http://www.wowinterface.com/downloads/info7324-OptionHouse.html

For more info i suggest asking for help in the Help! section or the Code Discussion forums.

Hi,

found your addon yesterday and I must say that I really like it. Some questions though:

Using my Enh. Shaman:

- I get unexp. Mainhand buff (WF)...correct?
- if I shift-rightlick there are no whispers, but messages like "no buffer found for ***"
- is there an option to check for ONLY guardian OR battle elixir (normally only use AGI on my shaman)

thanks

taalas

Hey taalas, thanks for checking it out.

Quote from taalas »

I get unexp. Mainhand buff (WF)...correct?

Hrm, no, that shouldn't be correct. I haven't seen that happen before. Can you describe the scenario under which that happened?

Quote from taalas »

if I shift-rightlick there are no whispers, but messages like "no buffer found for ***"

The shift-right-click only works after someone has already buffed you with the buff in question, so that it knows who to whisper. On the tooltip, if it knows who has buffed something, you'll see the name in parenthesis next to the buff. At that point, you should be able to shift-right-click and send a whisper directly to them.

Quote from taalas »

is there an option to check for ONLY guardian OR battle elixir (normally only use AGI on my shaman)

If you're not using both elixirs, you can always set up a custom buff check to ignore whichever one you're not using. You can find that under the 'Custom' section of the config.

One bug I've noticed on my resto shaman... if I don't have Water Shield on, it tells me "Missing Elemental Shield (XXXX)", where "XXXX" is the name of another shaman in my raid. For raiding, the only shield a resto shaman should have on (generally) is Water Shield, which is self-cast only, so it doesn't make sense to show someone else's name... and it certainly doesn't make any sense at all to that other shaman when he gets a tell asking him to please buff me with Elemental Shield. :P

Good find, that's a funny little bug. It was going to be rather complicated to fix, so I cheated a little bit. Since shamans of all specs typically use water shield, and the other two are highly situational (at least for self use), I changed the check to look explicitly for the water shield. If a shaman finds themselves wanting to use one of the other shields, they can always set that up in the custom check section.

Actually, I came up with a better solution, so I reverted the previous change. Hopefully that should fix the issue for all classes that have mappable self-buffs.

can you splitup guardian and battle? cause i am rogue and mostly just use battle elixir (agi) or flask ...

Read a little farther up in the thread. That question has been addressed a couple of times.

lol I so love this addon and every person that have slacked on buffs now so hate it :D
I have a small issue however, hard to describe... it is not "always" detecting proper buffs. For example it says I miss Blessing of Might while I actually have it. Clicking on it makes no difference, but if I change some other buff, apply poison for example, it detects the change and updates. Hapened 3-4 times in 2 weeks, so no way I can give a reproduction, just blamed some people wrongly :(
And yeah, speaking for buffing out of combat, my combat checking is disabled. Is the "left click to refresh" actually works?

Paladin buffs are a little tricky because two of them - kings and sanctuary - are talented. And there is a delay period that happens (due to the Blizzard api, not the addon) while BuffEnough tries to inspect the talents of the paladins in your party/raid and figure out if you should have those or not. So it may pick the wrong blessings or insist that you need one you already have until it can figure out what's what.

I'll see if I can improve that a little bit, but I don't think there's much I can do.

As for blessings, if there are two paladins in the raid, and I've manually set my blessing priority to "Wisdom first, Kings second, Salvation third", and I have Wisdom and Kings, BuffEnough will sometimes tell me I'm missing Salvation. It's fairly uncommon, but possibly something to look at if you have time.

Also, I'm not sure how much work it would be to intercept PallyPower assignments, but that could help with the blessings situation.

Basically the same issue. If it doesn't know that a paladin has kings in the raid, it's going to assume kings is an invalid buff to look for, and move on to the third option. At some point, the talent inspection can happen and it figures out that kings is available and then everything works as expected.

With regards to pally power, that was suggested before and I considered that option. But ultimately I don't want to surrender BuffEnough's logic to someone else's configuration. It's happened more than once for me in a raid where the paladins misconfigured PallyPower's assignments, and I ended up getting a different blessing than one I needed and BuffEnough alerted me to that issue.

Well, when it happened last night at Kalecgos, the same two paladins had been in the raid all night, and BuffEnough had correctly detected that Kings was available, so I don't think it was an issue with talent inspection.

Hrm. One of them in a different zone perhaps? Like after a wipe, you were inside but one of them was still running back? I'll play with the paladin blessings logic a little bit and see if I can figure out what's going on.