Authors CurseForge

r177, cleared saved vars, on my 80 arcane mage, in ironforge, unmounted.
I get this on load, withoutdoing anything:

515x ZOMGBuffs--16612\ZOMGBuffs.lua:3000: bad argument #1 to 'strfind' (string expected, got nil)

Every time I mouseover the zomgbuffs button i get:

5x ZOMGBuffs--16612\ZOMGBuffs.lua:3000: bad argument #1 to 'strfind' (string expected, got nil)
ZOMGBuffs--16612\ZOMGBuffs.lua:3000: in function <ZOMGBuffs\ZOMGBuffs.lua:2999>
ZOMGBuffs--16612\ZOMGBuffs.lua:3110: in function <ZOMGBuffs\ZOMGBuffs.lua:3007>
<in C code>: in function `Show'
Interface\FrameXML\RestrictedFrames.lua:312: in function `Show':
<string>:"			local list = self:GetFrameRef("list")...":3: in function <[string "			local list = self:GetFrameRef("list")..."]:1>
(tail call): ?:
<in C code>: ?
Interface\FrameXML\RestrictedExecution.lua:441: in function <Interface\FrameXML\RestrictedExecution.lua:412>:
(tail call): ?:
Interface\FrameXML\SecureHandlers.lua:82: in function `SecureHandler_OnSimpleEvent':
<string>:"*:OnEnter":3: in function <[string "*:OnEnter"]:1>
<in C code>: ?

Locals:
name = nil
icon = "Interface\Icons\Achievement_Dungeon_TheVioletHold_Heroic"
findFlask = "^Flask of "
findPot = "^Elixir of "

and:

5x ZOMGBuffs--16612\ZOMGBuffs.lua:3000: bad argument #1 to 'strfind' (string expected, got nil)
ZOMGBuffs--16612\ZOMGBuffs.lua:3000: in function <ZOMGBuffs\ZOMGBuffs.lua:2999>
ZOMGBuffs--16612\ZOMGBuffs.lua:3110: in function <ZOMGBuffs\ZOMGBuffs.lua:3007>
<in C code>: in function `Show'
Interface\FrameXML\SecureGroupHeaders.lua:211: in function <Interface\FrameXML\SecureGroupHeaders.lua:115>:
Interface\FrameXML\SecureGroupHeaders.lua:453: in function <Interface\FrameXML\SecureGroupHeaders.lua:379>:
<in C code>: ?
<in C code>: in function `Show'
Interface\FrameXML\RestrictedFrames.lua:312: in function `Show':
<string>:"			local list = self:GetFrameRef("list")...":3: in function <[string "			local list = self:GetFrameRef("list")..."]:1>
(tail call): ?:
<in C code>: ?
Interface\FrameXML\RestrictedExecution.lua:441: in function <Interface\FrameXML\RestrictedExecution.lua:412>:
(tail call): ?:
Interface\FrameXML\SecureHandlers.lua:82: in function `SecureHandler_OnSimpleEvent':
<string>:"*:OnEnter":3: in function <[string "*:OnEnter"]:1>
<in C code>: ?

Locals:
name = nil
icon = "Interface\Icons\Achievement_Dungeon_TheVioletHold_Heroic"
findFlask = "^Flask of "
findPot = "^Elixir of "

and:

5x ZOMGBuffs--16612\ZOMGBuffs.lua:3000: bad argument #1 to 'strfind' (string expected, got nil)
ZOMGBuffs--16612\ZOMGBuffs.lua:3000: in function <ZOMGBuffs\ZOMGBuffs.lua:2999>
ZOMGBuffs--16612\ZOMGBuffs.lua:3110: in function <ZOMGBuffs\ZOMGBuffs.lua:3007>
<in C code>: in function `Show'
Interface\FrameXML\SecureGroupHeaders.lua:211: in function <Interface\FrameXML\SecureGroupHeaders.lua:115>:
Interface\FrameXML\SecureGroupHeaders.lua:453: in function `SecureGroupHeader_Update':
Interface\FrameXML\SecureGroupHeaders.lua:57: in function <Interface\FrameXML\SecureGroupHeaders.lua:52>:
<in C code>: in function `SetAttribute'
Interface\FrameXML\RestrictedFrames.lua:314: in function `Show':
<string>:"			local list = self:GetFrameRef("list")...":3: in function <[string "			local list = self:GetFrameRef("list")..."]:1>
(tail call): ?:
<in C code>: ?
Interface\FrameXML\RestrictedExecution.lua:441: in function <Interface\FrameXML\RestrictedExecution.lua:412>:
(tail call): ?:
Interface\FrameXML\SecureHandlers.lua:82: in function `SecureHandler_OnSimpleEvent':
<string>:"*:OnEnter":3: in function <[string "*:OnEnter"]:1>
<in C code>: ?

Locals:
name = nil
icon = "Interface\Icons\Achievement_Dungeon_TheVioletHold_Heroic"
findFlask = "^Flask of "
findPot = "^Elixir of "

Themouseover ones show up as 3 diff errors, not a repeated on in bugsack.
I don't get any of these on my level 1 AH mage.

Still get those errors in r179, but with different line numbers. Let me know if you need them re-posted.

I'm not sure if you have any priests testing the alpha or not, but I've tried versions r178 and r179 and it won't let me buff anything except Inner Fire, and says I don't have Inner Fire even though I've just buffed it.

Quote from Fred7

515x ZOMGBuffs--16612\ZOMGBuffs.lua:3000: bad argument #1 to 'strfind' (string expected, got nil)

Found it, problem with Dalaran Brilliance. Should be fixed in r180.

r180 fixed those lua errors my mage was getting.

Quote from kethra79

I'm not sure if you have any priests testing the alpha or not, but I've tried versions r178 and r179 and it won't let me buff anything except Inner Fire, and says I don't have Inner Fire even though I've just buffed it.

Only my level 43 priest right now, but Fortitude seems to work there.

It almost sounds like the raid buff module isn't loading for some reason. Do you see Fortitude on the list of buffs when you right click and go to the configuration? Do you see the "Group Buffs" menu at all under there?

Did you delete all the ZOMGBuffs directories before extracting the test version? If you could check Logs\FrameXML.log for signs of any problems loading ZOMGBuffs_BuffTehRaid (and make sure it's enabled in the addon list), that would be helpful as well. That reminds me, I need to bump the TOC on those so that they still load when out of date addons are disabled...

Quote from Fred7

r180 fixed those lua errors my mage was getting.

Could you do me a favor and make sure that it's casting the Dalaran version of the spell (and that it shows you as having the int buff in the list when you hover over the icon)?

I made some pretty sweeping changes in that module, and while I think I preserved the aliasing for that, I don't have a mage with Dalaran Brilliance to test it.

r183 i get this on load:

1x ZOMGBuffs-$Revision: 177 $\ZOMGBuffs.lua:208: table index is nil

Locals:

No big button, and the minimap button has a red ? in it.

Yeah, I thought I was being smart but it turns out that the new drums of the wild don't actually exist in live yet... Fixed in 184.

Quote from thelibrarian

Could you do me a favor and make sure that it's casting the Dalaran version of the spell (and that it shows you as having the int buff in the list when you hover over the icon)?

I made some pretty sweeping changes in that module, and while I think I preserved the aliasing for that, I don't have a mage with Dalaran Brilliance to test it.

Rolled back to r180. Ungrouped.

It casts the correct spell, dalaran brilliance, if I'm missing an int buff. It won't try and cast it if i have either version up already.

Unbuffed, mousing over the button shows bright the icon for the arcane bril spell. Buffed, mousing over the button shows grayedout the icon for whatever version I'm buffed with.

Glad to hear it, Fred7, that's exactly what it's supposed to do.

Attention ZOMGBuffs users and testers!

r185 on the cata branch introduces experimental support for trying to "do the right thing" when it comes to buffs that don't stack with each other. The initial implementation flags Mark of the Wild and Blessing of Kings as mutually exclusive.

Now, I don't have a high enough druid or paladin to actually use these buffs, so this is mostly drycoded with some minor testing on low-level alts just to verify that it didn't explode when they joined a group. If you run into any issues with this version, I recommend rolling back to r184, which should be a stable version.

As I won't be able to do much testing tonight due to RL obligations, I would greatly appreciate it if anyone could manage to get a paladin and a druid together for some testing.

Things to try:

Does it show the correct icon for your class when solo?

After both are in a party together, does it only show one icon on the raid buff list when you hover over the icon? For a druid/paladin party, it should show Mark and Might, but not Kings.

Does this icon correctly dim when either buff is applied, and does it reflect which spell the player actually has?

If both players have Mark, and one of them right-clicks it off, does it prompt the paladin to cast Kings? Vice Versa?

(note: ZOMGBuffs currently only scans for buffs after a global cooldown, so you'll need to cast a random spell to get it to notice that they clicked off the buff. I'm contemplating changing this to check on UNIT_AURA, but unsure of the performance impact as its scanning is rather inefficient right now)

Rogues can put poisons on ranged weapons now.

r185.

I got this on switching specs (from secondary arcane to primary empty).

2x ZOMGBuffs_BuffTehRaid-$Revision: 181 $\ZOMGBuffs_BuffTehRaid.lua:2602: bad argument #1 to 'pairs' (table expected, got nil)

In a raid with a druid and a paladin, i saw 2 colums of grayed out marks of the wild icons. I couldnt play with the buffs, my char was neither of those.

Also wasn't there a way to display time remaining on all of the buffs you cast?

Quote from thelibrarian

Only my level 43 priest right now, but Fortitude seems to work there.

It almost sounds like the raid buff module isn't loading for some reason. Do you see Fortitude on the list of buffs when you right click and go to the configuration? Do you see the "Group Buffs" menu at all under there?

Did you delete all the ZOMGBuffs directories before extracting the test version? If you could check Logs\FrameXML.log for signs of any problems loading ZOMGBuffs_BuffTehRaid (and make sure it's enabled in the addon list), that would be helpful as well. That reminds me, I need to bump the TOC on those so that they still load when out of date addons are disabled...

Just updated to r186 after I saw this message. I did a full delete of the previous versions folders before I copied in the new ones. I'm not seeing anything in the log for ZOMGBuffs, and it is showing as enabled. In the options, I can see Fortitude and Shadow Protection, and they are checked, I just never get past Inner Fire. It's as though ZOMGBuffs isn't recognizing that I even HAVE Inner Fire on, so it keeps telling me to cast the spell before I can go on to the next one.


Update: OK, did a little playing around. I'd like to say one thing before I go on...I have a HUGE amount of respect for everyone who writes add-ons.

I think the problem lies in this line from the ZOMGBuffs_SelfBuffs.LUA file.

{id = 588, o = 2, duration = 10, charges = 20, who = "self", c = "FFA080"}, -- Inner Fire

When I saw that Inner Fire was still identified with charges, which it no longer has with the changes, I went back in-game and looked. Mine was set to have a minimum number of charges for some reason. Once I set the counter back down to 0 it started working.

Quote from kethra79

Just updated to r186 after I saw this message. I did a full delete of the previous versions folders before I copied in the new ones. I'm not seeing anything in the log for ZOMGBuffs, and it is showing as enabled. In the options, I can see Fortitude and Shadow Protection, and they are checked, I just never get past Inner Fire. It's as though ZOMGBuffs isn't recognizing that I even HAVE Inner Fire on, so it keeps telling me to cast the spell before I can go on to the next one.

Hmm, so it's repeatedly asking you to buff Inner Fire?

It might be related to it mistakenly thinking it has charges, which I just removed in the latest build. Can you try r187 and see if it's any better?

Still strange that it didn't happen to me when I tested it, as the priest I used was high enough to have Inner Fire and it seemed to be working.

I seem to be having it not treat BG Raids as buffable.

And thank you, thank you for updating this!!! <3

Quote from Fred7

Rogues can put poisons on ranged weapons now.

Good Morning.
Thelibrarian, Thanks alot for fizixing this wonderful addon :)
It would be possible to add ranged weapons to "buffable" weapons list?

Quote from And

Good Morning.
Thelibrarian, Thanks alot for fizixing this wonderful addon :)
It would be possible to add ranged weapons to "buffable" weapons list?

EDIT: Added in r192 -- should be working now.

Noticed some weirdness on my lowbie rogue of getting a "This action will make the item soulbound" prompt the first time I put poison on my ranged weapon after logging in each time, but I believe that's a blizzard issue, and shouldn't affect high-level rogues.

Quote from thelibrarian

Hmm, so it's repeatedly asking you to buff Inner Fire?

It might be related to it mistakenly thinking it has charges, which I just removed in the latest build. Can you try r187 and see if it's any better?

Still strange that it didn't happen to me when I tested it, as the priest I used was high enough to have Inner Fire and it seemed to be working.

I'm fairly sure it did have something to do with the charges. I updated my post, probably at the same time you where posting this. I had my Inner Fire set to a minimum # of charges, since I did PvP, and once I saw the line of code that showed charges I went back in game and checked that and set it to 0. Once I did that it worked fine.

I haven't been online since I made that post due to RL issues, but I just downloaded the most recent version r196 and I'll report back.