I'm still having trouble with the latest ZOMGBuffs in WoW Live where weapon buffs like rogue poisons or shaman weapon imbues are not detected properly.
To get it into a funny state, manually cast windfury weapon on your weapon. At this point, ZOMGBuffs should still say that you need to cast it. Click the ZOMGBuffs icon to recast it and the notification goes away. Right-click the buff icon to remove it and ZOMGBuffs doesn't notice. Mount up and briefly ZOMGBuffs will show the notification for Windfury but it will disappear due to no buffing while mounted. Dismount and ZOMGBuffs will still not notice that you need Windfury weapon.
I'm still having trouble with the latest ZOMGBuffs in WoW Live where weapon buffs like rogue poisons or shaman weapon imbues are not detected properly.
To get it into a funny state, manually cast windfury weapon on your weapon. At this point, ZOMGBuffs should still say that you need to cast it. Click the ZOMGBuffs icon to recast it and the notification goes away. Right-click the buff icon to remove it and ZOMGBuffs doesn't notice. Mount up and briefly ZOMGBuffs will show the notification for Windfury but it will disappear due to no buffing while mounted. Dismount and ZOMGBuffs will still not notice that you need Windfury weapon.
I dislike the whole way it's handled.. But it looks like I'm going to have to make a translation table of spell/item names -> weapon enchant names. Rarely are they the same.. :|
If you need any help reproducing the bug I'd be happy to help. I'm holding off updating ZOMGBuffs just to keep my little patch intact so it can switch templates for me... :)
I added the PARTY_MEMBERS_CHANGED. The rest of the code has changed a little since you posted that, so if you could update and check it that would be cool :)
r81963 (new version with Mage portal component, standalone libs) on the 2.4.3 Live servers. Logged on a 70 Priest that previously had ZOMGBuffs active. Error at logon:
ZOMGBuffs\\ZOMGBuffs_Portalz\\ZOMGBuffs_Portalz.lua:2: attempt to index global 'z' (a nil value).
Hi have the exactly same error that Zidomo reported:
[2008/09/23 08:50:07-1907-x1]: ...ns\ZOMGBuffs\ZOMGBuffs_Portalz\ZOMGBuffs_Portalz.lua:2: attempt to index global 'z' (a nil value):
---
Another issue I found is that automatic template switching seems not to work. I did setup a solo and group setting for non self buffs and activated autoswitch for solo and party. When Im invited to a group it never switches automatically. I always have to do it myself.
Hi have the exactly same error that Zidomo reported:
[2008/09/23 08:50:07-1907-x1]: ...ns\ZOMGBuffs\ZOMGBuffs_Portalz\ZOMGBuffs_Portalz.lua:2: attempt to index global 'z' (a nil value):
---
Another issue I found is that automatic template switching seems not to work. I did setup a solo and group setting for non self buffs and activated autoswitch for solo and party. When Im invited to a group it never switches automatically. I always have to do it myself.
Meh. Forgot the filelist.wau too. Will post a fix in a few mins.
I added the PARTY_MEMBERS_CHANGED. The rest of the code has changed a little since you posted that, so if you could update and check it that would be cool :)
Sure! I have made a patch against revision 81980 that you should be able to apply using TortoiseSVN to get it working. I have attached it to this post.
Please don't hesitate to ask if you have any questions about my modifications. (I have only tested it in parties, not in raids.)
Sure! I have made a patch against revision 81980 that you should be able to apply using TortoiseSVN to get it working. I have attached it to this post.
Please don't hesitate to ask if you have any questions about my modifications. (I have only tested it in parties, not in raids.)
Mmm, no. You missed the changes I put into modulePrototype, Raid and blessings modules. Which now check raid/party changes as this does, but in the modules rather than core.
Moving the check state thing to core is not really necessary imo. Could you test it out as-is without your changes.
[2008/09/23 22:36:04-2271-x550]: ZOMGBuffs-65478\ZOMGBuffs.lua:138: bad argument #1 to 'pairs' (table expected, got string)
I've gotten this error the last two times I leveled(to 36 and 37) on my retri paladin.
Will need the complete error report for this. That error could be coming from anywhere. You need to copy'n'paste the stack trace from BugSack or Swatter, whatever you use. If you don't use either, then start using one because those 1 line errors are useless 9 times out of 10. :)
Mmm, no. You missed the changes I put into modulePrototype, Raid and blessings modules. Which now check raid/party changes as this does, but in the modules rather than core.
Moving the check state thing to core is not really necessary imo. Could you test it out as-is without your changes.
The problem is this code in the CheckState method:
if (state ~= z.state) then
z.state = state
self:OnStateChanged(state, reason)
end
In the prototype class z points to core (ZOMGBuffs), which means that z.state updates the state in core. When the first module notices a state change it will write the new state in core. When the second module processes its events and calls CheckState it will not go into the if-statement because it also checks the state in core (which is already updated by the previous module) so it does not detect any state change at all.
In my opinion the logic is flawed and that is why I moved it to core instead. I thought it was better to let core handle it and just notify all interested modules about the state change. Maybe you want to change it so that every module keeps its own state flag and calls CheckState by themselves and that's fine too. Just make it work :).
I've been having some trouble recently where the 'pop up' box of buffs from the icon occasionally just gets stuck and won't go away when I move my mouse away from it. I don't think there were any errors. I tried enabling and disabling the mod, but the box returns 'popped out' and won't go away... I end up having to reload UI when it happens. Is it just me? :(
Will need the complete error report for this. That error could be coming from anywhere. You need to copy'n'paste the stack trace from BugSack or Swatter, whatever you use. If you don't use either, then start using one because those 1 line errors are useless 9 times out of 10. :)
That's all the BugSack window shows.
I can see I've actually gotten it 4 times, happens just as I *ding*:
[2008/09/20 23:01:10-2257-x187]: ZOMGBuffs-65478\ZOMGBuffs.lua:132: bad argument #1 to 'pairs' (table expected, got string)
---
[2008/09/22 13:29:17-2264-x159]: ZOMGBuffs-65478\ZOMGBuffs.lua:135: bad argument #1 to 'pairs' (table expected, got string)
---
[2008/09/22 15:26:59-2265-x372]: ZOMGBuffs-65478\ZOMGBuffs.lua:135: bad argument #1 to 'pairs' (table expected, got string)
---
[2008/09/23 22:36:04-2271-x552]: ZOMGBuffs-65478\ZOMGBuffs.lua:138: bad argument #1 to 'pairs' (table expected, got string)
---
Can Imagine something was update since it's now line 138.
my updater is pulling down the portals module incorrectly. it is putting an empty folder called zomgbuffs_zomgportals into the addons folder, and the correct portals folder is in the zomgbuffs main folder. i keep having to manually fix it after every update. could we get a fix for the folder structure?
got this error today when i was in arathi basin, not sure what triggered it:
ZOMGBuffs-65478\\ZOMGBuffs.lua:3864: attempt to index field 'db' (a nil value)\n\n
first error i have ever gotten from zomgbuffs, so i assume its one of the recent builds causing the error. only option i have changed with most recent build is to not show the zomgbuffs name on the icon (even though it still seems to be displaying even with the option off).
got this error today when i was in arathi basin, not sure what triggered it:
ZOMGBuffs-65478\\ZOMGBuffs.lua:3864: attempt to index field 'db' (a nil value)\n\n
first error i have ever gotten from zomgbuffs, so i assume its one of the recent builds causing the error. only option i have changed with most recent build is to not show the zomgbuffs name on the icon (even though it still seems to be displaying even with the option off).
Fixing error. And I'll redo the old icon, it has hard coded the icon text. :)
Zeksie, you have a bug in filelist.wau: ZOMGBuffs_Portalz is spelled as ZOMGBuffs_ZOMGPortalz. Due to this (I think) the Portalz module doesn't get extracted to separate directory :(
Zeksie, you have a bug in filelist.wau: ZOMGBuffs_Portalz is spelled as ZOMGBuffs_ZOMGPortalz. Due to this (I think) the Portalz module doesn't get extracted to separate directory :(
Oops. Thanks! :)
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
I'm still having trouble with the latest ZOMGBuffs in WoW Live where weapon buffs like rogue poisons or shaman weapon imbues are not detected properly.
To get it into a funny state, manually cast windfury weapon on your weapon. At this point, ZOMGBuffs should still say that you need to cast it. Click the ZOMGBuffs icon to recast it and the notification goes away. Right-click the buff icon to remove it and ZOMGBuffs doesn't notice. Mount up and briefly ZOMGBuffs will show the notification for Windfury but it will disappear due to no buffing while mounted. Dismount and ZOMGBuffs will still not notice that you need Windfury weapon.
Similar things happen with Rogue poisons.
I dislike the whole way it's handled.. But it looks like I'm going to have to make a translation table of spell/item names -> weapon enchant names. Rarely are they the same.. :|
I added the PARTY_MEMBERS_CHANGED. The rest of the code has changed a little since you posted that, so if you could update and check it that would be cool :)
ZOMGBuffs\\ZOMGBuffs_Portalz\\ZOMGBuffs_Portalz.lua:2: attempt to index global 'z' (a nil value).
[2008/09/23 08:50:07-1907-x1]: ...ns\ZOMGBuffs\ZOMGBuffs_Portalz\ZOMGBuffs_Portalz.lua:2: attempt to index global 'z' (a nil value):
---
Another issue I found is that automatic template switching seems not to work. I did setup a solo and group setting for non self buffs and activated autoswitch for solo and party. When Im invited to a group it never switches automatically. I always have to do it myself.
Meh. Forgot the filelist.wau too. Will post a fix in a few mins.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumSure! I have made a patch against revision 81980 that you should be able to apply using TortoiseSVN to get it working. I have attached it to this post.
Please don't hesitate to ask if you have any questions about my modifications. (I have only tested it in parties, not in raids.)
I've gotten this error the last two times I leveled(to 36 and 37) on my retri paladin.
Mmm, no. You missed the changes I put into modulePrototype, Raid and blessings modules. Which now check raid/party changes as this does, but in the modules rather than core.
Moving the check state thing to core is not really necessary imo. Could you test it out as-is without your changes.
Will need the complete error report for this. That error could be coming from anywhere. You need to copy'n'paste the stack trace from BugSack or Swatter, whatever you use. If you don't use either, then start using one because those 1 line errors are useless 9 times out of 10. :)
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThe problem is this code in the CheckState method:
if (state ~= z.state) then
z.state = state
self:OnStateChanged(state, reason)
end
In the prototype class z points to core (ZOMGBuffs), which means that z.state updates the state in core. When the first module notices a state change it will write the new state in core. When the second module processes its events and calls CheckState it will not go into the if-statement because it also checks the state in core (which is already updated by the previous module) so it does not detect any state change at all.
In my opinion the logic is flawed and that is why I moved it to core instead. I thought it was better to let core handle it and just notify all interested modules about the state change. Maybe you want to change it so that every module keeps its own state flag and calls CheckState by themselves and that's fine too. Just make it work :).
That's all the BugSack window shows.
I can see I've actually gotten it 4 times, happens just as I *ding*:
Can Imagine something was update since it's now line 138.
ZOMGBuffs-65478\\ZOMGBuffs.lua:3864: attempt to index field 'db' (a nil value)\n\n
first error i have ever gotten from zomgbuffs, so i assume its one of the recent builds causing the error. only option i have changed with most recent build is to not show the zomgbuffs name on the icon (even though it still seems to be displaying even with the option off).
Yeah, it should be using self instead of z, thanks.
Fixing error. And I'll redo the old icon, it has hard coded the icon text. :)
seen you posted a fix for the newest version, but i'm still getting spammed with errors concerning line 3864.
Oops. Thanks! :)