Is there any way to add a "just buff me!" or "buff self first!" toggle(s) for BGs?
When I res in AV and I'm the only one around, I end up having to manually buff myself. If there was a toggle along those lines, it would work perfectly.
Other than that, I've got no complaints. The mod works beautifully. My mage, druid and hunter all love it!
just started using this and there are a few problems i have, these have been mentioned before in this post, but confirming them:
1. would like to see a way to disable the chat spam when buffing someone. i could not find an option for this.
2. sink output is bugged, all the options are selected.
very nice addon, been looking for something like this.
Ran into an issue last night with pallypower compatibility involving being the extra paladin outside the instance to throw an extra set of blessings up before people zone in for a particular boss. Essentially I'm the only paladin in my new guild who uses ZOMGbuffs (to my knowledge anyway) and the paladin who was promoted for setting up pally power couldn't get any blessing assignments to stick for me so long as I was in group 8 (blessingmanager module set to 5 group mode). Everything he changed would seemingly get auto-swapped back... probably by ZOMGbuffs but I can't really be 100% sure of course. I was never even given any indication that he was changing my assignments, though I certainly believe he was. Needless to say this was a little frustrating and I ended up just going and downloading pallypower and disabling ZOMG for the duration to get things working properly.
Any idea what was going wrong there? Does ZOMG more or less ignore or deny blessing assignments from the comm channel while I'm outside of the "active" raid groups or something? I ask that mostly because it could match from how the blessings manager screen only shows paladins who are in groups 1-5 when the mod is set that way...
One thing I have noticed is that when doing group buffing, even if I only have the groups that I am buffing checked that it still pauses the buffing for the rest of the raid to arrive. Any thoughts?
Hello,
I have a little problem with ZOMGBuff. I have Improved Blessing of Wisdow but the lead Paladin can't see it with PallyPower. I have to install PallyPower so the lead can see my Improved Blessing.
Is it normal ?
Seem to be having an issue with the shaman weapon buffs. As a test, I set flametongue to main hand, and windfury to off hand in the Self Buffs menu. Reminders would pop up with no issue for the main hand, but were not showing up for the offhand. Then when manually buffing the offhand, the notice would pop up that the off hand needed buffed (which just was done manually), and would stay up (shouldn't since it's already on) but went away again right after clicking to reapply it from ZOMG (as it should). This persisted through every occurrence of buffs expiring last night while testing (just recently acquired dual wield and started using it).
I'm guessing this is what was referred to a few posts back with the weapon buffs not working properly for shaman and rogue?
Any update on this? It seems only to switch one template.
I have taken a look at the problem with ZOMGBuffs failing to switch templates automatically and I think I have fixed it. At least it works now for switching between solo/party. I haven't yet tried the other modes.
Ok, this is going to be a bit technical now. If you just want the "hotfix" you can download my two patched script files attached to this post and extract them in the ZOMGBuffs folder. The patch is based on revision r78152.1.
* BUG INFO
The first problem with the auto switching is that ZOMGBuffs does not listen to the PARTY_MEMBERS_CHANGED event so I corrected that.
The second problem is that the CheckStateChanged() method is run for each loaded module but it changes a global state variable, so only the first module gets to see the state change. Since the state is indeed global it should not be checked for each module. I therefore moved out the CheckStateChanged() method to the ZOMGBuffs.lua file and it is now run only once when your group is updated, and IF the state changes it signals this to all buffing modules.
There is also a typo in ZOMGBuffs.lua so it listens for RAID_ROSTER_UPDATED instead of RAID_ROSTER_UPDATE which is the correct name of the event. I'm not doing any raids so I have no idea what kind of problems this may yield. Just thought I'd point it out. I have corrected that in my patch as well.
I cleaned up ZOMGModulePrototype.lua and removed some things that were no longer needed. I hope I did not break anything! :)
So, in the Blessings Manager you can drag and drop greater blessings between paladins for a class to swap them around. This is cool. However, it doesn't move the exceptions with it. It would super peachy keen if it did.
No idea if this has been reported. Did a skimming search, but came up empty.
When on the IQD/MgT (and likely the raid SwP - haven't been there, so not positive), players sometimes have a zone-buff called K'iru's Song of Victory. When you attempt to buff yourself or your party (manually or via ZOMGBuffs) with Arcane Intellect/Brilliance, the zone-buff removes your personal buff, since it gives the same amount of Intellect. The buff also gives Stamina, so I would assume Priest buffs would cause the same thing to occur. The annoyance here is that ZOMGBuffs thinks that you do not have AI/AB and that you need to cast it, preventing ZOMGBuffs from moving on and reporting other buffs as missing.
While I suppose I could set up some sort of template for the IQD/MgT to not suggest AI/AB at all (I think?), I just felt that this may be something ZOMGBuffs should auto-detect. There are probably more zone/npc/item buffs which remove buffs you can cast, causing a similar issue, but I have not encountered any as of yet.
...is this considered an "exception buff" (10 minute blessing) and will ZOMGBuffs treat it as such so that I will be told when that 10 minute blessing is expiring/expired?
I have taken a look at the problem with ZOMGBuffs failing to switch templates automatically and I think I have fixed it. At least it works now for switching between solo/party. I haven't yet tried the other modes.
Many thanks, it is working like a charm for me now! :)
Now if only the pre-expiry rebuff setting could be included into the templates this would be the perfect buff mod for me as mage.
This may be a stupid question, but why isn't there a "Refresh" button in the blessings assignments, like in pally power? The Broadcast button only sends out your setting assignments to other players. The Refresh button should READ what the other paladins have set. I have found that when you don't have raid assist, the blessings manager still lets you assign blessing for other pallys, but they don't register on their pally power. So what you set for them changes in your interface, but doesn't update on theirs.
I don't know how in technical terms how pally power works, but I'm sure in PP whenever someone clicks a blessing, a "challenge and response" request is sent to the other player's PP. Then it replies if the new setting is accepted or not. If the reply is yes, THEN it is reflected in your own interface. Because ZOMG doesn't do this (again i'm not sure technically) it's the cause of many compatibility problems between ZOMG and PP. The problem with ZOMG is it is written assuming that it will accept all assignments, but with PP the default is to not accept assignment from other unless they have raid assist.
Although the blessing manager of ZOMG is far superior than that of PP's, until the compatibility problems are ironed out, I am still forced to use PP as unfortunately I'm the only one in the guild that uses ZOMG, and our class leader refuses to use ZOMG for some reason, and it's him most of the time that has raid assist and not me.
I unfortunately had no time to read this entire thread. But i wanted to say that i really love this Addon.
But I have two proposals
a) Would it be possible that in the list only those buffs are shown that are provided by your actual class.
b) I would kill for cyCircled support.
So again thanks for the addon ans the work you are doing.
This addon is awesome. Only 1 thing I can come up with atm, that would make it better.
Is it possible to have it react to "K'iru's Song of Victory" at the SSO island?
Mages can't cast int when people have that buff, so it shouldn't keep trying. I'm not sure if the sta part blocks priests too. Haven't tested that.
It has spellid 64302, and a duration of "0" when checked (looks like that will break quite a bit of checks in your code)
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
When I res in AV and I'm the only one around, I end up having to manually buff myself. If there was a toggle along those lines, it would work perfectly.
Other than that, I've got no complaints. The mod works beautifully. My mage, druid and hunter all love it!
1. would like to see a way to disable the chat spam when buffing someone. i could not find an option for this.
2. sink output is bugged, all the options are selected.
very nice addon, been looking for something like this.
Any idea what was going wrong there? Does ZOMG more or less ignore or deny blessing assignments from the comm channel while I'm outside of the "active" raid groups or something? I ask that mostly because it could match from how the blessings manager screen only shows paladins who are in groups 1-5 when the mod is set that way...
Any update on this? It seems only to switch one template.
I have a little problem with ZOMGBuff. I have Improved Blessing of Wisdow but the lead Paladin can't see it with PallyPower. I have to install PallyPower so the lead can see my Improved Blessing.
Is it normal ?
I'm guessing this is what was referred to a few posts back with the weapon buffs not working properly for shaman and rogue?
I have taken a look at the problem with ZOMGBuffs failing to switch templates automatically and I think I have fixed it. At least it works now for switching between solo/party. I haven't yet tried the other modes.
Ok, this is going to be a bit technical now. If you just want the "hotfix" you can download my two patched script files attached to this post and extract them in the ZOMGBuffs folder. The patch is based on revision r78152.1.
* BUG INFO
The first problem with the auto switching is that ZOMGBuffs does not listen to the PARTY_MEMBERS_CHANGED event so I corrected that.
The second problem is that the CheckStateChanged() method is run for each loaded module but it changes a global state variable, so only the first module gets to see the state change. Since the state is indeed global it should not be checked for each module. I therefore moved out the CheckStateChanged() method to the ZOMGBuffs.lua file and it is now run only once when your group is updated, and IF the state changes it signals this to all buffing modules.
There is also a typo in ZOMGBuffs.lua so it listens for RAID_ROSTER_UPDATED instead of RAID_ROSTER_UPDATE which is the correct name of the event. I'm not doing any raids so I have no idea what kind of problems this may yield. Just thought I'd point it out. I have corrected that in my patch as well.
I cleaned up ZOMGModulePrototype.lua and removed some things that were no longer needed. I hope I did not break anything! :)
When on the IQD/MgT (and likely the raid SwP - haven't been there, so not positive), players sometimes have a zone-buff called K'iru's Song of Victory. When you attempt to buff yourself or your party (manually or via ZOMGBuffs) with Arcane Intellect/Brilliance, the zone-buff removes your personal buff, since it gives the same amount of Intellect. The buff also gives Stamina, so I would assume Priest buffs would cause the same thing to occur. The annoyance here is that ZOMGBuffs thinks that you do not have AI/AB and that you need to cast it, preventing ZOMGBuffs from moving on and reporting other buffs as missing.
While I suppose I could set up some sort of template for the IQD/MgT to not suggest AI/AB at all (I think?), I just felt that this may be something ZOMGBuffs should auto-detect. There are probably more zone/npc/item buffs which remove buffs you can cast, causing a similar issue, but I have not encountered any as of yet.
If a player whispers for a buff, for example,
...is this considered an "exception buff" (10 minute blessing) and will ZOMGBuffs treat it as such so that I will be told when that 10 minute blessing is expiring/expired?
Many thanks, it is working like a charm for me now! :)
Now if only the pre-expiry rebuff setting could be included into the templates this would be the perfect buff mod for me as mage.
I don't know how in technical terms how pally power works, but I'm sure in PP whenever someone clicks a blessing, a "challenge and response" request is sent to the other player's PP. Then it replies if the new setting is accepted or not. If the reply is yes, THEN it is reflected in your own interface. Because ZOMG doesn't do this (again i'm not sure technically) it's the cause of many compatibility problems between ZOMG and PP. The problem with ZOMG is it is written assuming that it will accept all assignments, but with PP the default is to not accept assignment from other unless they have raid assist.
Although the blessing manager of ZOMG is far superior than that of PP's, until the compatibility problems are ironed out, I am still forced to use PP as unfortunately I'm the only one in the guild that uses ZOMG, and our class leader refuses to use ZOMG for some reason, and it's him most of the time that has raid assist and not me.
But I have two proposals
a) Would it be possible that in the list only those buffs are shown that are provided by your actual class.
b) I would kill for cyCircled support.
So again thanks for the addon ans the work you are doing.
If anything, ButtonFacade support would be cool.
You can configure which buffs are shown in the list through the menu. I think it's under Display -> List, or something like that.
Is it possible to have it react to "K'iru's Song of Victory" at the SSO island?
Mages can't cast int when people have that buff, so it shouldn't keep trying. I'm not sure if the sta part blocks priests too. Haven't tested that.
It has spellid 64302, and a duration of "0" when checked (looks like that will break quite a bit of checks in your code)