Authors CurseForge

Okay, was doing some checking, think I might have found the error. r77429 should fix it.

Everything works again, thank you ... can't play WoW without this mod ever again :)

This one definately deserves some testrunns.

As an enchanter it might prove very usefull.

This addon rocks! saves me so much time in raid, lots of <3 to you!

Is there any way to set up for instance "pass on all BoP that aren't cloth manual on the rest" without having to make like a truckload filters?


Would raelly be nice if you could select multiple choises in the armor/weapon types into one filter (basily make it autopass any BoP epic i can't equip) instead of having to make a truckload of filters (i will have to make one for eash armor/weapon type i can't use as it is now and that amkes it hard to keep track of).

Also on a small layout point.

Is it possible to make the layout of the window more like your standard windows file list (ie a list of all filters on the right and all the options to the left) so that you can see more of the filter list at the same time?

Also, any way to move the output to a different channel? i don't use general while raiding cos of the pammage from /1 /s and guild

I really liked your idea with having a list of active filters. I have been wanting to make it so you can select multiple filters for some time, but was wrestling with how to display it.

So.. there are now two lists: one is of available filters and the other is of active filters.

Also made it so you can add multiple filters of the same type (ie - add rare and epic quality filters at the same time) Each filter must have at least one match.

An example of the logic:
Quality:
Rare
Epic
Binds on:
None
Equip
Use

This will match all (Rare OR Epic) AND (None OR Equip OR Use)

When it upgrades your old database, you'll still see a lot of 'Any's, you can remove those from the active filters to clean it up if you so choose.

A few notes: you can either select a filter to remove individually, or select the title of the filter to remove all of that type. (You can also shift-right-click to remove instead of clicking the remove button)


As for sending output to another channel, I'll add that later, I want to make sure I have the multiple filter thing working first. Get to work beta testers! :)

The new filters are looking nice.

Went from 24 filters to manage BT/MH/SWP (8 for each instance) down to 2 filters for all of em.

Simmilar with BoE items, down from 3 to 1.

Sofar they seem to work nicely haven't been able to fully test them yet thou.

Popped an error while klicking around with the filters:

[2008/07/25 00:59:11-2501-x1]: PassLoot-3.3\Modules\ItemName.lua:140: attempt to index field '?' (a nil value)
PassLoot-3.3\Modules\ItemName.lua:60: in function <Interface\AddOns\PassLoot\Modules\ItemName.lua:58>
<in C code>: in function `Hide'
PassLoot-3.3\MainGUI.lua:67: in function `DisplayCurrentOptionFilter'
PassLoot-3.3\MainGUI.lua:47: in function `DisplayCurrentRule'
PassLoot-3.3\MainGUI.lua:138: in function `SetCurrentRule'
<string>:"*:OnClick":1: in function <[string "*:OnClick"]:1>

 ---

But as far as i can tell everything worked propely depite the error (seems it was just an objection to me klicking around to much without really looking where i klicked).

Ok, tried to reproduce bug. I got an error on that line, when i had 2 item name filters, i had the 2nd highlighted, and was in the middle of editing it, then shift-right clicked the first one.

That sound familiar?

edit: Okay, was able to produce 3 different bugs all similar in nature. They are just display bugs. Doesn't look like they will impede operations.

edit2: fixed.

Updated for WotLK compatibility

Added a ItemLevel and RequiredLevel filters
Added a Settings tab, where the quiet and enable mod checkbox lives now
Added an option to change output to different chat frames.
Changed the ShowTooltip() so if you get errors when mousing over things.. lemme know

I made a filter for Item vendor prices, but I havn't added it to the core module list yet. Since it uses the ItemPrice-1.1 library which is a good 250+ KB, I was thinking I might make it a separate addon instead of forcing the user to load a library they might/might not use. Then I got to thinking I might just move all the modules to their own addons.

I can't decide what to do.

Just query into existing mods that have item prices? Ludwig_SellValue etc.

Great mod btw, a must have.

Personally I use Valuation; I think most "vendor value" addons/libraries have a pretty simple API for querying them, and most addons that show vendor prices without maintaining their own database just support all of them.

Loot counter isn't working, was working perfectly with Mark of Illidari before the update. I've changed no rules.

Here's the loot counter after getting 4 Marks:

Quote from reale »

Loot counter isn't working, was working perfectly with Mark of Illidari before the update. I've changed no rules.

Which build was working fine?
79076 (July 24) I made it multiple filters (could have messed up here)
79132 (July 25) I fixed a ui error
80112 (Aug 10) I attempted to add WotLK compatibility (this is where i'd think it broke for you?)
80189 (Aug 11) I changed how I pass information to display in tooltips, added in itemlevel/required level filter, added changable chatframe ouput, and added a Settings tab
80512 (Aug 15) I added in the ItemPrice filter, LootWon filter unchanged at all.
80803 (Aug 22) I edited the .toc and .lua file descriptions to show version 3.4 instead of 3.3

I am gonna push another change in a minute to fix a few wotlk things, saw some arg1's and this's

Pretty sure it was this one:

80112 (Aug 10) I attempted to add WotLK compatibility (this is where i'd think it broke for you?)

Thank you

Well, I've tried every build that I listed, and I can't seem to replicate the problem. I had 3 rules that I tested in deadmines and each rule's counter incremented when it matched it's corresponding rule.

When it said it rolled on the marks, which rule did it say it used? It should have been in parenthesis. I'm wondering if it didn't match the rule you have highlighted (maybe the item name or some other filter is bugged, and it's rolling on a rule further down? or further up?)

I'll continue to keep looking into it.


edit: if you want to see what's going on, you can do a /script PassLoot.DebugVar = true
Be prepared for spam tho, and to turn it off, just /script PassLoot.DebugVar = false

Hrm... something I hadn't considered... Did it stop working for you when I changed the UI itself to let you set up multiple filters of the same type? (ie your screenshot is of the new layout vs the older layout)

I don't remember exactly when I'm sorry, confirmed not working again tonight in BT. I'll redo my rules and check again next week.

-ty

Ok, I think I found the bug.. and man was it hard to find.

If you have not added the counter or comparison filters to a rule yet, and you add the counter first it doesn't add the counter filter correctly. (if you add the comparison first, it automagically adds the counter filter.. and does it right)

I'm throwing in a better data validation check on each of the filters. If it detects invalid data, it sets it to a default value (0 for the counter), and saves it.

Hopefully this should fix your problem. And hopefully you didn't get too much grief from your guildmates when rolling when you shouldn't have. :)

Could you please use the GetSellValue API rather than referencing ItemPrice-1.1 directly? I already have a sell-value addon that doesn't use ItemPrice-1.1, and I'd really rather not have to load two sell-value databases. :P