Authors CurseForge

There seems to be a bug regarding the pet foods, e.g http://www.wowhead.com/?item=33874 and http://www.wowhead.com/?item=43005 show as adding AP to the pet, but since it's a pet only buff and not a Hunter buff then Hunter vs Wild shouldn't be transferring any AP to the pet from the stamina.

I just noticed that if I open one item link (in this case some epic shoulders), and then clicked repeatedly a professions link (tailoring), RB's Stat Summary on the item tooltip would multiply upon each click. (Playing on EU, Installed:1.4.4 (Released: 2009/04/14))

Does anyone know if it would be possible to code RatingBuster to not drop framerates a lot when mousing over items? It seems to be caused by the onupdate the client does for equipment tooltips.

Quote from Xinhuan

Not possible. RatingBuster already caches the tooltips, so all its doing on every OnUpdate is modifying the lines of the refreshed tooltip (Blizzard calls GameTooltip:SetBlah() every OnUpdate) that needs to be modified from a cache.

To solve the problem, Blizzard has to introduce a throttle into their OnUpdate code. They have already done this for bag buttons and action bar buttons since a year or two ago, but they did not update anything else, including but not limited to the mailbox buttons, the equipment buttons and the AH buttons.

I see. I hope Blizzard eventually throttle the rest then. It's quite annoying to mouse over a loot roll box to check out item stats and have my framerate cut in half, worst part about OnUpdate is higher end systems get hit more by the framerate hit due to performing more OnUpdates, though I guess capping my framerate could help.

If you're really seeing your framerate drop by 50% when you view an item tooltip, I'd say you have much bigger problems than anything RatingBuster is doing. I'm running about 125 addons on mediocre hardware (2.4 GHz single-core processor, 2 GB of RAM) and have no perceptible framerate loss when viewing item tooltips.

Quote from Phanx

If you're really seeing your framerate drop by 50% when you view an item tooltip, I'd say you have much bigger problems than anything RatingBuster is doing. I'm running about 125 addons on mediocre hardware (2.4 GHz single-core processor, 2 GB of RAM) and have no perceptible framerate loss when viewing item tooltips.

It's definitely RatingBuster, I can mouse over an item have the framerate drop, then disable the stat summaries and mouseover the same item and not have it drop, like I said the better the system you're running WoW on the worse the problem, when you're getting over 100 fps, that means OnUpdate is running over 100 times per second, on a lower system getting lower fps this isn't happening.

Also the fact it isn't occurring for bag and action bar buttons which are apparently throttled for OnUpdate also proves it isn't anything odd going on with my system or other addons.

Quote from Mikari

It's definitely RatingBuster, I can mouse over an item have the framerate drop, then disable the stat summaries and mouseover the same item and not have it drop, like I said the better the system you're running WoW on the worse the problem, when you're getting over 100 fps, that means OnUpdate is running over 100 times per second, on a lower system getting lower fps this isn't happening.

Also the fact it isn't occurring for bag and action bar buttons which are apparently throttled for OnUpdate also proves it isn't anything odd going on with my system or other addons.

Hm i run a dualcore 3.0 with 4GB of ram and a 512 graphics card and i notise no FPS drop whatsoever.

That the problem goes away when dissabeling RB donsen't mean its actually RB's code causing it, it might just aswell be another addon conflicting with RB.

Have you tested with only RB, and do you get the same effect when running only RB.

The framerate drop is much higher if you're starting at a higher fps.

This was after an item had just dropped in a heroic:

http://img517.imageshack.us/img517/6309/beforeo.png

This is after I moused over the item to see the tooltip:

http://img22.imageshack.us/img22/7424/aftern.png

If you have Vsync enabled to cap the framerate you won't notice it much at all, in places like Dalaran where I'm only getting around 45-50 fps it only drops to around 35 when mousing over items, e.g when I'm inspecting someone so it's harder to notice the drop.

Disabling stat summaries fixes the issue, I'm not quite sure how stat summaries is different to converting the ratings to percentages but it's the only thing causing the slow downs.

Quote from Xinhuan

You won't notice the FPS drop from 124 to 86 when standing in say Ironforge unless you were actually looking at a FPS meter. Nevertheless, the FPS drop is still there.

With notise, i mean nothing shows on the FPS meter when mousing over items, it keeps swaying in a +/- ~5-10 range.

Quote from Mikari

The framerate drop is much higher if you're starting at a higher fps.

This was after an item had just dropped in a heroic:

http://img517.imageshack.us/img517/6309/beforeo.png

This is after I moused over the item to see the tooltip:

http://img22.imageshack.us/img22/7424/aftern.png

If you have Vsync enabled to cap the framerate you won't notice it much at all, in places like Dalaran where I'm only getting around 45-50 fps it only drops to around 35 when mousing over items, e.g when I'm inspecting someone so it's harder to notice the drop.

Disabling stat summaries fixes the issue, I'm not quite sure how stat summaries is different to converting the ratings to percentages but it's the only thing causing the slow downs.

I just tested in daily Hc and i have summaries and all active, the difference when mousing over was within the normal +/- 5-10 FPS fluctuations i normally have.

What framerates are you getting, and what is it dropping to? Because I'm guessing you're vsynced or capping it, because I just disabled all addons except ratingbuster and then inspected someone in IF and had the same frame drop, went from 100 fps to 36 fps.

Actually even vsynced to 60 fps it still drops to 36 fps, it's either only affecting my system or your fps is too low for the OnUpdates to cause much of an issue.

Quote from Xinhuan

What are you mousing over in your tests? Remember I said a few posts up that Blizzard Bags and Blizzard Action Bars do not have this issue because they are OnUpdate throttled?

To see the problem, you should try mousing over items in the Blizzard loot rolling window, the Blizzard loot frame or any item in the Blizzard AH or Blizzard mailbox.

Since it was rollwindow on your screenshot i used that as referenace and had no negative effects on FPS.

Just tested AH aswell with FPS is being stable despite lots of extra tooltips being showed.

Quote from StormFX

I don't know if this is an issue with CC, LibDualSpec-10 or RB, but RB is now the second add-on I've found that doesn't pull LibDualSpec as a library through CC when running disembedded. It has to be manually installed.

Any chance of you throwing in wrappers so RB doesn't throw errors if LDS is missing?

I think it just takes time for CC to update its list, I don't use CC so I don't know if its still broken.

Quote from StormFX

Since LibDualSpec isn't actually a required library for the addon to function, can you put a wrapper around it? There's no reason for RB to spit out errors if the library's not there.

done in r246

The armor penetration rating-to-percentage conversion appears to be changing significantly on the 3.2.2 PTR. This conversion is already a convoluted one, so you may want to investigate this for LSL.