I got to fiddle with the new version last night, and I love that it shows mp5,etc. now. :) But... I think the not casting mp5 values are a little off... For example - I removed my shoulders with spirit on them - without the spirit they added (don't remember the exact number atm), I had 185 mp5 while not casting. Looking at the tooltip for my shoulders, RB says that the spirit will add 4 mp5. I put them on and my mp5 goes up to 190. I got similar results with all of my gear that had spirit on them. I do have a talent that increases mana regen *while casting* but these are the not casting values I was observing...
[2007/04/07 13:30:22-702-x1]: RatingBuster\RatingBuster-Locale-frFR.lua:12: AceLocale(RatingBuster): Improper translation exists. "Show Spell Crit from Intellect" is likely misspelled for locale frFR.
Ace2\AceLibrary\AceLibrary.lua:96: in function `error'
AceLocale-2.2-27198 (Ace2):212: in function `RegisterTranslations'
RatingBuster\RatingBuster-Locale-frFR.lua:12: in main chunk
---
[2007/04/07 13:30:22-702-x1]: RatingBuster-1.0.0 (r$Revision: 31849 $)\RatingBuster.lua:543: AceConsole-2.0: args.stat: "name" must be a string
Ace2\AceLibrary\AceLibrary.lua:96: in function `error'
AceConsole-2.0-31981 (Ace2):2462: in function `RegisterChatCommand'
RatingBuster-1.0.0 (r$Revision: 31849 $)\RatingBuster.lua:543: in main chunk
I've added some code to RatingBuster to display the bonus changes that would occur if you equiped the item. If you can't wear the armor type, nothing is displayed. Hopefully this or something similar will be considered for addition by Whitetooth.
I've added some code to RatingBuster to display the bonus changes that would occur if you equiped the item. If you can't wear the armor type, nothing is displayed. Hopefully this or something similar will be considered for addition by Whitetooth.
What would be nice is if this could be modified into a Library that can be used by other mod authors and implemented into their mods like ItemBonusLib.
I'm using the StatLogic:GetDiff method then formatting the output.
The above screen shots show EquipCompare running. Items that can be equipped in multiple places are compared to both items you currently have equipped.
You'll notice the EquipCompare ring tooltips don't show bonus change data in both columns. This view is the same tooltip you would get if you were directly hovering over one of your equipped rings. It shows what bonus changes would happen if you un-equipped that ring and equipped it in the other ring slot.
Quote from Nomad_Wanderer »
Quote from nrpieper »
I've added some code to RatingBuster to display the bonus changes that would occur if you equiped the item. If you can't wear the armor type, nothing is displayed. Hopefully this or something similar will be considered for addition by Whitetooth.
I've added some code to RatingBuster to display the bonus changes that would occur if you equiped the item. If you can't wear the armor type, nothing is displayed. Hopefully this or something similar will be considered for addition by Whitetooth.
Yep, This function is planned for the 1.1 release.
Also planned for future releases is a custom points system, with support Static points value like AEP, and Dynamic points value like TankPoints, with a formula editor for custom formulas.
I'll have a chance to work on RatingBuster again tomorrow when I get a 5 day break from work :)
I got to fiddle with the new version last night, and I love that it shows mp5,etc. now. :) But... I think the not casting mp5 values are a little off... For example - I removed my shoulders with spirit on them - without the spirit they added (don't remember the exact number atm), I had 185 mp5 while not casting. Looking at the tooltip for my shoulders, RB says that the spirit will add 4 mp5. I put them on and my mp5 goes up to 190. I got similar results with all of my gear that had spirit on them. I do have a talent that increases mana regen *while casting* but these are the not casting values I was observing...
I can give more detailed info if you need it.
Are the values off by a lot or just off by 1?
If its jst off by 1 then its because the mana regen from spirit is not a whole number, so if you already have 185.6 mp5, and add 4.6 mp5 it will show as 190.
What would be nice is if this could be modified into a Library that can be used by other mod authors and implemented into their mods like ItemBonusLib.
StatLogic-1.0 is the library that does all the dirty work for RatingBuster :p
Yep, This function is planned for the 1.1 release.
Also planned for future releases is a custom points system, with support Static points value like AEP, and Dynamic points value like TankPoints, with a formula editor for custom formulas.
I'll have a chance to work on RatingBuster again tomorrow when I get a 5 day break from work :)
cool, i was just thinking it would be nice to have the functionality of ratingbuster, bonuses, and pawn all in one addon. checked this thread and you already have it planned. good news :D
Yep, This function is planned for the 1.1 release.
Also planned for future releases is a custom points system, with support Static points value like AEP, and Dynamic points value like TankPoints, with a formula editor for custom formulas.
Ooo.. awesome! I'd love to be able to consolodate RatingBuster and Pawn.
Can we get a fix for the Lib errors for the current embedded version? Downloading the libs separately works fine but I prefer embedded libs that I don't have to manually update.
[2007/04/07 13:30:22-702-x1]: RatingBuster\RatingBuster-Locale-frFR.lua:12: AceLocale(RatingBuster): Improper translation exists. "Show Spell Crit from Intellect" is likely misspelled for locale frFR.
Ace2\AceLibrary\AceLibrary.lua:96: in function `error'
AceLocale-2.2-27198 (Ace2):212: in function `RegisterTranslations'
RatingBuster\RatingBuster-Locale-frFR.lua:12: in main chunk
---
the same.two errors
[2007/04/07 13:30:22-702-x1]: RatingBuster-1.0.0 (r$Revision: 31849 $)\RatingBuster.lua:543: AceConsole-2.0: args.stat: "name" must be a string
Ace2\AceLibrary\AceLibrary.lua:96: in function `error'
AceConsole-2.0-31981 (Ace2):2462: in function `RegisterChatCommand'
RatingBuster-1.0.0 (r$Revision: 31849 $)\RatingBuster.lua:543: in main chunk
hi, update FR for rating buster (two minors errors but we cant see spell crit from intellect and crit from agility, and there was a error message when i've load my ui)
2 lines must be changed in locale fr :
["Show Crit from Agility"] = "Montrer les effets de l'agilit\195\169 sur les coups critiques en m\195\169l\195\169e",
["Show Spell Crit from Intellect"] = "Montrer les effets de l'intelligence sur les coups critiques des sorts",
to :
["Show Crit chance from Agility"] = "Montrer les effets de l'agilit\195\169 sur les coups critiques en m\195\169l\195\169e",
["Show Spell Crit chance from Intellect"] = "Montrer les effets de l'intelligence sur les coups critiques des sorts",
i use both rating buster and tank point, and altought the option are activated i don't have the diff/toltal tankpoint of an item in its tooltip neither the compare stat of ratingbuster.
i use both rating buster and tank point, and altought the option are activated i don't have the diff/toltal tankpoint of an item in its tooltip neither the compare stat of ratingbuster.
Is it because i am on a frFR client?
thx.
Yes, because there is still no French localization for StatLogic-1.0.
Its not a eazy task, but hopefully someone will be willing to take the time to do it :)
I Love the new options with comparing items. I only have one problem with it, and that is enchants. would it be possible to ignore the enctant part when comparing items? As the item you don't have yet obviously don't have an enchant it come out much worse than it ought to be in the calculations. as soon as you get it you will enchant and sort of zero out those differences. It's sorta the same with sockets, but you have alot more choices there so it's still viable to have them show.
It's seems kinda tricky to me to hide the enchant in thee comparison, but show it in the summary of the item. And I don't really have a solution for it. Maybe if you have an enchant compare the two items as if they both had it. let's say you weapon has a +40spell dmg enchant, if you compare it to another weapon, it will always have 40 more dmg to show for, but if make the tooltip so that rating buster assumes you will enchant the other weapon with +40spell dmg as soon as you get it (which is what you'll do in most often) and then compare the two weapons as if tehy both had +40spell dmg things would be fair agian.
Thanks for a great mod!
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI can give more detailed info if you need it.
French client : two errors
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumAnyone intrested in taking a look can downlaod my changes here: http://www.holierthanwow.com/Portals/0/Addons/RatingBuster_20070410.zip
can you screenshot the modified tooltip?
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI'm using the StatLogic:GetDiff method then formatting the output.
The above screen shots show EquipCompare running. Items that can be equipped in multiple places are compared to both items you currently have equipped.
You'll notice the EquipCompare ring tooltips don't show bonus change data in both columns. This view is the same tooltip you would get if you were directly hovering over one of your equipped rings. It shows what bonus changes would happen if you un-equipped that ring and equipped it in the other ring slot.
Yep, This function is planned for the 1.1 release.
Also planned for future releases is a custom points system, with support Static points value like AEP, and Dynamic points value like TankPoints, with a formula editor for custom formulas.
I'll have a chance to work on RatingBuster again tomorrow when I get a 5 day break from work :)
Are the values off by a lot or just off by 1?
If its jst off by 1 then its because the mana regen from spirit is not a whole number, so if you already have 185.6 mp5, and add 4.6 mp5 it will show as 190.
StatLogic-1.0 is the library that does all the dirty work for RatingBuster :p
cool, i was just thinking it would be nice to have the functionality of ratingbuster, bonuses, and pawn all in one addon. checked this thread and you already have it planned. good news :D
Ooo.. awesome! I'd love to be able to consolodate RatingBuster and Pawn.
2 lines must be changed in locale fr :
to :
just add "chance" between crit and from
Rating buster does not work on the 2.1.0 PTR. :)
It does with the newest TipHooker-1.0 lib.
Is it because i am on a frFR client?
thx.
Yes, because there is still no French localization for StatLogic-1.0.
Its not a eazy task, but hopefully someone will be willing to take the time to do it :)
It's seems kinda tricky to me to hide the enchant in thee comparison, but show it in the summary of the item. And I don't really have a solution for it. Maybe if you have an enchant compare the two items as if they both had it. let's say you weapon has a +40spell dmg enchant, if you compare it to another weapon, it will always have 40 more dmg to show for, but if make the tooltip so that rating buster assumes you will enchant the other weapon with +40spell dmg as soon as you get it (which is what you'll do in most often) and then compare the two weapons as if tehy both had +40spell dmg things would be fair agian.
Thanks for a great mod!