Great mod! A couple of suggestions for the future:
1. Set it up as a Package so that modules can be disabled from the AddOn window.
2. Add an optional (customizable?) message for refusing invites/duels/etc. I currently use DeclineDuels rather than Wuss because it /tells the other person "I do not wish to participate in duelling." Thus, they do not spam me with duels trying to figure out why they're rejected so quickly. ::)
3. Add a module to automatically open all (or all non-special? non-ammo?) bags when visiting a bank/vendor/mailbox/AH/... Edit:
4. Perhaps add an option to Sell for getting rid of soulbound stuff which can't be used? (e.g. soulbound Plate rewards for cloth-bearing classes &c.)
Thanks for writing this! A lot of these are things I've always wished for, but didn't know could be fully automated.
It always worked perfectly for me before I started using AI, so I just assumed it still did. I'm sorry. :(
Oh hey, don't be sorry! I was just giving a bit of feedback. :)
Yes, bags_and_merchants still does work, at least here. Been using it forever. It also hasn't been updated in forever ;). Last update was r26541 on Jan 29/07; the first/last real code update was in Novemeber/06 when the Ace2 version was originally committed to the SVN by Elkano.
Very, very simple code. If it doesn't work for you, perhaps its some third-party inventory mod you are using that is interfering with it or not responding to the calls the mod uses to open/close bags. Such an inventory mod not responding to its "OpenAllBags"/"CloseAllBags" calls, or similar. bags_and_merchants works just fine with the default Blizzard bags.
If it doesn't work for you, perhaps its some third-party inventory mod you are using that is interfering with it or not responding to the calls the mod uses to open/close bags. Such an inventory mod not responding to its "OpenAllBags"/"CloseAllBags" calls, or similar. bags_and_merchants works just fine with the default Blizzard bags.
It's very likely this is the case, yes. All I remember is trying it (and a number of other similar addons) out and not getting anywhere, months ago. :)
And it does the job admirably. Still, I prefer to avoid having hordes of infrequently-updated mini-addons when well-supported consolidated ones exist and thought the feature would fit well with Automaton.
I finally got tired of the Rez and Summon modules accepting things after I manually cancelled them. Turns out the fix is pretty simple. Summon cancelling was tested and works; I didn't test cancelling a resurrection, but the principle is the same so it should work.
Rez.lua
Find:
function module:OnEnable()
self:RegisterEvent("RESURRECT_REQUEST")
end
Replace with:
function module:OnEnable()
self:RegisterEvent("RESURRECT_REQUEST")
StaticPopupDialogs["RESURRECT_NO_SICKNESS"].OnCancel = function()
DeclineResurrect()
if Automaton_Rez:IsEventScheduled("Automaton_Rez") then
Automaton_Rez:CancelScheduledEvent("Automaton_Rez")
end
if UnitIsDead("player") then
StaticPopup_Show("DEATH")
end
end
end
function module:OnDisable()
StaticPopupDialogs["RESURRECT_NO_SICKNESS"].OnCancel = function()
DeclineResurrect()
if UnitIsDead("player") then
StaticPopup_Show("DEATH")
end
end
end
Summon.lua
Find:
function module:OnEnable()
self:RegisterEvent("CONFIRM_SUMMON")
end
Replace with:
function module:OnEnable()
self:RegisterEvent("CONFIRM_SUMMON")
StaticPopupDialogs["CONFIRM_SUMMON"].OnCancel = function()
if Automaton_Summon:IsEventScheduled("Automaton_Summon") then
Automaton_Summon:CancelScheduledEvent("Automaton_Summon")
end
end
end
function module:OnDisable()
StaticPopupDialogs["CONFIRM_SUMMON"].OnCancel = nil
end
I finally got tired of the Rez and Summon modules accepting things after I manually cancelled them. Turns out the fix is pretty simple. Summon cancelling was tested and works; I didn't test cancelling a resurrection, but the principle is the same so it should work.
Rez.lua
Find:
function module:OnEnable()
self:RegisterEvent("RESURRECT_REQUEST")
end
Replace with:
function module:OnEnable()
self:RegisterEvent("RESURRECT_REQUEST")
StaticPopupDialogs["RESURRECT_NO_SICKNESS"].OnCancel = function()
DeclineResurrect()
if Automaton_Rez:IsEventScheduled("Automaton_Rez") then
Automaton_Rez:CancelScheduledEvent("Automaton_Rez")
end
if UnitIsDead("player") then
StaticPopup_Show("DEATH")
end
end
end
function module:OnDisable()
StaticPopupDialogs["RESURRECT_NO_SICKNESS"].OnCancel = function()
DeclineResurrect()
if UnitIsDead("player") then
StaticPopup_Show("DEATH")
end
end
end
Summon.lua
Find:
function module:OnEnable()
self:RegisterEvent("CONFIRM_SUMMON")
end
Replace with:
function module:OnEnable()
self:RegisterEvent("CONFIRM_SUMMON")
StaticPopupDialogs["CONFIRM_SUMMON"].OnCancel = function()
if Automaton_Summon:IsEventScheduled("Automaton_Summon") then
Automaton_Summon:CancelScheduledEvent("Automaton_Summon")
end
end
end
function module:OnDisable()
StaticPopupDialogs["CONFIRM_SUMMON"].OnCancel = nil
end
Could you please commit these changes to the SVN repository?
When someone summons me while I'm in combat, my chat log says 'accepting summon' but no window pops up. I have it set to accept summons instantly. Could it wait until I leave combat, and then accept the summon then? Or better yet, wait until I've been out of combat about 10 seconds, resetting that timer if I enter combat or target a hostile target, living or dead?
Here's a modified copy of the Summon module that *should* schedule summon acceptance for 10 seconds after combat ends. If you're in combat again at that time, it reschedules for 10 seconds after it ends again. If it still hasn't accepted by the time the summon expires, it notifies you. Totally drycoded, as I can't play WoW at work. :P Please test it if you can and let me know if it works. If it does I'll add this to my above changes to commit on the SVN tonight.
Another, far simpler option, would be to leave the summon window open and I can accept it manually after having killed and looted my target. But I like automatic. ^_^ I'll give this a try.
Turns out I don't have SVN access anymore (probably because I haven't used it once in the year since I requested it :P) so I'm waiting for new SVN access. Hopefully tonight.
1. Set it up as a Package so that modules can be disabled from the AddOn window.
2. Add an optional (customizable?) message for refusing invites/duels/etc. I currently use DeclineDuels rather than Wuss because it /tells the other person "I do not wish to participate in duelling." Thus, they do not spam me with duels trying to figure out why they're rejected so quickly. ::)
3. Add a module to automatically open all (or all non-special? non-ammo?) bags when visiting a bank/vendor/mailbox/AH/...
Edit:
4. Perhaps add an option to Sell for getting rid of soulbound stuff which can't be used? (e.g. soulbound Plate rewards for cloth-bearing classes &c.)
Thanks for writing this! A lot of these are things I've always wished for, but didn't know could be fully automated.
Bags & Merchants does this and nothing else.
And on another note...I am so glad to have Wuss back! :D
I guess this should be an Automaton module:
- http://www.wowinterface.com/downloads/info7404-OpenBankBags.html
Incidentally - I could never get this addon to work.
Oh hey, don't be sorry! I was just giving a bit of feedback. :)
Yes, bags_and_merchants still does work, at least here. Been using it forever. It also hasn't been updated in forever ;). Last update was r26541 on Jan 29/07; the first/last real code update was in Novemeber/06 when the Ace2 version was originally committed to the SVN by Elkano.
Very, very simple code. If it doesn't work for you, perhaps its some third-party inventory mod you are using that is interfering with it or not responding to the calls the mod uses to open/close bags. Such an inventory mod not responding to its "OpenAllBags"/"CloseAllBags" calls, or similar. bags_and_merchants works just fine with the default Blizzard bags.
It's very likely this is the case, yes. All I remember is trying it (and a number of other similar addons) out and not getting anywhere, months ago. :)
And it does the job admirably. Still, I prefer to avoid having hordes of infrequently-updated mini-addons when well-supported consolidated ones exist and thought the feature would fit well with Automaton.
Rez.lua
Find:
Replace with:
Summon.lua
Find:
Replace with:
Could you please commit these changes to the SVN repository?
cheers,
- Fin
Thank you for the time you've spent updating this. Much appreciated.
/auto queue enabled
/auto queue join
/auto queue delay
I turned off all these functions and the addon continued to join battlegrounds after 100 seconds.
Also these features seem to disable the "Esc" key from either clearing my target or opening the main menu. =(
Gossip:
- added a few auto-gossips
- added Netherwing egg quest
Loner:
- decline guild petitions too
Rez:
- cancel scheduled acceptance when cancelling manually
Summon:
- cancel scheduled acceptance when cancelling manually
- delay scheduled acceptance if in combat