Rename from AcePlayerMenu to PlayerMenu.
Change to use new AceHook2 method, maybe fix cannot use shift+click for who.
You can download from here: http://svn.wowace.com/files/
Or checkout from SVN.
Delete libs directory if you are using stand-alone Ace2 libs, it can speed up your mods' load time.
I am about to add a simply config menu, do you really need this? Of couse, it waste some WOW memory.
Seems to be a typo in the PlayerMenu toc. It says "libs\AceLocale-2.0\AceLocale-2.0.lua", while it should in fact be "libs\AceLocale-2.1\AceLocale-2.1.lua"
Currently I use Viper's PlayerLinkMenu, and I keep going back to that because of one important feature I'd like to see implemented here:
It allows for a direct clicking of various functions, similar to clickcasting on unitframes. Blizzard implements this itself, but it's very limited.
Say, if I want to do a /who on a player in chat, I can simply alt+leftclick the name to do that. If I want to whisper, I shift-leftclick. Invite? Ctrl-click, etc. Just as the order of the menu, this is configurable.
Currently, PlayerMenu only allows to be either not active, or active but overriding all nameclicks to open the menu. If this could be changed, I might choose to go with this one as well.
I've been using this handy addon for a while, but I've noticed something the other day, it seems I'm unable to right click on a name within the guild member window, and get the options, as i used to be able to do.
I think Blizzard changed something in the latest TBC push. Apparently Right Clicking on names in chat doesn't do anything anymore, thus making PlayerMenu not work.
A feature request: Add support for Alt-Inviting etc, so you can set different modifier clicks to different actions i.e Ctrl-Click is target, Alt-click is invite. This would be great and fits with the mod imo.
Latest SVN revisions of PlayerMenu (r19667) & Ace2 standalone (r21117) as of the time I tested it (WoW 2.x).
Getting the following error trying to do a guild invite off the menu:
"PlayerMenu-2.2\\PlayerMenu.lua:201: attempt to call global 'GuildInviteByName' (a nil value)\n(tail call): ?:\nInterface\\FrameXML\\UIDropDownMenu.lua:493: in function `UIDropDownMenuButton_OnClick':\n<string>:\"DropDownList1Button5:OnClick\":2: in function <[string \"DropDownList1Button5:OnClick\"]:1>". The mod stops working after that.
Zidomo, you have permission to invite players to your guild, correct? PlayerMenu should check for that, but I figured I would ask.
I'm guessing you are getting the error when inviting someone already in a guild.
There is no Blizzard code to check if a player is in a guild, so I'm not sure if there is a way around this. IsInGuild() only works for your player, not other players. I may have missed something at wowwiki though.
If anyone knows how to check if a player is guilded, please share.
After looking at the code, the following function will have to be recoded:
function PlayerMenu:UnitPopup_HideButtons()
local dropdownMenu = getglobal(UIDROPDOWNMENU_INIT_MENU)
for index, value in pairs(UnitPopupMenus[dropdownMenu.which]) do
if ( value == "GUILD_INVITE" ) then
if ( not CanGuildInvite() or dropdownMenu.name == UnitName("player") ) then
UnitPopupShown[index] = 0
else
UnitPopupShown[index] = 1
end
elseif ( value == "ADD_FRIEND" or value == "IGNORE" or value == "WHO" or value == "GET_NAME") then
if (dropdownMenu.name == UnitName("player")) then
UnitPopupShown[index] = 0
else
UnitPopupShown[index] = 1
end
end
end
end
Zidomo, you have permission to invite players to your guild, correct? PlayerMenu should check for that, but I figured I would ask.
I'm guessing you are getting the error when inviting someone already in a guild.
There is no Blizzard code to check if a player is in a guild, so I'm not sure if there is a way around this. IsInGuild() only works for your player, not other players. I may have missed something at wowwiki though.
If anyone knows how to check if a player is guilded, please share.
As the head of a 10 month old guild, pretty sure I have permission ;). Would not have tried to invite if I didn't have permission. The error occurs when trying to invite someone w/o a guild (happened this morning on a new invite).
Seeing your post, though, I tried again on an already-guilded person after relogging. The identical error occurs (same lines & everything).
The mod doesn't completely die, though, after the error; other menu actions are still available (but clicking Guild Invite is not).
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
Change to use new AceHook2 method, maybe fix cannot use shift+click for who.
You can download from here: http://svn.wowace.com/files/
Or checkout from SVN.
Delete libs directory if you are using stand-alone Ace2 libs, it can speed up your mods' load time.
I am about to add a simply config menu, do you really need this? Of couse, it waste some WOW memory.
It allows for a direct clicking of various functions, similar to clickcasting on unitframes. Blizzard implements this itself, but it's very limited.
Say, if I want to do a /who on a player in chat, I can simply alt+leftclick the name to do that. If I want to whisper, I shift-leftclick. Invite? Ctrl-click, etc. Just as the order of the menu, this is configurable.
Currently, PlayerMenu only allows to be either not active, or active but overriding all nameclicks to open the menu. If this could be changed, I might choose to go with this one as well.
Regards
Quin
Now that would be a sweet feature.
this a very small addon i had for ages that does just that (allow you to ctrl+click someone`s name in chat to target him).
Say it ain't so!
Getting the following error trying to do a guild invite off the menu:
"PlayerMenu-2.2\\PlayerMenu.lua:201: attempt to call global 'GuildInviteByName' (a nil value)\n(tail call): ?:\nInterface\\FrameXML\\UIDropDownMenu.lua:493: in function `UIDropDownMenuButton_OnClick':\n<string>:\"DropDownList1Button5:OnClick\":2: in function <[string \"DropDownList1Button5:OnClick\"]:1>". The mod stops working after that.
The rest of the menu functions appear to work OK.
I'm guessing you are getting the error when inviting someone already in a guild.
There is no Blizzard code to check if a player is in a guild, so I'm not sure if there is a way around this. IsInGuild() only works for your player, not other players. I may have missed something at wowwiki though.
If anyone knows how to check if a player is guilded, please share.
As the head of a 10 month old guild, pretty sure I have permission ;). Would not have tried to invite if I didn't have permission. The error occurs when trying to invite someone w/o a guild (happened this morning on a new invite).
Seeing your post, though, I tried again on an already-guilded person after relogging. The identical error occurs (same lines & everything).
The mod doesn't completely die, though, after the error; other menu actions are still available (but clicking Guild Invite is not).