I have two sets I switch with ClosetGnome. Set 1 gives me
955 spell damage bonus
1290 shadow damage bonus
71 spell hit rating
Set 2 gives me
822 spell damage bonus
1157 shadow damage bonus
202 spell hit rating
Set 1 gives 133 spell damage compared to set 2
Set 2 gives 131 spell hit rating compared to set 1
1) I wear set 1
2) Target myself
3) Use Copy Target (Wowequip), to load set 1 as current profile
4) I switch to set 2 (ClosetGnome)
5) Compare current wowequip profile (set1) with my current set (set 2)
In item bonus summary frame I see : spell damage (+59) shadow spell damage (+59) spell hit rating (-76)
Can you explain me differences between what I see in wowequip item bonus summary frame and the calculation I made using stats given by wow interface ?
Can you explain me differences between what I see in wowequip item bonus summary frame and the calculation I made using stats given by wow interface ?
Without the specific details of exactly what items are in set 1 and what items are in set 2 (with the relevant enchant and gems), the only thing I can say to explain this is that you have talents, pets, buffs and racial bonuses that modify your stats in some way.
WoWEquip currently only takes into account the stats from the gear, and doesn't include your base character stats, your talents, your racials or your pet. The numbers you see in the default ui's interface takes into account all of those (and are also known to display the incorrect numbers after a respec).
Also, I am uncertain if you are using an English client. If there is a bug somewhere, you will need to provide specific exact instructions/steps for me to reproduce it.
I equiped those to sets in the same context (base character stats, buffs, pet, etc.).
I know that wow takes into account those elements, that's why I compare differences between sets.
I made more comparisons and I found where the problem comes from.
The addon doesn't take into account bonuses coming from gems and enchants.
I think it comes from the fact that I'm using a French client.
For example when I compare Handwraps of Flowing Thought socketed with 2 Runed Living Ruby (+9 spell damage) enchanted with Major Spellpower (+20 spell damage) and the same item socketd with 2 Great Dawnstone (+8 spell hit rating) enchanted with Spell Strike (+15 spell hit rating), wowequip shows no difference.
I think it comes from the fact that I'm using a French client.
Ah that's where the problem is. WoWEquip currently only works fully in German and English. It works partially in French at the moment, but localization is something I can't really perform or do.
WoWEquip performs its item bonus calculations using ItemBonusLib written by Jerry, so if anything isn't calculated or added, the backend of the problem really lies with that library. As the wowace community doesn't really have that many French translators, any help would be appreciated in helping translate WoWEquip and ItemBonusLib to work in other languages.
For example when I compare Handwraps of Flowing Thought socketed with 2 Runed Living Ruby (+9 spell damage) enchanted with Major Spellpower (+20 spell damage) and the same item socketd with 2 Great Dawnstone (+8 spell hit rating) enchanted with Spell Strike (+15 spell hit rating), wowequip shows no difference.
From the above, I gather that spell damage and spell hit rating isn't being parsed correctly in French from the item tooltips? Would it be possible for you to provide the exact text of those lines (enchants and gems that aren't parsed correctly) in the tooltips and I'll forward them to Jerry?
Does that mean that we have to translate all enchants and gems bonuses in French ?
RatingBuster seems to work very well on my French client. Don't you use same library for enchants and gems bonuses ?
I will be happy to help for WoWEquip French localization.
Does that mean that we have to translate all enchants and gems bonuses in French ?
RatingBuster seems to work very well on my French client. Don't you use same library for enchants and gems bonuses ?
I will be happy to help for WoWEquip French localization.
That is correct. Please check ItemBonusLib-1.0.lua in your WoWEquip, and you will see that quite a bit of stuff (patterns) in English isn't translated to French at all.
The backend of RatingBuster is StatLogicLib. WoWEquip uses ItemBonusLib to do its calculation and not StatLogicLib. WoWEquip however does use StatLogicLib to calculate its derived statistics. There are also various backend calculations in StatLogicLib that are incorrect or not parsed just like ItemBonusLib.
The main reason for using ItemBonusLib is that StatLogicLib is unable to take into account set bonuses because it only scans for one item at a time as opposed to a set of items. If i were to switch to using StatLogicLib, I would have to manually key in and store data of every single set bonus of every single set item in the game and also update this should they change or add new sets in the future.
This means that I would much prefer to help to improve ItemBonusLib as the author (Jerry) is very active, while the author of StatLogicLib (Whitetooth) is known to be in the military and can (and have) disappeared for 4 months at a time without updates.
What do I have to do to make it work with my French client ?
Do I have to complete WoWEquip localization.frFR.lua file ?
Completing WoWEquip's localization.frFR.lua merely makes all the text in WoWEquip show up in French rather than English. To actually make the calculations work, you have to work with Jerry to localize ItemBonusLib in this thread: http://www.wowace.com/forums/index.php?topic=3083.260
The first step is finding out what isn't being parsed in the item tooltips.
Awesome addon! Love the features, and ability to socket and enchant new gear to see my stat changes. If I could make one suggestion a clear equipment button to clear all the gear in the window might be usefull.
what is the current status of the addon ?
I really like your final goal but in the actual state the only thing I use it for is gem and enchant a given item for comparaison with other addons modifying the tooltip (RatingBuster, CatPoint).
It is currently in limbo as I struggle to find time to update Postal, BankItems, Cartographer_Routes, GemHelper and Integrated Popbar.
The final goal doesn't seem very realizable because certain stats like melee crit and ranged crit are dependent on weapon skill, and there isn't much data to begin with.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumYes.
It's 55 if you look at the added stats in the item bonus summary frame.
Set 1 gives me
955 spell damage bonus
1290 shadow damage bonus
71 spell hit rating
Set 2 gives me
822 spell damage bonus
1157 shadow damage bonus
202 spell hit rating
Set 1 gives 133 spell damage compared to set 2
Set 2 gives 131 spell hit rating compared to set 1
1) I wear set 1
2) Target myself
3) Use Copy Target (Wowequip), to load set 1 as current profile
4) I switch to set 2 (ClosetGnome)
5) Compare current wowequip profile (set1) with my current set (set 2)
In item bonus summary frame I see :
spell damage (+59)
shadow spell damage (+59)
spell hit rating (-76)
Can you explain me differences between what I see in wowequip item bonus summary frame and the calculation I made using stats given by wow interface ?
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumWithout the specific details of exactly what items are in set 1 and what items are in set 2 (with the relevant enchant and gems), the only thing I can say to explain this is that you have talents, pets, buffs and racial bonuses that modify your stats in some way.
WoWEquip currently only takes into account the stats from the gear, and doesn't include your base character stats, your talents, your racials or your pet. The numbers you see in the default ui's interface takes into account all of those (and are also known to display the incorrect numbers after a respec).
Also, I am uncertain if you are using an English client. If there is a bug somewhere, you will need to provide specific exact instructions/steps for me to reproduce it.
I know that wow takes into account those elements, that's why I compare differences between sets.
I made more comparisons and I found where the problem comes from.
The addon doesn't take into account bonuses coming from gems and enchants.
I think it comes from the fact that I'm using a French client.
For example when I compare Handwraps of Flowing Thought socketed with 2 Runed Living Ruby (+9 spell damage) enchanted with Major Spellpower (+20 spell damage) and the same item socketd with 2 Great Dawnstone (+8 spell hit rating) enchanted with Spell Strike (+15 spell hit rating), wowequip shows no difference.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumAh that's where the problem is. WoWEquip currently only works fully in German and English. It works partially in French at the moment, but localization is something I can't really perform or do.
WoWEquip performs its item bonus calculations using ItemBonusLib written by Jerry, so if anything isn't calculated or added, the backend of the problem really lies with that library. As the wowace community doesn't really have that many French translators, any help would be appreciated in helping translate WoWEquip and ItemBonusLib to work in other languages.
From the above, I gather that spell damage and spell hit rating isn't being parsed correctly in French from the item tooltips? Would it be possible for you to provide the exact text of those lines (enchants and gems that aren't parsed correctly) in the tooltips and I'll forward them to Jerry?
Race: Dwarf
Class: Paladin
HP: 4427
MANA: 3903
CRIT%: 1.69%
RAP: 63 (if only I could use a ranged weapon... lol)
AP: 446
MANA REGEN: 81/mp5
SPELL CRIT%: 4.36%
DODGE%: 3.57%
PARRY%: 5%
BLOCK%: 5%
DEFENSE: 350
ARMOR: 146
SPI: 88
INT: 82
STA: 123
AGI: 73
STR: 128
RatingBuster seems to work very well on my French client. Don't you use same library for enchants and gems bonuses ?
I will be happy to help for WoWEquip French localization.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThat is correct. Please check ItemBonusLib-1.0.lua in your WoWEquip, and you will see that quite a bit of stuff (patterns) in English isn't translated to French at all.
The backend of RatingBuster is StatLogicLib. WoWEquip uses ItemBonusLib to do its calculation and not StatLogicLib. WoWEquip however does use StatLogicLib to calculate its derived statistics. There are also various backend calculations in StatLogicLib that are incorrect or not parsed just like ItemBonusLib.
The main reason for using ItemBonusLib is that StatLogicLib is unable to take into account set bonuses because it only scans for one item at a time as opposed to a set of items. If i were to switch to using StatLogicLib, I would have to manually key in and store data of every single set bonus of every single set item in the game and also update this should they change or add new sets in the future.
This means that I would much prefer to help to improve ItemBonusLib as the author (Jerry) is very active, while the author of StatLogicLib (Whitetooth) is known to be in the military and can (and have) disappeared for 4 months at a time without updates.
Do I have to complete WoWEquip localization.frFR.lua file ?
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumCompleting WoWEquip's localization.frFR.lua merely makes all the text in WoWEquip show up in French rather than English. To actually make the calculations work, you have to work with Jerry to localize ItemBonusLib in this thread:
http://www.wowace.com/forums/index.php?topic=3083.260
The first step is finding out what isn't being parsed in the item tooltips.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumForwarding this to Jerry to fix in ItemBonusLib. It will be fixed soon. This in fact affects Arcanum of Rapidity enchant as well.
Spell Hit doesn't show in the summary with the german client. (WoWEquip 53807.3)
http://www.wowhead.com/?item=34220
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumHP: 4080
MP: 4300
Base
Strength: 50
Agility: 56
Stamina: 77
Intellect: 131
Spirit: 144
Armor: 112
Spell
Bonus Damage\Healing: 0
Hit: 0
Spell Crit: 3.30%
Penetration: 0
Mana regen: 109
Melee
AP: 40
Crit: 0%
Defense
Defense: 350
Dodge: 4.28%
Parry\Block: 0%
Thank you for a fantastic addon ;).
Naked, Un-talented Lv. 70 Human Paladin
Base Sats:
4397 Health
3918 Mana
Strength: 126
Agility: 77
Stamina: 120
Intelect: 83
Spirit: 97
Armour: 154
Melee:
Attack Power: 442
Crit: 3.29%
Ranged:
Ranged Attack Power: 67
Crit: 3.29%
Spell:
Crit: 4.37%
Mana Regen: 86 (while not casting)
Denfenses:
Armour: 154
Defense: 350
Dodge: 3.73%
Parry: 5.00%
Block: 5.00%
And thanks for a great addon :D
to keep this post short as possible stats not listed are 0 or Same as caster form for bear cat stats.
HP = 4254
Mana = 3890
Base
Str- 73
Agi- 75
Stam- 82
Int- 120
Sp - 133
Armor - 150
Melee
Dmg 19-20
spd 2.0
Pwr 126
Ranged
Dam 10-11
Pow 65
Spell
Crit 3.35%
Mana Regen 109 (0 per 5 casting)
Def
Def 350
dodge 4.23%
Bear
HP 4454
Sta 102
Melee
Dmg 169-225
spd 2.50
pwr 336
Cat
Melee
Dmg 68-91
spd 1.0
Pwr 341
Awesome addon! Love the features, and ability to socket and enchant new gear to see my stat changes. If I could make one suggestion a clear equipment button to clear all the gear in the window might be usefull.
I really like your final goal but in the actual state the only thing I use it for is gem and enchant a given item for comparaison with other addons modifying the tooltip (RatingBuster, CatPoint).
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThe final goal doesn't seem very realizable because certain stats like melee crit and ranged crit are dependent on weapon skill, and there isn't much data to begin with.