Authors CurseForge

Quote from Seline »

Not spell crit, not spell hit, not melee hit, nor melee crit. It seems that spell haste is though. The other shows 3 didgits when at 0 (0.00%) while spell haste only shows 0%. My bad !

Attack power, expertise, spell damage, healing, and mana regeneration are all rounded down.

I'm currently working on a french translation, and I found some bugs :

- "Select Race" is hard-coded, ie is not a variable in the localization file

- in the select class dropdown menu, the title, which is titled "{class} Talents", doesn't work in french. The word "Talents" must be before the class name. "Rogue Talents" -> "Talents du voleur"

- is there a way to sort the races and classes in the dropdown list independatly of localization?

- the show helm/cloak checkbox are not saved after a disconnect (intended?)

- when using the "%" button, to toggle the comparison in percent or value, the "mana points"/"life points", and "chance to block"/"armor" lines are swapped

some improvements :
some frame docking for the "search equipement" frame could be useful, like the "dressing room" behaviour

it is kinda weird that you cannot reproduce the lines swapping. It happened for me with the EnGB client I use too. Here is some screenshots attached

Enchant Gloves - Threat enchant, shows up as Threat Reduction (%) -2

And Derived Stats should have the defense value there

Small request, when comparing gear, can you have the +0 or +0.00% show up as white instead of green?

I found a bug (or a couple of them):



my real spell crit is 14.85%, Wowequip shows 5.82%
my wand increases my spell crit by 0.45%, Wowequip says, it would increase it by 0.13%

hope you can fix it

t-master

The stats shown in WoWEquip are your stats from gear only. The numbers in WoWEquip are not intended to match what is shown on the character sheet. What you're seeing in your screenshot is that your gear gives you 5.82% crit from crit rating. Similarly, it correctly shows that your wand gives you 0.13% crit from crit rating. The "Derived Stats" section shows you more what you're expecting to see: your overall crit rating including the conversion of Intellect and the effect of talents. Note that WoWEquip does not, intentionally, include your base stats (as these depend on race, class, and level and compiling a complete database of each combination's base stats would be an enormous undertaking), and does not include talents that only affect certain spells (for example, if mnges still have the talent that increases the crit chance of Flamestrike, WoWEquip would ignore it, since it doesn't have a separate "Flamestrike crit chance" category). So, as you see, there is nothing to fix. The addon is working as intended; you just aren't reading it correctly. :)

Quote from Phanx »

Note that WoWEquip does not, intentionally, include your base stats (as these depend on race, class, and level and compiling a complete database of each combination's base stats would be an enormous undertaking)

Umm, why? We don't need an option to change our race or level to see what we our stats would be as a level 1 gnome shaman in T6 and sunwell pally gear, we're just seeing how a gear change would affect our current stats for our current race and class. Since you DO track what the change is, why not instead of displaying the "gear only" contribution, just pull the number for that stat conveniently pre-calculated for you on the character page and just apply the change to that, displaying that number.

KISS (no offense :P)

WoWEquip is usable on characters of all levels, not just level 70. For someone setting up an "endgame wishlist" on a level 45 character, it would be useless to include the current character's base stats. And without hard-coded data, WoWEquip has no way to know what that character's base stats would be at level 70.

Also, WoWEquip can be used to set up gear sets for characters other than the current one. For someone setting up a gear set for their alt while waiting on an AFK tank in a raid, it would be useless to include, say, orc shaman base stats when the character the gear is for is a tauren druid. Again, without hard-coded data, it would be impossible to know the correct base stats.

WoWEquip is intended primarily to compare sets of gear. Since your base stats do not change depending on what gear you wear, there is no need to include base stats. Adding 2.73% spell crit to your gear will add 2.73% spell crit to your character. Adding 14 intellect to your gear will add 14 intellect to your character. Base stats have no effect on gear stats, or on how gear stats are applied to your character.

Another feature of WoWEquip is the ability to compare one non-equipped set of gear to another non-equipped set of gear. If the derived stats section simply showed the difference between your current stats (in your currently equipped gear) and the stats from the selected gear profile, it would not be possible to compare "Wishlist A" and "Wishlist B". Your proposal would limit WoWEquip to only comparing against your currently equipped gear.

I think the current system is quite simple. It excludes base stats, plain and simple. It compares one set of gear to another set of gear, plain and simple. I'm not sure how you think crippling WoWEquip's comparison features by limiting it to the current character's level, talent spec (yes, some talents alter base stats), and equipped gear would be an improvement.

the stats shown in my screenshot are the derived stats
and wowequip says with my new gear the crit rating would be reduced by 1.x%
but if I calculate the new critrating manually, I would have more crit than before.
And wowequip always shows that my spellcrit points are reduced by 28
e.g. if I replace my frostfire circlet with 8 spellcrit points with the cowl of the illidan high lord with 47 spellcrit points it shows me -28
there must be something wrong with it
and if I replace my robe of the tempest with a plate chest without spell attributes it doesn't show me a negative value for spell hit and crit
it shows +0

t-master

Currently if I switch out one piece of my 5/5 Arena Set to a non set piece, it counts me as losing the 2 piece set bonus, although I'd still be wearing 4/5.

I've tried manually equipping every slot of gear, and the problem persists. Currently set consists of
S2 Shoulders
S3 Gloves/Helm
S4 Pants/Chest

Loss of set bonus happens when I change any slot.

Quote from Xinhuan »

Hi Flogre, I'm not sure why that bug occurs, because most people don't encounter it, but yes, I have heard some reports about it not working.

The code works by looking at the name of the set (which is the same on all gear of all seasons), and counting the number equipped, and then checking the appropriate set bonus line to see if its text is green (the line with (2) in it), if it is, include it.

Heh. Lo and behold, it seemed to fix itself. Was playing around with it a while ago before raid. Just opened it up after a few hours, and it's now displaying the correct amount of lost resilience. Jesus walks, eh?

Something is seriously wrong with agility/crit calculations in the derived stats thingy.

Look at this:

That's just me in my own gear, comparing to self.

Now, as soon as I remove my leg enchant (which is the 40stamina/12agility one), that's what happens:

You see, I've lost 12% crit according to wowequip, while in fact I've lost 12 agility. The stamina/hp is registered properly as you can see, showing -400 hp.

Even more, if I try to open my PvE gear profile in wowequip which got tons of agility, look at this:


Edit: Just tried with ONLY wowequip addon running, same thing happens. Latest version of WoWequip.

Edit2: Okay, I've got even some more info.

I tried reverting to some old 6xxx version, and the same bug occured. I wtfed a bit, because I do remember the agi/crit thing working properly in the past few months as I actually use it. So I went and disabled all addons and tried running only wowequip 6xxx with nothing else on, and it actually worked!

At that point I thought, it must be some other addon interfering then. So I tried enabling some of them one by one, and the problem starts occuring as soon as I enable RatingBuster.

I've also tried to do the exact same thing with the latest version, and it didn't work. Latest version, even when completely alone, with a fresh CVars file, still shows me -12% crit.

I believe the problem is with one of the libraries that RatingBuster and WoWEquip share, and it's logically correct that they do share some lib...

The problem was comming from the StatLogic-1.0 library and I fixed it by reverting both WoWEquip and RatingBuster to 6xxxxx versions. Wierd, though, as RatingBuster, even its newest version, always showed me the correct amount of crit/dodge agility would give, so the calculations are correct there...