Authors CurseForge

getting this error lately when dismounting

[2008/03/17 12:35:06-221-x10]: ClosetGnome-1.0.62548\ClosetGnome.lua:839: Invalid inventory slot in GetInventorySlotInfo
(tail call): ?:
AceEvent-2.0-63812 (Ace2):917: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:910>

 ---

I'm wondering if this mod behaves like itemrack.

here's the scenario.
equip set "normal"
decide i want to wear 2 pieces of stam gear, so i put them on
kill some stuff
mount up (switches to "mounted" set)
dismount, and switches back to "normal" set, with my stam gear substitutions
kill some more stuff
etc

when i last tried closetgnome, i had to choose a set to equip off of dismount, which replaced my stam gear choices and equipped the full set of "normal" instead. so i'd have to put my stam gear back on, etc.

so, has this changed in closetgnome?

i'd reeeeeeeally prefer to use it instead of itemrack, but with this "full set equipped" after dismounting behavior, i just cant live with it :)

if this behavior isn't in CG now, is it possible to add it in? i'd love an option to "enable itemrack behavior" or another separate CG module to accomplish this, or even a few lines of lua hacking!

thanks much guys!

yarrr

ok, i just tested it and it still behaves just like it did long ago :(

make set tank
make set mount (1 item, riding crop)
equip tank
change a few pieces of gear
mount up (changes only the 1 item, riding crop)
dismount = back to tank set, without my few changes

:(

so, can i request an option for "itemrack behavior"? thanks :)

Here is a patch for some improved shield handling behavior. Its based on the 2 hand -> off hand code that is currently in place. Basically, it finds an appropriate free slot using self:LocateFreeSlot() to put a shield (or other off hand item I would imagine, but haven't tested) in before it swaps a 2 hand weapon in.

--- reposted from another thread about ClosetGnome_Switcher and druid's tree forms, slightly edited here ---

Ok, just a little bit of to summarize what was the issue with ClosetGnome_Switcher and what's up to it.

pre-2.4: 2 druids in tree form in same group made CGS go nuts. "Tree of Life" have 2 buffs, and one of them is applied to the whole group (well, those in range).
post-2.4, Kemayo's patch: thanks Kemayo, greatly appreciated but I don't like to have CGS called for every friggin' HoT / DoT hitting me. And every time something ticks CGS is trying to switch my outfits. Mmm... any wise gnum would go on strike shortly after.

I did some tests on my branch (I don't have [yet] an svn access) and it seems to work fine.

You'll find my own ClosetGnome_Switcher in the attached archive (no externals included).

Tested on druid and warrior, might need some work to upgrade priests, shammies and rogues to the form changing logic.

Please give it a try. The ONLY "strange" behaviour is this: when druids change form UPDATE_SHAPESHIFT_FORM is called twice. Once for your "left" form, once for what you gained. This in the case you're changing from cat to bear (for example). The "middle" form is the Humanoid form, so practically you'll change outfits twice. Gnum isn't really happy about it but he said he can handle it. Just give him some extra cookies from time to time.

Cheers,
Arzach

PS: if you think it's not breaking anything and it works fine for you too, could some kind spirit with svn access update it ? Thanks.
PS2: if you find a smarter way to check for druid's forms ...
PS3: in the above code there's some debugging output left there. It's left there on purpose, comment it out before uploading to svn (if you're going to).

is there a way to toggle a set (for example in itemrack) if i equip the same set a second time it removes it and puts my other gear back on?

thanks

I have created a set that includes skulshatter warboots and Bladed shoulderpads of the merciless. No matter how many times I set these two items as being in the set the gnome cannot find them?

I end up having to go into my bags and manually put them on. Any ideas?

edit figured it out... if you edit a set when the slots are yellow and you click done it doesn't update. you must click the yellow slots till they turn green. Did this and it worked fine.

Hello all. I was recently told of some improvements to ClosetGnome that could have me switch over from the now archaic ItemRack. Are they in the latest 2.4 builds?

1. ItemRack has this neat feature that's very important to me. If you mouseover any slot on your character sheet, a little pop up bar will appear with everything else in your inventory that can fit that slot, and a blank slot which removes your currently carried item.

2. (this one I find a little hard to believe, but I was told CG now does everything ItemRack did). Shift-clicking on a slot in your inventory will spawn a movable, detachable well... itemrack, with whatever slots you clicked. Great for making yourself a little trinket bar.

If these two are fulfilled I'd love to make the switch over, since I hear ClosetGnome is superior to ItemRack in basic item switching.

For #1, try SwapMagic. For #2, I hear TrinketMenu works nicely (though I don't use it myself).

hi there i'm a jewelcrafter and for that i got unique equipped gems.i have a pve and a pvp gear and i socketed the (unique equipped)24atp and 12crit rating gem in my pve girdle and my arena breastplate. the problem happens when i try to switch from pve to pvp gear my closetgnome gets confused and it keeps on the pve breastplate with that error message: "you have the maximum of those gems socketed into equipped items."

so i always have to command him twice to get on the pvp gear.

Is it possible to have the fubar set list only show the sets you currently have in your bags?

As a tank, I have a LOT of sets... resist sets, max hp, max avoidance, partial resists, threat, 5man downgrade set, etc etc. I don't always carry everything with me, I do not have the space for it, so it would be nice to not see those in the fubar tooltip as an option if they aren't equipable.

Just wondering if anyone else is freezing for a few seconds whenever they switch sets, its been happening to me since 2.4~

So no response to my previous question.

Every time I switch gear sets i hit a "lag spike" aka 0 FPS for 1-2 seconds

its really annoying, any thoughts on why or how to fix it?

RE: Switcher

I did search first, but I didn't find specifically this (surprising, actually).

I used to use Switcher to change my weapon sets as I shifted (druid). Healer weapon/idol for caster form, EW/Terror for bear, EW/Everbloom for cat. Very handy for emergency healing mid-fight and funny for "you're going to tank with a healing weapon?!?" comments.

Ever since 2.3, however, if I shift directly from cat to bear (or vice-versa), I end up with a semi-random amalgam of weapons (usually the caster-form weapon and the form-appropriate idol).

I've thought about digging into the code myself to tweak this, but figured I'd post here first, in case the recent discussion about trees had triggered any light of a fix.

For all that I found the Switcher functionality very useful, it has been disabled since 2.3 because I can't emergency tank with an everliving nightstaff (well, I can, but it's less fun that emergency tanking in dps gear already is).

Any suggestions or known fixes?

ClosetGnome_Ripper

A while back, after I picked up an Idol of Feral Shadows, I wrote something I (just in my AddOns folder) called ClosetGnome_Ripper. Basically, it switches in a set when you hit a specified number of CP and then switching in a different set when you no longer have that many CP.

So, using myself as an example, my "CP0" set is the Everbloom Idol and my "CP5" set is the Idol of Feral Shadows, and my CP threshold is set to 5.

Until 2.3, this was mostly good for amusement, but now that the idol has gotten a bit of a buff, I figured maybe others would find it useful.

Now, this is my first real attempt at a mod, so it may have bugs. I have no problem handing it off to someone who can nurture it through adolescence. Alternatively, I could keep it, but may need some patience making it production-ready.

What should my next steps be?

I think I fixed the form-to-form shift issue. It specifically only happens if you have a default set (for healer weapons in caster form in my case) set.

What is happening is that the ClosetGnomeSwitcher_Druid:BuffLost function is returning true (for handled) based on the buff being lost (cat or bear, for example) resulting in the default set, if enabled, being equipped. The subsequent BuffGained function still triggers, but something in having two sets swapping at the same time (cancelform being instant and all that) doubtless causes the weird amalgam of items ending up equipped.

Now, not setting a default set will remove the problem, allowing you to shift from cat to bear and swap in dps or tanking weapons as needed. However, if you want to swap in healer weapons for shifting to emergency heal, that particular workaround won't do the trick.

The code changes I made to solve the problem are all in the Druid.lua file.

I defined a new local, formSet. I tried using CGS:currSet, but I was getting errors (either because I don't know what I'm doing or because of something else).

In ClosetGnomeSwitcher_Druid:BuffGained, I added the line "formSet = ClosetGnomeSwitcherDBPC[name]" which will initialize the local to your current set.

Then, in the final elseif clause of ClosetGnomeSwitcher_Druid:BuffLost, where it is handling all the druid forms types with default behavior (the function is mainly to handle innervate fading or prowl going away), I replaced the "return true" with:

if UnitPowerType("player") == 0 then
return true
elseif formSet == nil then
return true
else
return formSet
end

Basically, if you have mana, it returns true, triggering the swap to the default (caster-form) set. Otherwise, it returns your current form's set (the BuffGained event will still swap it when you hit the new form). The middle condition is just in case.

I've currently got my changes in a side directory. I'd like to see them get into the mainline codebase, though, so I can start patching Switcher again.

I don't think this will work if you go from cat to tree -- you'll end up with default weapons set. I'm sure it's fixable, but I've got a raid in 35 minutes, so won't be doing that anytime soon (and don't currently have a tree spec for unit testing).

ClosetGnome_Mount has GratuityLib in its X-Embeds. But I can run it just fine with LibGratuity-3.0 installed (disembedded). No idea if that is something that should be "upgraded".

ClosetGnome-1.0.65177\ClosetGnome.lua:839: Invalid inventory slot in GetInventorySlotInfo

On my mage, haven't experienced it on my rogue. Something to do with nothing in the ammo slot maybe (talking out my ass here I think)?