I have the same problem. It would be awesome if it worked like cg mount, where it just puts back on the set you had before you mounted. I have multiple sets and don't want to set a default for switcher. Honestly I would prefer this functionality go into cg_mount, but maybe that doesnt make sense. Still it is an awesome addon. :-)
Second the idea of Druid?s flight form going into cg_mount. Flight form is like a druid?s mount and the trinket you get from the quest serves the exact same purpose as the riding crop for all other classes. Even if flight form isnt a mount, moving it to cg_mount would make more sense than having it in switcher, imho :).
I too would love to see Flight Form (or at least Swift Flight Form) go into ClosetGnome_Mount. No druid with that form would use a mount in outland. My main wish is to have the Trinket Charm of Swift Flight equipped when switching to flight form and ofcourse to get the one I had before switching reequiped when switching back... I can make a default set (and it works well for me, technically) but that's not what I really want. I have different trinkets for Healing, Cat and Bear form and it would be lovely to have the trinket I used before switching reequipped when shifting out of Flight Form.
I woud prefer this as well.
Seconded, or fourthed or whatever.
fifthed! Switching to a 'default' set just doesn't work here.
Also, I didn't see this in the readme and while I did read through this thread yesterday, I may have missed it...
is there any way to 'hide' a set from the dropdown menu? For instance I have a Cat set and a Bear set and a CatSwitch set and a BearSwitch set. CatSwitch and BearSwitch are just weapon/idol and for the Switcher module...I will never choose to switch into them manually and I really don't need to see them...
You can hook the ClosetGnome:HideSetFromUI(setName) function and return true for your set names. Just make a small addon for yourself that does it, or edit ClosetGnome.lua directly and edit it like "if setName == 'MySet' then return true" or whatever.
Excellent, thank you. I have opened up the ClosetGnome_Mount.lua and trying to figure out a way to apply Swift Flight Form to it now...is that the right place to start for that?
One clue is that SpecialEvents_Mounted actually gets the buff name as the first argument (for example 'Swift Flight Form' or 'Ebon Gryphon Mount'), so you could actually see if there is a set with that name, and use that as the mount set if so, and default to 'Mount' if not.
I'm at work so it doesn't help that I can't possibly test anything. Also, I've never really done any programming work and whao this is complicated. About all I've decided is that using Find->Replace in WordPad is probably a bad idea.
Hello there
love this mod but theres one thing that annoys me greatly.
as a holy priest i use different gears for healin and for dps.
in my heal gear i have 2xLower city prayerbook as trinkets and in my dps set i have 2 differnt trinkets. when i equip my dps-set and then change to my heal gear it only equips one of my prayerbooks.
Just follow (or try to) all of this subject, but seems no one has the same trouble as I've got...
I just try to create a naked set... and even if the slots are empty when the set is save, I couldn't switch to this set properly, all my equips stay on... (and my bags have 20 free slots, so it must feet)
And on the paper doll, I must click two time to get my model naked (the first time my actual equip is shown).
I hope I haven't missed a post... so if someone have any idea on that, I take it :)
(I'm on FR_fr client, if it's relevant, and using OneBag)
2 requests. One is the one mentioned earlier, adding swift/flight form into cg mount. That would be awesome. Second, I have tried to use cg switcher to autoequip my pvp gear when i enter a bg but the bg never shows up on the list of zones for the plugin. Is there a solution I am missing?
If you have a unique-equipped gem in say your chest piece in the set you are wearing and you switch to set #2 with the same unique-equipped gem in your legs, switching in your legs will fail sometimes as it tries to switch the legs in before the chest is out.
It seems like order of gear switching is important and a little more complicated than switch all of set x out and all of set y in.
However you can just switch to that set twice and the pieces that failed to switch will be put in the 2nd time normally. I'm not really sure what's better having to switch to the set twice to get a few stray pieces (usually trinkets and pieces with conflicted gems) in or altering the switch logic to be a lot more complicated and slower.
If you have a unique-equipped gem in say your chest piece in the set you are wearing and you switch to set #2 with the same unique-equipped gem in your legs, switching in your legs will fail sometimes as it tries to switch the legs in before the chest is out.
Holy crap, that problem sucks.
Hope I can fix that, but I'm not going to try yet, maybe in a few weeks, a month or so.
I think I have ClosetGnome_Mount working with druid flight form. The problem was that SpecialEvents_Mounted does not fire for flight form, so I had to use SpecialEvents_PlayerBuffGained and SpecialEvents_PlayerBuffLost to test for being in flight form. This is probably not the most elegant solution, but it seems to work. (Well enough for me anyway.) I have attached my modified ClosetGnome_Mount.lua to this post.
If you have a unique-equipped gem in say your chest piece in the set you are wearing and you switch to set #2 with the same unique-equipped gem in your legs, switching in your legs will fail sometimes as it tries to switch the legs in before the chest is out.
Holy crap, that problem sucks.
Hope I can fix that, but I'm not going to try yet, maybe in a few weeks, a month or so.
Having dealt with that kind of issue in a different environment, my suggestion on how to deal with it is fairly easy, the only complication comes from how you can detect the failure. If the call to equip the item returns a status, it's easy, otherwise you have to check to see if you really equipped the item, and I'm not sure how much overhead would be involved.
Basically, you loop on equiping the items (either the entire set, easiest to code, or just the failed items, probably more efficient), and drop out of the loop when you either equip all items or you fail to equip any items (that weren't equipped in a previous iteration). Worst case, this would be an order N^2 algorithm, but I don't see it ever devolving far enough to be an issue.
A more elegant solution, but a good bit more work, would be to do that the first time, and remember the order you successfully equipped them.
Trying to code this looking specifically for unique-equipped gems would be a nightmare, and would be special case for that one problem, rather than dealing with similar issues in the future. It might provide an alternate solution to the offhand weapon issue. I haven't been tracking that so I don't know what the current solution is.
I think I have ClosetGnome_Mount working with druid flight form. The problem was that SpecialEvents_Mounted does not fire for flight form, so I had to use SpecialEvents_PlayerBuffGained and SpecialEvents_PlayerBuffLost to test for being in flight form. This is probably not the most elegant solution, but it seems to work. (Well enough for me anyway.) I have attached my modified ClosetGnome_Mount.lua to this post.
oho, I will try this when I get home, do I need to create a special 'Flight' set?
oho, I will try this when I get home, do I need to create a special 'Flight' set?
Yes, there will be a new setting in your "Mount" menu for flight form. (And yes, it's there even if you're not a druid. As I said, not the most elegant solution.)
oho, I will try this when I get home, do I need to create a special 'Flight' set?
Yes, there will be a new setting in your "Mount" menu for flight form. (And yes, it's there even if you're not a druid. As I said, not the most elegant solution.)
Sweet Fancy Moses, it works, I love you! Anyway we can get this added to the real closetgnome_mount on the svn?
First things first - thanks for making ClosetGnome! Such a cute little guy. :)
I'm having some trouble using the ClosetGnome_Zone module. In fact, I'm not able to use it at all. I couldn't figure out any command to give me some help and there are no options in neither the switcher nor any other menu allowing me to assign sets to specific zones. I'm using the enGB client with CG r44615.7, CG_Switcher r42614.38 and CG_Zone r45169.
I'm sorry if this question has already been answered but I haven't found anything strolling through this thread.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
I've reverted my changes and committed Hallithron's patch in the meantime, hope it really works as he promised :)
cheers,
mitch
fifthed! Switching to a 'default' set just doesn't work here.
is there any way to 'hide' a set from the dropdown menu? For instance I have a Cat set and a Bear set and a CatSwitch set and a BearSwitch set. CatSwitch and BearSwitch are just weapon/idol and for the Switcher module...I will never choose to switch into them manually and I really don't need to see them...
One clue is that SpecialEvents_Mounted actually gets the buff name as the first argument (for example 'Swift Flight Form' or 'Ebon Gryphon Mount'), so you could actually see if there is a set with that name, and use that as the mount set if so, and default to 'Mount' if not.
Or something.
I'm at work so it doesn't help that I can't possibly test anything. Also, I've never really done any programming work and whao this is complicated. About all I've decided is that using Find->Replace in WordPad is probably a bad idea.
love this mod but theres one thing that annoys me greatly.
as a holy priest i use different gears for healin and for dps.
in my heal gear i have 2xLower city prayerbook as trinkets and in my dps set i have 2 differnt trinkets. when i equip my dps-set and then change to my heal gear it only equips one of my prayerbooks.
any hope for fixin this?
Just follow (or try to) all of this subject, but seems no one has the same trouble as I've got...
I just try to create a naked set... and even if the slots are empty when the set is save, I couldn't switch to this set properly, all my equips stay on... (and my bags have 20 free slots, so it must feet)
And on the paper doll, I must click two time to get my model naked (the first time my actual equip is shown).
I hope I haven't missed a post... so if someone have any idea on that, I take it :)
(I'm on FR_fr client, if it's relevant, and using OneBag)
It seems like order of gear switching is important and a little more complicated than switch all of set x out and all of set y in.
However you can just switch to that set twice and the pieces that failed to switch will be put in the 2nd time normally. I'm not really sure what's better having to switch to the set twice to get a few stray pieces (usually trinkets and pieces with conflicted gems) in or altering the switch logic to be a lot more complicated and slower.
Holy crap, that problem sucks.
Hope I can fix that, but I'm not going to try yet, maybe in a few weeks, a month or so.
Having dealt with that kind of issue in a different environment, my suggestion on how to deal with it is fairly easy, the only complication comes from how you can detect the failure. If the call to equip the item returns a status, it's easy, otherwise you have to check to see if you really equipped the item, and I'm not sure how much overhead would be involved.
Basically, you loop on equiping the items (either the entire set, easiest to code, or just the failed items, probably more efficient), and drop out of the loop when you either equip all items or you fail to equip any items (that weren't equipped in a previous iteration). Worst case, this would be an order N^2 algorithm, but I don't see it ever devolving far enough to be an issue.
A more elegant solution, but a good bit more work, would be to do that the first time, and remember the order you successfully equipped them.
Trying to code this looking specifically for unique-equipped gems would be a nightmare, and would be special case for that one problem, rather than dealing with similar issues in the future. It might provide an alternate solution to the offhand weapon issue. I haven't been tracking that so I don't know what the current solution is.
oho, I will try this when I get home, do I need to create a special 'Flight' set?
Yes, there will be a new setting in your "Mount" menu for flight form. (And yes, it's there even if you're not a druid. As I said, not the most elegant solution.)
Sweet Fancy Moses, it works, I love you! Anyway we can get this added to the real closetgnome_mount on the svn?
I'm having some trouble using the ClosetGnome_Zone module. In fact, I'm not able to use it at all. I couldn't figure out any command to give me some help and there are no options in neither the switcher nor any other menu allowing me to assign sets to specific zones. I'm using the enGB client with CG r44615.7, CG_Switcher r42614.38 and CG_Zone r45169.
I'm sorry if this question has already been answered but I haven't found anything strolling through this thread.