Authors CurseForge

Isn't it time to remove that logon beta message?

Quote from cheadstina »

r32791:
Would it be possible to get an option to disable the:

self:Print(string.format(L["In combat: %s queued for swap."], name))

I use the switcher, and on my rogue I have a dagger in main hand so I can backstab. And then switch weapons to swords when fighting.

The sets only contains the weapons(I have set all the slots to red except for the two weapon slots).
Same thing happens on my warrior with stances, also here the involved sets only contains weapons.

Would love to avoid the queued-message(or a nice in-game option to remove that).

Thanks for a great addon.

Any news about that bug? This also happens when I change from my 2hand to 1hand+shield with my warrior while in combat. The sets only contains weapons(+shield).

It seems my closetgnome doesn't like to remember my fishing outfit >< anyone else get that? it only remembers one piece ><

First of all, thanks for this really great addon (love the messages it does). Any chance that different profiles will be implemented once? I just started a druid where I need to switch healing/tanking gear, but it only works global, not for different characters yet. Would be awesome to see this. Or did I just miss something?

Greetings.

p.s.: and sorry if this question was answered already, didn't have the time to read the last 30 pages oO

Huge feature request..

CG module that emulates ItemRacks "pop-out" functionality on the character screen, where when you shift+hover over a particular item slot (head, neck etc) it will display a pop-out where you can select other items in your bags using the same slot. I will seriously have your babies if you add a module that does that :)

Quote from OttoDeFe »

SwapMagic does this.

It's in the files.

Guess i missed this.. Thanks :)

Still getting that error I reported on June 20, page 29:

[2007/07/08 23:15:18-1680-x1]: ClosetGnome_Banker\Banker.lua:286: bad argument #1 to 'pairs' (table expected, got nil)
ClosetGnome_Banker\Banker.lua:286: in function `func'
Dewdrop-2.0-42392 (AHsearch):665: in function <...ace\AddOns\AHsearch\libs\Dewdrop-2.0\Dewdrop-2.0.lua:604>

FYI, weapon swapping from a two-hand weapon to a one-hand weapon plus a "held in off-hand" miscellaneous item isn't working quite right (read: at all). Remember that "held in off-hand" items don't come back as INVTYPE_WEAPON, they're INVTYPE_HOLDABLE.

I made a hack for ClosetGnome:EquipItem based on the shield hack a few pages ago:

-- holdable change starts here... (from forum courtesy Ruldar
if slot == 17 and self:ItemNameFromSlot(16) then
	local _,_,_,_,_,_,_,_,itemEquipLoc,_ = GetItemInfo(self:ItemNameFromSlot(16))
	if itemEquipLoc == "INVTYPE_2HWEAPON" then
	PickupInventoryItem(16)
	local toBag, toSlot = self:LocateFreeSlot()
	if toBag ~= nil then
	  PickupContainerItem(toBag, toSlot)
	else
	  AutoEquipCursorItem()
	end
  end
end
-- ...and ends here

I suspect there is a better way to fix it, but I don't have the time right now. I'll look in to it tomorrow if I get a chance.

So I looked in to it, and actually I think that probably is the best way to do it. Because of the way the set tables are built, and then interated, there's no elegant way to say "if I'm looking at slot 17, but slot 16 hasn't been handled yet, do slot 16," which is how I'd prefer to do it. Since we can't do that without overhauling set construction (or forcing ReallyWearSet() to do slot 16 first, which would be messy and mean rewriting a bit of ReallyWearSet()), the only way left is to make sure that slot 16 doesn't have a 2h weapon in it when we try to equip slot 17, which is exactly what the hack above does.

So, I cleaned it up a bit, and here is a revised clipping from ClosetGnome:EquipItem():

			...
			table.insert(deequipQueue, slot)
		end
	else
		-- We can't equip off-hand items if we still have a 2h weapon equipped. In such an event, we should deequip the 2h weapon first.
		local wpnisTwoHand = self:ItemNameFromSlot(16) and ( self:GetItemEquipLoc(self:ItemNameFromSlot(16)) == "INVTYPE_2HWEAPON" )
		if slot == 17 and wpnisTwoHand then
			PickupInventoryItem(16)
			local toBag, toSlot = self:LocateFreeSlot()
			if toBag ~= nil then
				PickupContainerItem(toBag, toSlot)
			else
				AutoEquipCursorItem()
			end
		end
		local bagNum, slotNum = self:FindItem(item)
		if bagNum > -1 then
		...

NOTE: I'm at work, and can't actually test that code, but I'm pretty sure it should work. Just make sure it does before you commit it... I will test it over lunch (sometime after noon Pacific time), but until then you're on your own. ;)