Something I was noticing yesterday...
When I click on a quest and it opens up the nQuestlog quest pane, as well as the Lightheaded pane... the ESC button does not close them.
Would it be possible to have those windows affected by ESC to close?
Sometimes when I have those panes up and I start getting attacked (by mob or PVP), I use ESC to close the windows quick so i can see the action.
Otherwise I have to move mouse cursor to the close option, and sometimes click the abort option....
Your time / insight is appreciated.
Here you go. The code was already there in DetailsFrame.lua and was just commented out (was probably from QuestsFu and the author of nQuestLog didn't like that behavior). Just download the new DetailsFrame.lua that I've attached and replace the one in the nQuestLog\modules directory and it will hide the details and comments frames when you hit escape. Works perfectly in my testing, but let me know if it causes any problems for you.
Edit: Whoops, never mind, looks like this breaks hitting escape for the WoW menu, haha. Removing attachment for now. I'll see if I can fix it.
Edit2: Ok, it should be working now. I've reattached the DetailsFrame.lua file with the new code. Please try it out and let me know how it goes.
I don't like how the current code works, as it generates a ton of extra load when you're showing the details frame due to unnecessary refreshes every second, causing the game to stutter badly when you have the details frame open. I plan to fix this, maybe this weekend, by getting rid of the refresh event and only doing a refresh/show/hide based on actual events, such as clicking a quest in nQuestLog. It's a minor annoyance, but still annoying and not how it should be.
Edit: Never mind, this is the QuestGivers module doing this. I highly recommend unchecking QuestGivers in the nQuestLog options, as the Comments frame gives you this functionality plus more and it doesn't cause really bad stuttering like the QuestGivers module does.
Thank you yet again 1337rx8...
its working like a charm. FYI, I am not seeing the issues you mentioned about having QuestGivers checked.
Well, if you have the QuestGivers module enabled, and you click to view the details of a quest that has QuestGivers data, you should notice a slight stutter every 1 second when it refreshes that whole frame to update the QuestGivers coordinates displayed. When you close the details frame, it stops updating and doesn't stutter of course, but it's annoying if you're trying to run somewhere with the details frame open. I just uncheck it, since that info is in the Comments frame under "Starts:", plus you can have it do a Cartographer waypoint from that, which doesn't make the game stutter, updates more quickly, works across zones, and is more useful. QuestGivers requires Cartographer to work anyway, so I may try to change it to use Cartographer waypoints and work properly across zones, for those who want to use it and who aren't using LightHeaded.
i admit i am new to this - but i cant figure this out, i accidentally hide the nquestlog minimap thing and i cant figure ot how to get it back. i tried /nquestlog and /nql to get options but no help and there was no readme in the file i dowload - plz help
Speaking of which, would it be possible (well of course it is... easy might be the right word then ^^) to implemented something like ctrl-click on the fubar plugin to have nQL locked/unlocked ?
It is quite a pain to have to delve into the submenus to do this :/
Ah, thanks. That's the version I was using, it didn't have the mobmap integration that was mentioned earlier which is why I thought there was a newer version out.
Another few feature suggestions:
1) When a quest is done, option to choose which color the "(done)" text it? by default it's white, though green has always been my preference
2) When other members in your group are on the same quest, option to show it like in questFu where there's a "<1>" beside the quest name and "1" is the number of people in your group that share that quest
3) Option to show completed quests regardless of zone (hide the other quests in the zone if you're not currently in the zone)
The mobmap integration needs to be put on the svn. I'm not comfortable with diffs (since I haven't used one before) so I don't want to break anything. That's why it's still sitting there. ;) Someone else will need to check those changes in or 1337rx8 will need to get an svn account.
The mobmap integration needs to be put on the svn. I'm not comfortable with diffs (since I haven't used one before) so I don't want to break anything. That's why it's still sitting there. ;) Someone else will need to check those changes in or 1337rx8 will need to get an svn account.
I agree, I am no coder. Would someone please put it up or give the person an svn account?
I accidently hid the mini-map icon which turned off nQuestLog and can't figure out how to get it working again. I've tried everything I could think of. Even deleting and re-installing a new file, but nothing works. Help?
I accidently hid the mini-map icon which turned off nQuestLog and can't figure out how to get it working again. I've tried everything I could think of. Even deleting and re-installing a new file, but nothing works. Help?
Deleting the nquestlog.lua file in your wow\WTF\ACCOUNT\your_account_name\SavedVariables folder should reset it.
When either zone header or zone level are set to "color by level", the colors aren't right...
Everything is green, even though for my char some should be yellow/orange.
i.e.
i'm lvl 40, and a lvl 40-50 zone is shown as green when it should be orange.
is this topic the best place to post bugs or is there a bugtracker somewhere that these should be posted?
I'll fill out the form and request SVN access, probably today or this weekend at the latest. So, hopefully I'll be able to apply the changes soon. I'm pretty comfortable with Lua coding now, so I doubt I'll mess anything up...nothing that I can't fix, at least :).
I'll fill out the form and request SVN access, probably today or this weekend at the latest. So, hopefully I'll be able to apply the changes soon. I'm pretty comfortable with Lua coding now, so I doubt I'll mess anything up...nothing that I can't fix, at least :).
Thank you from all of us NON coders!! :)
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
Here you go. The code was already there in DetailsFrame.lua and was just commented out (was probably from QuestsFu and the author of nQuestLog didn't like that behavior). Just download the new DetailsFrame.lua that I've attached and replace the one in the nQuestLog\modules directory and it will hide the details and comments frames when you hit escape. Works perfectly in my testing, but let me know if it causes any problems for you.
Edit: Whoops, never mind, looks like this breaks hitting escape for the WoW menu, haha. Removing attachment for now. I'll see if I can fix it.
Edit2: Ok, it should be working now. I've reattached the DetailsFrame.lua file with the new code. Please try it out and let me know how it goes.
I don't like how the current code works, as it generates a ton of extra load when you're showing the details frame due to unnecessary refreshes every second, causing the game to stutter badly when you have the details frame open. I plan to fix this, maybe this weekend, by getting rid of the refresh event and only doing a refresh/show/hide based on actual events, such as clicking a quest in nQuestLog. It's a minor annoyance, but still annoying and not how it should be.
Edit: Never mind, this is the QuestGivers module doing this. I highly recommend unchecking QuestGivers in the nQuestLog options, as the Comments frame gives you this functionality plus more and it doesn't cause really bad stuttering like the QuestGivers module does.
its working like a charm. FYI, I am not seeing the issues you mentioned about having QuestGivers checked.
Well, if you have the QuestGivers module enabled, and you click to view the details of a quest that has QuestGivers data, you should notice a slight stutter every 1 second when it refreshes that whole frame to update the QuestGivers coordinates displayed. When you close the details frame, it stops updating and doesn't stutter of course, but it's annoying if you're trying to run somewhere with the details frame open. I just uncheck it, since that info is in the Comments frame under "Starts:", plus you can have it do a Cartographer waypoint from that, which doesn't make the game stutter, updates more quickly, works across zones, and is more useful. QuestGivers requires Cartographer to work anyway, so I may try to change it to use Cartographer waypoints and work properly across zones, for those who want to use it and who aren't using LightHeaded.
but you can also configure it with Niagara, i think
It is quite a pain to have to delve into the submenus to do this :/
- http://www.wowinterface.com/downloads/info7408-nQuestLogBinds.html
:)
I will give it a shot anyway.
Also a feature suggestion:
Option to hide collapsed zones?
Another few feature suggestions:
1) When a quest is done, option to choose which color the "(done)" text it? by default it's white, though green has always been my preference
2) When other members in your group are on the same quest, option to show it like in questFu where there's a "<1>" beside the quest name and "1" is the number of people in your group that share that quest
3) Option to show completed quests regardless of zone (hide the other quests in the zone if you're not currently in the zone)
I agree, I am no coder. Would someone please put it up or give the person an svn account?
Deleting the nquestlog.lua file in your wow\WTF\ACCOUNT\your_account_name\SavedVariables folder should reset it.
When either zone header or zone level are set to "color by level", the colors aren't right...
Everything is green, even though for my char some should be yellow/orange.
i.e.
i'm lvl 40, and a lvl 40-50 zone is shown as green when it should be orange.
is this topic the best place to post bugs or is there a bugtracker somewhere that these should be posted?
Thank you from all of us NON coders!! :)