OK, I tested it out and the killer features for me are:
- The quest list stays up all the time
- Info regarding completed objectives is hidden and doesn't clutter the screen
- Instructions shown on mouse-over, so there's no need to open the quest log all the time.
LightHeaded\LightHeaded.lua:234: attempt to index local 'data' (a nil value)
nQuestLog-1.0\modules\Comments.lua:182: in function `runChildren'
Tablet-2.0-41876 (TabletLib):2355: in function `children'
Tablet-2.0-41876 (TabletLib):2399: in function `Open'
nQuestLog-1.0\modules\Comments.lua:230: in function `Update'
nQuestLog-1.0\modules\Comments.lua:132: in function <Interface\AddOns\nQuestLog\modules\Comments.lua:130>
(tail call): ?:
<in C code>: in function `UpdateQuestDetail'
nQuestLog-1.0\modules\DetailsFrame.lua:141: in function `ShowLog'
nQuestLog-1.0\events.lua:311: in function <Interface\AddOns\nQuestLog\events.lua:308>
<in C code>: in function `ShowLog'
nQuestLog-1.0\events.lua:340: in function `OnQuestLogClickQuest'
nQuestLog-1.0\events.lua:132: in function `OnQuestLogClick'
<string>:"*:OnMouseDown":5: in function <[string "*:OnMouseDown"]:1>
Started getting this error last night when clicking on quests in the minion.
can I make a request, dunno if it has been request before though. Party notification of quest progress. I currently use a separate mod for this, would be nice to just add it...one less mod..
I've added functionality to click on quest objectives to have them mapped by MobMap. The diff file is attached. It's very little code to achieve such a wonderful integration that nQuestLog was missing. Please merge with SVN or let me know what else I need to do if I haven't done something right here. Thanks!
Here is another diff submission for added functionality for the LightHeaded comments frame. Here's a summary of the changes:
nQuestLog LightHeaded Comments frame
- Rearranged the layout a bit for a more compact and (IMO) better-looking display.
- Corrected the "sharable" display so that it's accurate, rather than being completely broken like it is right now with any quest log (this needs to be fixed in LightHeaded).
- Fixed the display of reputation which wasn't working due to outdated nQuestLog comments frame code.
- Added ordered quest series list that allows clicking to view each quest in the list within the same frame.
Please apply to SVN or let me know what I need to do if this isn't the right way to request this. I've been testing this for about 5 days now and it works GREAT! The only quirky thing is that if two or more quests in a quest series have the same name, only the first one is shown when clicked. I plan to try to fix this, but it's really only a minor concern and doesn't generate any bugs or crashes or anything. I will try to add quest rewards if I can, but the stuff I fixed/added was much higher priority for me.
Like how this does interface with Lightheaded... would love to see it do the same for MobMap.
Also eager to see the changes that 1337rx8 made.
For the LightHeaded stuff, the display code is basically copied from LightHeaded, modified a bit, and then used. It calls LightHeaded for the data and then displays it using the copied LightHeaded code (which I and others have modified, of course).
As for MobMap, what else would you like to see besides what I added? This was the big feature for me, but I can look into adding other MobMap functionality if you could list what you'd like to see. Adding quest rewards to the LightHeaded frame is already on my list, and that will probably come from MobMap, I imagine. Just to clarify, I'm not interested in adding anything that LightHeaded already provides. Thanks.
well, when you say you added... I am assuming you are refering to the Diff in the post just a few up. If so, I have not seen those changes yet as I usualy pull from the SVN so I am eagerly awaiting somone to upload them.
The feature I like from mob map is the ability to click on the mob that needs to be killed and the area that the mob can be found in will be outlined in cartographer. If thats what you have added in your diff... Im very stoaked about it (ya thats a good thing).
well, when you say you added... I am assuming you are refering to the Diff in the post just a few up. If so, I have not seen those changes yet as I usualy pull from the SVN so I am eagerly awaiting somone to upload them.
The feature I like from mob map is the ability to click on the mob that needs to be killed and the area that the mob can be found in will be outlined in cartographer. If thats what you have added in your diff... Im very stoaked about it (ya thats a good thing).
Good hunting to you.
Yeah, that's exactly what has been added. Whatever the objective is, if it can be mapped it will. So whether it's a mob, a drop, or whatever, if MobMap can map it it will open the map and identify the location of that objective. Enjoy! (once it's added)
Just in case it takes a while for this stuff to get into SVN, I'm attaching the full DetailsFrame.lua and Comments.lua files with my modifications. Just replace the files of the same name within your Addons\nQuestLog\Modules folder and you'll have the new functionality.
Thanks for the positive feedback. I'm glad the enhancements are working well. Hopefully, someone with SVN access will see this thread and apply the diffs to SVN. :)
Additionally, I'm working on further enhancements as follows:
DONE (and currently testing)
Show an estimate of the actual XP you will get if you are currently 6 or more levels above the quest level and thus get reduced XP.
This is in addition to the display of the full xp, and is in parentheses to the right of it [for example...(75 @ level 21)].
This formula is from WowWiki.com, and although not 100% accurate (plus or minus 3% in my tests), it's close enough. After many hours of trying my own formulas, I've come to the conclusion that Blizzard must use multiple formulas or a very complex single formula to calculate this, depending on various factors, and I don't have enough data to determine exactly what those formulas and factors are.
Show information from MobMap.
This includes the type of quest (solo, group, dungeon, raid, etc.), the faction (Horde, Alliance, or Horde/Alliance), the zone, the monetary reward of the quest (if any), and the additional monetary reward at level 70 instead of XP.
I'm using a formula that I came up with to extract the level 70 reward money out of MobMap's total reward and separate this into two figures. Based on my current tests, the formula is 100% accurate.
All of this information is also stored at WowHead.com, so if LightHeaded starts exporting that additional data from WowHead's database, I'll get it from LightHeaded instead. Currently, however, LightHeaded does not support this.
Add zone name to quest NPC coordinates.
Currently, the comments frame uses calls to LightHeaded to list starting or ending NPC coordinates when you click the NPC name. Since this can get confusing with just coordinates and no zone name, I've added the zone name to the left of the coordinates in the comments frame.
Additionally, if the zone name is different than your current zone, and you click to track via Cartographer_WayPoints, it will display the name of the zone in parentheses after the NPC name.
[br]TO DO
Currently beginning work on adding the non-money rewards from MobMap to the comments window. I'm not sure if this will be possible at this point, and it's likely going to be fairly complicated if it is possible. This should complete the MobMap integration.
Try to filter out invalid MobMap quest data. MobMap always seems to have the valid quest data in its database, but sometimes an invalid quest entry with the same name will take precedence and mess up the MobMap Info display.
Thanks for the positive feedback. I'm glad the enhancements are working well. Hopefully, someone with SVN access will see this thread and apply the diffs to SVN..........
Your work is pretty much appreciated. I have tested it today and it looks definitely useful and working. Could I please add myself to the army of those kindly asking someone to add this to SVN?
Currently beginning work on adding the non-money rewards from MobMap to the comments window. I'm not sure if this will be possible at this point, and it's likely going to be fairly complicated if it is possible. This should complete the MobMap integration.
DONE (and currently testing). Also added quest difficulty coloring to quests in the LightHeaded Quest Series. Just need to try to filter out invalid MobMap quest data now.
Something I was noticing yesterday...
When I click on a quest and it opens up the nQuestlog quest pane, as well as the Lightheaded pane... the ESC button does not close them.
Would it be possible to have those windows affected by ESC to close?
Sometimes when I have those panes up and I start getting attacked (by mob or PVP), I use ESC to close the windows quick so i can see the action.
Otherwise I have to move mouse cursor to the close option, and sometimes click the abort option....
Your time / insight is appreciated.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
Isn't trying and seeing for yourself a lot better than any explanation?
Off the top of my head,
But there's probably some more I'm forgetting.
Thanks!
- The quest list stays up all the time
- Info regarding completed objectives is hidden and doesn't clutter the screen
- Instructions shown on mouse-over, so there's no need to open the quest log all the time.
Good addon.
Started getting this error last night when clicking on quests in the minion.
nQuestLog LightHeaded Comments frame
- Rearranged the layout a bit for a more compact and (IMO) better-looking display.
- Corrected the "sharable" display so that it's accurate, rather than being completely broken like it is right now with any quest log (this needs to be fixed in LightHeaded).
- Fixed the display of reputation which wasn't working due to outdated nQuestLog comments frame code.
- Added ordered quest series list that allows clicking to view each quest in the list within the same frame.
Please apply to SVN or let me know what I need to do if this isn't the right way to request this. I've been testing this for about 5 days now and it works GREAT! The only quirky thing is that if two or more quests in a quest series have the same name, only the first one is shown when clicked. I plan to try to fix this, but it's really only a minor concern and doesn't generate any bugs or crashes or anything. I will try to add quest rewards if I can, but the stuff I fixed/added was much higher priority for me.
Also eager to see the changes that 1337rx8 made.
For the LightHeaded stuff, the display code is basically copied from LightHeaded, modified a bit, and then used. It calls LightHeaded for the data and then displays it using the copied LightHeaded code (which I and others have modified, of course).
As for MobMap, what else would you like to see besides what I added? This was the big feature for me, but I can look into adding other MobMap functionality if you could list what you'd like to see. Adding quest rewards to the LightHeaded frame is already on my list, and that will probably come from MobMap, I imagine. Just to clarify, I'm not interested in adding anything that LightHeaded already provides. Thanks.
The feature I like from mob map is the ability to click on the mob that needs to be killed and the area that the mob can be found in will be outlined in cartographer. If thats what you have added in your diff... Im very stoaked about it (ya thats a good thing).
Good hunting to you.
Yeah, that's exactly what has been added. Whatever the objective is, if it can be mapped it will. So whether it's a mob, a drop, or whatever, if MobMap can map it it will open the map and identify the location of that objective. Enjoy! (once it's added)
Just in case it takes a while for this stuff to get into SVN, I'm attaching the full DetailsFrame.lua and Comments.lua files with my modifications. Just replace the files of the same name within your Addons\nQuestLog\Modules folder and you'll have the new functionality.
Thanks for the time and effort 1337rx8
Additionally, I'm working on further enhancements as follows:
DONE (and currently testing)
- Add zone name to quest NPC coordinates.
- Currently, the comments frame uses calls to LightHeaded to list starting or ending NPC coordinates when you click the NPC name. Since this can get confusing with just coordinates and no zone name, I've added the zone name to the left of the coordinates in the comments frame.
- Additionally, if the zone name is different than your current zone, and you click to track via Cartographer_WayPoints, it will display the name of the zone in parentheses after the NPC name.
[br]TO DOYour work is pretty much appreciated. I have tested it today and it looks definitely useful and working. Could I please add myself to the army of those kindly asking someone to add this to SVN?
Thanks
DONE (and currently testing). Also added quest difficulty coloring to quests in the LightHeaded Quest Series. Just need to try to filter out invalid MobMap quest data now.
When I click on a quest and it opens up the nQuestlog quest pane, as well as the Lightheaded pane... the ESC button does not close them.
Would it be possible to have those windows affected by ESC to close?
Sometimes when I have those panes up and I start getting attacked (by mob or PVP), I use ESC to close the windows quick so i can see the action.
Otherwise I have to move mouse cursor to the close option, and sometimes click the abort option....
Your time / insight is appreciated.