tazmanyak, thanks. I appear to have made the same error in all the non-english localization files. Will fix them all tonight.
Iceroth, good idea. I'll see what I can come up with. Maybe clicking on an event will trigger a sample of it?
Rasapian, aye I need to address this. Its the same issue Gorfob brought up. You can reset options if you really want 0 right now =)
andreasg, as mentioned, the sct_evebt_config.lua file can handle this. I do plan on making an in game UI to add Custom Events, but its still a little ways off.
m0j0, I'd say its pretty stable at this point. The events i mention in the original post are the only things that won't work on live server. They don't cause bugs, you just won't get the events. So really what I know doesn't work on live is: honor, reputation, buff fades, and the new Skill event. All these are using a new event that doesn't need parsing, but WoW only has in 1.12.
zophiel, strange. I'll take a look.
mattftw, buff fades currently don't work on live as I mention above.
Check the Interface menu - I believe there is an option in there to show damage above mobs. What the addon probably does is uncheck this for you, but after you remove it it will remain unchecked.
I'm not at the game now, but I believe that option is there...
Just to expand on the error zophiel mentioned, when opening the SCT options it resets the SCTD options. So every time you open the SCT options you have to open SCTD options to set them back to how you want them, before clicking "Save and Close".
I'll have to take a look at the SCTD reseting problem. I didn't encounter this in my self testing. Wonder maybe if something changed in AceDB-2.0. Whatever it is, I'll try and have the fix out later today.
I have commited the localization fixes so update if you need them.
EDIT: Nevermind, think I found the SCTD reset issue. Please get lastest from SVN and let me know. You may need to reset your options manually (with the button or slash command) to get everything working. If it still doesn't work for you after that, please try and list for me steps to reproduce. Thanks!
I don't know if I'm the only one having issues with this mod (I seem to) but I'm getting strictly nothing to come out of SCT 5.0.
I used to have the "Standard" setup and added a simple Overpower message for my warrior. I understand some feature will only work on PTR 1.12 but on Live 1.11 there's nothing that prints out at all. No damage, no taken damage nothing.
Maybe I took everything wrong on the SVN. That's even more wierd is that I'm getting the SCT & SCTD menu to show and save a profile in my saved vars.
[EDIT] It seems that I was having issues with Fubar1.0 and OneView that was causing some Ace2 addons not to load completely .. now fixed
EDIT: Nevermind, think I found the SCTD reset issue. Please get lastest from SVN and let me know. You may need to reset your options manually (with the button or slash command) to get everything working. If it still doesn't work for you after that, please try and list for me steps to reproduce. Thanks!
Had the reset issue too, with the latest svn version... but just read your "You may need to reset your options manually" statement. So I logged out, deleted SavedVariables\sct.lua and tried it again. Unfortunatly it's still resetting for me (disabled/changed some options, did a reloadui... voila, all resetted)
Can you give me some more detail as to how to reproduce it? I tried everything i could think of yesterday and was never able to. New characters, multiple machines, etc...Can you try turning off all other Ace/Ace2 mods and see if you still get the issue? Are you using any Ace profiles? Can you see if you still get the issue if you go straight to the sctd options using /sctd menu?
I'm really at a loss on this. If anyone wants to help trouble shoot its found on line 179 of sctd.lua. Its calls UpdateValues here incase the user has reset or copied characters. The UpdateValues updates any SCTD var that is currently nil. The only reason anything should be nil at that point is on a reset or char copy, so I'm not seeing why its resting options for people that haven't done that.
Can you give me some more detail as to how to reproduce it? ... Can you try turning off all other Ace/Ace2 mods and see if you still get the issue? Are you using any Ace profiles?
Ok, tried it with a completly clean Interface/WTF folder. Only the latest SCT/SCTD's are installed.
After the first /sctd menu, the options look like this:
:: Screen 1 - first start, nothing configured
As you can see, he is not resetting everything.. color crits still is enabled, fade speed still 3, only target still enabled - but other things got resetted like periodic damage, pet damage, use sct animation...
I guess you thought it's resetting everything and you just tried it with one of the options that isn't resetting? ;-)
edit: and btw, the reset doesn't happen for me when the option frame shows, it's resetted before... directly after the UI reload I'm getting periodic / pet dmg spam that I disabled before the reload - so I don't think the SCTD:ShowMenu()-Function has anything to do with it
OK I updated SCT
I clicked the reset button
Made changes
Saved and closed the SCT options
killed a few mobs
reopened the SCT stettings, the act of opening the SCT steeings resets SCTD settings, very bizarre
Thanks Sariash, that will help me track this down. Could you possibly post your SavedVariables\sct.lua file after that happened, or at least the info for the character you are on?
The UpdateValues is where the problem is happening, its called both on ShowMenu and in OnInitialize. For whatever reason, some of the settings are not getting saved, or saved as nil, and on reload/login/menu open they are getting set to default. I puposely set all check box checks to 1 or false, so I'm not sure how they are getting set back to nil.
Some of the ones that are reseting, could you try changing their colors, and see if the colors reset too?
Thanks Sariash, that will help me track this down. Could you possibly post your SavedVariables\sct.lua file after that happened, or at least the info for the character you are on?
Isn't that one of the features he lists in the initial post that are 1.12 only? Or are you talking about something different and/or on the test realm?
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIceroth, good idea. I'll see what I can come up with. Maybe clicking on an event will trigger a sample of it?
Rasapian, aye I need to address this. Its the same issue Gorfob brought up. You can reset options if you really want 0 right now =)
andreasg, as mentioned, the sct_evebt_config.lua file can handle this. I do plan on making an in game UI to add Custom Events, but its still a little ways off.
m0j0, I'd say its pretty stable at this point. The events i mention in the original post are the only things that won't work on live server. They don't cause bugs, you just won't get the events. So really what I know doesn't work on live is: honor, reputation, buff fades, and the new Skill event. All these are using a new event that doesn't need parsing, but WoW only has in 1.12.
zophiel, strange. I'll take a look.
mattftw, buff fades currently don't work on live as I mention above.
I'm not at the game now, but I believe that option is there...
Other than that, great job!
Yep, that sounds good.
OH, and as eerrrr said, there's something fishy with SCTD options, they tend to forget their settings at times.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumEDIT: Nevermind, think I found the SCTD reset issue. Please get lastest from SVN and let me know. You may need to reset your options manually (with the button or slash command) to get everything working. If it still doesn't work for you after that, please try and list for me steps to reproduce. Thanks!
I used to have the "Standard" setup and added a simple Overpower message for my warrior. I understand some feature will only work on PTR 1.12 but on Live 1.11 there's nothing that prints out at all. No damage, no taken damage nothing.
Maybe I took everything wrong on the SVN. That's even more wierd is that I'm getting the SCT & SCTD menu to show and save a profile in my saved vars.
[EDIT] It seems that I was having issues with Fubar1.0 and OneView that was causing some Ace2 addons not to load completely .. now fixed
[me=uaxli]downloads[/me]
Had the reset issue too, with the latest svn version... but just read your "You may need to reset your options manually" statement. So I logged out, deleted SavedVariables\sct.lua and tried it again. Unfortunatly it's still resetting for me (disabled/changed some options, did a reloadui... voila, all resetted)
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI'm really at a loss on this. If anyone wants to help trouble shoot its found on line 179 of sctd.lua. Its calls UpdateValues here incase the user has reset or copied characters. The UpdateValues updates any SCTD var that is currently nil. The only reason anything should be nil at that point is on a reset or char copy, so I'm not seeing why its resting options for people that haven't done that.
Ok, tried it with a completly clean Interface/WTF folder. Only the latest SCT/SCTD's are installed.
After the first /sctd menu, the options look like this:
:: Screen 1 - first start, nothing configured
I configured it like this:
:: Screen 2 - just configured everything to my liking
After an UI reload it looks like this:
:: Screen 3 - reloaded the UI to see 'some' options resetted
As you can see, he is not resetting everything.. color crits still is enabled, fade speed still 3, only target still enabled - but other things got resetted like periodic damage, pet damage, use sct animation...
I guess you thought it's resetting everything and you just tried it with one of the options that isn't resetting? ;-)
edit: and btw, the reset doesn't happen for me when the option frame shows, it's resetted before... directly after the UI reload I'm getting periodic / pet dmg spam that I disabled before the reload - so I don't think the SCTD:ShowMenu()-Function has anything to do with it
I clicked the reset button
Made changes
Saved and closed the SCT options
killed a few mobs
reopened the SCT stettings, the act of opening the SCT steeings resets SCTD settings, very bizarre
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThe UpdateValues is where the problem is happening, its called both on ShowMenu and in OnInitialize. For whatever reason, some of the settings are not getting saved, or saved as nil, and on reload/login/menu open they are getting set to default. I puposely set all check box checks to 1 or false, so I'm not sure how they are getting set back to nil.
Some of the ones that are reseting, could you try changing their colors, and see if the colors reset too?
This is the sct.lua after the reload UI ...
SCT_CONFIG = { ["chars"] = { ["Sariash of Blackhand"] = { ["SCTD_SPELLCOLOR"] = false, ["COLORS"] = { ["SCTD_SHOWPET"] = { ["r"] = 0.6, ["g"] = 0.6, ["b"] = 0, }, ["SCTD_SHOWSPELL"] = { ["r"] = 1, ["g"] = 1, ["b"] = 0, }, ["SCTD_SHOWMELEE"] = { ["r"] = 1, ["g"] = 1, ["b"] = 1, }, ["SCTD_SHOWPERIODIC"] = { ["r"] = 1, ["g"] = 1, ["b"] = 0, }, ["SCTD_SHOWCOLORCRIT"] = { ["r"] = 0.2, ["g"] = 0.4, ["b"] = 0.6, }, }, ["SCTD_SHOWMELEE"] = 1, ["SCTD_USESCT"] = 1, ["LOWMANA"] = 0.4000000059604645, ["SCTD_SHOWDMGTYPE"] = false, ["SCTD_SHOWTARGETS"] = false, ["SCTD_SHOWCOLORCRIT"] = false, ["SCTD_SHOWRESIST"] = 1, ["SCTD_SHOWPET"] = 1, ["SCTD_ENABLED"] = 1, ["ANIMATIONSPEED"] = 0.01499999966472387, ["LOWHP"] = 0.4000000059604645, ["SCTD_SHOWSPELL"] = 1, ["FRAMESDATA"] = { [3] = { ["ANITYPE"] = 1, ["ALPHA"] = 1, ["DIRECTION"] = false, ["FADE"] = 3, ["FONTSHADOW"] = 2, ["TEXTSIZE"] = 24, ["FONT"] = 1, ["ANISIDETYPE"] = 1, ["YOFFSET"] = 210, ["XOFFSET"] = 0, }, }, ["SCTD_DMGFONT"] = 1, ["SCTD_SHOWPERIODIC"] = 1, ["SCTD_FLAGDMG"] = false, ["SCTD_PVPDMG"] = false, ["SCTD_STICKYCRIT"] = 1, ["SCTD_SHOWSPELLNAME"] = 1, ["SCTD_TARGET"] = 1, }, }, }Colors don't.