You should never have a standalone LibStub. You should have the following libraries: Ace2, DewdropLib, FuBarPlugin-2.0, RosterLib, LibSharedMedia-3.0, SpecialEventsEmbed, TagCompiler-1.0, Waterfall-1.0.
hmm just tried for the first time, and got tons of error just during browsing config:
[2008/05/09 11:36:14-1769-x3]: Assessment-r54978\Assessment.lua:392: bad argument #1 to 'unpack' (table expected, got nil)
Dewdrop-2.0-56529 (BugSack):1864: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:1832>
Dewdrop-2.0-56529 (BugSack):2768: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:2727>
Dewdrop-2.0-56529 (BugSack):619: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:603>
---
[2008/05/09 11:36:14-1769-x2]: Couldn't find CVar named 'CombatLogRangeCreature':
Dewdrop-2.0-56529 (BugSack):1504: in function `FeedAceOptionsTable'
Dewdrop-2.0-56529 (BugSack):1864: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:1832>
Dewdrop-2.0-56529 (BugSack):2768: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:2727>
Dewdrop-2.0-56529 (BugSack):619: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:603>
---
[2008/05/09 11:36:14-1769-x2]: Couldn't find CVar named 'CombatDeathLogRange':
Dewdrop-2.0-56529 (BugSack):1504: in function `FeedAceOptionsTable'
Dewdrop-2.0-56529 (BugSack):1864: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:1832>
Dewdrop-2.0-56529 (BugSack):2768: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:2727>
Dewdrop-2.0-56529 (BugSack):619: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:603>
---
[2008/05/09 11:36:14-1769-x2]: Couldn't find CVar named 'CombatLogRangeFriendlyPlayersPets':
Dewdrop-2.0-56529 (BugSack):1504: in function `FeedAceOptionsTable'
Dewdrop-2.0-56529 (BugSack):1864: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:1832>
Dewdrop-2.0-56529 (BugSack):2768: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:2727>
Dewdrop-2.0-56529 (BugSack):619: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:603>
---
[2008/05/09 11:36:14-1769-x2]: Couldn't find CVar named 'CombatLogRangeFriendlyPlayers':
Dewdrop-2.0-56529 (BugSack):1504: in function `FeedAceOptionsTable'
Dewdrop-2.0-56529 (BugSack):1864: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:1832>
Dewdrop-2.0-56529 (BugSack):2768: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:2727>
Dewdrop-2.0-56529 (BugSack):619: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:603>
---
[2008/05/09 11:36:14-1769-x2]: Couldn't find CVar named 'CombatLogRangeHostilePlayersPets':
Dewdrop-2.0-56529 (BugSack):1504: in function `FeedAceOptionsTable'
Dewdrop-2.0-56529 (BugSack):1864: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:1832>
Dewdrop-2.0-56529 (BugSack):2768: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:2727>
Dewdrop-2.0-56529 (BugSack):619: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:603>
---
[2008/05/09 11:36:14-1769-x2]: Couldn't find CVar named 'CombatLogRangeHostilePlayers':
Dewdrop-2.0-56529 (BugSack):1504: in function `FeedAceOptionsTable'
Dewdrop-2.0-56529 (BugSack):1864: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:1832>
Dewdrop-2.0-56529 (BugSack):2768: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:2727>
Dewdrop-2.0-56529 (BugSack):619: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:603>
---
[2008/05/09 11:36:14-1769-x4]: Couldn't find CVar named 'CombatLogRangeParty':
Dewdrop-2.0-56529 (BugSack):1504: in function `FeedAceOptionsTable'
Dewdrop-2.0-56529 (BugSack):1864: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:1832>
Dewdrop-2.0-56529 (BugSack):2768: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:2727>
Dewdrop-2.0-56529 (BugSack):619: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:603>
---
[2008/05/09 11:36:14-1769-x2]: Couldn't find CVar named 'CombatLogRangePartyPet':
Dewdrop-2.0-56529 (BugSack):1504: in function `FeedAceOptionsTable'
Dewdrop-2.0-56529 (BugSack):1864: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:1832>
Dewdrop-2.0-56529 (BugSack):2768: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:2727>
Dewdrop-2.0-56529 (BugSack):619: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:603>
---
[2008/05/09 11:37:34-1769-x2]: Assessment-r54978\Assessment.lua:392: bad argument #1 to 'unpack' (table expected, got nil)
Dewdrop-2.0-56529 (BugSack):1864: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:1832>
Dewdrop-2.0-56529 (BugSack):727: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:660>
---
[2008/05/09 11:38:21-1769-x33]: Dewdrop-2.0-56529 (BugSack):2017: Couldn't find CVar named 'CombatLogRangeCreature'
Dewdrop-2.0-56529 (BugSack):2017: in function <...face\AddOns\BugSack\Libs\Dewdrop-2.0\Dewdrop-2.0.lua:1989>
---
hmm just tried for the first time, and got tons of error just during browsing config:
Which version? Trunk? One of the branches?
All of the "Couldn't find CVar" options are the result of you browsing the "Combat Log Range" options; since post-2.4 WoW does not allow setting the combat log range, these cvars no longer exist.
I just made a commit undoing Jncl's toc number bump; Assessment (trunk version) is NOT yet functional in 2.4, so the toc number should NOT indicate 2.4 compatibility. I have no idea why he'd change that. ???
Damage (80% working). Still missing: Pet merge (need to set up a roster update handler and build pet/partyxpet/raidxpet association tables, since we don't get tokens back from CLEU as we did from parser)
Healing (0% working). Haven't even had a chance to look at it yet, need to see if Sano's version is workable.
Sano, when I last looked at your branch, you still had a bunch of Parserlib references. These need to go away entirely. Is your Healing module in a state where it works with pure COMBAT_LOG_EVENT_UNFILTERED events?
By any chance is your "pet merge" code retroactive? i.e. is pet data still stored separately, and only merged for display? That was the only thing I disliked about Assessment's pet handling pre-2.4; you couldn't merge or unmerge pets on the fly.
Either way, you can probably just post your modified file as an attachment in this thread. :)
Edit: Also, your image links don't work. I can't read what the page says, but there's no picture on it.
Well, what I'd like to see is the data stored separately, and then either shown with the pet's damage attributed to the owner, or the pet as a separate unit, depending on the current setting. I don't need to see it both ways at the same time. :)
if profile.mergePetWithOwner then
abilityNamePet = ("(%s) %s"):format(tostring(PetID), tostring(abilityName))
if sourceAffiliation >0 then
UpdateDamageData(damageDealt, OwnerID, eventData, attackType, abilityNamePet)
end
end
if not profile.mergePetWithOwner then
if sourceAffiliation >0 then
UpdateDamageData(damageDealt, sourceName, eventData, attackType, abilityName)
end
end
Healing (0% working). Haven't even had a chance to look at it yet, need to see if Sano's version is workable.
I tried out both yesterday. I thought it was somewhat funny that you have dmg mostly he working, he only has damage taken working, he has healing mostly working from what I saw, and you don't. You guys should talk. ;)
i've got the following libs:
Ace2, Libstub, sharedmedia, dewdrop, fubarplugin, roster, specialevents, tagcompiler, waterfall
all that are in the embeds.xml @ assessment
Which version? Trunk? One of the branches?
All of the "Couldn't find CVar" options are the result of you browsing the "Combat Log Range" options; since post-2.4 WoW does not allow setting the combat log range, these cvars no longer exist.
The version on SVN is 73218, so the version you loaded is most likely not compatiable with WoW 2.4. Did you get it from files.wowace.com?
IMO, the old version on files.wowace.com should be removed or have a warning stating it doesn't work in 2.4 and a new version is under development.
Dunno, but don't think so, looks like only the .toc file was changed.
You can check changes here;
http://fish.wowace.com/browse/WowAce/trunk/Assessment/
Why would Jncl update the .toc of the original addon if it hasn't been updated to work with 2.4 ?
So the toc should not be changed to 20400.
b: the devil made him do it
c: "it wasn't me, you can't prove it, and nobody saw me, anyway" -- Bart Simpson
:-)
Damage (80% working). Still missing: Pet merge (need to set up a roster update handler and build pet/partyxpet/raidxpet association tables, since we don't get tokens back from CLEU as we did from parser)
Healing (0% working). Haven't even had a chance to look at it yet, need to see if Sano's version is workable.
Sano, when I last looked at your branch, you still had a bunch of Parserlib references. These need to go away entirely. Is your Healing module in a state where it works with pure COMBAT_LOG_EVENT_UNFILTERED events?
no merge with pet :
but i dont know how to work with svn - so if you need code i can post it here.
sry for bad english - its not my native.
By any chance is your "pet merge" code retroactive? i.e. is pet data still stored separately, and only merged for display? That was the only thing I disliked about Assessment's pet handling pre-2.4; you couldn't merge or unmerge pets on the fly.
Either way, you can probably just post your modified file as an attachment in this thread. :)
Edit: Also, your image links don't work. I can't read what the page says, but there's no picture on it.
about retroactive - i can make like this :
DamageDone (merged) -> clik -> subset DamageDone (separate) -> click subset DamageDoneByAbilites.
PS. Remade Aura working, but working only in combat
maybe in the end of week remade Healing.
if profile.mergePetWithOwner then abilityNamePet = ("(%s) %s"):format(tostring(PetID), tostring(abilityName)) if sourceAffiliation >0 then UpdateDamageData(damageDealt, OwnerID, eventData, attackType, abilityNamePet) end end if not profile.mergePetWithOwner then if sourceAffiliation >0 then UpdateDamageData(damageDealt, sourceName, eventData, attackType, abilityName) end endif you want i can rewrite like this
I tried out both yesterday. I thought it was somewhat funny that you have dmg mostly he working, he only has damage taken working, he has healing mostly working from what I saw, and you don't. You guys should talk. ;)