Authors CurseForge

Playing with my warlock in BG:

[2008/07/27 03:27:13-5404-x1]: Heatsink\Heatsink.lua:911: table index is nil
Heatsink\Heatsink.lua:1072: in function `ScanSpells'
Heatsink\Heatsink.lua:897: in function `?'
CallbackHandler-1.0\CallbackHandler-1.0.lua:146: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:146>
<string>:"safecall Dispatcher[1]":4: in function <[string "safecall Dispatcher[1]"]:4>
<in C code>: ?
<string>:"safecall Dispatcher[1]":13: in function `?'
CallbackHandler-1.0\CallbackHandler-1.0.lua:91: in function `Fire'
AceEvent-3.0\AceEvent-3.0.lua:70: in function <Interface\AddOns\Ace3\AceEvent-3.0\AceEvent-3.0.lua:69>

Good catch, fixed in 79335.

[2008/08/01 14:01:05-5494-x3]: Heatsink\Heatsink.lua:911: table index is nilCallbackHandler-1.0\CallbackHandler-1.0.lua:146: in function <...Ons\Ace3\CallbackHandler-1.0\CallbackHandler-1.0.lua:146><string>:"safecall Dispatcher[1]":4: in function <[string "safecall Dispatcher[1]"]:4><in C code>: ?<string>:"safecall Dispatcher[1]":13: in function `?'CallbackHandler-1.0\CallbackHandler-1.0.lua:91: in function `Fire'AceEvent-3.0\AceEvent-3.0.lua:70: in function <Interface\AddOns\Ace3\AceEvent-3.0\AceEvent-3.0.lua:69>---

In BG with my warlock.

I posted this earlier, but bumping: would you mind assigning playerClass before the call to self:ScanSpells() in OnEnable? "Show school" option doesn't work in the current version, I've sent you a PM about a month ago but maybe you didn't see it.

There's another thing that needs fixing for this option to work properly: in Heatsink:SPELL_UPDATE_COOLDOWN() there's "schoolName" in a couple of places, however that should be "school".

A different problem is chained cooldowns not working, for example Cold Snap. There are 2 things needed to fix this in UNIT_SPELLCAST_SUCCEEDED():
- add another parameter so the function becomes Heatsink:UNIT_SPELLCAST_SUCCEEDED(event, unit, spellName)
- remove id and use "chainedSpellName" as argument to GetBar(): local bar = self.cooldown:GetBar(chainedSpellName)

Chained cooldowns work with those fixes.

And another bump for the paladin Turn Evil/Undead:

groupedCooldown:

	[spellname(2878)] = L["Turn"], -- 2878 Turn Undead
	[spellname(10326)] = L["Turn"], -- 10326 Turn Evil

I attached the fixed Heatsink.lua if it makes it easier.

Thanks in advance. :)

that's what i get for trying to clean up variable names.

Works great now, thanks!

I couldn't seem to get it to work on the PTR (3.02). Also, forgive me if I'm wrong, but can I filter the cooldowns in Heatsink (by ability)? I have many cooldowns that I don't care about enough to clutter up the screen and would like to specify exactly what to track (as a hunter, that is FD, shots/stings, traps and a few buffs and trinkets).

no, filtering means data collection, and data collection means garbage bloat in savedvariables. if you want filtering, try CDT2.

Quote from durcyn »

no, filtering means data collection, and data collection means garbage bloat in savedvariables. if you want filtering, try CDT2.

Lets be realistic here... CDT2 and RBM will do just fine... just not in WOTLK since they're not being supported anymore. And you're concerned about garbage bloat when I'm concerned about screen bloat. Yes, you're the boss, but I hope someone can make a Heatsink2 that just includes a list of which CD's to display. I'll trade some extra memory for more useful on-screen information anytime :-)

Nice addon, thanks for that.

One thing though: would it be able to group the Judgment of... cooldowns from a paladin into one simple "Judgment" cooldown bar? It's very quickly filling my screen space to have 3 bars for every single judgement I do ;)

Regarding the paladin spells post-3.0, here's a list of things that changed (probably not exhaustive):

* the "Bubble" grouped cooldown is not applicable anymore, Divine Shield and Divine Protection are on separate cooldowns now

* there are 3 Judgements as grouped cooldowns:

[spellname(53408)] = L["Judgement"], -- Judgement of Wisdom
[spellname(20271)] = L["Judgement"], -- Judgement of Light
[spellname(53407)] = L["Judgement"], -- Judgement of Justice

* Blessing of Protection/Freedom/Sacrifice and Judgement are gone and need to be removed from schoolGroups table. The new Hands to be added to schoolGroups are:

[spellname(10278)] = L["Holy"], -- 1022 Hand of Protection
[spellname(1044)] = L["Holy"], -- 1044 Hand of Freedom
[spellname(6940)] = L["Holy"], -- 6940 Hand of Sacrifice
[spellname(1038)] = L["Holy"], -- 1022 Hand of Salvation

I've changed the above and they're working fine, would be great if you can add those to Heatsink.

A trickier problem is that Holy Shock cooldown doesn't show. I suspect the reason why this happens is the non-standard tooltip text: post-3.0 it has a 20 yards range as a damage spell and 40 yards as a healing spell. The 2 ranges are shown on separate tooltip lines and this breaks the tooltip scanning with LibGratuity in ScanSpells:

if Gratuity:Find("cooldown", 2, 3, true) then

If the check above was extended to include an additional line, would that break any other class/spell?

Thanks in advance!

Any thought of making an option for one logarithmic bar to display cooldown icons, similar to Forte_Warlock?

There really needs to be an ace rewrite of that cooldown module, it's all I use from the package.

Committed: http://www.wowace.com/projects/heatsink/files/88-r103/

tagged, thanks

Hm... the updated version is not working at all. Can't access a menu with /heatsink, no cooldowns showing - nothing. The modified version from Mists works still though (only getting an error message at login)

Edit: Solved it. The Libs folder was missing. Copied it from the older Heatsink version. Working now ;)

make sure you grab the latest, I had to clean up some syntax errors in tomsommer's commit.

Aye, used R 3.0.3-3. Always checking the recently updated projects. R 3.0.3-3 didn't have the Libs included ;)

Will there be an update for the new Death Knight? So far it's a bit bugged, showing cooldowns with 0 seconds and for spells that I am not even specced for.

Shouldn't be happening - i only start bars for spells in the spellbook. Screenshot?