actually, as i understand it, skillet rescans on any CHAT_MSG_SKILL event (leveling or learning a new skill).
i think the problem is that the internal indices used to interface with the wow api become misaligned and aren't fixed on rescans.
for example, you queue up a tailor skill that has an api index of 15. that index will be fine until something tells the server to change -- new skill in the mix, a change to the server search filter, and maybe even a skill up (dunno how the default system deals with this, but i seem to recall that skills move around when they change color). so those old indices in the queue are now pointing to different skills.
i think there's other data that gets cached that also might not recognize when things have changed (particularly the search filter) and that'll lead to nils as well.
i'm curious what's up with nogudnik. he was very active up till about a month ago... we all know real life happens. not that i have tons of time, but i'd be happy to jump in and fix things but i don't really know the protocol for that kind of thing.
i'm curious what's up with nogudnik. he was very active up till about a month ago... we all know real life happens. not that i have tons of time, but i'd be happy to jump in and fix things but i don't really know the protocol for that kind of thing.
I'm wondering where nogudnik is at as well. I haven't seen him post since the holidays or so.
If I were you, lilsparky, I'd make the updates/changes on your copy of Skillet.
When nogudnik becomes more active, propose the changes you've made while he was gone.
The only thing though, I don't think you should distribute the changes you've made without the author's ok.
It may be nice to ask the author for approval for creating Skillet branch, but according to the GPLv3 used by Skillet you are already allowed to make and publish your changes ;-)
I personally like and use Skillet and I would like anyone to continue development even by branching the current work. My most missed feature is displaying count of created items (when one recipe create more items at once) and fixing the bugs: 1) The requirements are not always correct and sometimes there are leftovers displayed from previous recipe. 2) Right after the last Patch day the whole list was missing and sometimes instead of Skillet the Blizzard UI was displayed - after few ReloadUIs and recipe list rescans the issue was corrected...
The changes in the branch could get backported to the trunk by nogudnik if he sees the improvements.
well, i've had email exchanges with him in the past, so i fired one off to him just now.
i'll go ahead and start looking to things and how to fix them. he's been pretty open about collaboration, so i don't expect he'd get too protective of skillet unless he was planning on returning soon to address these issues himself.
how does one set up a branch and how do people then d/l that branch? would it then only be available via the svn (and not the normal files list)?
Well, you could also "branch" by creating a new addon and calling it "LilSkillet" or something like that. Then it'd appear in the files.wowace.com list and become downloadable by poor little me. ;)
well, i've had email exchanges with him in the past, so i fired one off to him just now.
i'll go ahead and start looking to things and how to fix them. he's been pretty open about collaboration, so i don't expect he'd get too protective of skillet unless he was planning on returning soon to address these issues himself.
how does one set up a branch and how do people then d/l that branch? would it then only be available via the svn (and not the normal files list)?
You're right lilsparky, he is pretty open about collaboration.
For the SVN, I have no clue. As the guys that runs the forum.
Well, you could also "branch" by creating a new addon and calling it "LilSkillet" or something like that. Then it'd appear in the files.wowace.com list and become downloadable by poor little me. ;)
Hehe, I don't think that would be the "branching" if you create a new addon. :)
First off, I'd like to apologise to everyone for not letting you know what was going on. I've not abandoned Skillet, but I've also not been able to free up much time to work on it in the last couple of months.
However, it looks like work is going to ease up a bit and I should finally be able to get back into Skillet. My first prorities will be to clean up as many bugs as I can and get a somewhat stable realease ready. After that I have to do some refactoring to the internals (ever wonder why the queue suddenly displays different receipes? bad data storage on my part). After that, there are a lot of feature requests to work on.
I've also talked to lilsparky and have let him know that I have no problems at all with him creating a branch of Skillet in the Subversion repository and merging changes down into the main branch of Skillet. Hopefullly, I'll be able to tackle enough bugs that he can focus on the fun stuff, but it is always nice to have another set of hand working on the code.
Please make it so that recipies that combine into more than one item are able to show the number of combines instead of number of resulting items in the brackets next to the recipe name and in the cast bar. The new change makes crafting things like bullets a real mess.
I do like that Skillet now shows on the icon how many items result from a single combine.
Please make it so that recipies that combine into more than one item are able to show the number of combines instead of number of resulting items in the brackets next to the recipe name and in the cast bar. The new change makes crafting things like bullets a real mess.
There was a bug (missing code actually) that never calculated the number of items produced from a single combine. So what you are seeing now is actually the intended behaviour. However, I can see how the change would make things a bit confusing. I'll put in a config option so that you can pick the behaviour you want to see.
Welcome back nogudnik and thanks for adding the number of created items to Skillet!
HunterZ requested that the numbers in brackets be the number of created items instead of number of possible runs of the recipe. I like the later (number of recipe runs) and I'd like to add a feature request to add the number of created items per one run next to the recipe name.
Example:
[5] Crafted Light Shot 200x [0/20/20] -- Using items in bank I can do 20 runs for 200 bullets each...
[5] Crude Scope [0/4/4] -- 1x is omitted
BTW: What is the "best" Inventory addon for use with Skillet? I'm using OneBag and related addons which comes with OneStorage, but this isn't supported by Skillet. Just because of Skillet I use Possessions :(
Would it be possible for the numbers of craftable items to change based on the current queue? I guess you could take the data of mats required (aka 'Shopping List') and subtract that from mats available to show the number craftable. This would help when trying to craft several different items that all use common mats.
Hi nogudnik and thank you for this very handy addon.
Quote from NavyFC »
Would it be possible for the numbers of craftable items to change based on the current queue? I guess you could take the data of mats required (aka 'Shopping List') and subtract that from mats available to show the number craftable. This would help when trying to craft several different items that all use common mats.
I'd very much like this feature requested by NavyFC as well. Seconded.
Welcome back nogudnik and thanks for adding the number of created items to Skillet!
HunterZ requested that the numbers in brackets be the number of created items instead of number of possible runs of the recipe. I like the later (number of recipe runs) and I'd like to add a feature request to add the number of created items per one run next to the recipe name.
You have it backwards. Right now (due to a recent change in Skiller) it says I can combine 800 Arcanite Shells on my Paladin Engineer. When I queue them up it starts counting down on the actionbar: 800...799...798...787...etc. This is bad!
I want to see that I have 4 combines' worth of mats both on the recipe display (e.g., "Arcanite Shells [4/4/4] instead of [800/800/800]), not 800 bullets' worth, and I'd like that to be reflected in the cast bar so that it counts down properly.
I still want to be able to see on the Arcanite Shells (for example) icon that one combine makes 200 shells. The left side in Skillet (and the number in the cast bar when combining) should reflect the number of combines, while the icon on the top-right should indicate the number of items resulting from one combine. Otherwise there are many problems:
- The user has to do a bunch of extra math to figure out how many actual combines can be queued in order to use a specific number of mats or specific number of combines (useful when leveling skills).
- There has to be enforcement of per-combine numbers to restrict the user from queuing, say, 199 bullets instead of 200.
- I'm pretty sure some items have a random range (like 1-3) of items that can result from a single combine. There's no way to account for this, and reverting to listing the number of combines instead of number of results would be inconsistent.
- Currently, if I decide to make 800 bullets, Quartz (my castbar addon) is told I am doing 800 combines instead of 4, and starts counting down 800...799...798...etc.
yeah, the standard tradeskill window puts a # in the icon indicated the number of items created with a single "run" of the tradeskill. like, netherweave nets make 2 nets at a time.
i could kind of see the point of saying "i want 10 netherweave nets" and then only queueing up 5 runs of nets, but i think that's overthinking things.
also note that there are some recipes that create multiple items that don't have the correct information returned from the api (like spellcloth w/ spellfire specialization) and crafting has no api call to handle this (small prismatic shards). i've asked over and over for these oversights to be corrected, but i've never gotten any traction on the issue.
BTW: What is the "best" Inventory addon for use with Skillet? I'm using OneBag and related addons which comes with OneStorage, but this isn't supported by Skillet. Just because of Skillet I use Possessions :(
I use http://www.wowace.com/wiki/BankItems and I absolutely love it for all my characters, and it's one of the addons that works with Skillet 100%.
BTW: What is the "best" Inventory addon for use with Skillet? I'm using OneBag and related addons which comes with OneStorage, but this isn't supported by Skillet. Just because of Skillet I use Possessions :(
i think the problem is that the internal indices used to interface with the wow api become misaligned and aren't fixed on rescans.
for example, you queue up a tailor skill that has an api index of 15. that index will be fine until something tells the server to change -- new skill in the mix, a change to the server search filter, and maybe even a skill up (dunno how the default system deals with this, but i seem to recall that skills move around when they change color). so those old indices in the queue are now pointing to different skills.
i think there's other data that gets cached that also might not recognize when things have changed (particularly the search filter) and that'll lead to nils as well.
i'm curious what's up with nogudnik. he was very active up till about a month ago... we all know real life happens. not that i have tons of time, but i'd be happy to jump in and fix things but i don't really know the protocol for that kind of thing.
I'm wondering where nogudnik is at as well. I haven't seen him post since the holidays or so.
If I were you, lilsparky, I'd make the updates/changes on your copy of Skillet.
When nogudnik becomes more active, propose the changes you've made while he was gone.
The only thing though, I don't think you should distribute the changes you've made without the author's ok.
I personally like and use Skillet and I would like anyone to continue development even by branching the current work. My most missed feature is displaying count of created items (when one recipe create more items at once) and fixing the bugs: 1) The requirements are not always correct and sometimes there are leftovers displayed from previous recipe. 2) Right after the last Patch day the whole list was missing and sometimes instead of Skillet the Blizzard UI was displayed - after few ReloadUIs and recipe list rescans the issue was corrected...
The changes in the branch could get backported to the trunk by nogudnik if he sees the improvements.
i'll go ahead and start looking to things and how to fix them. he's been pretty open about collaboration, so i don't expect he'd get too protective of skillet unless he was planning on returning soon to address these issues himself.
how does one set up a branch and how do people then d/l that branch? would it then only be available via the svn (and not the normal files list)?
Yes. :)
Branching (from the wiki)
You're right lilsparky, he is pretty open about collaboration.
For the SVN, I have no clue. As the guys that runs the forum.
Edit: It was replied to already.
Hehe, I don't think that would be the "branching" if you create a new addon. :)
It is an option, though.
However, it looks like work is going to ease up a bit and I should finally be able to get back into Skillet. My first prorities will be to clean up as many bugs as I can and get a somewhat stable realease ready. After that I have to do some refactoring to the internals (ever wonder why the queue suddenly displays different receipes? bad data storage on my part). After that, there are a lot of feature requests to work on.
I've also talked to lilsparky and have let him know that I have no problems at all with him creating a branch of Skillet in the Subversion repository and merging changes down into the main branch of Skillet. Hopefullly, I'll be able to tackle enough bugs that he can focus on the fun stuff, but it is always nice to have another set of hand working on the code.
I do like that Skillet now shows on the icon how many items result from a single combine.
There was a bug (missing code actually) that never calculated the number of items produced from a single combine. So what you are seeing now is actually the intended behaviour. However, I can see how the change would make things a bit confusing. I'll put in a config option so that you can pick the behaviour you want to see.
HunterZ requested that the numbers in brackets be the number of created items instead of number of possible runs of the recipe. I like the later (number of recipe runs) and I'd like to add a feature request to add the number of created items per one run next to the recipe name.
Example:
[5] Crafted Light Shot 200x [0/20/20] -- Using items in bank I can do 20 runs for 200 bullets each...
[5] Crude Scope [0/4/4] -- 1x is omitted
BTW: What is the "best" Inventory addon for use with Skillet? I'm using OneBag and related addons which comes with OneStorage, but this isn't supported by Skillet. Just because of Skillet I use Possessions :(
I'd very much like this feature requested by NavyFC as well. Seconded.
You have it backwards. Right now (due to a recent change in Skiller) it says I can combine 800 Arcanite Shells on my Paladin Engineer. When I queue them up it starts counting down on the actionbar: 800...799...798...787...etc. This is bad!
I want to see that I have 4 combines' worth of mats both on the recipe display (e.g., "Arcanite Shells [4/4/4] instead of [800/800/800]), not 800 bullets' worth, and I'd like that to be reflected in the cast bar so that it counts down properly.
I still want to be able to see on the Arcanite Shells (for example) icon that one combine makes 200 shells. The left side in Skillet (and the number in the cast bar when combining) should reflect the number of combines, while the icon on the top-right should indicate the number of items resulting from one combine. Otherwise there are many problems:
- The user has to do a bunch of extra math to figure out how many actual combines can be queued in order to use a specific number of mats or specific number of combines (useful when leveling skills).
- There has to be enforcement of per-combine numbers to restrict the user from queuing, say, 199 bullets instead of 200.
- I'm pretty sure some items have a random range (like 1-3) of items that can result from a single combine. There's no way to account for this, and reverting to listing the number of combines instead of number of results would be inconsistent.
- Currently, if I decide to make 800 bullets, Quartz (my castbar addon) is told I am doing 800 combines instead of 4, and starts counting down 800...799...798...etc.
I'm sorry but it's just a flawed idea.
i could kind of see the point of saying "i want 10 netherweave nets" and then only queueing up 5 runs of nets, but i think that's overthinking things.
also note that there are some recipes that create multiple items that don't have the correct information returned from the api (like spellcloth w/ spellfire specialization) and crafting has no api call to handle this (small prismatic shards). i've asked over and over for these oversights to be corrected, but i've never gotten any traction on the issue.
I use http://www.wowace.com/wiki/BankItems and I absolutely love it for all my characters, and it's one of the addons that works with Skillet 100%.
*cough* http://jira.wowace.com/browse/SKL-66 *cough*
As of a couple of minutes ago, you should be able to use OneBag+OneBank+OneView with Skillet. Let me know if you get any odd results :-)