Here is an attempt to make the DPS module shows optimistic DPS.
It consider combat duration being : min(now, time of last shot + 4sec) - time of first shot.
Btw, is there any plan to allow merging of pet data into master ones (at least at display) ?
Edit: attached a better calculation code. Now combat duration is [time of last hit - time of first hit ]. Combat is ended either by player_regen or after 4 seconds of inactivity. This allows to measure the burst DPS.
[2007/05/17 21:37:26-1021-x1]: Violation-1.0.35693\Violation.lua:1151: attempt to index upvalue 'db' (a nil value)
Violation-1.0.35693\Violation.lua:318: in function `func'
Dewdrop-2.0-35237 (DewdropLib):525: in function <...erface\AddOns\DewdropLib\Dewdrop-2.0\Dewdrop-2.0.lua:464>
[2007/05/17 21:37:26-1021-x1]: Violation-1.0.35693\Violation.lua:1151: attempt to index upvalue 'db' (a nil value)
Violation-1.0.35693\Violation.lua:318: in function `func'
Dewdrop-2.0-35237 (DewdropLib):525: in function <...erface\AddOns\DewdropLib\Dewdrop-2.0\Dewdrop-2.0.lua:464>
Is there a problem with dewdrop?? I can see in many Ace2 mods people are having problems with it...
Here is an attempt to make the DPS module shows optimistic DPS.
It consider combat duration being : min(now, time of last shot + 4sec) - time of first shot.
Btw, is there any plan to allow merging of pet data into master ones (at least at display) ?
Edit: attached a better calculation code. Now combat duration is [time of last hit - time of first hit ]. Combat is ended either by player_regen or after 4 seconds of inactivity. This allows to measure the burst DPS.
I've updated the DPS module with this. Just renamed EndedCombat to ResetDPSTimer since that's the correct name for that function, other than that left your code in tact since it looked ok.
Hi,
someone already mentioned this on the second page, I guess. A keybinding for reset would be great or a line command so I can create a makro. Is there already something like this?
Forgive me if this was asked before, but I'm curious if the functionality to change the font size and scale (width/height)aspects of the bars themselves is planned.
otherwise I've been testing this mod side-by-side with sw_stats. I see great potential in Violation, because while sw_Stats will track everything down to the ants eyelash, newer versions seem to be getting more and more memory intensive in raid situations.
With more control of the sizing aspects of violation and i'll put sw_stats on the back burner and use violation instead. and the planned ability to parse sw_stats would just be icing on the cake! :)
thanks for great work on a great mod so far, fellas.
I added a hit critical rate (or "critical hit rate", plz correct me) module to Violation. I'm unsure if DOTs could crit. Actually I assume they don't so the module ignores all DOTs. I'm planning to add a "critical heal rate" soon. The question is : can HOTs crit ?
Edit: Rophy answered those questions on IRC. Thank you. The module is doing it right.
Dot's and Hot's can not crit, the same counts for channelled spells (at least warlock and priest channeled spells, I am not sure about arcane missiles)
The only exeption are spells such as Immolate, moonfire, regrowth and fireball (there are probably more), which do damage (or heal) instantly and then also have a dot (or hot) effect after that. The instant effect can crit, but the dot can not.
Edit, damn, the questions were answered already, nerf IRC
Dot's and Hot's can not crit, the same counts for channelled spells (at least warlock and priest channeled spells, I am not sure about arcane missiles)
Has anyone else observed the damage done not matching DPS? I was in an instance run last night, and although our tank was tied for lowest level, actually tanking (sword and board and all), and although three people beat him in DPS, he was second in damage done (by a fair margin). I would attribute that to the others being out of combat more if I didn't already know that wasn't the case.
Has anyone else observed the damage done not matching DPS?
Yep, and that's not related to Violation. Some DD classes have short bursts of very high DPS while others have a lower but sustained DPS.
Edit : and remember that last version of DPS module only calculate individual burst DPS, not DPS over an entire fight of the whole party (though that could be an option).
What is Recount? Linking a zip file doesn't do much ><.
Yeah sorry there just isn't any wiki or anything for it just "Graphical Damage/healing Analyzer (Cryect)". Reminds me of Recap in some ways, giving additional data/stats. From my user view looks like they're both trying to accomplish similar goals.
Date: 2007-05-21 17:30:44
ID: 51
Error occured in: Global
Count: 1
Message: ..\AddOns\Violation\Violation.lua line 445:
attempt to call method 'WhisperDataToPlayer' (a nil value)
Debug:
[C]: WhisperDataToPlayer()
Violation\Violation.lua:445: editBoxFunc()
...erface\AddOns\DewdropLib\Dewdrop-2.0\Dewdrop-2.0.lua:2342:
...erface\AddOns\DewdropLib\Dewdrop-2.0\Dewdrop-2.0.lua:2328
Vioation is under dev, and code is in flux. If you had read the commit messages you'd have known this would happen.
-Ammo
My bad, sorry.
The idea of the add-on is great. The realisation atm lets me hope once it will be a very nice and handy mod i will gladly use.
What i would like to see is:
1) Possibility to get the menu by RMB on the window
2) Viewing Damage Done and DPS in a single info row
3) Replacement of the "Damage per Second" phrase in the tooltip to "DPS" as the whole phrase takes too much space
4) Viewing Healing Done, HPS and Overhealing in a single info row
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIt consider combat duration being : min(now, time of last shot + 4sec) - time of first shot.
Btw, is there any plan to allow merging of pet data into master ones (at least at display) ?
Edit: attached a better calculation code. Now combat duration is [time of last hit - time of first hit ]. Combat is ended either by player_regen or after 4 seconds of inactivity. This allows to measure the burst DPS.
Violation-1.0.35693\Violation.lua:318: in function `func'
Dewdrop-2.0-35237 (DewdropLib):525: in function <...erface\AddOns\DewdropLib\Dewdrop-2.0\Dewdrop-2.0.lua:464>
Is there a problem with dewdrop?? I can see in many Ace2 mods people are having problems with it...
I have Duece Commander. But I use Niagra....
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI've updated the DPS module with this. Just renamed EndedCombat to ResetDPSTimer since that's the correct name for that function, other than that left your code in tact since it looked ok.
-Ammo
someone already mentioned this on the second page, I guess. A keybinding for reset would be great or a line command so I can create a makro. Is there already something like this?
Thanks :)
otherwise I've been testing this mod side-by-side with sw_stats. I see great potential in Violation, because while sw_Stats will track everything down to the ants eyelash, newer versions seem to be getting more and more memory intensive in raid situations.
With more control of the sizing aspects of violation and i'll put sw_stats on the back burner and use violation instead. and the planned ability to parse sw_stats would just be icing on the cake! :)
thanks for great work on a great mod so far, fellas.
Ice
-
View User Profile
-
View Posts
-
Send Message
Forum Moderator-
View User Profile
-
View Posts
-
Send Message
Curse PremiumEdit: Rophy answered those questions on IRC. Thank you. The module is doing it right.
The only exeption are spells such as Immolate, moonfire, regrowth and fireball (there are probably more), which do damage (or heal) instantly and then also have a dot (or hot) effect after that. The instant effect can crit, but the dot can not.
Edit, damn, the questions were answered already, nerf IRC
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumVioation is under dev, and code is in flux. If you had read the commit messages you'd have known this would happen.
-Ammo
Arcane missiles can crit :) .
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumYep, and that's not related to Violation. Some DD classes have short bursts of very high DPS while others have a lower but sustained DPS.
Edit : and remember that last version of DPS module only calculate individual burst DPS, not DPS over an entire fight of the whole party (though that could be an option).
What is Recount? Linking a zip file doesn't do much ><.
Yeah sorry there just isn't any wiki or anything for it just "Graphical Damage/healing Analyzer (Cryect)". Reminds me of Recap in some ways, giving additional data/stats. From my user view looks like they're both trying to accomplish similar goals.
My bad, sorry.
The idea of the add-on is great. The realisation atm lets me hope once it will be a very nice and handy mod i will gladly use.
What i would like to see is:
1) Possibility to get the menu by RMB on the window
2) Viewing Damage Done and DPS in a single info row
3) Replacement of the "Damage per Second" phrase in the tooltip to "DPS" as the whole phrase takes too much space
4) Viewing Healing Done, HPS and Overhealing in a single info row