I've gone back through the post 2.4 posts, but haven't seen anything regarding the decurse meter. Did 2.4 break this and are there any plans to fix the decurse meter?
Search didn't bring up a post; Is there any way of adding percentages back into the tooltip again? Total damage is niiiice, but I prefer using %'s so to see who is useless and who is overpowered.
Just started using Violation and love it... However, it's not merging my pet damage together... I've verified it's checked... and have unchecked/rechecked it...
Just started using Violation and love it... However, it's not merging my pet damage together... I've verified it's checked... and have unchecked/rechecked it...
Any idea? :P
It will start merging when you're grouped/in a raid, sometimes it isn't merging when solo. Strange i know.
No addons can save changes or data given to it since you've started the game if you get DC'ed. Saved variables files aren't written to when you get DC'ed.
That's strange, i've made changes to addons when i'm online just before i DC'ed and when i login, those changes are not reset. It doesn't reset when i ALT-F4 out of the game either, only time settings resets is when i shut down the process or have to do a hard reboot.
There's also a slight delay when you get a DC, just when you logout or exit the game normally.
I'm encountering a bug with violation and pets, namely water elementals. Whenever I'm in a 25 man raid with another frost mage, pet merging seems to be working correctly (but can I get confirmation that water elemental damage isn't being double-counted for both mages when pets are merged?). If during the same game session, but a completely different raid or 5 man, I use my water elemental, I'll see the other mage's name as a meter in damage done, even though they're not there. The damage seems to be added to me, and then by itself for the nonpresent mage. Same thing happens with priest shadowfiends. Violation is set to reset every time I enter combat. I tried out some alternative meters, and I can't stand them in comparison to this one, hope this can be fixed.
I changed Violation to use unit GUIDs internally now, so the pet issues should be solved. I didn't get a chance to test it in a raid, group or with an *actual* pet yet. But theoretically it should work I think :P
I changed Violation to use unit GUIDs internally now, so the pet issues should be solved. I didn't get a chance to test it in a raid, group or with an *actual* pet yet. But theoretically it should work I think :P
I fixed some minor error to have it working a little better, though it is still bugged :
When you dismiss your pet / your pet die and then you revive / recall it, the pet gets assigned a new GUID. Violation gets very confused and stop recording data for the new pet instance.
Having a method Violation:CraftGUID(guid, flags) that works this way :
- if the unit is a pet, mangle the pet GUID to get rid of the serial number and append the owner GUID to prevent collision if the same kind of pet have the same GUID prefix (warlock pets), return the crafted GUID,
- else if the unit is strictly "MINE", return the player GUID (this should catch non-pet things, like trap snakes),
- else, return the given GUID.
That's not simple and will not handle well non-pet things of other players.
Since Violation_CombatLogRange is not needed anymore, could you please add a tiny feature from it to Violation:
Automaticly toggle /combatlog everytime you enter/leave an instance
Ta,
Any idea? :P
It will start merging when you're grouped/in a raid, sometimes it isn't merging when solo. Strange i know.
Is it possible to have Violation not auto-reset collected data after a /reloadui?
Not possible atm, also it resets data when you get a DC. Possibly to add an option to save it though, but it's all up to the author(s).
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumNo addons can save changes or data given to it since you've started the game if you get DC'ed. Saved variables files aren't written to when you get DC'ed.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumA disconnect (DC) doesn't save anything, because it's impossible. Just like Seerah said.
There's also a slight delay when you get a DC, just when you logout or exit the game normally.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI fixed some minor error to have it working a little better, though it is still bugged :
When you dismiss your pet / your pet die and then you revive / recall it, the pet gets assigned a new GUID. Violation gets very confused and stop recording data for the new pet instance.
Sample characterPets tables :
Before:
{ ["0xF5402F7B34000071"] = "0x000000000003133C" }
I dismiss then recall my pet.
After:
{ --[[ table: 10E23438 ]]
["0xF5402F7B34000071"] = "0x000000000003133C",
["0xF5402F7B34000093"] = "0x000000000003133C"
} --[[ table: 10E23438 ]]
And finally, damages from trap snakes are ignored. They are not technically pets so they could be accounted for the player.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumIf you want to fix it then go ahead.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumHaving a method Violation:CraftGUID(guid, flags) that works this way :
- if the unit is a pet, mangle the pet GUID to get rid of the serial number and append the owner GUID to prevent collision if the same kind of pet have the same GUID prefix (warlock pets), return the crafted GUID,
- else if the unit is strictly "MINE", return the player GUID (this should catch non-pet things, like trap snakes),
- else, return the given GUID.
That's not simple and will not handle well non-pet things of other players.
-
View User Profile
-
View Posts
-
Send Message
Curse Premium-
View User Profile
-
View Posts
-
Send Message
Forum Moderatoron zoning
Automaticly toggle /combatlog everytime you enter/leave an instance