Request: make the filter work negatively, not positively.
I would like to disable ALL gains except for those that I specifically enter into the filter. I think setting things up this way would solve the spam problem that seems to be annoying so many people.
Also, would it be possible to enable "begins to cast" when out of combat only? I find other notifications useful in combat, but "begins to cast" is definitely only needed OOC.
can you add back in an Option for npc Emotes? I have relied on those for so long, in so many quests (wrangling rays) and boss fights (lurker, hydross, so many more) that I already miss it after only a day :D
can you add back in an Option for npc Emotes? I have relied on those for so long, in so many quests (wrangling rays) and boss fights (lurker, hydross, so many more) that I already miss it after only a day :D
thanks :)
Seconded! Sorely missed. In fact, going the extra mile and including creature say/yell/whisper as well as emote would be freakin' awesome. *encouraging, hopeful look*
local function giveFilter()
filter = {
name = L["Spell Filter"],
type = "group",
args = {
filterdesc = {
order = 0,
type = "description",
name = L["You can select spells to be ignored in future messages from the list below. This list is automatically filled with currently filtered spells and spells you encountered during this session."],
},
filters = {
order = 1, type = "group", name = "", inline = true,
get = function( k ) return db.filtered[k.arg] end,
set = function( k, v ) db.filtered[k.arg] = v and v or nil end, -- do not set to false, we cleanup this way since nil values are actually removed
args = {},
},
},
}
-- make sure we learn all filtered spells.
for k, v in pairs(db.filtered) do
learned[k] = true
end
-- fill filter args
filterArgs = filter.args.filters.args
for k, v in pairs( learned ) do
giveOneFilter(k)
end
return filter
end
Each time the giveFilter() is called back the filter.args.filters.args is cleaned and refilled by giveOneFilter() iterations that recreate a piece of table.
Since table creation is rather expensive I feel that the display/refresh/toggle of "Spell Filter" page
become significantly slow after the filter size grows upto, say, 300 entries.
Actually it isnt that slow but one can feel the WOW screen "frozen" for 1+ sec.
Feature Request:
The way I use the Learning Mode + Spell Filter is about to trying hard to find out
some "unchecked" spells in the list consisting of mostly "checked" spells.
It's a bit tiring when the list grows big, so what I request is to make this process easier.
My suggestion is to make those newly "learned" spells in this session on the top of list;
in other words the primary sorting key is "session" and secondary sorting key is "spellID".
Each time the giveFilter() is called back the filter.args.filters.args is cleaned and refilled by giveOneFilter() iterations that recreate a piece of table.
Since table creation is rather expensive I feel that the display/refresh/toggle of "Spell Filter" page
become significantly slow after the filter size grows upto, say, 300 entries.
Actually it isnt that slow but one can feel the WOW screen "frozen" for 1+ sec.
Wrong. that function is only called once. The problem is AceGUI has to render 300 checkboxes and labels etc.
grr i had to disable addon.. seeing such spam in center of my screen is not good.. anyway didnt came out how to pull out any setting screen for wh.
Please use another addon.
I'm open for good suggestions on how to fix it all etc, if this is the only type of message you want to leave as a comment, find another place to be pathetic.
Couple of suggestions for it would be to have it come preset with "pvp" and "Player" spells that would be commonly desired for seeing in the output.
Another thing perhaps I am dumb, but would it be a good idea to color code the actual types of spells being cast too. all heals one color, holy damage, shadow damage, control spells.
Just some thoughts :)
Quote from yacoob »
I mean "Enemy players only" :)
Glad to see that option as "is coming" :)
Keep it good work, Thanks :)
Couple of suggestions for it would be to have it come preset with "pvp" and "Player" spells that would be commonly desired for seeing in the output.
Another thing perhaps I am dumb, but would it be a good idea to color code the actual types of spells being cast too. all heals one color, holy damage, shadow damage, control spells.
Just some thoughts :)
I could probably color by spellschool/type. I'll add it to a featurerequest list.
If this addon requires the Sink library, could you please mark it as such so that WowAceUpdater will automatically download it as a dependency? That might be why WH isn't working for me.
If this addon requires the Sink library, could you please mark it as such so that WowAceUpdater will automatically download it as a dependency? That might be why WH isn't working for me.
I would like to disable ALL gains except for those that I specifically enter into the filter. I think setting things up this way would solve the spam problem that seems to be annoying so many people.
Also, would it be possible to enable "begins to cast" when out of combat only? I find other notifications useful in combat, but "begins to cast" is definitely only needed OOC.
thanks :)
Try /ace3 ;) The config window will have the Witchhunt Modules as option.
or esc > interface options > addons > witchhunt
Seconded! Sorely missed. In fact, going the extra mile and including creature say/yell/whisper as well as emote would be freakin' awesome. *encouraging, hopeful look*
local function giveFilter() filter = { name = L["Spell Filter"], type = "group", args = { filterdesc = { order = 0, type = "description", name = L["You can select spells to be ignored in future messages from the list below. This list is automatically filled with currently filtered spells and spells you encountered during this session."], }, filters = { order = 1, type = "group", name = "", inline = true, get = function( k ) return db.filtered[k.arg] end, set = function( k, v ) db.filtered[k.arg] = v and v or nil end, -- do not set to false, we cleanup this way since nil values are actually removed args = {}, }, }, } -- make sure we learn all filtered spells. for k, v in pairs(db.filtered) do learned[k] = true end -- fill filter args filterArgs = filter.args.filters.args for k, v in pairs( learned ) do giveOneFilter(k) end return filter endEach time the giveFilter() is called back the filter.args.filters.args is cleaned and refilled by giveOneFilter() iterations that recreate a piece of table.
Since table creation is rather expensive I feel that the display/refresh/toggle of "Spell Filter" page
become significantly slow after the filter size grows upto, say, 300 entries.
Actually it isnt that slow but one can feel the WOW screen "frozen" for 1+ sec.
The way I use the Learning Mode + Spell Filter is about to trying hard to find out
some "unchecked" spells in the list consisting of mostly "checked" spells.
It's a bit tiring when the list grows big, so what I request is to make this process easier.
My suggestion is to make those newly "learned" spells in this session on the top of list;
in other words the primary sorting key is "session" and secondary sorting key is "spellID".
Wrong. that function is only called once. The problem is AceGUI has to render 300 checkboxes and labels etc.
-Ammo
Please use another addon.
I'm open for good suggestions on how to fix it all etc, if this is the only type of message you want to leave as a comment, find another place to be pathetic.
-Ammo
any chance for WH, to get "show only enemy" option? ;)
Having screen flooded by text its not what we like most ;)
You can set it to target only.
Or do you mean enemy players only (that options is coming)
-Ammo
Glad to see that option as "is coming" :)
Keep it good work, Thanks :)
Couple of suggestions for it would be to have it come preset with "pvp" and "Player" spells that would be commonly desired for seeing in the output.
Another thing perhaps I am dumb, but would it be a good idea to color code the actual types of spells being cast too. all heals one color, holy damage, shadow damage, control spells.
Just some thoughts :)
I could probably color by spellschool/type. I'll add it to a featurerequest list.
-Ammo
Download it from the files page.
The .toc states the dependancy just fine:
## OptionalDeps: Ace3, LibSink-2.0
-Ammo
## X-Embeds: Ace3, LibSink-2.0
(But don't remove the line you had because that's required by WoW's LUA code. Which of course you know. =P)
You can also include this:
## X-AceForum: 1654
And that'll include the link to this thread.
Also, it doesn't really seem to be an Optional dependency. The addon doesn't run without it. But that doesn't really affect anything of course.
I'm done jumping through hoops for WAU.
-Ammo