Authors CurseForge

Thanks, I did miss StatLogicLib - maybe this should be added as embed? Or at least as dependency?

Also, it's still not quite working for me, I'm getting the following error now when mouse-overing an item after setting up a set for Auto Shot (according to the DrDamage maintainer, this is due to changes in DrDamage that ItemValue has to adjust to):

Date: 2008-04-04 17:07:02
ID: 52
Error occured in: Global
Count: 1
Message: ..\AddOns\DrDamage\Melee.lua line 707:
attempt to index field '?' (a nil value)
Debug:
[C]: ?
DrDamage\Melee.lua:707: MeleeCalc()
ItemValue_DrDamage\MeleeSet.lua:234: CalcValues()
ItemValue_DrDamage\MeleeSet.lua:195: UpdateValues()
ItemValue_DrDamage\MeleeSet.lua:170:
ItemValue_DrDamage\MeleeSet.lua:167
(tail call): ?
ItemValue\ItemValue.lua:1643: GetTooltipText()
ItemValue\ItemValue.lua:1584: handler()
...ddOns\ItemValue\Libs\TipHooker-1.0\TipHooker-1.0.lua:193:
...ddOns\ItemValue\Libs\TipHooker-1.0\TipHooker-1.0.lua:187
[C]: SetInventoryItem()
EQCompare\EQCompare.lua:307:
EQCompare\EQCompare.lua:261
(tail call): ?
Skinner\UIElements1.lua:29:
Skinner\UIElements1.lua:27
(tail call): ?
[C]: ?
[C]: pcall()
Stubby\Stubby.lua:340:
Stubby\Stubby.lua:324
(tail call): ?
[C]: SetBagItem()
TBag\TBag.lua:2016: TBag_SetInventoryItem()
TBag\TInv.lua:477: TInv_ItemButton_OnEnter()
[string "*:OnEnter"]:1:
[string "*:OnEnter"]:1

Quote from Niightblade »

Now when I make a new DrDamageSet and enter "Fireball" as the spell and "13" as the rank I get this error message:

..\AddOns\ItemValue_DrDamage\CasterSet.lua line 266:
 attempt to call method 'GetSpellInfo' (a nil value)

I'm getting this as well, occurs on any mouseover of items etc and blocks other tooltip mods from working.

One feature i thought might be of interest was to have a TankPoints plugin as well as DrDamage, then we only need a 'HealPoints' mod and we'll have all of the calculations done for us, also plllllease add a /iv bi feature and itemquality/source filtering if possible, would be nice to be able to filter blues for alts, pvp gear or instance :)

ItemValue_DrDamage should be working again, now (thanks Nayala).
StatLogicLib is currently needed but not listed as a Dependency or Embedded, I'll be fixed soon, after looking into LibItemBonus-2.0 and if I could just use StatLogicLib to do the Item scanning.

Quote from Thexod »

ItemValue_DrDamage should be working again, now (thanks Nayala).
StatLogicLib is currently needed but not listed as a Dependency or Embedded, I'll be fixed soon, after looking into LibItemBonus-2.0 and if I could just use StatLogicLib to do the Item scanning.

ItemValue_DrDamage still doesn't work for me. Now I get the following error:

[2008/04/13 08:08:33-3941-x1]: DrDamage-1.4.0\Caster.lua:904: attempt to index upvalue 'spellInfo' (a nil value)
ItemBonusLib-1.0-67662:494: in function <...s\ItemBonusLib\ItemBonusLib-1.0\ItemBonusLib-1.0.lua:494>
<in C code>: ?
AceEvent-2.0-66043 (Ace2):368: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:345>

---

It seems ItemValue is calling into DrDamage while DrDamage is still not fully initialized.

Ok so I've finally gotten the DrDamge plugin working (woot). However, I expeced to see the actual dps difference, not an arbitrary "score". Is this possible? (I can do it manually.)

Is there a way to display non-numerical values in the formula?
Lets say I want to see intellect and agility on an item separately but not their individual sums.
I know this can be achieved through 2 lines in the tool tip, but I'm trying to have it one.

For instance

The 1 Ring
Binds when equipped
Finger
+1 Strength
+1 Agility
+1 Stamina
+1 Intellect
+1 Spirit
Requires Level 10
"Not quite as good as the 2 Ring"

AGI+INT---------------1+1

The formal would display 1+1 or 1,1 or 1<space>1

Anything so that I can distinguish the two stats but on one line.

Quote from Garfi »

Message: ..\AddOns\DrDamage\Melee.lua line 707:
attempt to index field '?' (a nil value)

Had a look at this myself as it hasn't been fixed, i'm not a master coder but i have a temp fix that gets melee working again, edit line 235 in meleeset.lua to read this

TempSpellData = select(2, DrDamage:MeleeCalc(Spell, #DrDamage.spellInfo[Spell], true, true))

I'm sure that is a messy way of getting it working so feel free to /slap me for it^

is this mod still maintained ?
Since last patch the tooltip text is missing on many items for me :<

Will the AddOn be rejuvenated in WotLK? Is Thexod even still playing/coding?

I tried Pawn, and it's very nice and all, but it lacks the gem-magic ItemValue has.

Is there maybe a "better" ItemValue-like addon than Pawn?

Quote from tjista

Will the AddOn be rejuvenated in WotLK? Is Thexod even still playing/coding?

I tried Pawn, and it's very nice and all, but it lacks the gem-magic ItemValue has.

Is there maybe a "better" ItemValue-like addon than Pawn?

Also interested in this answer

I put up some clones of ItemValue and ItemValue_DrDamage that use LibItemBonus-2.0 and should handle the new spell power stuff correctly. (Not sure if healing might need a 1.88 multiplier though.) Thexod if you are still around feel free to merge whatever you want from my changes back in to the mainline.

• ItemValue with my changes
• ItemValue_DrDamage with my changes

Changes:

• Uses LibDataBroker-1.1 instead of FuBarPLugin-2.0
• Uses LibItemBonus-2.0 instead of ItemBonusLib-1.0
• Fixed some embeds.
• Fixed Spell damage / Healing => Spell power
• Fixed Spell hit, crit and haste to use the new unified hit, crit and haste.

Thx for your help :-)

Hello Nayala,
I have one error when i use you version
2008/11/06 00:36:37-16-x1]: ItemValue-r104\Libs\LibItemBonus-2.0\core.lua:1034: attempt to index upvalue 'L' (a nil value)
AceAddon-2.0-91091 (AllPlayed):983: in function <...\AddOns\AllPlayed\libs\AceAddon-2.0\AceAddon-2.0.lua:976>
<in C code>: ?
AceEvent-2.0-91091 (AllPlayed):260: in function `TriggerEvent'
AceEvent-2.0-91091 (AllPlayed):910: in function <...\AddOns\AllPlayed\libs\AceEvent-2.0\AceEvent-2.0.lua:903>
---
But when I turned off AllPlayed, I had another
[2008/11/06 00:46:38-18-x1]: ItemValue-r104\Libs\LibItemBonus-2.0\core.lua:1034: attempt to index upvalue 'L' (a nil value)
AceAddon-2.0-91091 (Automaton):983: in function <...\AddOns\Automaton\Libs\AceAddon-2.0\AceAddon-2.0.lua:976>
<in C code>: ?
AceEvent-2.0-91091 (Automaton):260: in function `TriggerEvent'
AceEvent-2.0-91091 (Automaton):910: in function <...\AddOns\Automaton\Libs\AceEvent-2.0\AceEvent-2.0.lua:903>

And when I turned off Automaton, I had another
008/11/06 00:49:13-19-x1]: ItemValue-r104\Libs\LibItemBonus-2.0\core.lua:1034: attempt to index upvalue 'L' (a nil value)
AceAddon-2.0-91091 (BigWigs):983: in function <...ce\AddOns\BigWigs\Libs\AceAddon-2.0\AceAddon-2.0.lua:976>
<in C code>: ?
AceEvent-2.0-91091 (BigWigs):260: in function `TriggerEvent'
AceEvent-2.0-91091 (BigWigs):910: in function <...ce\AddOns\BigWigs\Libs\AceEvent-2.0\AceEvent-2.0.lua:903>

I had the same error with AtlasLootFu but i forgot to copy the error :-)

Thanks, I think I know what's causing the error, forgotten I had fixed my copy of LibItemBonus-2.0 to work around it.

Should be fixed in r105.

Edit: Looks like the packager hasn't picked it up yet.
Edit 2: Packager is running again. The changes for r105 are in r106.

Let me know if that doesn't fix the errors.

The error is fixed. thx :)

I still have a problem but I don't know if it has already worked with a French client.
I prefer how to SmartFitter worked with gems but it wasn't perfect. Meta didn't work or not fully implemented. The tooltip did not tell the gem's color to use for the best value (use or don't use socket bonnus).



[2008/11/12 16:49:09-88-x1]: ItemValue-r106\ItemValue.lua:1249: attempt to index local 'BestJewelCombination' (a nil value)
ItemValue-r106\ItemValue.lua:133: in function `set'
AceConsole-2.0-91091 (Automaton):1752: in function <...Ons\Automaton\Libs\AceConsole-2.0\AceConsole-2.0.lua:1564>
AceConsole-2.0-91091 (Automaton):2402: in function `?'
Interface\FrameXML\ChatFrame.lua:3191: in function `ChatEdit_ParseText':
Interface\FrameXML\ChatFrame.lua:2911: in function `ChatEdit_SendText':
Interface\FrameXML\ChatFrame.lua:2932: in function `ChatEdit_OnEnterPressed':
<string>:"*:OnEnterPressed":1: in function <[string "*:OnEnterPressed"]:1>

---

I should really try reading the thread to see if my question is answered already.

But a new one! Are any of the WoWAce alphas pushed to Curse yet?

Edit again. How exactly does the Dr. Damage import feature work?

I can't get your embedded version of itemvalue to work...

As soon as I put in your version of ItemValue, massive explosion.. 32 errors in bugsack from a variety of addons..

Can I run your branch Disembedded? or something?