v1.3 Added right-click menu options to skip certain buff checks (Shadow Protection, Food, Weapon)
Added checks for 2.4 weapon coatings
Updated checks for Shattrath flasks
v1.2 Localization support
v1.1 Now with oRA2 and CT_RA integration!
v1.0 Initial release
I've updated my buff checking module (MoBuffs) to use Peragor's talent lib, and it seems to work well. I'll be uploading it to the SVN shortly. Yes, it's yet another buff checking module, but this is one that I've been working on since TBC came out. It's heavily heuristic based -- and absolutely zero config (you have enough to manage with raids already). I've looked at other buff checkers and they were all either too complicated, required everyone to have it installed, or simply incomplete.
Here's a *partial* list of the things it checks:
-- If player in not same zone as you, assume they are not active in raid (wait list, alt, etc.) and therefore not a source of buffs.
-- If the raid has a warlock, at least one person should be soulstoned.
-- Warn if more than one raid member has soulstone.
-- If the raid has a mage, everyone (with mana bar) should have arcane int/bril.
-- If the raid has a druid, everyone should have mark/gift of the wild.
-- If the raid has a priest, everyone should have fortitude.
-- If the raid has a priest, everyone should have shadow protection.
-- If the raid has a priest with 21 points in Discipline, then everyone (with mana bar) should have divine spirit.
-- If the raid has a paladin, everyone should have one blessing (not picky on which) per paladin in raid.
-- If the party has a paladin, everyone should have one aura (not picky which, except crusader) per paladin in party.
-- No player should have shadow resist aura if priest in raid.
-- No player should have crusader aura.
-- If the party has a hunter (with 31 marksmanship), everyone in party should have trueshot aura.
-- If player is hunter, should have an aspect up (not picky which - except beast/pack).
-- No player should have Aspect of the Beast or Aspect of the Pack.
-- If player is hunter, should have pet out (not picky which).
-- If player is mage, should have armor up (not picky which - mana, frost, ice, etc.)
-- If player is warlock, should have armor up (not picky which - fel, demon, etc.)
-- If player is warlock, should have pet out (not picky which).
-- If player is priest, should have Inner Fire up.
-- If player is does not have mana bar, should not have Blessing of Wisdom.
-- If player is Priest, Mage, or Lock, and there are less than 4 paladins in raid, he should not have Blessing of Might.
-- If player marked as 'maintank' through UI, assume player is a TANK.
-- If player marked as tank through oRA2 or CT_RA interface, assume player is a TANK.
-- If player is in "defensive stace", or in "bear form", or has "righteous fury", assume player is a TANK.
-- If player is TANK, should not have Blessing Of Salvation.
-- If player is TANK, and raid has a druid, he should have thorns (careful, this can break CC).
-- If player is TANK, and player is a paladin, should have righteous fury.
-- Everyone should have a battle and guardian elixir -or flask- up (not picky which).
-- Everyone should have a food buff up (not picky which).
-- Everyone should have a weapon buff (not picky which) like oil or sharpening stone.
Like I said, this is heuristic based, meaning it uses simple rules of thumb. They will not apply to every situation so a raid leader should use his head. This is just a tool to give you a heads up when something is probably missing.
It's also useful to see who's putting forth the effort (with buffs, pots, etc.) and who's slacking.
Just one tiny idea, following this thread. How about putting the logic into a library allowing to query missing Buffs, Potions, Food, ect. on a certain player. Thus other addons could use it too, such as BigBrother (might be wrong here, never used it >_>) or an addon (still to be writen ^^) only querying yourself.
Like the look of this, will hopefully give it a test out later assuming that I remember to download it before logging in :)
Is it possible for perhaps the following (apologies if it can already do this):
1/ Disable/Enable specific buff checks (eg shad prot isnt needed all the time, same with flasks etc
I really wanted it to be zero-config. There are a lot of buffs that are situational, like shadow protection, etc. even "Aspect of the Cheetah" -- ie. hunter speedy legs -- is useful in some raid circumstances. That's why I pointed out the raid leader (and the player) have to use their heads to interpret the output.
Quote from Hack »
2/ Option to output a brief list to chat somewhere (eg guild, raid, officer or whisper)
I understand if you do not wish to add eiter of the above as you are keeping it minimal and config free..
Will try later tonight if I recall and let you know how it does (only doing a 10man raid tonight but better than nowt eh :) )
You can already click on the player's name in the list to send them a whisper. I'll consider adding options to send it to raid, officer, as well.
Looks good. The only suggestion I have is to make the tooltip a bit cleaner... abbreviate / colorize / add more space between buff names. Currently a long list of yellow text requires a lot of "processing time". Colors, or more spacing, would make it easier to see "at a glance".
I agree, it can be a little overwhelming. Thanks for the suggestions. I've been working on improving that. I've been playing with alternate display types, like listing buffs on the left, with a list of players missing that buff on the right.
In most raiding situations, however, with most buffers "doing their jobs", the display gets amazingly short. For us, missing buffs tend to be the exception, and this just lets me catch them (ie. doing a quick sanity check before boss pull.) If you're consistently seeing long lists of missing buffs on lots of people, then I doubt any buff monitoring mod is going to help much :)
I stumbled onto your mod here and I love it. The only issue I have is that as a druid I apply my weightstone and yet the mod still says I am missing a temporary weapon buff. Am I missing something?
I stumbled onto your mod here and I love it. The only issue I have is that as a druid I apply my weightstone and yet the mod still says I am missing a temporary weapon buff. Am I missing something?
No, it should recognize all temporary weapon buffs. Here's the current list:
-- (Lesser|Greater) Ward of Shielding
-- Sharpened (+\d+ Damage)
-- Weighted (+\d+ Damage)
-- Anesthetic Poison
-- Deadly Poison [IVX]*
-- Crippling Poison [IVX]*
-- Wound Poison [IVX]*
-- Instant Poison [IVX]*
-- Mind-numbing Poison [IVX]*
-- (Minor|Superior|Brillant|Blessed) (Mana|Wizard) Oil
-- Wizard Oil
-- Frost Oil
-- Shadow Oil
Do you know which weightstone you were using?
One possibility is that currently +damage temporary weapon enchants don't affect you while you are in feral form. This is being changed in patch 2.4. I'll check to see if this is affecting my code.
You may have noticed that I removed the libraries that you had checked in as direct copies on the SVN. That's not the correct way of using the SVN, so they had to go. I also added them as externals instead. But you may want to check that things are working as expected - especially when using updaters such as WAU. Some adjustments of the TOC and/or the embeds.xml files may be needed too.
You may have noticed that I removed the libraries that you had checked in as direct copies on the SVN. That's not the correct way of using the SVN, so they had to go. I also added them as externals instead. But you may want to check that things are working as expected - especially when using updaters such as WAU. Some adjustments of the TOC and/or the embeds.xml files may be needed too.
Thanks! I'll double check everything. Sorry for the confusion.
You may have noticed that I removed the libraries that you had checked in as direct copies on the SVN. That's not the correct way of using the SVN, so they had to go. I also added them as externals instead. But you may want to check that things are working as expected - especially when using updaters such as WAU. Some adjustments of the TOC and/or the embeds.xml files may be needed too.
Okay, there are few libs broken now. An example is Tablet-2.0. How do I add it as an external with the Totoise SVN client?
Right click the folder, go to Properties, hit the Tortoise tab (might be SVN tab) click the properties button there and a new window pops up. If you've updated your local copy there should be an entry that says svn:externals, click on that then click edit.
I stumbled onto your mod here and I love it. The only issue I have is that as a druid I apply my weightstone and yet the mod still says I am missing a temporary weapon buff. Am I missing something?
This should be fixed now. I had a bug in my regex matching string.
The latest version in SVN also has preliminary oRA2/CT_RA integration for determining who's a tank.
-- If player is warlock, should have pet out (not picky which).
This isn't always true - if the warlock has the Demonic Sacrifice talent, they may not want to have a pet out because they have one of the sacrifice buffs up. Just as a suggestion to improve the heuristic, perhaps you can make sure they have a pet *or* have one of the following buffs: Burning Wish, Fel Stamina, Touch of Shadow, Fel Energy.
This isn't always true - if the warlock has the Demonic Sacrifice talent, they may not want to have a pet out because they have one of the sacrifice buffs up. Just as a suggestion to improve the heuristic, perhaps you can make sure they have a pet *or* have one of the following buffs: Burning Wish, Fel Stamina, Touch of Shadow, Fel Energy.
This is probably my favorite implementation of simple raid buff checking among the overflow of buff checking mods on the SVN right now. A quick look in FuBar to see who isn't buffing, instead of having to type out commands/open up Waterfall or embarass people in party/raid/officer chat.
It has a problem though. Yes...it eats CPU time ;). It does so when you are idle and either solo or in a party/raid, which it shouldn't be doing. It may be the LibTalentQuery-1.0 library doing it, which the only required library for it that I have embedded; every other library I have standalone. Or it may be the mod. Regardless, it would be great if you could cut or eliminate the usage.
When idle, either in a raid or solo, it continually eats 0.105 CPU/sec median (measured with OptionHouse). Not total CPU, but ongoing consumption. RaidBuffStatus and FuBar_RaidBuffFu (the other two buff checkers I've recently installed) use 0 CPU when idle.
Its likely scanning for everyone's buffs all the time, in order to keep the results text updated (as you need to do nothing to see updated results). This is really not needed and may be why its eating CPU when idle. Change it to do a buff check only when you click the FuBar icon (or similar)? Or something else that will cut the idle usage.
This is probably my favorite implementation of simple raid buff checking among the overflow of buff checking mods on the SVN right now. A quick look in FuBar to see who isn't buffing, instead of having to type out commands/open up Waterfall or embarass people in party/raid/officer chat.
It has a problem though. Yes...it eats CPU time ;). It does so when you are idle and either solo or in a party/raid, which it shouldn't be doing. It may be the LibTalentQuery-1.0 library doing it, which the only required library for it that I have embedded; every other library I have standalone. Or it may be the mod. Regardless, it would be great if you could cut or eliminate the usage.
When idle, either in a raid or solo, it continually eats 0.105 CPU/sec median (measured with OptionHouse). Not total CPU, but ongoing consumption. RaidBuffStatus and FuBar_RaidBuffFu (the other two buff checkers I've recently installed) use 0 CPU when idle.
Its likely scanning for everyone's buffs all the time, in order to keep the results text updated (as you need to do nothing to see updated results). This is really not needed and may be why its eating CPU when idle. Change it to do a buff check only when you click the FuBar icon (or similar)? Or something else that will cut the idle usage.
I suspect it's the way I'm using LibTalentQuery, as it should only scan the raid (or yourself or party) when you open the window by hovering over the icon (and then only do the scan once). You should notice that the buff list in the window doesn't refresh until you close the window and re-open it. I'll install OptionHouse and see if I can duplicate your results.
-Pach
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
I've updated my buff checking module (MoBuffs) to use Peragor's talent lib, and it seems to work well. I'll be uploading it to the SVN shortly. Yes, it's yet another buff checking module, but this is one that I've been working on since TBC came out. It's heavily heuristic based -- and absolutely zero config (you have enough to manage with raids already). I've looked at other buff checkers and they were all either too complicated, required everyone to have it installed, or simply incomplete.
The wiki page (with screenshots) for it is here: http://www.wowace.com/wiki/MoBuffs
Here's a *partial* list of the things it checks:
-- If player in not same zone as you, assume they are not active in raid (wait list, alt, etc.) and therefore not a source of buffs.
-- If the raid has a warlock, at least one person should be soulstoned.
-- Warn if more than one raid member has soulstone.
-- If the raid has a mage, everyone (with mana bar) should have arcane int/bril.
-- If the raid has a druid, everyone should have mark/gift of the wild.
-- If the raid has a priest, everyone should have fortitude.
-- If the raid has a priest, everyone should have shadow protection.
-- If the raid has a priest with 21 points in Discipline, then everyone (with mana bar) should have divine spirit.
-- If the raid has a paladin, everyone should have one blessing (not picky on which) per paladin in raid.
-- If the party has a paladin, everyone should have one aura (not picky which, except crusader) per paladin in party.
-- No player should have shadow resist aura if priest in raid.
-- No player should have crusader aura.
-- If the party has a hunter (with 31 marksmanship), everyone in party should have trueshot aura.
-- If player is hunter, should have an aspect up (not picky which - except beast/pack).
-- No player should have Aspect of the Beast or Aspect of the Pack.
-- If player is hunter, should have pet out (not picky which).
-- If player is mage, should have armor up (not picky which - mana, frost, ice, etc.)
-- If player is warlock, should have armor up (not picky which - fel, demon, etc.)
-- If player is warlock, should have pet out (not picky which).
-- If player is priest, should have Inner Fire up.
-- If player is does not have mana bar, should not have Blessing of Wisdom.
-- If player is Priest, Mage, or Lock, and there are less than 4 paladins in raid, he should not have Blessing of Might.
-- If player marked as 'maintank' through UI, assume player is a TANK.
-- If player marked as tank through oRA2 or CT_RA interface, assume player is a TANK.
-- If player is in "defensive stace", or in "bear form", or has "righteous fury", assume player is a TANK.
-- If player is TANK, should not have Blessing Of Salvation.
-- If player is TANK, and raid has a druid, he should have thorns (careful, this can break CC).
-- If player is TANK, and player is a paladin, should have righteous fury.
-- Everyone should have a battle and guardian elixir -or flask- up (not picky which).
-- Everyone should have a food buff up (not picky which).
-- Everyone should have a weapon buff (not picky which) like oil or sharpening stone.
Like I said, this is heuristic based, meaning it uses simple rules of thumb. They will not apply to every situation so a raid leader should use his head. This is just a tool to give you a heads up when something is probably missing.
It's also useful to see who's putting forth the effort (with buffs, pots, etc.) and who's slacking.
I hope others find it useful as well.
-Pach
Is it possible for perhaps the following (apologies if it can already do this):
1/ Disable/Enable specific buff checks (eg shad prot isnt needed all the time, same with flasks etc
2/ Option to output a brief list to chat somewhere (eg guild, raid, officer or whisper)
I understand if you do not wish to add eiter of the above as you are keeping it minimal and config free..
Will try later tonight if I recall and let you know how it does (only doing a 10man raid tonight but better than nowt eh :) )
Just one tiny idea, following this thread. How about putting the logic into a library allowing to query missing Buffs, Potions, Food, ect. on a certain player. Thus other addons could use it too, such as BigBrother (might be wrong here, never used it >_>) or an addon (still to be writen ^^) only querying yourself.
I really wanted it to be zero-config. There are a lot of buffs that are situational, like shadow protection, etc. even "Aspect of the Cheetah" -- ie. hunter speedy legs -- is useful in some raid circumstances. That's why I pointed out the raid leader (and the player) have to use their heads to interpret the output.
You can already click on the player's name in the list to send them a whisper. I'll consider adding options to send it to raid, officer, as well.
Thanks for the feedback.
-Pach
I agree, it can be a little overwhelming. Thanks for the suggestions. I've been working on improving that. I've been playing with alternate display types, like listing buffs on the left, with a list of players missing that buff on the right.
In most raiding situations, however, with most buffers "doing their jobs", the display gets amazingly short. For us, missing buffs tend to be the exception, and this just lets me catch them (ie. doing a quick sanity check before boss pull.) If you're consistently seeing long lists of missing buffs on lots of people, then I doubt any buff monitoring mod is going to help much :)
-Pach
-Pach
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThere's only 1 screenshot on the wiki page right now. I'll try to get some more up tonight.
-Pach
No, it should recognize all temporary weapon buffs. Here's the current list:
-- (Lesser|Greater) Ward of Shielding
-- Sharpened (+\d+ Damage)
-- Weighted (+\d+ Damage)
-- Anesthetic Poison
-- Deadly Poison [IVX]*
-- Crippling Poison [IVX]*
-- Wound Poison [IVX]*
-- Instant Poison [IVX]*
-- Mind-numbing Poison [IVX]*
-- (Minor|Superior|Brillant|Blessed) (Mana|Wizard) Oil
-- Wizard Oil
-- Frost Oil
-- Shadow Oil
Do you know which weightstone you were using?
One possibility is that currently +damage temporary weapon enchants don't affect you while you are in feral form. This is being changed in patch 2.4. I'll check to see if this is affecting my code.
-Pach
Thanks! I'll double check everything. Sorry for the confusion.
Okay, there are few libs broken now. An example is Tablet-2.0. How do I add it as an external with the Totoise SVN client?
Any help would be appreciated.
Thanks.
-Pach
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThe line you need to add is something like
quick edit: Looked at the addon this time, you need to go inside the main folder to the Libs folder to change the externals. :)
This link is from the tutorial, might explain something I forgot.
http://www.wowace.com/wiki/SVN_For_Beginners#Setting_SVN_Properties_.28i.e._Externals.29
Thanks Starinnia. The wiki link was very helpful.
-Pach
This should be fixed now. I had a bug in my regex matching string.
The latest version in SVN also has preliminary oRA2/CT_RA integration for determining who's a tank.
-Pach
This isn't always true - if the warlock has the Demonic Sacrifice talent, they may not want to have a pet out because they have one of the sacrifice buffs up. Just as a suggestion to improve the heuristic, perhaps you can make sure they have a pet *or* have one of the following buffs: Burning Wish, Fel Stamina, Touch of Shadow, Fel Energy.
Thanks. I'll add that check.
-Pach
It has a problem though. Yes...it eats CPU time ;). It does so when you are idle and either solo or in a party/raid, which it shouldn't be doing. It may be the LibTalentQuery-1.0 library doing it, which the only required library for it that I have embedded; every other library I have standalone. Or it may be the mod. Regardless, it would be great if you could cut or eliminate the usage.
When idle, either in a raid or solo, it continually eats 0.105 CPU/sec median (measured with OptionHouse). Not total CPU, but ongoing consumption. RaidBuffStatus and FuBar_RaidBuffFu (the other two buff checkers I've recently installed) use 0 CPU when idle.
Its likely scanning for everyone's buffs all the time, in order to keep the results text updated (as you need to do nothing to see updated results). This is really not needed and may be why its eating CPU when idle. Change it to do a buff check only when you click the FuBar icon (or similar)? Or something else that will cut the idle usage.
I suspect it's the way I'm using LibTalentQuery, as it should only scan the raid (or yourself or party) when you open the window by hovering over the icon (and then only do the scan once). You should notice that the buff list in the window doesn't refresh until you close the window and re-open it. I'll install OptionHouse and see if I can duplicate your results.
-Pach