Authors CurseForge

GetBonus() already exists, and has slightly different semantics.

I have added :GetRatingBonus() and :GetFriendlyBonus() as public API and modified :GetBonus() to be compatible with previous version and also give access to the complete internal GetBonus() function parameters.

Quote from Zidomo »

"ItemBonusLib-1.0-50636:114: attempt to index global 'self' (a nil value)"

Fixed in r50745, Thanks.

Any chance of getting this change incorporated?

Old:

if r <= 0.1 and g >= 0.9 and b <= 0.1 then
  self:AddBonusInfo(info.bonuses, bonus)
end

New:

if r <= 0.1 and g >= 0.9 and b <= 0.1 then
  self:AddBonusInfo(info.bonuses, bonus)
else
  if (info.sockets == nil) then info.sockets = {}; end
  self:AddBonusInfo(info.sockets, bonus);
end

This allows my code access to the inactive socket bonuses, without impacting the normal bonus results. Now that you've added support for empty sockets, this is about the only piece of information I need which ItemBonusLib doesn't supply.

Thanks!

Quote from Corde »

Any chance of getting this change incorporated?

Yes. info.inactive_gem_bonus contains this information.

Quote from Bejitt »

In ItemBonusLib:GetUnitEquipment, could you add something to conditionally disable hiding the Inspect frame?

I'm adding some code so that IBL does not close the inspect frame if you want to inspect the target. I could try and not call NotifyInspect() and ClearInspectPlayer(), which are likely to be simply related with showing the set bonus information in the tooltips of the inspect frame, an information IBL doesn't need.

Quote from bashui »

Jerry, did you see my question above? What do you think of adding this or some similar functionality (or letting me know if something like this already exists :))

Yes, I saw it. I'll add some way to get this number in the next implementation, but I don't want to put it in the bonus table, as an addon might want to iterate through these table and expect each key to have a defined meaning. i.e. ItemBonusLib:IsValidName(key) should return true for every entry in the bonus table.

Quote from Tristanian »

There are a few bonuses in IBL that are not properly mapped to a 'friendly name'. You may want to look at this, Jerry.

I have added "Reduced Threat" as the friendly name of THREATREDUCTION.

Please provide a list of missing Friendly names, with a proposal for Friendly name, if possible.
Note that as any pattern may introduce a new bonus type, the list of Friendly names is not guaranteed to be complete. That's why GetBonusFriendlyName() returns the bonus type name by default.

I believe I have a list somewhere in WoWEquip.... digging it out... I basically did my own translations since about half the bonus types don't have a friendly name at all, or the friendly name that was returned was a string that was too long to be displayed.

Below is a cut/paste portion of bonuses from my data file, since I'm kinda lazy to edit it. These ones probably don't have a translation last I checked 1-2 months ago.

	CR_WEAPON_FERAL		= {id = 3, t = L["Feral Combat s. rating"],	r = "FERAL_WEAPON_RATING"},

	CR_WEAPON_AXE_2H	= {id = 3, t = L["2H-Axe skill rating"],		r = "2H_AXE_WEAPON_RATING"},
	CR_WEAPON_MACE_2H	= {id = 3, t = L["2H-Mace skill rating"],		r = "2H_MACE_WEAPON_RATING"},
	CR_WEAPON_FIST		= {id = 3, t = L["Fist skill rating"],		r = "FIST_WEAPON_RATING"},
	CR_WEAPON_STAFF		= {id = 3, t = L["Staff skill rating"],		r = false},
	CR_WEAPON_GUN		= {id = 3, t = L["Gun skill rating"],		r = "GUN_WEAPON_RATING"},
	CR_WEAPON_BOW		= {id = 3, t = L["Bow skill rating"],		r = "BOW_WEAPON_RATING"},
	CR_WEAPON_CROSSBOW	= {id = 3, t = L["Crossbow skill rating"],		r = "CROSSBOW_WEAPON_RATING"},

	THREATREDUCTION		= {id = 8, t = L["Threat Reduction (%)"]},
	MELEEDMG		= {id = -1, t = L["Summed Melee Damage"]},

	CASTINGREG		= {id = 5, t = L["Mana Regen w/casting (%)"]},
	NATURECRIT		= {id = 4, t = L["Spell Crit (Nature)"]},
	CASTINGREGROWTH		= {id = -1, t = "-Cast (Regrowth)"},
	CASTINGHOLYLIGHT	= {id = -1, t = "-Cast (Holy Light)"},
	CASTINGHEALINGTOUCH	= {id = -1, t = "-Cast (Healing Touch)"},
	CASTINGFLASHHEAL	= {id = -1, t = "-Cast (Flash Heal)"},
	CASTINGCHAINHEAL	= {id = -1, t = "-Cast (Chain Heal)"},
	DURATIONREJUV		= {id = -1, t = "+Dur (Rejuvenation)"},
	DURATIONRENEW		= {id = -1, t = "+Dur (Renew)"},
	MANAREGNORMAL		= {id = -1, t = "Normal Life/Mana Regen"},
	IMPCHAINHEAL		= {id = -1, t = "Healing (Chain Heal)"},
	IMPREJUVENATION		= {id = -1, t = "Healing (Rejuvenation)"},
	IMPLESSERHEALINGWAVE	= {id = -1, t = "Healing (L.H. Wave)"},
	IMPFLASHOFLIGHT		= {id = -1, t = "Healing (Flash of Light)"},
	REFUNDHEALINGWAVE	= {id = -1, t = "Refund % mana (H. Wave)"},
	JUMPHEALINGWAVE		= {id = -1, t = "-% Heal/jump (H. Wave)"},
	CHEAPERDRUID		= {id = -1, t = "-% Mana (HT/Rg/Rej/Tr)"},
	REFUNDHTCRIT		= {id = -1, t = "Refund % mana (HT)"},
	CHEAPERRENEW		= {id = -1, t = "-% Mana (Renew)"},

	HEALTHREG_P		= {id = 5, t = L["Normal Health Regen"]},
	RUNSPEED		= {id = 8, t = L["Run Speed %"]},
	MOUNTSPEED		= {id = 8, t = L["Mount Speed %"]},
	SWIMSPEED		= {id = 8, t = L["Swim Speed %"]},
	STEALTH			= {id = 8, t = L["Stealth %"]},
	RANGED_SPEED_BONUS	= {id = 8, t = L["Ranged Speed Bonus %"]},
	NEGPARRY		= {id = 8, t = L["Less Parry %"]},
	STUNRESIST		= {id = 6, t = L["Stun Resistance %"]},
	FEARRESIST		= {id = 6, t = L["Fear Resistance %"]},
	DISORIENTRESIST		= {id = 6, t = L["Disorient Resistance %"]},
	MELEETAKEN		= {id = 8, t = L["Less Melee Dmg Taken"]},
	DMGTAKEN		= {id = 8, t = L["Less Spell Dmg Taken"]},
	UNDERWATER		= {id = 8, t = L["Underwater Breathing"]},
	LOCKPICK		= {id = 8, t = L["Lockpicking"]},
	STEALTHDETECT		= {id = 8, t = L["Stealth Detection"]},
	DISARMIMMUNE		= {id = 8, t = L["Disarm Immune"]},
	SLOWFALL		= {id = 8, t = L["Less Falling Damage %"]},
	IMPRESS			= {id = 8, t = L["Impress Others!"]},
	MOJO			= {id = 8, t = L["Mojo!"]},
	EMPTY_SOCKET_BLUE	= {id = 7, t = L["Empty Blue Socket"]},
	EMPTY_SOCKET_META	= {id = 7, t = L["Empty Meta Socket"]},
	EMPTY_SOCKET_RED	= {id = 7, t = L["Empty Red Socket"]},
	EMPTY_SOCKET_YELLOW	= {id = 7, t = L["Empty Yellow Socket"]},

Quote from Nickenyfiken »

I get a lot of the same error on my shaman so i made a extra check in function MergeDetails and the error goes away. I have attached a diff file for the change i made.

Could please instead try the following ?

 for slot, value in pairs(slots) do
  if type(value) ~= "number" then 
   self:Print("Error ! value has the type '%s' for slot '%s' and bonus '%s', type(value), slot, bonus)
  else
   bonuses[bonus] = (bonuses[bonus] or 0) + value
  end
 end

and give me the information, as well as the item in the corresponding slot(s) ?