I still got the problem that when I look at other character's banks/bags, I have many slots which show no texture, no tooltip, no stackcount, or any combination thereof.
When I delete all the Saveddata-files + rescan it all ingame, it works again, but slowly bugs out again. Is that some blizzard-side limitation.
(edit)
Oh wait - that has to do with my WoW's itemcache resetting every week on restart, right? :X
Just tried out OneBag today; looks like it does everything I want and I'll probably keep it. Thanks!
I did run into one problem. OneBank, and the bank portion of OneView, doesn't seem to respect the "Bag Break" setting. It works in OneBag and OneView's bag portion, but OneBank seems to insist on lumping the bags together. Furthermore, in testing, I was able to reliably produce the following error: "Interface\AddOns\OneBag\OneCore.lua:571: bad argument #1 to 'fmod' (number expected, got nil)". Steps to reproduce: in OneBank, turn on "Bag Break", and set "Vertical Alignment" to "Bottom" (the order of these steps doesn't seem to matter). This error only seems to appear in OneBank; I could not reproduce it in OneBag and OneView.
Minor quibble: I couldn't find a way to set the OneRing frame's scale... is it supposed to inherit this from the setting in OneBag? If so, it's not respecting it (I have OneBag set to 80% scale but OneRing is always at 100%).
I still got the problem that when I look at other character's banks/bags, I have many slots which show no texture, no tooltip, no stackcount, or any combination thereof.
When I delete all the Saveddata-files + rescan it all ingame, it works again, but slowly bugs out again. Is that some blizzard-side limitation.
(edit)
Oh wait - that has to do with my WoW's itemcache resetting every week on restart, right? :X
Just tried out OneBag today; looks like it does everything I want and I'll probably keep it. Thanks!
I did run into one problem. OneBank, and the bank portion of OneView, doesn't seem to respect the "Bag Break" setting. It works in OneBag and OneView's bag portion, but OneBank seems to insist on lumping the bags together. Furthermore, in testing, I was able to reliably produce the following error: "Interface\AddOns\OneBag\OneCore.lua:571: bad argument #1 to 'fmod' (number expected, got nil)". Steps to reproduce: in OneBank, turn on "Bag Break", and set "Vertical Alignment" to "Bottom" (the order of these steps doesn't seem to matter). This error only seems to appear in OneBank; I could not reproduce it in OneBag and OneView.
Minor quibble: I couldn't find a way to set the OneRing frame's scale... is it supposed to inherit this from the setting in OneBag? If so, it's not respecting it (I have OneBag set to 80% scale but OneRing is always at 100%).
hrm, sadly the code base has gradually degraded since the major work I did on it. 8 months and still mostly stable is pretty good though :) I will be moving to address most of these issues though, I apologize for being so busy :(
Would it be possible to add 2 features that Bagnon has?
Search line and adding to the item's tooltip how many of that item you have across all characters.
Thanks.
[2007/09/25 15:36:37-35-x1]: <string>:"BBankFrameItem1:OnShow":1: attempt to call global 'BankFrameItemButton_OnUpdate' (a nil value)
<in C code>: in function `Show'
OneBank-2.0.36565\OneBank.lua:110: in function <Interface\AddOns\OneBank\OneBank.lua:110>
<in C code>: ?
AceEvent-2.0-49307 (Ace2):307: in function `TriggerEvent'
AceEvent-2.0-49307 (Ace2):962: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:955>
[2007/09/25 15:36:37-35-x1]: <string>:"BBankFrameItem1:OnShow":1: attempt to call global 'BankFrameItemButton_OnUpdate' (a nil value)
<in C code>: in function `Show'
OneBag-2.0.42263\OneCore.lua:601: in function `OrganizeFrame'
OneBag-2.0.42263\OneCore.lua:706: in function `UpdateBag'
OneBank-2.0.36565\OneBank.lua:155: in function `StartOnUpdate'
OneBank-2.0.36565\OneBank.lua:217: in function `OnCustomShow'
OneBag-2.0.42263\OneCore.lua:820: in function `OnShow'
<string>:"*:OnShow":1: in function <[string "*:OnShow"]:1>
<in C code>: in function `Show'
OneBank-2.0.36565\OneBank.lua:110: in function <Interface\AddOns\OneBank\OneBank.lua:110>
<in C code>: ?
AceEvent-2.0-49307 (Ace2):307: in function `TriggerEvent'
AceEvent-2.0-49307 (Ace2):962: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:955>
---
any ideas? Seems like every entry in the bank is giving an error. I am getting like 20-30 of each of these until buggrabber just shutsdown from the spam. Seems to only happen when I open it up, as if I leave it open, no more errors, however when I move something into the bag the stacks I merge don't update with the new values. If I reopen my bank though it shows the right amount.
I'm also having troubles with OneBag, no item tooltips -- alongside CowTip. With CowTip disabled, still no item tooltips, looks like an issue with the new tooltips and OneBag.
For any and every item I mouseover in OneBag, I get the following error -- which isn't really telling me which mod/library could be at fault...very odd error.
[2007/09/25 19:34:11-419-x11]: Interface\FrameXML\MainMenuBarBagButtons.lua:82: Usage: GameTooltip:SetOwner(frame):
Interface\FrameXML\MainMenuBarBagButtons.lua:82: in function `BagSlotButton_OnEnter':
<string>:"*:OnEnter":2: in function <[string "*:OnEnter"]:1>
Retesting now -- there is definatly a mod interfearing in item linkage/tooltipping -- to perform an easy check, disable all mods except OneBag and check to see if it works, if it does, it's another mod causing interfearance. That is how I noticed LootLink causing interfearance with mine.
For any and every item I mouseover in OneBag, I get the following error -- which isn't really telling me which mod/library could be at fault...very odd error.
[2007/09/25 19:34:11-419-x11]: Interface\FrameXML\MainMenuBarBagButtons.lua:82: Usage: GameTooltip:SetOwner(frame):
Interface\FrameXML\MainMenuBarBagButtons.lua:82: in function `BagSlotButton_OnEnter':
<string>:"*:OnEnter":2: in function <[string "*:OnEnter"]:1>
Again, caused by Bliz updating their _OnEnter() syntax; this time, in their function in MainMenuBarBagButtons.lua.
The fix is to update OneBag\templates.xml on line 57 so that the code looks like:
I'd submit that to the SVN myself but a) I don't know if anyone other than Kaelten can do that and b) I don't like submitting changes to other peoples' addons without asking first, anyway. ;)
Hope that helps, though. Still trying to track down that pesky BBankFrameItem bug...
It's LootLink's _OnEnter() function causing problems as it's not been updated to use the new 'self' parameter.
Quick-fix is to open LootLink.lua to line 2596 (in the version I'm using) and look for code like this:
function LootLink_ContainerFrameItemButton_OnEnter()
LootLink_AutoInfoOff();
lOriginal_ContainerFrameItemButton_OnEnter();
Update it to look like this:
function LootLink_ContainerFrameItemButton_OnEnter(self)
LootLink_AutoInfoOff();
lOriginal_ContainerFrameItemButton_OnEnter(self);
That fixed my LootLink issues.
Now to work out what the heck is causing the MainMenuBarBagButtons nonsense... *sigh*
Telo has recently updated his addons to work properly in WoW 2.2, including fixing the LootLink bugs. Check out the official forums link: Telo's AddOns updated for 2.2 patch.
Not recommending you use any of them--LootLink will increase your memory usage & logon time by more than any other mod you'll ever run ;)--but they are updated.
i don't use LootLink but i had a different problem
<string>:"BBankFrameItem[b]X[/b]:OnShow":1: attempt to call global '[i]BankFrameItemButton_OnUpdate[/i]' (a nil value)
<in C code>: in function `Show'
OneBank-2.0.36565\OneBank.lua:110: in function <Interface\AddOns\OneBank\OneBank.lua:110>
<in C code>: ?
AceEvent-2.0-49307 (Ace2):307: in function `TriggerEvent'
AceEvent-2.0-49307 (Ace2):962: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:955>
so i followed it back to onebag's template file, Lines 10-12
<OnShow>
BankFrameItemButton_OnUpdate()
</OnShow>
Deleted those lines out and my errors went away, it dosn't appear to brake any functionality.
i don't use LootLink but i had a different problem
<SNIP>
Deleted those lines out and my errors went away, it dosn't appear to brake any functionality.
That'll get rid of the errors, yes, but it doesn't fix the problem. :(
If you open your OBB and try to move items around, their border hilights will update but not the textures.
I managed to fix (hack? :P) this in the OneBank\OneBank.lua file at around line 113 by adding a call to the new BankFrameItemButton_Update() function that Blizzard added (as a replacement to the now-missing *OnUpdate() function):
if not self.frame.bags[-1].colorLocked then
for k, v in ipairs(self.frame.bags[-1]) do
self:SetBorderColor(v)
BankFrameItemButton_Update(v)
end
end
It's definitely nothing more than a temporary hack, I think, as that loop seems to only run when the bag in question isn't "colorLocked" but it works for me, for now. I'll definitely be glad when an official fix is available. =)
When I delete all the Saveddata-files + rescan it all ingame, it works again, but slowly bugs out again. Is that some blizzard-side limitation.
(edit)
Oh wait - that has to do with my WoW's itemcache resetting every week on restart, right? :X
I did run into one problem. OneBank, and the bank portion of OneView, doesn't seem to respect the "Bag Break" setting. It works in OneBag and OneView's bag portion, but OneBank seems to insist on lumping the bags together. Furthermore, in testing, I was able to reliably produce the following error: "Interface\AddOns\OneBag\OneCore.lua:571: bad argument #1 to 'fmod' (number expected, got nil)". Steps to reproduce: in OneBank, turn on "Bag Break", and set "Vertical Alignment" to "Bottom" (the order of these steps doesn't seem to matter). This error only seems to appear in OneBank; I could not reproduce it in OneBag and OneView.
Minor quibble: I couldn't find a way to set the OneRing frame's scale... is it supposed to inherit this from the setting in OneBag? If so, it's not respecting it (I have OneBag set to 80% scale but OneRing is always at 100%).
very possible.
hrm, sadly the code base has gradually degraded since the major work I did on it. 8 months and still mostly stable is pretty good though :) I will be moving to address most of these issues though, I apologize for being so busy :(
## X-AceLibrary-OneStorage-2.0: true
to the OneStorage.toc so that OneView doesn't puke on itself if OneStorage is installed but not loaded..
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumCould look into this please? It looks so much better with this texture. >.<
Search line and adding to the item's tooltip how many of that item you have across all characters.
Thanks.
[2007/09/25 15:36:37-35-x1]: <string>:"BBankFrameItem1:OnShow":1: attempt to call global 'BankFrameItemButton_OnUpdate' (a nil value)
<in C code>: in function `Show'
OneBank-2.0.36565\OneBank.lua:110: in function <Interface\AddOns\OneBank\OneBank.lua:110>
<in C code>: ?
AceEvent-2.0-49307 (Ace2):307: in function `TriggerEvent'
AceEvent-2.0-49307 (Ace2):962: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:955>
[2007/09/25 15:36:37-35-x1]: <string>:"BBankFrameItem1:OnShow":1: attempt to call global 'BankFrameItemButton_OnUpdate' (a nil value)
<in C code>: in function `Show'
OneBag-2.0.42263\OneCore.lua:601: in function `OrganizeFrame'
OneBag-2.0.42263\OneCore.lua:706: in function `UpdateBag'
OneBank-2.0.36565\OneBank.lua:155: in function `StartOnUpdate'
OneBank-2.0.36565\OneBank.lua:217: in function `OnCustomShow'
OneBag-2.0.42263\OneCore.lua:820: in function `OnShow'
<string>:"*:OnShow":1: in function <[string "*:OnShow"]:1>
<in C code>: in function `Show'
OneBank-2.0.36565\OneBank.lua:110: in function <Interface\AddOns\OneBank\OneBank.lua:110>
<in C code>: ?
AceEvent-2.0-49307 (Ace2):307: in function `TriggerEvent'
AceEvent-2.0-49307 (Ace2):962: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:955>
---
any ideas? Seems like every entry in the bank is giving an error. I am getting like 20-30 of each of these until buggrabber just shutsdown from the spam. Seems to only happen when I open it up, as if I leave it open, no more errors, however when I move something into the bag the stacks I merge don't update with the new values. If I reopen my bank though it shows the right amount.
Disabling OneBag.
[2007/09/25 19:34:11-419-x11]: Interface\FrameXML\MainMenuBarBagButtons.lua:82: Usage: GameTooltip:SetOwner(frame):
Interface\FrameXML\MainMenuBarBagButtons.lua:82: in function `BagSlotButton_OnEnter':
<string>:"*:OnEnter":2: in function <[string "*:OnEnter"]:1>
---
Disable LootLink and tooltips will work with OneBag again.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumQuick-fix is to open LootLink.lua to line 2596 (in the version I'm using) and look for code like this:
Update it to look like this:
That fixed my LootLink issues.
Now to work out what the heck is causing the MainMenuBarBagButtons nonsense... *sigh*
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumAgain, caused by Bliz updating their _OnEnter() syntax; this time, in their function in MainMenuBarBagButtons.lua.
The fix is to update OneBag\templates.xml on line 57 so that the code looks like:
I'd submit that to the SVN myself but a) I don't know if anyone other than Kaelten can do that and b) I don't like submitting changes to other peoples' addons without asking first, anyway. ;)
Hope that helps, though. Still trying to track down that pesky BBankFrameItem bug...
Telo has recently updated his addons to work properly in WoW 2.2, including fixing the LootLink bugs. Check out the official forums link: Telo's AddOns updated for 2.2 patch.
Not recommending you use any of them--LootLink will increase your memory usage & logon time by more than any other mod you'll ever run ;)--but they are updated.
-
View User Profile
-
View Posts
-
Send Message
Curse Premiumso i followed it back to onebag's template file, Lines 10-12
<OnShow> BankFrameItemButton_OnUpdate() </OnShow>Deleted those lines out and my errors went away, it dosn't appear to brake any functionality.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumThat'll get rid of the errors, yes, but it doesn't fix the problem. :(
If you open your OBB and try to move items around, their border hilights will update but not the textures.
I managed to fix (hack? :P) this in the OneBank\OneBank.lua file at around line 113 by adding a call to the new BankFrameItemButton_Update() function that Blizzard added (as a replacement to the now-missing *OnUpdate() function):
It's definitely nothing more than a temporary hack, I think, as that loop seems to only run when the bag in question isn't "colorLocked" but it works for me, for now. I'll definitely be glad when an official fix is available. =)
Use that "fix" at your own risk! :o
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumAll errors gone and everything works. Thanks for the Fix OrionShock.