Is there anyway you could add support for the auction prices that WoWHead has for items?
Technically I could. They are listed the same way as vendor sell-values. But I have some doubt how useful they are. I can see at least two problems with those data. First, I think different servers can have vastly different AH prices. Wowhead's AH price is an average of many servers. Perhaps those prices could still be used in comparison with other prices. The second problem is worse. Wowhead only records prices for each unique item-id. That means they take an average of all "subitems". While vendor sell-values are identical for the subitems, the AH value often varies a lot.
Take for example Bonecaster's Shroud. This item does not exist by itself in the game. Only subitems are available as displayed on Wowhead, such as Bonecaster's Shroud of Intellect and Bonecaster's Shroud of the Boar. The first might sell fairly well on the AH. The other is in my opinion vendor junk. But Wowhead only shows one price. (Unless there is some feature on the site I have missed.)
So I am not sure collecting AH prices from Wowhead is worth it. But I am open to opinions and suggestions. :)
Am I blind and missing an option or is there no way to set a graphical coin view? I'd love to see one if it isn't there already ;)
You are not blind. :) It's a simple addon that in fact has no options at all currently. But I have been asked by several people now to provide some more display options and customization. So I will add something soonish. :P
Will this display sell value on quest rewards? I always like to compare the price of items so i can sell for the most cash.
Yes. If the item is in the database, it shows sell value in almost all types of item tooltips in the game. If you find a tooltip where it ought to be displayed but is not, please let me know. I have not personally been able to test some of the more obscure ones (in particular some of the new gem/socket-related ones).
There are a few deliberate exceptions though:
Sell value is not shown for items in your bag when visiting a vendor since the game already does this. I feared it might cause confusion in case of discrepancies.
Sell value is not shown for bag slots (i.e. the equipped bags themselves). A user asked me to remove this and I obeyed.. hehe.
Sell value is not shown on the comparison tooltips. I just didn't consider it very useful. :)
Btw, for quest rewards in particular you could consider also using VendorBait. It works with ItemPrice and a few other sell-value addons.
Hi, here is a french translation for this great add-on
Hope it will be useful for some people.
L:RegisterTranslations("frFR", function() return {
["Sells for"] = "Vendu pour",
["Display style"] = "Style d'affichage",
["Text"] = "Texte",
["Text color"] = "Couleur du texte",
["Custom text"] = "Texte personnalis?",
["Bag slots"] = "Sac",
["Show price for bag slots"] = "Affiche le prix des sacs",
["Record vendor prices"] = "Enregistrer les prix des marchands",
["Purge prices!"] = "Purge des prix!",
["Purge recorded vendor prices"] = "Purge de l'enregistrement des prix des marchands",
}
end)
I'v added support for ItemPrice to GarbageFu many weeks (if not months) ago, simply by adding a few lines of code to the GarbageFu_Vendor.lua file. I didn't embed the libary, i just use the GetSellValue API (so basically any other item price addon that use that will work too). I'm really surprised that support hasn't been added to GarbageFu yet, so i was wondering if i could add it myself to the trunk so others can benefit too, although i have no idea how to contact the author, and ask if it is ok with him.
In my opinion ItemPrice is the best item price database available both in terms of technical implementation and coverage. I hope that it will stick to vendor prices (from wowhead) and don't go down the slippery road of auction prices, and i certainly wouldn't like to see inter-client communication either (as some have suggested).
Remember that there are two parts to this addon: The addon itself and the library ItemPrice-1.0 that stores prices mined from wowhead (and is also the one that implements the GetSellValue API). The library is unlikely to be changed much (apart from regular price updates, of course).
ItemPriceTooltip (the addon) may get some more features over time, but they will not affect the library. I do still want to keep the addon simple too, though. Auction prices from wowhead will not be included in the addon itself. It might be interesting to make a new library for this. (But see my comments above about why I don't think wowhead's auction prices are all that useful.) Synchronizing data with other users is something I consider beyond the scope of this addon. It is my hope that having a regularly updated library with prices reduces the need for such a feature.
Unfortunately, this mod doesn't seem to work for me. :(
This is what I get on login, and I see no tooltip info at all, and I can't find "IPT" somewhere in Niagara (or configure it with slash commands). Any idea what's wrong?
This is what I get on login, and I see no tooltip info at all, and I can't find "IPT" somewhere in Niagara (or configure it with slash commands). Any idea what's wrong?
If there is a syntax error in the file, the addon will simply not load. So that would be the reason you don't see it.
But I don't know why you are getting that syntax error. It parses correctly for me and loads fine. I double-checked both my local copy and with the latest zip from files.wowace.com. Both work fine for me. Any chance you made some accidental error when doing the localization? Please try deleting your copy and download the latest.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
Index: ItemPriceTooltip.lua =================================================================== --- ItemPriceTooltip.lua (r?vision 36730) +++ ItemPriceTooltip.lua (copie de travail) @@ -233,6 +233,10 @@ local _, _, count = _G.GetTradeTargetItemInfo(index) addPrice(self, count) end + + function ItemPrice:Links_LinkOpened(_, frame) + addPrice(frame, 1) + end end @@ -320,6 +324,7 @@ self:installHooks(_G.ItemRefTooltip, Hooks) self:RegisterEvent("MERCHANT_SHOW", 0.5) + self:RegisterEvent("Links_LinkOpened") self:getPriceDB() endmerged in trunk ?
Thanks
Technically I could. They are listed the same way as vendor sell-values. But I have some doubt how useful they are. I can see at least two problems with those data. First, I think different servers can have vastly different AH prices. Wowhead's AH price is an average of many servers. Perhaps those prices could still be used in comparison with other prices. The second problem is worse. Wowhead only records prices for each unique item-id. That means they take an average of all "subitems". While vendor sell-values are identical for the subitems, the AH value often varies a lot.
Take for example Bonecaster's Shroud. This item does not exist by itself in the game. Only subitems are available as displayed on Wowhead, such as Bonecaster's Shroud of Intellect and Bonecaster's Shroud of the Boar. The first might sell fairly well on the AH. The other is in my opinion vendor junk. But Wowhead only shows one price. (Unless there is some feature on the site I have missed.)
So I am not sure collecting AH prices from Wowhead is worth it. But I am open to opinions and suggestions. :)
You are not blind. :) It's a simple addon that in fact has no options at all currently. But I have been asked by several people now to provide some more display options and customization. So I will add something soonish. :P
Yes. If the item is in the database, it shows sell value in almost all types of item tooltips in the game. If you find a tooltip where it ought to be displayed but is not, please let me know. I have not personally been able to test some of the more obscure ones (in particular some of the new gem/socket-related ones).
There are a few deliberate exceptions though:
Btw, for quest rewards in particular you could consider also using VendorBait. It works with ItemPrice and a few other sell-value addons.
Hope it will be useful for some people.
L:RegisterTranslations("frFR", function() return { ["Sells for"] = "Vendu pour", ["Display style"] = "Style d'affichage", ["Text"] = "Texte", ["Text color"] = "Couleur du texte", ["Custom text"] = "Texte personnalis?", ["Bag slots"] = "Sac", ["Show price for bag slots"] = "Affiche le prix des sacs", ["Record vendor prices"] = "Enregistrer les prix des marchands", ["Purge prices!"] = "Purge des prix!", ["Purge recorded vendor prices"] = "Purge de l'enregistrement des prix des marchands", } end)Thanks and congrats to the author.
Bye
I think the forum converted an accented character into a question mark. Is the following correct (hoping the conversion doesn't happen again):
["Custom text"] = "Texte personnalis?e",
EDIT: It did get converted. Grrr. Well, it is supposed to end with an "e accent aigu" followed by a regular "e". :)
There could be other accents that were stripped. It might be the doing of the code-tag.
Btw, I added a few texts recently. Perhaps you can translate those also when you have time.
Here is it with code (Only accent in this text)
I'll translate new texts as soon as possible.
Thanks
Bye
In my opinion ItemPrice is the best item price database available both in terms of technical implementation and coverage. I hope that it will stick to vendor prices (from wowhead) and don't go down the slippery road of auction prices, and i certainly wouldn't like to see inter-client communication either (as some have suggested).
ItemPriceTooltip (the addon) may get some more features over time, but they will not affect the library. I do still want to keep the addon simple too, though. Auction prices from wowhead will not be included in the addon itself. It might be interesting to make a new library for this. (But see my comments above about why I don't think wowhead's auction prices are all that useful.) Synchronizing data with other users is something I consider beyond the scope of this addon. It is my hope that having a regularly updated library with prices reduces the need for such a feature.
Fixed!
L:RegisterTranslations("deDE", function() return { ["Sells for"] = "Verkauf f\195\188r", ["Display style"] = "Anzeigestil", ["Text"] = "Text", ["Text color"] = "Textfarbe", ["Custom text"] = "Benutzerdefinierter Text", ["Bag slots"] = "Taschenpl\195\164tze", ["Show price for bag slots"] = "Den Preis f\195\188r Taschenpl\195\164tze anzeigen", ["Record vendor prices"] = "H\195\164ndlerpreise aufzeichnen", ["Purge prices!"] = "Preise l\195\182schen!", ["Purge recorded vendor prices"] = "Alle aufgezeichneten H\195\164ndlerpreise l\195\182schen", ["Modifier key only"] = "Nur Modifikator-Taste", ["Only show price when a modifier key is held down"] = "Preise nur anzeigen, wenn eine Modifikator-Taste gedr\195\188ckt wird", ["Unknown sell price"] = "Unbekannter Verkaufspreis", ["Modifier key"] = "Modifikator-Taste", ["Choose a modifier key"] = "Eine Modifikator-Taste ausw\195\164hlen", ["Show statistics"] = "Statistiken anzeigen", ["Show statistics for stored prices"] = "Statistiken f\195\188r gespeicherte Preise anzeigen", ["Prices in library: %d"] = "Preise in der Datenbank: %d", ["Recorded vendor prices: %d"] = "Aufgezeichnete H\195\164ndlerpreise: %d", } end)Thanks! :)
Unfortunately, this mod doesn't seem to work for me. :(
This is what I get on login, and I see no tooltip info at all, and I can't find "IPT" somewhere in Niagara (or configure it with slash commands). Any idea what's wrong?
If there is a syntax error in the file, the addon will simply not load. So that would be the reason you don't see it.
But I don't know why you are getting that syntax error. It parses correctly for me and loads fine. I double-checked both my local copy and with the latest zip from files.wowace.com. Both work fine for me. Any chance you made some accidental error when doing the localization? Please try deleting your copy and download the latest.