Today's update (r48162) seems to have changed behaviour with Bartender3 paging (see my post immediately above). Thank you! However, it is still buggy: with this update, the l2c display does update when bars page in and out, but they always seem to display the numbers for the previously-active bar. I tested this with several characters and the behaviour was the same. I'm glad this addon is seeing some progress, as I can see it'll be extremely useful once it works for me. Getting tantalizingly close...
I have (yet) another implementation idea concerning lern2count, that should reduce lag spikes that occurs when updating the different counts. It will hopefully also fix the issue where button paging is done too early (I hope).
48477 seems to be working with Bartender3 again. The L2C display sometimes does seem to lag a bit after paging (waiting for the next mana tick maybe?), but if I wait a bit it will eventually display the correct values.
Part of the implementation I wrote is to split the updating process between a few screen updates, instead of all at once. This helps getting a smoother framerate, at the expense of a slight lag in the numbers. The lag is framerate dependant, and if you're running at 20 fps, it may take up to half a second (10 updates) to finish.
Request for support of TrinityBars2, switched over to TB2 and there isn't any count, any way to see if it can be supported to work as well as before.
It's a major pain to support TrinityBars2 as it is written right now, so I'm not gonna do it. Ask the TrinityBars2 author to make it so that updateAction_OnEvent in TrinityBars2.lua can be hooked. When it's done, I'll add support.
if IsAddOnLoaded("TrinityBars2") then
TrinityBars2_OnEvent_Hook = TrinityBars2.ActionButton_OnEvent
local function TrinityBars2_Buttons_UpdateCountList(add)
local i = 1
-- use of the _G table to account for unlimited buttons in TB2
while _G["TrinityActionButton"..i] do
local frame = getglobal("TrinityActionButton"..i.."Count")
if frame then
add(frame, "action", i)
end
i = i + 1
end
end
function ltc:TrinityBars2_OnEvent_Hook(button)
self.hooks.TrinityBars2_OnEvent_Hook(button)
local frame = getglobal(button:GetName().."Count")
local info = self:GetCountList()[frame]
if info then
self:UpdateCount (frame, info)
end
end
ltc:Hook("TrinityBars2_OnEvent_Hook", true)
ltc:RegisterPlugin(TrinityBars2_Buttons_UpdateCountList)
end
Any way you can check it out and see if it works for you?
Thank you and Maul for the time spent trying to make the addons work.
Lern2Count seems to be miscounting energy-based ablilities (Rogue and Druid cat form). It seems to be counting in reverse: for instance, when shifting to cat form (emptying my energy bar), my abilities will show various positive numbers. As the energy bar fills up, the numbers decrease until they hit 0 when the bar is full.
thanks to Jerry i can post my request at a more official place :)
I would love to see learn2count supporting Bongos3. I hope it will not be that much work. I miss this fine piece of code so much.
Thank you in advance.
Greetings, could you take a look at Bartender 4 support, there were some changes to it and since then the count hasn't shown up, the numbers do show for the pet bars, just not the main action bars. Thanks.
L
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
[2007/09/05 13:50:48-802-x5]: lern2count\Core.lua:347: attempt to perform arithmetic on local 'prev_time' (a nil value)
I have (yet) another implementation idea concerning lern2count, that should reduce lag spikes that occurs when updating the different counts. It will hopefully also fix the issue where button paging is done too early (I hope).
I've looked at FlexBar2, and it seems somewhat difficult. Does FlexBar2 shows the default counts for actions, like the number of reagents ?
Excuse for my bad English
Thanks, L
It's a major pain to support TrinityBars2 as it is written right now, so I'm not gonna do it. Ask the TrinityBars2 author to make it so that updateAction_OnEvent in TrinityBars2.lua can be hooked. When it's done, I'll add support.
Any way you can check it out and see if it works for you?
Thank you and Maul for the time spent trying to make the addons work.
L
thanks to Jerry i can post my request at a more official place :)
I would love to see learn2count supporting Bongos3. I hope it will not be that much work. I miss this fine piece of code so much.
Thank you in advance.
Kind regards
X-buZZ
[2008/05/16 09:24:35-4204-x1]: lern2count-0.1\Default\Bongos3_Buttons.lua:55: '<eof>' expected near 'end'
i included a showtooltip with spellname and rank, and it works fine with my macros.:)
is it possible to implement a numeric countdown like abinfo and/or an extra spellready button flash?
fine regards
thank you so much for implementing Bongos3 support that outstanding fast!
It feels godd to have it back on my bars.
I have another request: Can you please add some option to position the text on the buttons horizontally and vertically?
Keep up the great work!
Best regards
X-buZZ
L