Authors CurseForge

button:1 is left click. You want button:2

Can one of you write a cyCircled plugin for it? Please? :)

Bumpity

Quote from avazza »

Yeah we need cyCircled!

I've created a template for klappa :

local addonName = "Klappa"

cyCircled_Klappa = cyCircled:NewModule(addonName)

function cyCircled_Klappa:AddonLoaded(addon)
	self.db = cyCircled:AcquireDBNamespace(addonName);
	cyCircled:RegisterDefaults(addonName, "profile", {
		["Main"] = true,
		["Popup"] = true,
	})
	self:SetupElements();
end

function cyCircled_Klappa:GetElements()
	return {
		["Main"] = true,
		["Popup"] = true,
	}
end

function cyCircled_Klappa:SetupElements()
	local size = Klappabar1Button:GetWidth()
	self.elements = {
		["Main"] = {
			args = {
				button = { width = size, height = size, },
			},
			elements = {},
		},
		["Popup"] = { 
			args = {
				button = { width = size, height = size, },
			},
			elements = {},
		},
	}

	for k,v in pairs(Klappa.root.buttons) do
		table.insert(self.elements["Main"].elements, "Klappabar"..k.."Button")
		for k2,v2 in pairs(Klappa.root.buttons[k].popupButtons) do
			table.insert(self.elements["Popup"].elements, "Klappabar"..k.."PopUpButton"..k2)
		end
	end

end

However, for non-square buttons, it doenst work quite right :



I dont know if its the overlay skin from cyCircled, or the backdrop of the original buttons thats showing thru - but at least with square buttons it matches the look of everything else.

Also, with circular buttons, the label text is below the circular border - which doesnt happen with other baraddons, and as far as I can tell the text is all created the same way - I must be missing where the frame strata are setup.

I hate everyone but my Mage loves this addon. lol.

It's missing the option to hide the minimap button.
Gief, now.

I've created a template for klappa

It's a start! I noticed the same issues you're having but can't seem to figure it out. :/

Quote from kaybe »

Very nice, thank you.

This is just a start. There's some issues still with it that I was unable to resolve. If you can figure it out and get it working right, post it and I'll add it to cyCircled on the SVN.

This is the one thing I'm waiting for to enable Klappa! :D

Wonderful! Just let me know when it's done and I'll add the plugin! :)

Two errors:

Dragging on an empty button slot:

[2007/09/27 23:49:44-160-x3]
Klappa\KlappaPopUp.lua:160: attempt to index field '?' (a nil value) Klappa\KlappaPopUp.lua:42: in function <Interface\AddOns\Klappa\KlappaPopUp.lua:42>

Dragging any icon:

[2007/09/27 23:51:16-160-x1]
Klappa\KlappaPopUp.lua:153: PickupSpell(): Invalid spell slot
Klappa\KlappaPopUp.lua:153: in function `ButtonDrag' Klappa\KlappaPopUp.lua:42: in function <Interface\AddOns\Klappa\KlappaPopUp.lua:42>

BTW, I'll be adding the cC plugin shortly.

CyCircled plugin added. Seems to work fine. Oh, as far as the icon edges showing through, perhaps you could adjust the scale a little bit? It doesn't do it on all icons, only certain ones.

May I suggest some optimizations ?

Instead of :

	local pbuttons = Klappa.db.profile.buttons[self.index].popupButtons;
	local npopups = Klappa.db.profile.buttons[self.index].popups;
	Klappa.db.profile.buttons[self.index] = {};
	Klappa.db.profile.buttons[self.index].popupButtons = pbuttons;
	Klappa.db.profile.buttons[self.index].popups = npopups;

Please do :

    local button = Klappa.db.profile.buttons[self.index]
    for k in pairs(button) do
		if k ~= 'popupButtons' and k ~= 'popups' then
			button[k] = nil 
        end
	end

It avoids recreating a new table every time this function is created (and thus fixes a memory leak).

Btw things like :

		Klappa.db.profile.buttons[self.index].spell = spellName.."("..spellRank..")";
		Klappa.db.profile.buttons[self.index].texture = curtexture;
		Klappa.db.profile.buttons[self.index].spellID = slot;
		Klappa.db.profile.buttons[self.index].spellName = spellName;
		Klappa.db.profile.buttons[self.index].spelltype = spelltype;

Could be optimized into :

		local button = Klappa.db.profile.buttons[self.index]
		button.spell = spellName.."("..spellRank..")";
		button.texture = curtexture;
		button.spellID = slot;
		button.spellName = spellName;
		button.spelltype = spelltype;

Besides saving some CPU cycles, it enhances readability and maintainability.