Best to first determine wether the problem lies with SpamSentry or another addon. To find out: disable SpamSentry, then check if the problem is fixed. If it is, please let me know and I'll have a good look at both addons. If it isn't; the problem lies with a different addon.
Also, there's a similar thread running on the homepage of WIM, you may want to post there or have a look for suggested solutions.
Well, I unchecked the SpamSentry -> Options -> Channel -> Whisper option and reloaded my UI, had a friend whisper me + WIM popped up with his whisper. However if I recheck it and reload UI and he whispers me again WIM doesn't appear until I start a reply to him.
Anyone who isn't on friends/guild I will always miss their first whisper in WIM + usually their whisper entirely. Now if they whisper me a second time it will show up in WIM, but won't display the first whisper within the WIM window.
Well, I unchecked the SpamSentry -> Options -> Channel -> Whisper option and reloaded my UI, had a friend whisper me + WIM popped up with his whisper. However if I recheck it and reload UI and he whispers me again WIM doesn't appear until I start a reply to him.
Anyone who isn't on friends/guild I will always miss their first whisper in WIM + usually their whisper entirely. Now if they whisper me a second time it will show up in WIM, but won't display the first whisper within the WIM window.
Odd, odd, haven't seen this when I tested with WIM. I'll reinstall WIM this weekend and see if I can reproduce the problem.
I had a spare hour so did some testing with the help of a friend. I ran only two addons during testing: WIM and SpamSentry. We have tried virtually every setup I could think off: guilded/unguilded on friendlist or not, using words that would trigger SpamSentry, etc. Even tried with various level settings, and played with some settings in WIM. In no way I was able to reproduce the problem you reported: the first tell going missing when someone whispers you.
I can only conclude that the problem is caused by either a very specific WIM-option, or by another addon. SpamSentry and WIM are working perfectly fine together as far as I can test.
[2008/05/14 15:38:40-2130-x17]: WhoLib-1.0-73809 (SpamSentry):296: attempt to index field 'Args' (a nil value)
Haven't seen this error myself, but it looks as if it's caused by a version conflict: aka you're running an old version of WhoLib on one of your other addons.
Quote from Gamefaq »
PS: I do Translations into deDE for various other (Ace)Addons and Updated my SVN SpamSentry Version deDE Locals if you want i can commit them to SVN.
Updated locales is always nice to have :) Unfortunately for you, the SpamSentry SVN is locked, so you can't upload it directly. If you send me a PM with the locale, or post it in this thread, I'll upload it to the SVN.
The problem appeared when turning in quests, so I was finally able to reproduce it. Pushed another change in WhoLib (well, almost a full fallback), and now the line 296-problem seems sorted too :)
After a busy day, hopefully peace and quiet is restored on the world of Azeroth :)
Updated locales is always nice to have :) Unfortunately for you, the SpamSentry SVN is locked, so you can't upload it directly. If you send me a PM with the locale, or post it in this thread, I'll upload it to the SVN.
Well i can still upload even if you lock it...but i respect if you don't want other to mess with your Files but don't forget you can revert all unwanted changes everytime on SVN. SVN is made that many can work together on one Project.
PS: Attached my SpamSentry SVN Version (All deDE Files are Changed and the Toc File)
Changes:
Updated all deDE Files
Translated missing Strings
Changed deDE File Format to UTF-8 (can use now German Umlauts and ASCII Codes)
Tweak deDE Description in Toc File
Well i can still upload even if you lock it...but i respect if you don't want other to mess with your Files but don't forget you can revert all unwanted changes everytime on SVN. SVN is made that many can work together on one Project.
PS: Attached my SpamSentry SVN Version (All deDE Files are Changed and the Toc File)
Changes:
Updated all deDE Files
Translated missing Strings
Changed deDE File Format to UTF-8 (can use now German Umlauts and ASCII Codes)
Tweak deDE Description in Toc File
Thanks for your work! I've updated SpamSentry with the new locales.
I uploaded a new release the other day, a quick overview of the changes:
- The SpamSentry icon will now turn red when spam has been caught
- Fixed French localisation so that it will now correctly monitor guild-recruitment and looking-for-group channels
- Updated filters to fix a false positive
Can anything be done about the horendus chat lag this causes? I realize that having to parse every line that comes in will cause a good bit of lag but if I'm talking to someone in /say I see what they say over their head several seconds before I see it in the chat log.
Might I recommend a dynamic white list? May cause more lag for unwhite listed but a larger improvement over all. Actions that would add people to the white list:
Anybody on friends list (only check for one's online)
Guild mates (again only those online)
Anybody you've /replied to in whisper (periodic online check like WIM?)
Last 20-50 (or maybe to keep things from getting out of hand, 100 - # of people in above lists, or 20, whichever is greater) people who have spoken in any monitored chat channel with at least 3 messages that weren't marked as spam.
For the last one maybe do a time sorted list, anytime they say something they get moved back to the front of the list, that way active talkers stay on list. The last two items would reset each time you log on.
Even if you had to check each incoming name against 100 avatars that has to be exponentially less taxing than doing numerous regexp checks on everything they say, esp as you have to add more and more things to check for.
It's a fair question, but I have to disappoint you. Most if not all lag you experience in your chat is caused by the game client, not by SpamSentry. You can easily verify this by installing PerformanceFu and monitor the cpu-usage of SpamSentry. We are talking a scale of less then milliseconds for SpamSentry to process a chatmessage.
The only exception is when SpamSentry is holding a message to verify it's sender by a who-query. This however only happens when the message contains a fair number of spam-characteristics.
I once had a nice picture on the wikipage along with some text that explained in detail how SpamSentry handles text from incoming messages. I'll see if I can find it and repost the whole thing.
As for whitelists: no matter the alghoritm you use, it will be very liable to abuse.
Feel free to look into the core.lua file. The functions SS:SpamCheck1 and SS:SpamCheck2 have detailed documentation on what heuristics are used.
Can anything be done about the horendus chat lag this causes? I realize that having to parse every line that comes in will cause a good bit of lag but if I'm talking to someone in /say I see what they say over their head several seconds before I see it in the chat log.
Might I recommend a dynamic white list? May cause more lag for unwhite listed but a larger improvement over all. Actions that would add people to the white list:
Anybody on friends list (only check for one's online)
Guild mates (again only those online)
Anybody you've /replied to in whisper (periodic online check like WIM?)
Last 20-50 (or maybe to keep things from getting out of hand, 100 - # of people in above lists, or 20, whichever is greater) people who have spoken in any monitored chat channel with at least 3 messages that weren't marked as spam.
For the last one maybe do a time sorted list, anytime they say something they get moved back to the front of the list, that way active talkers stay on list. The last two items would reset each time you log on.
Even if you had to check each incoming name against 100 avatars that has to be exponentially less taxing than doing numerous regexp checks on everything they say, esp as you have to add more and more things to check for.
Tried unchecking ''Delay suspicious chat messages'' or whatever it's called? Can't remember exactly what the option is called, but turning it off will decrease the chat ''lag'' you're talking about, and it had no downsides when i was using it.
Tried unchecking ''Delay suspicious chat messages'' or whatever it's called? Can't remember exactly what the option is called, but turning it off will decrease the chat ''lag'' you're talking about, and it had no downsides when i was using it.
This delay is as said only done on suspicious messages; in your average day conversations you will hardly or never see it happen. Disabling this option will have the downside that multi-message spams may not be fully blocked.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
Well, I unchecked the SpamSentry -> Options -> Channel -> Whisper option and reloaded my UI, had a friend whisper me + WIM popped up with his whisper. However if I recheck it and reload UI and he whispers me again WIM doesn't appear until I start a reply to him.
Anyone who isn't on friends/guild I will always miss their first whisper in WIM + usually their whisper entirely. Now if they whisper me a second time it will show up in WIM, but won't display the first whisper within the WIM window.
I did an unzip -l earlier this morning and saw that the paths were fixed. Thanks for taking care of this!
-- Scorpie
Odd, odd, haven't seen this when I tested with WIM. I'll reinstall WIM this weekend and see if I can reproduce the problem.
I had a spare hour so did some testing with the help of a friend. I ran only two addons during testing: WIM and SpamSentry. We have tried virtually every setup I could think off: guilded/unguilded on friendlist or not, using words that would trigger SpamSentry, etc. Even tried with various level settings, and played with some settings in WIM. In no way I was able to reproduce the problem you reported: the first tell going missing when someone whispers you.
I can only conclude that the problem is caused by either a very specific WIM-option, or by another addon. SpamSentry and WIM are working perfectly fine together as far as I can test.
[2008/05/13 19:35:13-2726-x4]: WhoLib-1.0-64386 (SpamSentry):501: Deformat-2.0: Bad argument #3 to `Deformat' (string expected, got nil)
---
PS: I do Translations into deDE for various other (Ace)Addons and Updated my SVN SpamSentry Version deDE Locals if you want i can commit them to SVN.
Haven't seen this error myself, but it looks as if it's caused by a version conflict: aka you're running an old version of WhoLib on one of your other addons.
Updated locales is always nice to have :) Unfortunately for you, the SpamSentry SVN is locked, so you can't upload it directly. If you send me a PM with the locale, or post it in this thread, I'll upload it to the SVN.
I have this too.
And SpamSentry is the only addon which has WhoLib of all addons I have.
After a busy day, hopefully peace and quiet is restored on the world of Azeroth :)
Anea
Well i can still upload even if you lock it...but i respect if you don't want other to mess with your Files but don't forget you can revert all unwanted changes everytime on SVN. SVN is made that many can work together on one Project.
PS: Attached my SpamSentry SVN Version (All deDE Files are Changed and the Toc File)
Changes:
Updated all deDE Files
Translated missing Strings
Changed deDE File Format to UTF-8 (can use now German Umlauts and ASCII Codes)
Tweak deDE Description in Toc File
Thanks for your work! I've updated SpamSentry with the new locales.
- The SpamSentry icon will now turn red when spam has been caught
- Fixed French localisation so that it will now correctly monitor guild-recruitment and looking-for-group channels
- Updated filters to fix a false positive
greets
Anea
- Fixed typo in German localisation
- Fixed small bug
- Updated filters
No big changes as you can see :)
I'm currently toying with Ace3 and modularity, and it's not unlikely that you'll be seeing an Ace3 rewrite of SpamSentry in the near future.
Might I recommend a dynamic white list? May cause more lag for unwhite listed but a larger improvement over all. Actions that would add people to the white list:
For the last one maybe do a time sorted list, anytime they say something they get moved back to the front of the list, that way active talkers stay on list. The last two items would reset each time you log on.
Even if you had to check each incoming name against 100 avatars that has to be exponentially less taxing than doing numerous regexp checks on everything they say, esp as you have to add more and more things to check for.
It's a fair question, but I have to disappoint you. Most if not all lag you experience in your chat is caused by the game client, not by SpamSentry. You can easily verify this by installing PerformanceFu and monitor the cpu-usage of SpamSentry. We are talking a scale of less then milliseconds for SpamSentry to process a chatmessage.
The only exception is when SpamSentry is holding a message to verify it's sender by a who-query. This however only happens when the message contains a fair number of spam-characteristics.
I once had a nice picture on the wikipage along with some text that explained in detail how SpamSentry handles text from incoming messages. I'll see if I can find it and repost the whole thing.
As for whitelists: no matter the alghoritm you use, it will be very liable to abuse.
Feel free to look into the core.lua file. The functions SS:SpamCheck1 and SS:SpamCheck2 have detailed documentation on what heuristics are used.
Anea
Tried unchecking ''Delay suspicious chat messages'' or whatever it's called? Can't remember exactly what the option is called, but turning it off will decrease the chat ''lag'' you're talking about, and it had no downsides when i was using it.
This delay is as said only done on suspicious messages; in your average day conversations you will hardly or never see it happen. Disabling this option will have the downside that multi-message spams may not be fully blocked.