Seeing the same as everyone else. Feed button is always showing. This really took me by surprise. I kept trying to feed my pet, but the button never went away.
I also have a mend pet button and don't want KOTJ to do this. At least add an option to revert to the previous behavior.
[2007/06/20 11:12:53-1178-x1]: KingOfTheJungle\KingOfTheJungle.lua:487: attempt to compare number with nil
AceAddon-2.0-40431 (Ace2):663: in function <Interface\AddOns\Ace2\AceAddon-2.0\AceAddon-2.0.lua:656>
<in C code>: ?
AceEvent-2.0-40601 (Ace2):232: in function `TriggerEvent'
AceEvent-2.0-40601 (Ace2):910: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:903>
---
Let me know if you keep getting this error in latest version, and repost error if it occurs, Thank you :)
Yeah I got mine to show up again by removing the add-on and reinstalling it. The Feed Pet Button is on all the time. I like Mend Pet so I'm not going to mess with that setting again. All I really need now is for the button to go away if my pet doesn't need to eat. That was the feature that sold me on KOTJ.
If you want to have the old style option, then you have to disable the Mend Pet button in the settings as mentioned earlier.
If you have Mend Pet enabled then the button will be persistent and never hide. This due to blizz not allowing to show/hide buttons in combat.
Default logic without Mend Pet is as follows :
- Show button when pet is unhappy or content and there is food and you are not in combat and there is a pet
Default logic with Mend Pet is :
- When in combat swap to Mend Pet, otherwise to Feed Pet
There will be some changes in the future like revive pet/call pet/dismiss pet, and i will see how those work with all in one button. Otherwise i might split those into 2 buttons. One Feed Pet and one Mend/Revive/Call/Dismiss. How things seem to be looking i think i am going to prefer the latter solution.
Stick to the official release if you don't want the *bloat*, as you call it. It works as it should and does what you want. Besides, this addon is not *only* a feed pet addon. It maybe in it's current state, but it is never intended that way. I'll make the functionality as optional as possible, but this still remains a development version and not a release version. Release versions can be found on the official website like curse, ui.wow or wowi.
I guess I'll have to figure out how to turn off the updating of KOTJ from the ace updater. It's a shame you aren't listening to your userbase on this. They don't want the extras, they want a feed pet addon and until recently KOTJ was the best. Good luck, and I enjoyed using your addon while it did what I wanted. Oh and if it isn't an official release then maybe the Ace Updater shouldn't be installing it. I shouldn't have to use yet another site, or another tool do get the official release of an Ace2 addon.
I guess I'll have to figure out how to turn off the updating of KOTJ from the ace updater. It's a shame you aren't listening to your userbase on this. They don't want the extras, they want a feed pet addon and until recently KOTJ was the best. Good luck, and I enjoyed using your addon while it did what I wanted.
This is a little harsh. The mod programmers here are donating their time/skills and aren't beholden to the user base. If the mod is good and useful, folks will use it... If not they won't. Not a big deal.
That said, I didn't realize the feed button being on the whole time was a feature lol. I've since switched to feed-o-matic to give it a shot but may come back to KOTJ in the future.
I don't think it was harsh, it was simply stating that I'll have to make sure that wowace doesn't update KOTJ because it seems to be picking up the development version of it, which means I have to re-download it from the mentioned sites. I am hoping there is a way to make the updater only download the official releases.
Now as a suggestion to the developer, perhaps if you made KOTJ have 2 hidden buttons that are overlayed one on top of the other. You keep the feed pet part the same as it was, and then just show the mend pet when in combat. Then there is no real button switching, just hiding and showing of the buttons which won't be blocked by Blizzard.
If pet happiness < x show feed button else hide feed button
If combat = true show mend pet button else hide mend pet button
Then just put both buttons in the exact same position on screen.
You can then add other stuff in the same way (all with a toggle) or as is done with the food for the various spells. Change the combat button to the portrait of your pet while in combat, and when you mouse over it, every useful thing while in combat could show. Bestial Wrath, Intimidate, Mend Pet, etc...
These are BETA addons you are updating and you should expect to see cutting edge features which may not be fully functional or bug-free. If this doesn't sound appealing for you, stop reading this page and update your addons through release versions from mod sites instead. Some addons are more beta than others.
I think you all just lack patience and take time to read what is said. All will be fully optional at a certain point, but it is in a stage of development that it is not. If you can't live with it, then just read the quote from samasnier.
Besides i don't get what you mean that i don't listen to my userbase. I clearly pointed out what i would do, and i did a lot of things for the userbase as well. Which i personally never needed. This also includes a Mend Pet feature for example. Fact is that in it's current state it is not optimal, and some people don't even want it. But you'll just have to wait till it is in a more refined state where it is optional. Patience my dear :) I need to go outside and see the sunshine as well now and then, next to playing WoW, and then some coding and studying as well.
It will be all ok, but this still remains a development version. And that is what many people forget.
It looks like ParserLib has been pulled from !!!StandaloneLibraries. As far as I can tell there's only one place in KOTJ using ParserLib. Here's what I used to switch it over to Parser-3.0:
PL:RegisterEvent("KOTJ", event, function(event, info)
if info.type == 'feedpet' and info.victim == ParserLib_SELF then
KingOfTheJungle:Chat(string.format(L["%s loves %s, mjummie."],UnitName("pet"),info.item))
end
end)
And in KingOfTheJungle.toc changed the X-Embeds and OptionalDeps from ParserLib to Parser-3.0. And Libs\ParserLib-1.1\ParserLib.lua to Libs\Parser-3.0\Parser-3.0.lua. I only run with the standalone libs though so I'm not sure if I've got that last bit right.
It looks like ParserLib has been pulled from !!!StandaloneLibraries. As far as I can tell there's only one place in KOTJ using ParserLib. Here's what I used to switch it over to Parser-3.0:
And in KingOfTheJungle.toc changed the X-Embeds and OptionalDeps from ParserLib to Parser-3.0. And Libs\ParserLib-1.1\ParserLib.lua to Libs\Parser-3.0\Parser-3.0.lua. I only run with the standalone libs though so I'm not sure if I've got that last bit right.
Were you having a problem with KOTJ? ParserLib-3.0 was written with ParserLib-1.0 included and designed to use ParselLib-1.0 when called for in an addon. I guess if beerke desires to change it he can test your code changes and implement them but it's not really required at this point.
Were you having a problem with KOTJ? ParserLib-3.0 was written with ParserLib-1.0 included and designed to use ParselLib-1.0 when called for in an addon. I guess if beerke desires to change it he can test your code changes and implement them but it's not really required at this point.
Yes, when I revert back to the version without my change I get this error. Although it looks like you're right about Parser-3.0 being backwards compatible, making the .toc change alone seems to be sufficient to fix the error.
I have never been able to get conjured mage food to work with Kotj - is there something I am missing? I have looked under the config options but frankly its kinda a mess with all the food groups and these itemids that are blank.
Have two hunters (one horde, one alliance) and both are currently getting an error with the feeding side of the mod. When the pet needs food, the food button fails to appear (I still get the 'x loves meat' message when I feed them manually). Opening the food setup screen gives this error;
[2007/08/07 15:47:24-81-x1]: FrameLib-1.0-39066 (KingOfTheJungle):266: Usage: KOTJFoodButton1Icon:SetPoint("point" [, region or nil] [, "relativePoint"] [, offsetX, offsetY])
FrameLib-1.0-39066 (KingOfTheJungle):266: in function `SetPoint'
FrameLib-1.0-39066 (KingOfTheJungle):209: in function `CreateTexture'
KingOfTheJungle\KingOfTheJungleUIFoods.lua:112: in function `KOTJUI_CreateFoodLists'
KingOfTheJungle\KingOfTheJungleUI.lua:25: in function `KOTJUI_Show'
KingOfTheJungle\KingOfTheJungle.lua:149: in function `func'
Dewdrop-2.0-44792 (FuBar):710: in function <...erface\AddOns\FuBar\libs\Dewdrop-2.0\Dewdrop-2.0.lua:649>
---
Any ideas?
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
I also have a mend pet button and don't want KOTJ to do this. At least add an option to revert to the previous behavior.
Let me know if you keep getting this error in latest version, and repost error if it occurs, Thank you :)
Yeah I got mine to show up again by removing the add-on and reinstalling it. The Feed Pet Button is on all the time. I like Mend Pet so I'm not going to mess with that setting again. All I really need now is for the button to go away if my pet doesn't need to eat. That was the feature that sold me on KOTJ.
Mollock
If you have Mend Pet enabled then the button will be persistent and never hide. This due to blizz not allowing to show/hide buttons in combat.
Default logic without Mend Pet is as follows :
- Show button when pet is unhappy or content and there is food and you are not in combat and there is a pet
Default logic with Mend Pet is :
- When in combat swap to Mend Pet, otherwise to Feed Pet
There will be some changes in the future like revive pet/call pet/dismiss pet, and i will see how those work with all in one button. Otherwise i might split those into 2 buttons. One Feed Pet and one Mend/Revive/Call/Dismiss. How things seem to be looking i think i am going to prefer the latter solution.
Remember this is a dev version :)
with option to not use, I am perfectly happy with just the feed pet action which is why I installed this nice addon.
That said, I didn't realize the feed button being on the whole time was a feature lol. I've since switched to feed-o-matic to give it a shot but may come back to KOTJ in the future.
Now as a suggestion to the developer, perhaps if you made KOTJ have 2 hidden buttons that are overlayed one on top of the other. You keep the feed pet part the same as it was, and then just show the mend pet when in combat. Then there is no real button switching, just hiding and showing of the buttons which won't be blocked by Blizzard.
If pet happiness < x show feed button else hide feed button
If combat = true show mend pet button else hide mend pet button
Then just put both buttons in the exact same position on screen.
You can then add other stuff in the same way (all with a toggle) or as is done with the food for the various spells. Change the combat button to the portrait of your pet while in combat, and when you mouse over it, every useful thing while in combat could show. Bestial Wrath, Intimidate, Mend Pet, etc...
Besides i don't get what you mean that i don't listen to my userbase. I clearly pointed out what i would do, and i did a lot of things for the userbase as well. Which i personally never needed. This also includes a Mend Pet feature for example. Fact is that in it's current state it is not optimal, and some people don't even want it. But you'll just have to wait till it is in a more refined state where it is optional. Patience my dear :) I need to go outside and see the sunshine as well now and then, next to playing WoW, and then some coding and studying as well.
It will be all ok, but this still remains a development version. And that is what many people forget.
In KingOfTheJungle.lua
Removed:
local PL = ParserLib:GetInstance("1.1")Changed from:
KingOfTheJungle = AceLibrary("AceAddon-2.0"):new("AceConsole-2.0", "AceDB-2.0","AceDebug-2.0", "AceEvent-2.0")To:
KingOfTheJungle = AceLibrary("AceAddon-2.0"):new("AceConsole-2.0", "AceDB-2.0","AceDebug-2.0", "AceEvent-2.0", "Parser-3.0")And changed from:
PL:RegisterEvent("KOTJ", event, function(event, info) if info.type == 'feedpet' and info.victim == ParserLib_SELF then KingOfTheJungle:Chat(string.format(L["%s loves %s, mjummie."],UnitName("pet"),info.item)) end end)To:
self:RegisterParserEvent({eventType = "Feed Pet", recipientID = "player"}, function(info) KingOfTheJungle:Chat(string.format(L["%s loves %s, mjummie."],UnitName("pet"),info.item)) end)And in KingOfTheJungle.toc changed the X-Embeds and OptionalDeps from ParserLib to Parser-3.0. And Libs\ParserLib-1.1\ParserLib.lua to Libs\Parser-3.0\Parser-3.0.lua. I only run with the standalone libs though so I'm not sure if I've got that last bit right.
Were you having a problem with KOTJ? ParserLib-3.0 was written with ParserLib-1.0 included and designed to use ParselLib-1.0 when called for in an addon. I guess if beerke desires to change it he can test your code changes and implement them but it's not really required at this point.
Yes, when I revert back to the version without my change I get this error. Although it looks like you're right about Parser-3.0 being backwards compatible, making the .toc change alone seems to be sufficient to fix the error.
Furthermore, I can't find any documention.
Pete
[2007/08/07 15:47:24-81-x1]: FrameLib-1.0-39066 (KingOfTheJungle):266: Usage: KOTJFoodButton1Icon:SetPoint("point" [, region or nil] [, "relativePoint"] [, offsetX, offsetY])
FrameLib-1.0-39066 (KingOfTheJungle):266: in function `SetPoint'
FrameLib-1.0-39066 (KingOfTheJungle):209: in function `CreateTexture'
KingOfTheJungle\KingOfTheJungleUIFoods.lua:112: in function `KOTJUI_CreateFoodLists'
KingOfTheJungle\KingOfTheJungleUI.lua:25: in function `KOTJUI_Show'
KingOfTheJungle\KingOfTheJungle.lua:149: in function `func'
Dewdrop-2.0-44792 (FuBar):710: in function <...erface\AddOns\FuBar\libs\Dewdrop-2.0\Dewdrop-2.0.lua:649>
---
Any ideas?