I would like to have a feature that shortens chat channel names so [Guild] would become [G].
The following mods can both do that with their "channelnames.lua" modules (run one or the other): SimpleChatMods and BasicChatMods. BasicChatMods is a slightly code-updated version of the first one with fewer modules; it lacks Simple's "best in class" playernames.lua coloring module and a couple other ones.
Just comment out the modules that Minimalist duplicates in the TOC of whichever of the above you use and it will work.
On the nil bug:
GetGossipAvailableQuests returns title1, level1, islowevel1, title2, level2, islowlevel2, [....] in this patch.
Now, this is nice, but IsLowLevel is either nil or 1. This means that table.getn/#t don't work for getting the size of this table now. After working on several methods for dealing with this, including using the tcount table helper from wowwiki, I think the best method is just to assume a quest giver won't have more than 8 quests in a window and set the for loop that displays quest levels in gossip windows to do a for i=1,24,3 loop that breaks the first time i is nil (meaning there is no title).
On the taint:
I guess its probably:
function Minimalist:MinQLOn()
self:Hook("GetQuestLogTitle", true)
self:RegisterEvent("QUEST_GREETING")
self:GHOn()
end
My guess is GetQuestLogTitle is now protected and needs a securehook. Ill try out both of these solutions when I get home today and maybe push a fix tonight.
Yes
ver 55515 as of my posting date off the svn will update tonight as there is an update to the one I am using and report back..
Thrumbar
Good, I replaced the old ctmod based way of doing QuestLog levels that replaced a blizz function with a version based on hooking questlog_update. If you have any more Minimalist taint after that, please let me know.
I like minimalist's auto-repair option, its helpful but to a degree though. With 2.3 especially there is in my opinion a greater incentive to repair exclusively with vendors to which I am Exalted. I'd like an option perhaps to specify that auto-repair should only happen if at or above a certain reputation.
I have noticed a small issue, when speaking to certain NPCs that are both quest-related and vendors/grypho riders the mod will auto-skip the gossip. Its only minorly annoying as I realize whats happening and have to go temporarily disable the mod's auto-skip setting while I turn in/accept a quest.
This has happened frequently with gyphon master related npcs, not certain if you feel its worth addressing and temporarily not skipping the conversation :).
At this point, everything that can really taint has been fixed. If you see messages that indicate minimalist is tainting, its probably a just the chat functions get blamed for upstream taint from execution.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
/sign
The following mods can both do that with their "channelnames.lua" modules (run one or the other): SimpleChatMods and BasicChatMods. BasicChatMods is a slightly code-updated version of the first one with fewer modules; it lacks Simple's "best in class" playernames.lua coloring module and a couple other ones.
Just comment out the modules that Minimalist duplicates in the TOC of whichever of the above you use and it will work.
That option is already in minimalist..
Type: /min
select: Chat
Check: Reduce chat clutter
This shortens channels to 1,2,3,4 etc and changes Guild to (G)
No need to use other chat progs to do this as Min has it taken care of...
That's what I get for never (ever) having enabled or considered that option in Minimalist ;). Yes, it has that option.
And a lot of taint
On the nil bug:
GetGossipAvailableQuests returns title1, level1, islowevel1, title2, level2, islowlevel2, [....] in this patch.
Now, this is nice, but IsLowLevel is either nil or 1. This means that table.getn/#t don't work for getting the size of this table now. After working on several methods for dealing with this, including using the tcount table helper from wowwiki, I think the best method is just to assume a quest giver won't have more than 8 quests in a window and set the for loop that displays quest levels in gossip windows to do a for i=1,24,3 loop that breaks the first time i is nil (meaning there is no title).
On the taint:
I guess its probably:
function Minimalist:MinQLOn()
self:Hook("GetQuestLogTitle", true)
self:RegisterEvent("QUEST_GREETING")
self:GHOn()
end
My guess is GetQuestLogTitle is now protected and needs a securehook. Ill try out both of these solutions when I get home today and maybe push a fix tonight.
Gettinf taint on minimalist attached taint log.
Using the very latest SVN?
still a lot of taint from min..
Yes
ver 55515 as of my posting date off the svn will update tonight as there is an update to the one I am using and report back..
Thrumbar
Good, I replaced the old ctmod based way of doing QuestLog levels that replaced a blizz function with a version based on hooking questlog_update. If you have any more Minimalist taint after that, please let me know.
To be honest, I haven't looked at how the guild stuff works yet. Ill take a looksee
Yes, I know its anal retentive. :-p
Getting buff timers reworked are next on the todo after I track down the last pieces of taint.
This has happened frequently with gyphon master related npcs, not certain if you feel its worth addressing and temporarily not skipping the conversation :).