Authors CurseForge

No official or unofficial topic here, but the takeover-author (Bigzero) posts here, so putting this up.

The mod hasn't worked at all since WoW 2.3 went in; the icon shows up on the dressing room frame (in the top right corner), but its not clickable and the Dewdrop menus are nowhere to be found.

Some recent commits have tried to fix this. But logging in today after enabling the updated mod for the first time since r56071 (Nov. 26), the following errors are thrown up. Using r56633 (Dec. 5), standalone libraries, USEng server/client. Also, going back into the dressing room frame after the errors occur, the icon is still not clickable/usable:

"AceLocale-2.2-40629 (Ace2):487: AceLocale(GlowFoSho): Translation \"Clear\" does not exist.\nGlowFoSho-1.3\\GlowFoSho.lua:163: in function <Interface\\AddOns\\GlowFoSho\\GlowFoSho.lua:107>\n<in C code>: in function `pcall'\nAceAddon-2.0-46764 (Ace2):24: in function <Interface\\AddOns\\Ace2\\AceAddon-2.0\\AceAddon-2.0.lua:23>\nAceAddon-2.0-46764 (Ace2):999: in function `ManualEnable'\nAceAddon-2.0-46764 (Ace2):927: in function <Interface\\AddOns\\Ace2\\AceAddon-2.0\\AceAddon-2.0.lua:920>\n<in C code>: ?\nAceEvent-2.0-56171 (Ace2):263: in function `TriggerEvent'\nAceEvent-2.0-56171 (Ace2):914: in function <Interface\\AddOns\\Ace2\\AceEvent-2.0\\AceEvent-2.0.lua:907>"

"AceLocale-2.2-40629 (Ace2):487: AceLocale(GlowFoSho): Translation \"Removes enchant from the weapon in the dressing room.\" does not exist.\nGlowFoSho-1.3\\GlowFoSho.lua:164: in function <Interface\\AddOns\\GlowFoSho\\GlowFoSho.lua:107>\n<in C code>: in function `pcall'\nAceAddon-2.0-46764 (Ace2):24: in function <Interface\\AddOns\\Ace2\\AceAddon-2.0\\AceAddon-2.0.lua:23>\nAceAddon-2.0-46764 (Ace2):999: in function `ManualEnable'\nAceAddon-2.0-46764 (Ace2):927: in function <Interface\\AddOns\\Ace2\\AceAddon-2.0\\AceAddon-2.0.lua:920>\n<in C code>: ?\nAceEvent-2.0-56171 (Ace2):263: in function `TriggerEvent'\nAceEvent-2.0-56171 (Ace2):914: in function <Interface\\AddOns\\Ace2\\AceEvent-2.0\\AceEvent-2.0.lua:907>"

The two localization errors are relatively trivial to fix
(although I can't understand how they don't show up for the author when he tests the addon)

["Clear"] = true,
["Removes enchant from the weapon in the dressing room."] = true,

need to be added to Locale-enUS.lua.

However, even after fixing the localization I also have the problem with
the GlowFoSho icon being "dead" and it's not an embeds problem.
Libraries are declared and loaded correctly.

The above concern this package:
http://files.wowace.com/GlowFoSho/GlowFoSho-r56633.zip

The 2 localization strings have been added to r56638.

A little followup on the post above since the unclickable button problem remains.

1. I'm also using CloseUp mod and WoWEquip mod.
2. The issue is solved if you change GlowFoSho.lua, line 94:
from

gfsbutton = CreateFrame("Button","GlowFoSho_Button",UIParent)

to

gfsbutton = CreateFrame("Button","GlowFoSho_Button",DressUpFrame)

Same could be achieved by Disabling/Enabling the addon
since the OnEnable code parents it to DressUpFrame unlike the OnInitialize code.

Sorry about the mess with GlowFoSho since 2.3, especially in the past 2 days.

Localizations have been fixed. I'm not really sure how they disappeared in the first place.

As far as the icon being unclickable, that should have been fixed as of the last update. I can't really test it, since it was working for me in the first place, but the problem was that SetParent command would set the frame strata to that of the parent (I wasn't aware of that). Now the SetFrameStrata command is after SetParent, so it should work fine.

It's a great little addon and your work is much appreciated it :)

Now that we have your ear, I've noticed something I'm not sure it's a cosmetic bug,
or something that is not possible under api.

It affects dual-wielders.
When for example my warrior has a sword in main-hand and a shield in off-hand.
If I go from the menu to change the enchant,
it equips the sword to the off-hand removing the shield (in dressup frame)
and shows the new glow on the off-hand weapon.

Same happens with my rogue.

Quote from Astaldo »

It's a great little addon and your work is much appreciated it :)

Now that we have your ear, I've noticed something I'm not sure it's a cosmetic bug,
or something that is not possible under api.

It affects dual-wielders.
When for example my warrior has a sword in main-hand and a shield in off-hand.
If I go from the menu to change the enchant,
it equips the sword to the off-hand removing the shield (in dressup frame)
and shows the new glow on the off-hand weapon.

Same happens with my rogue.

r56660 is finally working.

Somewhat. I am also running into the same problem as above. Access an enchant in the Dewdrop list. When you click it, instead of the glow being applied to the main hand weapon, the mod duplicates the main hand weapon in the off-hand (removing what you had in the off-hand) and applies the chant glow there. Can make it difficult to see the glow. Don't recall this happening pre-2.3. Tested on a low level rogue.

I'll see what I can do about the offhand, but as far as I remember you can't really control where the weapon appears in the dressing room. The enchant will always be applied and shown for the weapon that was ctrl-clicked last (or your main-hand weapon if no weapon was ctrl-clicked).

Quote from bigzero »

I'll see what I can do about the offhand, but as far as I remember you can't really control where the weapon appears in the dressing room. The enchant will always be applied and shown for the weapon that was ctrl-clicked last (or your main-hand weapon if no weapon was ctrl-clicked).

That's good enough for me.
It seems you're right... to make it apply to the weapon of choice you just have to ctrl-click it last.
Thanks.

i just updated 5mins ago and im getting this error.

Error: AceHook-2.1: Attempt to hook secure function "ChatFrame_MessageEventHandler". Use `SecureHook' or add `true' to the argument list to override.
File: Interface\AddOns\GlowFoSho\GlowFoSho.lua
Line: 202
Count: 1

before you ask no i did not change anything i actually forgot to even try :).

Thanks for reporting. I wasn't getting the error myself, but I fixed it. Let me know if something goes wrong again.

error is gone now that for the quick responce i noticed that you did some code changing, im assuming this was to make it more stable of sumthing, although i can still add my little change :).

Hmm.. installed this addon but didnt see anything.. Maybe it doesnt work with outfitter?

no it does i use outfitter but outfitter dosnt affect the Dressing Room, you know when you shift-click on a item to see what it looks like.

Quote from dragonis »

error is gone now that for the quick responce i noticed that you did some code changing, im assuming this was to make it more stable of sumthing, although i can still add my little change :).

I guess I forgot to mention it (it's in the commit messages on svn or the change log in WAU). I added an over-chat "enchanting" feature. whisper someone with the mod !glow <weapon link> <enchant link> and it will whisper them back with that weapon enchanted.

Also I was trying to make things work with other languages, so that's where a bunch of code came in. Not completely positive that really works though.

Hmm.. installed this addon but didnt see anything.. Maybe it doesnt work with outfitter?

Are you sure there's no icon in the top-right corner of the Dressing room? try typing /glowfosho and see what that gives you. If nothing comes up the mod isn't loading.

i think he/she is looking for the icon in the character frame.

with the current 2.4 version of glowfosho, you cannot link any items into trade/guild/party etc with enchants on them, you can try but the enchant will not show.

any possible fix?

i just updated today and there seems to be a change in regards to spell info ill have a look later and see if all is well.

Quote from dragonis »

with the current 2.4 version of glowfosho, you cannot link any items into trade/guild/party etc with enchants on them, you can try but the enchant will not show.

Maybe this addon will help with that problem: LinkBugFixer