JJSheets, have my babies :P or let me have yours whichever you prefer.
But... I don't want babies...
I've waited for many many moons for this level of customization. Thank you! Oh also, I would say, we could use a unit frames mod with this level of customization too! CreateFrame() is a wonderful thing, when given a waterfall config and on the fly creating your unit frames would be simply uber :)
Pitbull. I also suggest Aloft, but it isn't a unit frame mod, but a nameplate mod.
Quick suggestion added: can you possibly add a text substitution that can pull spell rank so we can added a text sub that says like Rank [rank]
A good idea. I'll add it to my list.
Quote from Locked »
Quote from jjsheets »
If enough people yell about it, I will also make the pet bar available (I hear some of you non Hunters/Warlocks would like to make use of it).
/y This is me yelling to make the pet bar available
Please.
Okay... pretty sure that's at least two yells for it. Adding it to the list also... No guarantees when it gets in though.
JJSheets, possible bug, or maybe it's simply my overexhuberant use of the bars already :P. Have 28 buttons i have setup that are set as a stance bar so they switch based on my druid stances and everytime i switch i get a 1-2 second pause while it's shoving in those buttons.
Also, did you accidentally leave a debugging mode turned on? i'm getting all this spell data everytime i cast something (cdspl21: 504007.66, 1, 1) bunch of stuff like that?
With regards to performance, it seems that it updates the usable-color (no mana/energy) very slowly. For a class with energy (druid/rogue) that is problematic as energy regens very fast. I don't really seem to have performance problems as such. So it may just be a matter of your code not updating the status often enough.
There is also a bug that's not as easy to report because it's not consistently reproducible. When putting macros on a button, I have several times suddenly seen a different macro in that button. One time it was a macro that was also on another button. Another time it was a yet unused macro. I can't really say what is causing it. But I think it happened after shapeshifting. Shapeshifting again did not resolve the bug. I had to manually replace the macro again.
Getting the following error when zoning (cross-continent):
Message: ..\AddOns\InfiniBar\IB_Standard.lua line 1040:
attempt to index field 'Proxy' (a nil value)
Debug:
Ace2\AceEvent-2.0\AceEvent-2.0.lua:321: TriggerEvent()
Ace2\AceEvent-2.0\AceEvent-2.0.lua:997:
Ace2\AceEvent-2.0\AceEvent-2.0.lua:990
Yep, I left some debugging code on... was using it to figure out why the Cooldowns were flickering. Gone now.
Also the bug on line 1040 should be fixed. If not, let me know and I'll kill it again.
Macros are interesting. I'll have to check the Blizzard SecureActionButton code to be sure, but I may be able to store macros by name, rather than by number. Blizzard alphabetizes macros every time you create a new one, so macros tend to need replacing in InfiniBar at the moment. I'll see what I can do, though it probably won't be until after 5:00 CST tonight.
really nice progression! :) Just found a more or less serious bug when I configured my bars. I selected a "state setting" (tested several stances with the same result) for a bar, but then the whole config screen was suddenly empty and I couldnt access it anymore by clicking on the FuBar or minimap button. Relogging fixes this!
Now include alt selfcast and this is my mod! ;)
PS: just found out that I can only choose "state setting" for my first 2 bars only.(I have 4 besides the micro and bagbar) The state settings for my third and fourth bar just display "actionbar1" for both. When I select this then the config window is empty and I cant access it anymore as I wrote above.
Abilities that work on "next melee" such as druid's Maul do on Blizzard's bars get a "checked" visual appearence so that you can see it is activated. This seems to be missing from InfiniBar.
Also, would you mind giving a short introduction to the "State Settings" part? I must admit that I simply don't understand what it does. I have a feeling I could do some neat things with it and I would love to test it. That's of course only if you feel it is ready for testing yet. :)
Abilities that work on "next melee" such as druid's Maul do on Blizzard's bars get a "checked" visual appearence so that you can see it is activated. This seems to be missing from InfiniBar.
Was just stopping in to report this as well. Noticed it on my Hunter alt with Raptor Strike.
JJSheets, possible bug, or maybe it's simply my overexhuberant use of the bars already :P. Have 28 buttons i have setup that are set as a stance bar so they switch based on my druid stances and everytime i switch i get a 1-2 second pause while it's shoving in those buttons.
I'm having the same problem. Haven't tested with stances yet, but it does that for my CTRL-page.
Unfortunately, the spike is big enough to prevent me from using this on my main - can't afford that lag for stuff like fear-dancing. Apart from that, I'm all over this addon - best bar mod ever. I'm loving it on my alts.
Another, significantly less critical issue I've come across, is that there seems to be no feedback on button presses. Generally bar mods have had some sort of graphic overlay as soon as you're pressing the key (independant of actual skill activation). Sometimes I'm in doubt if my key-press actually registered or not.
It's not a huge deal, and I imagine it'd only worsen the performance issues, so... might not be worth it.
Oh, and a feature request:
For starters, it'd be awesome to have a list somewhere of which text subs (like [key] and [itemcount]) are actually available. Maybe I'm just an idiot and missed it, or maybe there aren't others than those two yet. A tooltip, or something, in the UI would be perfect.
In addition to that, one text sub that would be specifically useful for me: Would it be possible to put in the cooldown count for a skill other than the one in the button?
I have a macro that uses both Revenge and Shield Block. I like having it display Revenge so that I can always see when it's available, but it'd be awesome if I could also see my Shield Block cooldown on the same button.
Again, awesome, awesome addon. Looking forward to future versions. Hope something can be done about that page-switching lag.
Yea, the paging lag is the only thing from stopping me from completely. I can deal with no pet bar, making macros for it will do, but the 1-2 seconds of lag everytime I page is making me lag too much to use in a combat situation.
Yea, the paging lag is the only thing from stopping me from completely. I can deal with no pet bar, making macros for it will do, but the 1-2 seconds of lag everytime I page is making me lag too much to use in a combat situation.
I believe I have tracked down the cause of this, though the fix may take a while. Most recent version uploaded has dreamlayout and borderless button styles (don't use with cyCircled). It has a fix for macros changing around when you add/remove macros (calls them by name now instead of by number), a fix for some fade in and fade out bugs, and I hope a fix for the issues when hearthing/teleporting across zones.
Edit: This error also occurs after deleting a macro that is on a button. I had to manually delete it from the saved variables file to stop the error spam. :)
if have a problem.. i use omnicc and barpaging (shift,ctrl and stealth)
now when i use my hearthstone on ctrl+2, i release ctrl and see the cooldown on my "2" button :(
if have a problem.. i use omnicc and barpaging (shift,ctrl and stealth)
now when i use my hearthstone on ctrl+2, i release ctrl and see the cooldown on my "2" button :(
I have seen something similar. A button for a spell that has no cooldown suddenly showed a long cooldown (1 minute or so) ticking down. I assume it was simply showing the cooldown for the wrong button - tough I am not sure which button it should have shown cooldown for.
I used to use discord so this is looking pretty appealing to me. I'll try it once you have the code to hide bliz default bars (it's a must).
That's already implemented. You can also have InfiniBar control the micro-menubar and the bag-bar. This works fine with one small caveat; make the bag/menu-bars before hiding the main menu - otherwise they will be hidden (though only until next UI reload, I think).
Are there any guide to how to set basic things up? Like others here in the thread, I'm having difficulties figureing out what the different settings mean. What are the actionbar1-6 used for? Are they linked to the State Definitions (the slider you can set to 1 though 6?
Basically, what I am aiming for, is to make 12 buttons for each form on my druid. So, if I am in catform, I have a set of 12 buttons, if Im in bearform, another set - but placed at the same position on the screen.
Also, I would like to have two sets of "default" buttons for my hunter - one set with ranged abilities, and one with melee abilities. I figure that this is possible to make - but I cant bend my mind enough to accomplish it.
Any help, or a link to a guide/tutorial would be great!
I have one more suggestion that would make this perfect. Anyway or are you soon to add profiles? I logged on my other characters to be sad to see that my settings didnt save for others to use. If this were to be put in it would be great. (didnt look to see if anyone asked about this so sorry if this is repeat request.)
Yea, the paging lag is the only thing from stopping me from completely. I can deal with no pet bar, making macros for it will do, but the 1-2 seconds of lag everytime I page is making me lag too much to use in a combat situation.
I believe I have tracked down the cause of this, though the fix may take a while. Most recent version uploaded has dreamlayout and borderless button styles (don't use with cyCircled). It has a fix for macros changing around when you add/remove macros (calls them by name now instead of by number), a fix for some fade in and fade out bugs, and I hope a fix for the issues when hearthing/teleporting across zones.
As of r32354, I'm experiencing zero lag. Awesome job! :D
This easily secures InfiniBar as my favorite bar addon. Thank you very much :)
Few minor issues that I can think of:
I like the whole "green border around buffs" thing. I also like CyCircled. The two don't seem to play well together - can anything be done about that?
Cooldowns seem to ignore page switching now - at least with CTRL-paging. I haven't had a chance to test stances yet. I don't think this used to be a problem? Right now, if I use a skill on my main bar, that skill's cooldown is also displayed on my CTRL-bar. If I use the skill on the CTRL-bar, its own cooldown is then temporarily displayed until my next page switch, at which point the main bar's cooldowns seem to take over again.
I'm getting some odd behaviour with one of my macros - but not others. With the problematic macro, the icon is never shown on my bars (but it's there - I can drag it off the button and it'll show under my mouse), and if I mouse over it, I get this error:
InfiniBar-1.0\MacroSupport.lua:59: bad argument #2 to 'strsplit' (string expected, got nil)
/y This is me yelling to make the pet bar available
Please.
But... I don't want babies...
Pitbull. I also suggest Aloft, but it isn't a unit frame mod, but a nameplate mod.
A good idea. I'll add it to my list.
Okay... pretty sure that's at least two yells for it. Adding it to the list also... No guarantees when it gets in though.
Also, did you accidentally leave a debugging mode turned on? i'm getting all this spell data everytime i cast something (cdspl21: 504007.66, 1, 1) bunch of stuff like that?
With regards to performance, it seems that it updates the usable-color (no mana/energy) very slowly. For a class with energy (druid/rogue) that is problematic as energy regens very fast. I don't really seem to have performance problems as such. So it may just be a matter of your code not updating the status often enough.
There is also a bug that's not as easy to report because it's not consistently reproducible. When putting macros on a button, I have several times suddenly seen a different macro in that button. One time it was a macro that was also on another button. Another time it was a yet unused macro. I can't really say what is causing it. But I think it happened after shapeshifting. Shapeshifting again did not resolve the bug. I had to manually replace the macro again.
Message: ..\AddOns\InfiniBar\IB_Standard.lua line 1040:
attempt to index field 'Proxy' (a nil value)
Debug:
Ace2\AceEvent-2.0\AceEvent-2.0.lua:321: TriggerEvent()
Ace2\AceEvent-2.0\AceEvent-2.0.lua:997:
Ace2\AceEvent-2.0\AceEvent-2.0.lua:990
Also the bug on line 1040 should be fixed. If not, let me know and I'll kill it again.
Macros are interesting. I'll have to check the Blizzard SecureActionButton code to be sure, but I may be able to store macros by name, rather than by number. Blizzard alphabetizes macros every time you create a new one, so macros tend to need replacing in InfiniBar at the moment. I'll see what I can do, though it probably won't be until after 5:00 CST tonight.
Most recent revision is 32243.
really nice progression! :) Just found a more or less serious bug when I configured my bars. I selected a "state setting" (tested several stances with the same result) for a bar, but then the whole config screen was suddenly empty and I couldnt access it anymore by clicking on the FuBar or minimap button. Relogging fixes this!
Now include alt selfcast and this is my mod! ;)
PS: just found out that I can only choose "state setting" for my first 2 bars only.(I have 4 besides the micro and bagbar) The state settings for my third and fourth bar just display "actionbar1" for both. When I select this then the config window is empty and I cant access it anymore as I wrote above.
Also, would you mind giving a short introduction to the "State Settings" part? I must admit that I simply don't understand what it does. I have a feeling I could do some neat things with it and I would love to test it. That's of course only if you feel it is ready for testing yet. :)
Was just stopping in to report this as well. Noticed it on my Hunter alt with Raptor Strike.
I'm having the same problem. Haven't tested with stances yet, but it does that for my CTRL-page.
Unfortunately, the spike is big enough to prevent me from using this on my main - can't afford that lag for stuff like fear-dancing. Apart from that, I'm all over this addon - best bar mod ever. I'm loving it on my alts.
Another, significantly less critical issue I've come across, is that there seems to be no feedback on button presses. Generally bar mods have had some sort of graphic overlay as soon as you're pressing the key (independant of actual skill activation). Sometimes I'm in doubt if my key-press actually registered or not.
It's not a huge deal, and I imagine it'd only worsen the performance issues, so... might not be worth it.
Oh, and a feature request:
For starters, it'd be awesome to have a list somewhere of which text subs (like [key] and [itemcount]) are actually available. Maybe I'm just an idiot and missed it, or maybe there aren't others than those two yet. A tooltip, or something, in the UI would be perfect.
In addition to that, one text sub that would be specifically useful for me: Would it be possible to put in the cooldown count for a skill other than the one in the button?
I have a macro that uses both Revenge and Shield Block. I like having it display Revenge so that I can always see when it's available, but it'd be awesome if I could also see my Shield Block cooldown on the same button.
Again, awesome, awesome addon. Looking forward to future versions. Hope something can be done about that page-switching lag.
I believe I have tracked down the cause of this, though the fix may take a while. Most recent version uploaded has dreamlayout and borderless button styles (don't use with cyCircled). It has a fix for macros changing around when you add/remove macros (calls them by name now instead of by number), a fix for some fade in and fade out bugs, and I hope a fix for the issues when hearthing/teleporting across zones.
Message: ..\AddOns\InfiniBar\MacroSupport.lua line 57:
bad argument #2 to 'strsplit' (string expected, got nil)
Debug:
[C]: ?
[C]: strsplit()
InfiniBar\MacroSupport.lua:57: IB_GetEffectiveMacroInfo()
InfiniBar\IB_Standard.lua:1298: HighlightBuff()
InfiniBar\IB_Standard.lua:1114:
InfiniBar\IB_Standard.lua:1096
InfiniBar\IB_Standard.lua:282:
InfiniBar\IB_Standard.lua:281
[C]: SetAttribute()
InfiniBar\IB_Standard.lua:706: UpdateButtonState()
InfiniBar\IB_Standard.lua:629: UpdateAllButtonsStates()
InfiniBar\IB_Standard.lua:218: EnableBar()
InfiniBar\IB_Core.lua:168: OnProfileEnable()
InfiniBar\IB_Core.lua:139:
InfiniBar\IB_Core.lua:133
Edit: This error also occurs after deleting a macro that is on a button. I had to manually delete it from the saved variables file to stop the error spam. :)
now when i use my hearthstone on ctrl+2, i release ctrl and see the cooldown on my "2" button :(
I have seen something similar. A button for a spell that has no cooldown suddenly showed a long cooldown (1 minute or so) ticking down. I assume it was simply showing the cooldown for the wrong button - tough I am not sure which button it should have shown cooldown for.
That's already implemented. You can also have InfiniBar control the micro-menubar and the bag-bar. This works fine with one small caveat; make the bag/menu-bars before hiding the main menu - otherwise they will be hidden (though only until next UI reload, I think).
Basically, what I am aiming for, is to make 12 buttons for each form on my druid. So, if I am in catform, I have a set of 12 buttons, if Im in bearform, another set - but placed at the same position on the screen.
Also, I would like to have two sets of "default" buttons for my hunter - one set with ranged abilities, and one with melee abilities. I figure that this is possible to make - but I cant bend my mind enough to accomplish it.
Any help, or a link to a guide/tutorial would be great!
As of r32354, I'm experiencing zero lag. Awesome job! :D
This easily secures InfiniBar as my favorite bar addon. Thank you very much :)
Few minor issues that I can think of:
I like the whole "green border around buffs" thing. I also like CyCircled. The two don't seem to play well together - can anything be done about that?
Cooldowns seem to ignore page switching now - at least with CTRL-paging. I haven't had a chance to test stances yet. I don't think this used to be a problem? Right now, if I use a skill on my main bar, that skill's cooldown is also displayed on my CTRL-bar. If I use the skill on the CTRL-bar, its own cooldown is then temporarily displayed until my next page switch, at which point the main bar's cooldowns seem to take over again.
I'm getting some odd behaviour with one of my macros - but not others. With the problematic macro, the icon is never shown on my bars (but it's there - I can drag it off the button and it'll show under my mouse), and if I mouse over it, I get this error:
Here's the problematic macro:
Here's another macro, which works just fine:
I'll post more later, when I think of it. Thanks again for the awesome work! :)