I noticed some thingies;
- The fading didnt work.
- If you set the actionbar pages to 1 it gets wonky after you press a modifier with modifier-swap on.
- I set Shift Pages, Control Pages and Alt Pages. Control doesnt page.
- When I hold shift and press a keybind (say, 1) it doesnt work. clicking the button at that time neither works.
- When selecting the layout the values are 0 but when you apply that layout (with 0) it gives you an error about it being nil.
- I think it would be easier to set the values to 36, -36 and the number of cols/rows to the number of buttons in the bar automatically when you select the layout, for horizontal and vertical. (haven't checked out the circular yet :))
Thats it for now I think. Otherwise great addon :o
I suppose I ought to make the option of alt, shift, control, right mouse buttton as self cast.
- As someone above suggested please an option to hide the standard blizz bar :)
As soon as I program in features for taking over the bag bar and main menu bar. Might be a day or two.
- possibility to hide a certain bar in a certain stance. (I use a lot of potions and items in casterform, but since
druids in animal form can use that it would be nice to fade a bar which is holding my potions and stuff, out)
I know I can do this in combat without the fading... and that's likely how I'll do it. If I can figure a good way to do fading in and out in combat it'll even look nice.
Quote from Wesslen »
"Show if player is not at full health or mana (if player has mana), or if target is friendly and not at full health, or the bar is being moused over."
Obviously this is something that you want during combat, so I'm not certain how easy it'll be to do this. I do like the idea though, and will see if I can do it. :)
Quote from Vangual »
- Allow the user to enter macrotext himself, not just reference to the (limited amount) macros from the main game /macro interface.
This has been a planned feature pretty much since I first started on InfiniBar. As soon as I can get a multiline text box in waterfall, this is going in.
Quote from Industrial »
I noticed some thingies;
- The fading didnt work.
"Show out of Combat" option now no longer fades in or out, it merely hides and shows. To make this look right, I'd have to do a major hack job, so for now, fading won't be working with this option. Once I can figure a good way to fade in and out during combat, it's going in.
- If you set the actionbar pages to 1 it gets wonky after you press a modifier with modifier-swap on.
Can't reproduce this... seems to work fine to me. Though I will say that waterfall likes to confuse slider numbers between sliders.
- I set Shift Pages, Control Pages and Alt Pages. Control doesnt page.
Fixed. It helps to spell 'ctrl' properly. :)
- When I hold shift and press a keybind (say, 1) it doesnt work. clicking the button at that time neither works.
Okay... still trying to figure out why this is happening, but at least I'm seeing it. :) I think it's related to keybinds.
- When selecting the layout the values are 0 but when you apply that layout (with 0) it gives you an error about it being nil.
- I think it would be easier to set the values to 36, -36 and the number of cols/rows to the number of buttons in the bar automatically when you select the layout, for horizontal and vertical. (haven't checked out the circular yet :))
The GUI is getting a redesign soon. I'll be fixing this and more when that happens.
Would it be possible to have the bars chance their page on other buttons than ctrl/alt/shift? Doing it with the middle mouse button would be really useful, so you wouldn't have to press two buttons with the same hand if you have keybindings.
I've already tried to hack the code myself, but without success.
When you drag a button with the button unlocked, it will not go to where it should . Instead, it will go to where the bottom right corner is next to the top left corner before you let go when dragging it.
I have having the same problem as Locked is with the button dragging. Now that I've figured out the manual settings through the config it's okay though. I wasn't hitting Return after each filling in a field to get the positioning to take effect. Industrial's comment about 36/-36 helped me make the leap too!
The scale slider for the buttons seems to be working in .05 increments but only shows the tenths digit. So you get two notches on the slider displaying .9 that I believe are .95 and then .9.
My only additional feature request beyond what others have already mentioned is, I would like checkbox to set a bar to only show on mouse over. Being able to check that and "show out of combat" would be great for a profession bar I don't want to see unless I want to use them and I don't want popping up if I'm mousing around in combat.
Looks good so far, the one thing that would really make the difference for me would be context paging (change page to X if target friendly, change page to Y if target is enemy). As far as I can tell no other action bar addon post-WoW2.0 can do that, and it's really something I'd rate very high on the "features I can't play without" list. :)
Dreamlayout appearance for buttons would also be nice (apologies if it's there and I didn't find it), but it's just cosmetics after all.
Revision 32119 just uploaded, Cleaned up the GUI, and added in support for #show and #showtooltip in macros.
If you are pulling from SVN, make sure to update Waterfall to revision 32118, since this makes setting x and y offsets of bars and buttons take effect while you are typing. Also this makes the settings for layouts not require an enter keypress to be used.
Looks very promising. I've been looking for that kind of flexibility ever since Discord broke. :)
Just curious. What if anything does developing this addon mean to the future of FlexBar2?
It means only that I'm not directly programming for FlexBar2. Cncfanatics is still working on FlexBar2 (to my knowledge), and any of my code or experience he wants to use he is welcome to. :)
It seems like for layouts, the horizontal setting makes vertical bars and the vertical setting makes horizontal bars. Also, ctrl shift and alt pages cause me to lag for about 1 second each time i hit either of them.
Is InfiniBar:RegisterTextSub() intended to be called from other addons too? Or is it only meant to be used internally by InfiniBar? There are some textsubs I'd love to add. Can the trigger be any Ace-event?
I understand you are waiting for Waterfall to be able to implement direct macro editing. If possible, you might consider making the method to apply it already so we could test and use it by calling it directly.
As you can perhaps see from my line of questions, I prefer to use code for configuration as opposed to a GUI. So I guess I should ask if that's something you will generally support too. Or will you mainly support configurations via Waterfall or similar GUI?
Is InfiniBar:RegisterTextSub() intended to be called from other addons too? Or is it only meant to be used internally by InfiniBar? There are some textsubs I'd love to add. Can the trigger be any Ace-event?
Yes, InfiniBar:RegisterTextSub() is intended to be used from other addons, as well as used internally by InfiniBar itself. See http://ace.pastey.net/10092 for some details on how to use it as well as other configurations.
I understand you are waiting for Waterfall to be able to implement direct macro editing. If possible, you might consider making the method to apply it already so we could test and use it by calling it directly.
As you can perhaps see from my line of questions, I prefer to use code for configuration as opposed to a GUI. So I guess I should ask if that's something you will generally support too. Or will you mainly support configurations via Waterfall or similar GUI?
For the moment I am only interested in the Waterfall GUI as the primary method of making changes. As a general rule however, one could study the source code to use lua code to make configurations. Dewdrop and slash commands are distant future items (I have enough difficulty making one User interface look good and be intuitive). If you wanted to, you could use the following code to clear out the macro number, and set up macro text:
local myBar = InfiniBar:GetBar(barname)
myBar:SetButtonAttributeCurState(btnNumber,'type','macro')
myBar:SetButtonAttributeCurState(btnNumber,'macro',nil)
myBar:SetButtonAttributeCurState(btnNumber,'macrotext',yourmacrotext)
Doing this could potentially cause problems when using the GUI for the modified button, at least until I can get a multiline control in Waterfall. Replace barname with a string containing your bar's name, btnnumber with the number of the button on the given bar, and yourmacrotext with a string containing the macrotext you want, newlines converted to \n's. This sets the macro to be contained in the current state, so make sure you are in the correct stance/actionbar page, stealth mode, or have the right key modifier pressed.
This, at the moment, is not supported, may not actually work (though it ought to, I just haven't tested it yet), and if any problems occur due to it, they will only be fixed when I get around to macros contained in buttons. Good Luck! :)
A strange bug. My druid took a portal to Moonglade. That caused all textures for buttons with spells to be blank. Buttons with items and macros were not affected. Changing bars (by shapeshifting) got the textures back - but only for the bars that were set to change on shapeshifting. Relogging solved it though.
It's the only portal I've tried while testing. So I don't know if it's a general zoning issue or something specific for Moonglade.
Edit: Only the textures were affected. The buttons and tooltips still worked.
Edit2: Just tried using a Hearthstone. It caused the same issue with blank texture. So I guess it's a general zoning issue.
Whe using a CyCircled skin, InfiniBar no long seems to trim the corners like it used to.
And when using this with CyCircled, can the buff coloring be change to change the color of the button like it does when it is equipped, instead of like it is being casted?
For Alt, Ctrl, and Shift keybindings (I don't use the page toggles,) make the abbreviation a-X c-X s-X. That would be wonderful. :)
I'll be switching to this for my bars as soon as the hiding of the default interface is in. Assuming it isn't already, I've been playing around with them while bt3 is still installed.
A strange bug. My druid took a portal to Moonglade. That caused all textures for buttons with spells to be blank. Buttons with items and macros were not affected. Changing bars (by shapeshifting) got the textures back - but only for the bars that were set to change on shapeshifting. Relogging solved it though.
It's the only portal I've tried while testing. So I don't know if it's a general zoning issue or something specific for Moonglade.
Edit: Only the textures were affected. The buttons and tooltips still worked.
Edit2: Just tried using a Hearthstone. It caused the same issue with blank texture. So I guess it's a general zoning issue.
This has been fixed since just after you reported this. Never posted since I was working on some other bugs.
Quote from Locked »
Whe using a CyCircled skin, InfiniBar no long seems to trim the corners like it used to.
And when using this with CyCircled, can the buff coloring be change to change the color of the button like it does when it is equipped, instead of like it is being casted?
This, too, has been fixed for a bit.
I also have fixed the Flickering Cooldowns of Doom, now cooldowns are as smooth as they should be.
I removed the code forcing buttons to stay entirely on the screen, now they will not bunch up at the edges.
In addition, All of the fadein/out code currently implemented should be working even in combat.
And finally, I am proud to report that the Blizzard Actionbars, pet bar, and stance bar, as well as the art for it, are now capable of being hidden. The Bag Bar and the Micro Menu bar can now also be controlled by InfiniBar (though they are not currently being skinned with cyCircled). If enough people yell about it, I will also make the pet bar available (I hear some of you non Hunters/Warlocks would like to make use of it). To take control, simply click the appropriate button at the top of your Config screen.
Note the Bag Bar and Micro Menu bars can not have regular buttons added to them, nor can buttons currently be removed from them (this will probably change at a later date, or I may make some system of hiding the bags and/or keyring). If you no longer want InfiniBar to control either of these bars, just delete the bar, and it will revert the buttons back to their default settings.
The most recent version of InfiniBar is 32220. Should be available in zip form within 20 minutes or less.
Quote from Doonga »
Suggestion:
For Alt, Ctrl, and Shift keybindings (I don't use the page toggles,) make the abbreviation a-X c-X s-X. That would be wonderful. :)
Quite Possible. I'd actually like better abbreviations for all of the paging options, when they're all active, the list of states gets very confused.
I'll be switching to this for my bars as soon as the hiding of the default interface is in. Assuming it isn't already, I've been playing around with them while bt3 is still installed.
JJSheets, have my babies :P or let me have yours whichever you prefer.
I've waited for many many moons for this level of customization. Thank you! Oh also, I would say, we could use a unit frames mod with this level of customization too! CreateFrame() is a wonderful thing, when given a waterfall config and on the fly creating your unit frames would be simply uber :)
Quick suggestion added: can you possibly add a text substitution that can pull spell rank so we can added a text sub that says like Rank [rank]
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
- The fading didnt work.
- If you set the actionbar pages to 1 it gets wonky after you press a modifier with modifier-swap on.
- I set Shift Pages, Control Pages and Alt Pages. Control doesnt page.
- When I hold shift and press a keybind (say, 1) it doesnt work. clicking the button at that time neither works.
- When selecting the layout the values are 0 but when you apply that layout (with 0) it gives you an error about it being nil.
- I think it would be easier to set the values to 36, -36 and the number of cols/rows to the number of buttons in the bar automatically when you select the layout, for horizontal and vertical. (haven't checked out the circular yet :))
Thats it for now I think. Otherwise great addon :o
Odd... they ought to have worked immediately.
I suppose I ought to make the option of alt, shift, control, right mouse buttton as self cast.
As soon as I program in features for taking over the bag bar and main menu bar. Might be a day or two.
I know I can do this in combat without the fading... and that's likely how I'll do it. If I can figure a good way to do fading in and out in combat it'll even look nice.
Obviously this is something that you want during combat, so I'm not certain how easy it'll be to do this. I do like the idea though, and will see if I can do it. :)
This has been a planned feature pretty much since I first started on InfiniBar. As soon as I can get a multiline text box in waterfall, this is going in.
"Show out of Combat" option now no longer fades in or out, it merely hides and shows. To make this look right, I'd have to do a major hack job, so for now, fading won't be working with this option. Once I can figure a good way to fade in and out during combat, it's going in.
Can't reproduce this... seems to work fine to me. Though I will say that waterfall likes to confuse slider numbers between sliders.
Fixed. It helps to spell 'ctrl' properly. :)
Okay... still trying to figure out why this is happening, but at least I'm seeing it. :) I think it's related to keybinds.
The GUI is getting a redesign soon. I'll be fixing this and more when that happens.
After that I add options for shift/alt/ctrl self casts, and other feature requests.
I've already tried to hack the code myself, but without success.
Macro support doesn't seem to be handling #showtooltip. The following macro shows the Pick Pocket icon and tooltip on an InfiniBar button.
I have having the same problem as Locked is with the button dragging. Now that I've figured out the manual settings through the config it's okay though. I wasn't hitting Return after each filling in a field to get the positioning to take effect. Industrial's comment about 36/-36 helped me make the leap too!
The scale slider for the buttons seems to be working in .05 increments but only shows the tenths digit. So you get two notches on the slider displaying .9 that I believe are .95 and then .9.
My only additional feature request beyond what others have already mentioned is, I would like checkbox to set a bar to only show on mouse over. Being able to check that and "show out of combat" would be great for a profession bar I don't want to see unless I want to use them and I don't want popping up if I'm mousing around in combat.
Thanks again!
Looks good so far, the one thing that would really make the difference for me would be context paging (change page to X if target friendly, change page to Y if target is enemy). As far as I can tell no other action bar addon post-WoW2.0 can do that, and it's really something I'd rate very high on the "features I can't play without" list. :)
Dreamlayout appearance for buttons would also be nice (apologies if it's there and I didn't find it), but it's just cosmetics after all.
Thanks in advance!
If you are pulling from SVN, make sure to update Waterfall to revision 32118, since this makes setting x and y offsets of bars and buttons take effect while you are typing. Also this makes the settings for layouts not require an enter keypress to be used.
Just curious. What if anything does developing this addon mean to the future of FlexBar2?
It means only that I'm not directly programming for FlexBar2. Cncfanatics is still working on FlexBar2 (to my knowledge), and any of my code or experience he wants to use he is welcome to. :)
I understand you are waiting for Waterfall to be able to implement direct macro editing. If possible, you might consider making the method to apply it already so we could test and use it by calling it directly.
As you can perhaps see from my line of questions, I prefer to use code for configuration as opposed to a GUI. So I guess I should ask if that's something you will generally support too. Or will you mainly support configurations via Waterfall or similar GUI?
Yes, InfiniBar:RegisterTextSub() is intended to be used from other addons, as well as used internally by InfiniBar itself. See http://ace.pastey.net/10092 for some details on how to use it as well as other configurations.
For the moment I am only interested in the Waterfall GUI as the primary method of making changes. As a general rule however, one could study the source code to use lua code to make configurations. Dewdrop and slash commands are distant future items (I have enough difficulty making one User interface look good and be intuitive). If you wanted to, you could use the following code to clear out the macro number, and set up macro text:
Doing this could potentially cause problems when using the GUI for the modified button, at least until I can get a multiline control in Waterfall. Replace barname with a string containing your bar's name, btnnumber with the number of the button on the given bar, and yourmacrotext with a string containing the macrotext you want, newlines converted to \n's. This sets the macro to be contained in the current state, so make sure you are in the correct stance/actionbar page, stealth mode, or have the right key modifier pressed.
This, at the moment, is not supported, may not actually work (though it ought to, I just haven't tested it yet), and if any problems occur due to it, they will only be fixed when I get around to macros contained in buttons. Good Luck! :)
Awesome, thank you. :)
As soon as I have a little more time to play around with this one, I'll give it a shot.
Revision 32178 fixes the scaling issues, as well as adds the ability to make given state combinations hide the bar.
It's the only portal I've tried while testing. So I don't know if it's a general zoning issue or something specific for Moonglade.
Edit: Only the textures were affected. The buttons and tooltips still worked.
Edit2: Just tried using a Hearthstone. It caused the same issue with blank texture. So I guess it's a general zoning issue.
And when using this with CyCircled, can the buff coloring be change to change the color of the button like it does when it is equipped, instead of like it is being casted?
For Alt, Ctrl, and Shift keybindings (I don't use the page toggles,) make the abbreviation a-X c-X s-X. That would be wonderful. :)
I'll be switching to this for my bars as soon as the hiding of the default interface is in. Assuming it isn't already, I've been playing around with them while bt3 is still installed.
This has been fixed since just after you reported this. Never posted since I was working on some other bugs.
This, too, has been fixed for a bit.
I also have fixed the Flickering Cooldowns of Doom, now cooldowns are as smooth as they should be.
I removed the code forcing buttons to stay entirely on the screen, now they will not bunch up at the edges.
In addition, All of the fadein/out code currently implemented should be working even in combat.
And finally, I am proud to report that the Blizzard Actionbars, pet bar, and stance bar, as well as the art for it, are now capable of being hidden. The Bag Bar and the Micro Menu bar can now also be controlled by InfiniBar (though they are not currently being skinned with cyCircled). If enough people yell about it, I will also make the pet bar available (I hear some of you non Hunters/Warlocks would like to make use of it). To take control, simply click the appropriate button at the top of your Config screen.
Note the Bag Bar and Micro Menu bars can not have regular buttons added to them, nor can buttons currently be removed from them (this will probably change at a later date, or I may make some system of hiding the bags and/or keyring). If you no longer want InfiniBar to control either of these bars, just delete the bar, and it will revert the buttons back to their default settings.
The most recent version of InfiniBar is 32220. Should be available in zip form within 20 minutes or less.
Quite Possible. I'd actually like better abbreviations for all of the paging options, when they're all active, the list of states gets very confused.
Done.
I've waited for many many moons for this level of customization. Thank you! Oh also, I would say, we could use a unit frames mod with this level of customization too! CreateFrame() is a wonderful thing, when given a waterfall config and on the fly creating your unit frames would be simply uber :)
Quick suggestion added: can you possibly add a text substitution that can pull spell rank so we can added a text sub that says like Rank [rank]