I have a fix for deDE, since it's broken in your latest beta. May I commit it and if yes, where to? ;) Also I can't get Professions or Class categories to work, their menu is empty .. are they kinda hardcoded?
ps: it also spams debug messages in edit mode like Barnum=n :)
pps: at mailbox the mainbag does also open (can you surpress it?)
proposal to add optional support for informant (advantage is big database known items). from informant categories/professions can be retrieved pretty easy.
also, i seen option something like "highlight new items" and this option is disabled - is this not implemented yet ?
I remember tekkub said on irc something about only registering bagupdate events when the arkinventory frame is open, and only sorting (or building or whatever) the inventory onshow of the bag frame.
Just tried this out and it's working decently, I read through the forums pages and didn't notice any mention of this. When I go to the bank, ArkI opens both the default bank frame, and my inventory frame on the bank screen, so I have to switch to my Character Inventory manually, and then I don't get a clear & sorted view of my bank items. I tried turning off Open Bank by default, but that didn't seem to make much difference.
The ability to assign individual items to categories is great, I'm finally able to sort my MANY different gear sets into their own areas =)
I remember tekkub said on irc something about only registering bagupdate events when the arkinventory frame is open, and only sorting (or building or whatever) the inventory onshow of the bag frame.
1.26 sort of does this, if the window is not open it wont calculate anything, still needs to scan the bag though. although i could delay this until the window is opened, will need to move things around a bit but might be worth it.
ps: it also spams debug messages in edit mode like Barnum=n :)
damn, i used a print instead of a debug when i has having a problem with the bars. it's "fixed" in my working copy now
pps: at mailbox the mainbag does also open (can you surpress it?)
sorry, thats a blizzard thing. i'm not going to interfere with the blizzard bank/backpack/bag frames at this point.
I have a fix for deDE, since it's broken in your latest beta. May I commit it and if yes, where to? ;)
um, not sure, i'm not very good with this svn stuff, there must be some way for you to commit just that change and for me to get just that without stuffing up the code i already have? if you have to, just create a new tags and i'll pull the deDE out
Also I can't get Professions or Class categories to work, their menu is empty .. are they kinda hardcoded?
kinda, yes, because they're system based i didn't see any need to not have them hardcoded, they're in a couple of separate hardcoded tables that get merged (with the dynamic custom categories) into a single dynamic category table that gets used to display all of them
When I go to the bank, ArkI opens both the default bank frame, and my inventory frame on the bank screen, so I have to switch to my Character Inventory manually, and then I don't get a clear & sorted view of my bank items. I tried turning off Open Bank by default, but that didn't seem to make much difference.
the trunk release does that, only has a single window, the 1.26 beta has separate windows for bank, bag and keyring so you can see everything at the same time - unless you mean something else is going wrong in 1.26?
The most straightforward way to deal with people giving codefixes is for them to generate a patch through subversion (be it tortoise or whatever) which is basically a diff file you can then use to merge into your working copy, check the changes, and commit them, especially if you've already edited the last commit and are working on new stuff.
So I'm enjoying ArkInventory so far. I only have a couple issues with it:
Whenever I goto mailbox or bank or vendor, etc, my backpack opens up (F12). Would be nice if AI kept it from opening.
Most items just don't seem to sort without manually telling them what is what. Like when I make a region "CONSUMABLE" I'd expect all potions and food and drink to go there, but only potions go there. Food and Drink don't appear to be assigned to any of the default categories. Also, any sort of food type item for cooking, NONE of it is assigned to the COOKING profession. Same with cloth, should be assigned to TAILORING, etc. The list goes on and on. Even my Totems and Ankhs don't appear to be assigned to the SHAMAN category. Anyways my point is that it would be nice if AI could use some sort of external database of predefined category assignments for items. I don't know if there are any ACE addons that provide this or not... I remember a long long time ago there was this addon called RegeantInfo, it was simply a database of items and their matching categories that other addons could use for sorting items similar to what I'm talking about.
Whenever I goto mailbox or bank or vendor, etc, my backpack opens up (F12). Would be nice if AI kept it from opening.
Man, I really can see how developers get angry at users now. End-users really are the laziest people in the world when it comes to research. If you'd read back but 3-5 posts you'd see why this isn't yet the case. Hell, you didn't even have to go back a pack to check the reason for this.
Quote from Jakobud »
Most items just don't seem to sort without manually telling them what is what. Like when I make a region "CONSUMABLE" I'd expect all potions and food and drink to go there, but only potions go there. Food and Drink don't appear to be assigned to any of the default categories. Also, any sort of food type item for cooking, NONE of it is assigned to the COOKING profession. Same with cloth, should be assigned to TAILORING, etc. The list goes on and on. Even my Totems and Ankhs don't appear to be assigned to the SHAMAN category. Anyways my point is that it would be nice if AI could use some sort of external database of predefined category assignments for items. I don't know if there are any ACE addons that provide this or not... I remember a long long time ago there was this addon called RegeantInfo, it was simply a database of items and their matching categories that other addons could use for sorting items similar to what I'm talking about.
The item database does need a lot of work, yes. It's not currently using the Ace2 libraries of predefined item categories but it's own internal database. Would require a fairly hefty rewrite from what I understand in order to use those categories but I'm hoping it's on the Horizon.
As for me, I have a new request for ArkInv. Wonder if we could get a "Quick Edit" mode whereby you simply hold a modifier key down (alt+ctrl maybe) and click (right/left, not sure) on an item and it would bring up the menu to set categories. I find myself picking bits and pieces up and wanting to toss them directly into a category but having to go into the full edit mode just to move them.
Would it be possible to store stuff in a category by name of the item and also possibly by enchant on item? ie i got several armorsets with the same name but different enchants, i would like to be able to store those in different categorys. This would also be good for a particular armorset as ppl often has different resgear and keeping them separated would be sooo nice :D
Man, I really can see how developers get angry at users now. End-users really are the laziest people in the world when it comes to research. If you'd read back but 3-5 posts you'd see why this isn't yet the case. Hell, you didn't even have to go back a pack to check the reason for this.
Ya it's called "just listing off my issues with it." I'm not saying "oh I found a new bug" without reading back.
Whenever I goto mailbox or bank or vendor, etc, my backpack opens up (F12). Would be nice if AI kept it from opening.
it's a blizzard function, remove arkinv and it'll still happen. apart from that i wont be touching the blizzard frames any time soon becuase not being able to access your bags/bank if something goes wrong with this mod is a major pain.
Most items just don't seem to sort without manually telling them what is what. Like when I make a region "CONSUMABLE" I'd expect all potions and food and drink to go there, but only potions go there. Food and Drink don't appear to be assigned to any of the default categories.
if blizzard tagged it as consumable then it'll be in the consumable category (as of 1.26) FOOD and DRINK i've added separate categories for (and tooltip searches to put things in there)
Also, any sort of food type item for cooking, NONE of it is assigned to the COOKING profession. Same with cloth, should be assigned to TAILORING, etc. The list goes on and on. Even my Totems and Ankhs don't appear to be assigned to the SHAMAN category. Anyways my point is that it would be nice if AI could use some sort of external database of predefined category assignments for items.
my biggest gripe with this is that not everyone is a tailor, not everyone is a cook. runecloth to me is for first aid (which is where i've put mine), and while i do cook some people use food to feed to their pets, not cook. if an item has only a single purpose then it can be set as such, but when it has more than one i'd prefer to leave it with it's blizzard tag and let the player decide to recategorise it.
I don't know if there are any ACE addons that provide this or not... I remember a long long time ago there was this addon called RegeantInfo, it was simply a database of items and their matching categories that other addons could use for sorting items similar to what I'm talking about.
i think there are but as above, most items have multiple categories so i'm going with a minimalistic approach.
An option to hide empty slots (we already have a used/total counter) would make me a happy gnome.
im adding the ability to hide categories, this will cover what others want as well, you should be able to hide the EMPTY categories if you dont want those shown.
The item database does need a lot of work, yes. It's not currently using the Ace2 libraries of predefined item categories but it's own internal database. Would require a fairly hefty rewrite from what I understand in order to use those categories but I'm hoping it's on the Horizon.
would depend on how their database was structured, but yes it would require a re-write of the way i keep track of categories.
Wonder if we could get a "Quick Edit" mode whereby you simply hold a modifier key down (alt+ctrl maybe) and click (right/left, not sure) on an item and it would bring up the menu to set categories. I find myself picking bits and pieces up and wanting to toss them directly into a category but having to go into the full edit mode just to move them.
probably not very soon, the items are actually using blizzards default xml so that i get secure functionality, so long as i don't play with the click handlers i'm ok, adding what you want would mean playing with that and probably tainting the code such that the client wont let it happen or would barf in combat.
actually, i could add a keybinding for edit mode, that way you could use shift F12 to toggle edit mode on/off? would that be ok?
Excellent mod:) Using the latest r22280 version it won't remember the keybinding. I have to remap it everytime I start WOW..weird I know lol.
ok, yeah thats really odd, mine remembers it across sessions as well as across computers. i sync everything up to a USB drive when i want to code/play on another computer.
An option to hide empty slots (we already have a used/total counter) would make me a happy gnome.
this is now functional in the next beta, you can hide/unhide any category you want via the bar menu.
I have a typo fix for you for the latest ..\tags version. It's attached to this post, you quried "CATEGORY_PROJECTILE_EMPTY_ARROW" which doesn't exist. Just choose 'Apply Patch' in Tortoise.
Category assignment is now based on PeriodicTable-2.0
Nearly completely wiped out tooltip scanning
Profession categories should now work correctly (or at least try to)
Added some categories(Food/Drink, Health/Mana potions, etc.)
I don't know how all this SVN system works, so the file is in attachment.
Maybe you'll find some of these changes useful.
PS. Zip is w/o deps, also requires PT2.
I would love to see some kind of manual sorting of items within a category... basically making the bars like virtual bags so that items can be moved individually. I like to order my gems by quality, put all pearls together, put all grinding stones together, that sort of thing. I currently can't do that without making each type a custom category, and there aren't enough to go around. I tried sorting things in my regular bags the way I like and then selecting "By Bag" sorting, but that scatters stuff all over the place (r22280). "No Sorting" is even worse of course. Maybe I'm overlooking something.
It would also be cool to be able to rename custom categories, e.g. rename "Custom 1" to "Fire Resist". Doesn't seem to be a way of doing that without editing the lua. Again, maybe I'm overlooking something.
Back to vBagnon for now, but I'll be keeping an eye on this one... it has a lot of potential. :)
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
ps: it also spams debug messages in edit mode like Barnum=n :)
pps: at mailbox the mainbag does also open (can you surpress it?)
awesome work so far!
also, i seen option something like "highlight new items" and this option is disabled - is this not implemented yet ?
thanks
Ostap
The ability to assign individual items to categories is great, I'm finally able to sort my MANY different gear sets into their own areas =)
damn, i used a print instead of a debug when i has having a problem with the bars. it's "fixed" in my working copy now
sorry, thats a blizzard thing. i'm not going to interfere with the blizzard bank/backpack/bag frames at this point.
um, not sure, i'm not very good with this svn stuff, there must be some way for you to commit just that change and for me to get just that without stuffing up the code i already have? if you have to, just create a new tags and i'll pull the deDE out
kinda, yes, because they're system based i didn't see any need to not have them hardcoded, they're in a couple of separate hardcoded tables that get merged (with the dynamic custom categories) into a single dynamic category table that gets used to display all of them
the trunk release does that, only has a single window, the 1.26 beta has separate windows for bank, bag and keyring so you can see everything at the same time - unless you mean something else is going wrong in 1.26?
Man, I really can see how developers get angry at users now. End-users really are the laziest people in the world when it comes to research. If you'd read back but 3-5 posts you'd see why this isn't yet the case. Hell, you didn't even have to go back a pack to check the reason for this.
The item database does need a lot of work, yes. It's not currently using the Ace2 libraries of predefined item categories but it's own internal database. Would require a fairly hefty rewrite from what I understand in order to use those categories but I'm hoping it's on the Horizon.
As for me, I have a new request for ArkInv. Wonder if we could get a "Quick Edit" mode whereby you simply hold a modifier key down (alt+ctrl maybe) and click (right/left, not sure) on an item and it would bring up the menu to set categories. I find myself picking bits and pieces up and wanting to toss them directly into a category but having to go into the full edit mode just to move them.
Would it be possible to store stuff in a category by name of the item and also possibly by enchant on item? ie i got several armorsets with the same name but different enchants, i would like to be able to store those in different categorys. This would also be good for a particular armorset as ppl often has different resgear and keeping them separated would be sooo nice :D
Ya it's called "just listing off my issues with it." I'm not saying "oh I found a new bug" without reading back.
if blizzard tagged it as consumable then it'll be in the consumable category (as of 1.26) FOOD and DRINK i've added separate categories for (and tooltip searches to put things in there)
my biggest gripe with this is that not everyone is a tailor, not everyone is a cook. runecloth to me is for first aid (which is where i've put mine), and while i do cook some people use food to feed to their pets, not cook. if an item has only a single purpose then it can be set as such, but when it has more than one i'd prefer to leave it with it's blizzard tag and let the player decide to recategorise it.
i think there are but as above, most items have multiple categories so i'm going with a minimalistic approach.
im adding the ability to hide categories, this will cover what others want as well, you should be able to hide the EMPTY categories if you dont want those shown.
would depend on how their database was structured, but yes it would require a re-write of the way i keep track of categories.
probably not very soon, the items are actually using blizzards default xml so that i get secure functionality, so long as i don't play with the click handlers i'm ok, adding what you want would mean playing with that and probably tainting the code such that the client wont let it happen or would barf in combat.
actually, i could add a keybinding for edit mode, that way you could use shift F12 to toggle edit mode on/off? would that be ok?
this is now functional in the next beta, you can hide/unhide any category you want via the bar menu.
Maybe you'll find some of these changes useful.
PS. Zip is w/o deps, also requires PT2.
It would also be cool to be able to rename custom categories, e.g. rename "Custom 1" to "Fire Resist". Doesn't seem to be a way of doing that without editing the lua. Again, maybe I'm overlooking something.
Back to vBagnon for now, but I'll be keeping an eye on this one... it has a lot of potential. :)