Authors CurseForge

the compare tooltip is showing up for me fine but im not seeing the stats from bonuses :(

using 1.2 on a rogue

setting /bonuses hidearmor to hidetooltip

hovered the mouse over a fist weapon: tooltip, no bonuses

hovered the mouse over a one handed axe: no tooltip
hovered the mouse over a two handed axe: no tooltip

hovered the mouse over a two handed sword: tooltip, but no bonuses
hovered the mouse over a two handed mace: tooltip, but no bonuses

something is seriously wrong :D

settings /bonuses hidearmor to hidenone

all tooltips and bonuses show (also for non usable items)

self.db.profile.IgnoreArmor == 0 in TooltipScan:Process() makes all the trouble, commenting the line out (+ the one "end" some lines below) fixes it.

I dunno what your settings are, but it's working fine for me.

hidenone means even on items you cant use, the equipped item tooltip and stat comparison shows up.

hidecompare means the equipped item tooltip still shows up, but the stat comparison does not.

hidetooltip means when you mouse over or click an item you cant use, no extra tooltips show up.

I use standalone libs so i deleted the libs dir from the zip file and installed that way, i get the relevent stats on the tool tip but am getting following errors which are annoying since i never had erros before i put tis addon in.


BugGrabberDB = {
["throttle"] = true,
["limit"] = 510,
["errors"] = {
{
["message"] = "Bonuses\\Core.lua:351: Usage: GetItemInfo(itemID|\"name\"|\"itemlink\")\nBonuses\\Core.lua:351: in function `Process'\nBonuses\\Core.lua:343: in function <Interface\\AddOns\\Bonuses\\Core.lua:339>\n(tail call): ?:\n(tail call): ?:\n(tail call): ?:\n<in C code>: ?\n<in C code>: ?\n<in C code>: in function `pcall'\nStubby-1508\\Stubby.lua:308: in function <Interface\\AddOns\\Stubby\\Stubby.lua:292>\n(tail call): ?:\nOutfitter\\Outfitter.lua:8276: in function `SetBagItem'\nItemSync-r25808\\ItemSync.lua:722: in function `Scan_Prices'\nItemSync-r25808\\ItemSync.lua:170: in function <Interface\\AddOns\\ItemSync\\ItemSync.lua:170>\n<in C code>: ?\nAceEvent-2.0-25921 (Ace2):324: in function `TriggerEvent'\nAceEvent-2.0-25921 (Ace2):962: in function <Interface\\AddOns\\Ace2\\AceEvent-2.0\\AceEvent-2.0.lua:955>\n\n ---",
["type"] = "error",
["time"] = "2007/03/08 18:44:18",
["session"] = 574,
["counter"] = 7,
}, -- [1]
{
["message"] = "Bonuses\\Core.lua:351: Usage: GetItemInfo(itemID|\"name\"|\"itemlink\")\nBonuses\\Core.lua:351: in function `Process'\nBonuses\\Core.lua:343: in function <Interface\\AddOns\\Bonuses\\Core.lua:339>\n(tail call): ?:\n(tail call): ?:\n(tail call): ?:\n<in C code>: ?\n<in C code>: ?\n<in C code>: in function `pcall'\nStubby-1508\\Stubby.lua:308: in function <Interface\\AddOns\\Stubby\\Stubby.lua:292>\n(tail call): ?:\nOutfitter\\Outfitter.lua:8276: in function `SetBagItem'\nItemSync-r25808\\ItemSync.lua:722: in function `Scan_Prices'\nItemSync-r25808\\ItemSync.lua:170: in function <Interface\\AddOns\\ItemSync\\ItemSync.lua:170>\n<in C code>: ?\nAceEvent-2.0-25921 (Ace2):324: in function `TriggerEvent'\nAceEvent-2.0-25921 (Ace2):962: in function <Interface\\AddOns\\Ace2\\AceEvent-2.0\\AceEvent-2.0.lua:955>\n\n ---",
["type"] = "error",
["time"] = "2007/03/08 23:34:01",
["session"] = 576,
["counter"] = 4,
}, -- [2]
{
["message"] = "Bonuses\\Core.lua:351: Usage: GetItemInfo(itemID|\"name\"|\"itemlink\")\nBonuses\\Core.lua:351: in function `Process'\nBonuses\\Core.lua:343: in function <Interface\\AddOns\\Bonuses\\Core.lua:339>\n(tail call): ?:\n(tail call): ?:\n(tail call): ?:\n<in C code>: ?\n<in C code>: ?\n<in C code>: in function `pcall'\nStubby-1508\\Stubby.lua:308: in function <Interface\\AddOns\\Stubby\\Stubby.lua:292>\n(tail call): ?:\nOutfitter\\Outfitter.lua:8276: in function `SetBagItem'\nItemSync-r25808\\ItemSync.lua:722: in function `Scan_Prices'\nItemSync-r25808\\ItemSync.lua:170: in function <Interface\\AddOns\\ItemSync\\ItemSync.lua:170>\n<in C code>: ?\nAceEvent-2.0-25921 (Ace2):324: in function `TriggerEvent'\nAceEvent-2.0-25921 (Ace2):962: in function <Interface\\AddOns\\Ace2\\AceEvent-2.0\\AceEvent-2.0.lua:955>\n\n ---",
["type"] = "error",
["time"] = "2007/03/09 01:04:09",
["session"] = 580,
["counter"] = 4,
}, -- [3]
},
["save"] = true,
["session"] = 580,
}

Quote from Syzgyn »

I dunno what your settings are, but it's working fine for me.

hidenone means even on items you cant use, the equipped item tooltip and stat comparison shows up.

hidecompare means the equipped item tooltip still shows up, but the stat comparison does not.

hidetooltip means when you mouse over or click an item you cant use, no extra tooltips show up.

if IgnoreArmor > 0 then no bonus processing is done at all. hidetooltip means IgnoreArmor gets the value of 2 and no processing is done, even for items that you CAN use.

Quote from Syzgyn »

I'll try to seperate out the Localizations for the next version.

That would be great. ^^

:)

Icerat my guess is a conflict with another addon. Install it with embedded libs and see if you still get the error.

Sharky Aha, I see what you're saying. Fixed in next version, but if you want to change it yourself, replace the conditional on line 373 with

if not self.db.profile.IgnoreArmor == 1 then

Would it be possible to strip out some of text Blizz puts for equip and use. For example "Equip: Increases your parry rating by 18" might as well just look like "+18 parry" and so on. The use ones can be "Use: +18 parry" or even "U: +18 parry". The on equip stuff looks nutty to me as it should be up with the base stat stuff and look the same. Of course I have to equip the item to get the increased stats :)

The On Equip: thing has at least importance for Druids. On equip procs work. On equip armor and bonuses don't get multiplied by bear, HOTW, etc. Only the "white" text gets special modifiers for us. I don't know if other classes have the kind of weird things that druids have to look out for, but that's probably why they're divided up like that.

I'm not going to be changing the original tooltips, sorry.

Here is a suggestion:
For weapons, calculate the differences between the average damage. Many classes have damage modifiers to instant attacks (particularly Rogues and Warriors) that are based on weapon damage. It is important to compare average damage rather than DPS. For example, a 1.7 sword w/ 60 DPS has an average damage of 102. A 2.6 sword with 58 DPS has an average damage of 150. That's 50% more damage on your instant attacks from a weapon that appears inferior. If your a rogue using Sinister Strike with Lethality and Aggression, that's a difference of 117 on your criticals and 51 on normal hits.

Quote from Syzgyn »

Icerat my guess is a conflict with another addon. Install it with embedded libs and see if you still get the error.

Sharky Aha, I see what you're saying. Fixed in next version, but if you want to change it yourself, replace the conditional on line 373 with

if not self.db.profile.IgnoreArmor == 1 then

Getting the same even with the embedded libs :(

Quote from Syzgyn »

I'm not going to be changing the original tooltips, sorry.

Thank you very much!
I can understand why one would want something like that but I'm glad you leave the tooltips as is.

[2007/03/10 09:43:15-601-x12]: Bonuses\Core.lua:351: Usage: GetItemInfo(itemID|"name"|"itemlink")
Bonuses\Core.lua:351: in function `Process'
Bonuses\Core.lua:343: in function <Interface\AddOns\Bonuses\Core.lua:339>
(tail call): ?:
(tail call): ?:
(tail call): ?:
<in C code>: ?
<in C code>: ?
<in C code>: in function `pcall'
Stubby-1508\Stubby.lua:308: in function <Interface\AddOns\Stubby\Stubby.lua:292>
(tail call): ?:
Outfitter\Outfitter.lua:8276: in function `SetBagItem'
ItemSync-r25808\ItemSync.lua:722: in function `Scan_Prices'
ItemSync-r25808\ItemSync.lua:170: in function <Interface\AddOns\ItemSync\ItemSync.lua:170>
<in C code>: ?
AceEvent-2.0-25921 (Ace2):324: in function `TriggerEvent'
AceEvent-2.0-25921 (Ace2):962: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:955>

---

using 1.2

something is wrong with +spell crit rating, it gets doubled somehow

http://img103.imageshack.us/img103/5668/wowscrnshot031007165627ap3.jpg

Can you turn on debugging, then click the item or mouseover, and show me all the text it spews out? (It's alot)

Quote from Seerah »

What's getting doubled? Those percentages are correct.

Spell Crit Rating should be 11, not 22.

Quote from Syzgyn »

Can you turn on debugging, then click the item or mouseover, and show me all the text it spews out? (It's alot)

Never mind, it was a bug in my RatingBuster support.

p.s.

Please add support for Atlasloot.