Authors CurseForge

thanks a lot atcha :)

vive Sylvanaar xD thanks

Quote from Squidalicious »

ah ok I'm using r26930 from the downloader zips page from the website.. I don't have the svn downloader or such installed anymore, it seems to use a lot of resources... guess I have to install it again to get this one.

Just FYI, but the zip files are should only be collections of files from the archives, you shouldn't need to install a downloader to get what you need. Have you tried again since you posted?

cheers,

- Fin

Suggestion: CopyChat module improvement

Current chat copy is a bit clumsy, the copy button opens a popup that shows only what I have visible in my chat frame at the time and it doesn't look exactly like my chat frame either -> hard to find the line I want to copy sometimes. Even more clumsy if I want to copy several lines that are not right next to each other.

==> Change it/add an option to click timestamp(*) to open similar popup as with UrlCopy that has the clicked line in it.

(*): Why timestamp? Because many people have that already and if you don't need timestamp but would like to take advantage of this feature, you could make 'dummy' timestamp, something like "|", ">" or even perhaps even just an empty space that you could click when you want to copy a line.

When i trying to post quest titles in chat Prat replacing things like [70+] with item links.

Quote from Iceroth »

Suggestion: CopyChat module improvement

Current chat copy is a bit clumsy, the copy button opens a popup that shows only what I have visible in my chat frame at the time and it doesn't look exactly like my chat frame either -> hard to find the line I want to copy sometimes. Even more clumsy if I want to copy several lines that are not right next to each other.

==> Change it/add an option to click timestamp(*) to open similar popup as with UrlCopy that has the clicked line in it.

(*): Why timestamp? Because many people have that already and if you don't need timestamp but would like to take advantage of this feature, you could make 'dummy' timestamp, something like "|", ">" or even perhaps even just an empty space that you could click when you want to copy a line.

If this happens, please give us an option to have it the way it is now.

I'm still having issues with a right aligned chatframe not allowing links to be clicked :(
I have checked "fix links" in the options and reloaded.
Side note, even when I change the justification of that chatframe, I still cant click on the links for that session- is that a normal symptom? If you need any other info, just yell- am using v27361.

Thanks!

Has there been any fix for the class colors to take shammys into account (im ally only) cos as it is now shammy and mage are the same color.

Quote from Kerecha »

Has there been any fix for the class colors to take shammys into account (im ally only) cos as it is now shammy and mage are the same color.

They are not the same color, shammy is more greenish. In fact, Prat uses the blizzard raid colors, it's just that shammy's and mages look alike colorwise

-Ammo

ye, shammy/hordepally color is cyan, pretty bad choice of Blizzard imo :/ not bright enough


maybe masswhines on the forums can make em change it :P

It's not a bad color tbh. It's just that (IIRC) many many men have troubles seeing greenish shades, and hence can't notice the different greenlevels in those two colors as easily.

I found in trac that clicking links in windows other than left justified windows was supposed to be fixed but it does not work.

Anyone have this working?

Quote from sylvanaar »

afaik those changes are in the current release. The algorithm does not correct for leading text before the link. So if you are using timestamps or your have some text on the line before the link it will be off.

Yeah, stupid me posted before looking at the code... after testing its not only time stamps, it looks like the calculation is off, but I am a lua nub and don't know how to fix it.

In the function Prat_Justify:MoveLink to fix the leading text dont you need to just add the current lead back into it?

b:GetWidth() gets the window width
b:GetStringWidth() get the width of the line being printed
coeff is 1 or 2 depending if centered

so
o:SetPoint(a, b, c, (b:GetWidth()-b:GetStringWidth())/coeff, e)
will always set the itemlink button at the start of the line.

cant you use the existing d variable to move it over the needed amount or?

o:SetPoint(a, b, c, ((b:GetWidth()-b:GetStringWidth())/coeff)+d/coeff, e)

I couldn't it to work but maybe there is something I am missing

I am really new to lua so I am still trying to figure this out and coming up with strange results.

I added in a line to output what the calculation is and I get a never ending output of numbers.

function Prat_Justify:MoveLink(coeff, ...)
 for i=1,select("#", ...) do
  local o = select(i, ...)
    a,b,c,d,e = o:GetPoint()
    if b and b:GetObjectType() == "FontString" and o:GetObjectType() == "Button" then
    	o:ClearAllPoints()
    	o:SetPoint(a, b, c, ((b:GetWidth()-b:GetStringWidth())/coeff)+d/coeff, e)
		DEFAULT_CHAT_FRAME:AddMessage(" ... " .. ((b:GetWidth()-b:GetStringWidth())/coeff)+d/coeff .. " ... ", 1, 1, 1);
    end
 end
end

very strange I would have thought it would have outputed once but it seems to repeat over and over does that mean it has to redraw the button all the time?

Quote from Gregory »

When i trying to post quest titles in chat Prat replacing things like [70+] with item links.

That is not Prat, it's most likely Ludwig or another data mod doing this.

more research

function Prat_Justify:MoveLink(coeff, ...)
 for i=1,select("#", ...) do
  local o = select(i, ...)
    a,b,c,d,e = o:GetPoint()
    if b and b:GetObjectType() == "FontString" and o:GetObjectType() == "Button" then
    	o:ClearAllPoints()
		p = (b:GetWidth()-b:GetStringWidth())/coeff+d/coeff
    	o:SetPoint(a, b, c, p, e)		
		DEFAULT_CHAT_FRAME:AddMessage(" ...Result: " .. (b:GetWidth()-b:GetStringWidth())/coeff+d/coeff .. " ...Window width: " .. b:GetWidth() .. " ...string width: " .. b:GetStringWidth() .. " ...d:" .. d .. " ...p: " .. p, 1, 1, 1);
    end
 end
end

Ends up with a never ending accumulation

but if I put clearallpoints right after the setpoint it does it once. I am not sure what that function does since its not on wowwiki

Would we get support for /rt (/retell), this is how Confab does it:

function Confab_ReTell() 
  local LastSentTellTarget = ChatEdit_GetLastToldTarget(ChatFrameEditBox);
  if (LastSentTellTarget) then
    ChatFrameEditBox:SetAttribute("tellTarget", LastSentTellTarget);
    ChatFrameEditBox:SetAttribute("chatType", "WHISPER");
    ChatEdit_UpdateHeader(ChatFrameEditBox);
    ChatFrame_OpenChat("");
  end
end