Authors CurseForge

I would ask that this not be done. If they are hungry, let them eat Cork. For me, I find that a debuff removing addon should do only that.

Quote from theondry »

I would ask that this not be done.  If they are hungry, let them eat Cork.  For me, I find that a debuff removing addon should do only that.

Agreed. Get detox to be everything or as close to Decursive as possible, but leave it at that. If you decide to add other options to further enchance what is currently there, great, but the core functionality should remain the same imo.

Quote from maia »

Make me a nice icon that will work in various resolutions. Or suggest a different one. I don't really care which icon Detox is using. :)

I suggest Mokura, the evil poison/disease cloud. :-p

Here's both icons, refined a bit and tested... Here's a screenshot:



Mok works better in lower resolutions than Yuk does, I'm afraid.

Mok ftw.

-Ammo

using it at chinese wow,I got this error window

Update all your Ace2 addons. There was some change in AceOO.

-Ammo

I was getting some extremely poor performance with Detox this morning, mostly on players joining/leaving the raid. Attached are my increasing rate and tekSupport OnEvent pictures. This was r8173 by the bye. Edit: this is in fact the latest revision.

Personally I prefer Yuk over Mok, but I'll leave the decision to you guys (lets say, whoever commits a new icon wins ;) ).

Qtr, as for the bad performance: basically two functions are triggered on PARTY_MEMBERS_CHANGED: Detox:UpdateRoster(), which will rescan the roster and create a table with all units, and once that's done, Detox:UpdatePriorityList(), which updates the priority list and creates the config menu for the priority list.

The first function will be replaced by RosterLib soon, as I'm planning to introduce a new priority code which should streamline the process a lot - and for the second function I can only try to add some more compost to it (wonder why it's using 280kb/call, I really am).

So in case you're also running LuaProfiler (I prefer v1.4 over v1.5 because you'll see everything at a glance), please try to find out which function is causing the problem. I'll be raiding this weekend, but it would help a lot if I'd have some more feedback before saturday.

Thanks again.

Quote from dreadlyone »

Quote from theondry »

I would ask that this not be done. If they are hungry, let them eat Cork. For me, I find that a debuff removing addon should do only that.

Agreed. Get detox to be everything or as close to Decursive as possible, but leave it at that. If you decide to add other options to further enchance what is currently there, great, but the core functionality should remain the same imo.

Exactly my Opinion. The Display of curses etc. IS a Decursive Functionality btw. ;)

Quote from Duglum »

Quote from dreadlyone »

Quote from theondry »

I would ask that this not be done.  If they are hungry, let them eat Cork.  For me, I find that a debuff removing addon should do only that.

Agreed.  Get detox to be everything or as close to Decursive as possible, but leave it at that.  If you decide to add other options to further enchance what is currently there,  great, but the core functionality should remain the same imo.

Exactly my Opinion. The Display of curses etc. IS a Decursive Functionality btw. ;)

Well, what I was suggesting was the possibility to merge the 2 addons if 90% of the code was the same. They would be separate addons. If someone had BOTH addons give them the ability to merge the addons together.

As for now, Detox will only be a Decursive replacement. Not more, not less. I don't really know how the live display will look - Moonsorrow wanted to work on it this weekend.

Quote from OttoDeFe »

Quote from Nakawe »

Quote from Duglum »

Well.. i don't need a full Buffscan-thingy, i just want to have curses displayed. ;)

hmm, doesnt the scan happen anyway and just information needed is taken from table?  If this is the case.....  is there any way in future to integrate corkfu with detox? 

Kinda like honor_fu and Exp_fu are merged.

You COULD call it "PityParty", but then, not everyone wants the fusion...

Hmm, if you dont want the fusion the dont fuse them, for those of us that do, the option to fuse would be nice. But, as maia said we have to wait to see what moonsorrow comes up with

Instead of the talk about merging Detox with Cork... is there a buff/debuff scan library that could be ripped out of both an used as a shared library. That would be the only thing that I think might make sense. If this is already being done, ignore me.

CorkFu is great for seeing that a bunch of people just got debuffed. AFAIK, it doesn't tell you what the debuff is nor does it give the proper icon for that debuff. That's the only thing I preferred about Decursive's display.

Example: I'm raiding Naxx as a paladin. We're fighting those ghostly staves. 10 people are Frost Nova'd and one is Polymorph'd. As far as CorkFu is concerned, there are simply 11 people debuffed by magic.

Of course I realise this is more of a CorkFu complaint...

Oh, and Mr Yuk looks very cool. That other icon is too...happy.

Quote from Peragor »

is there a buff/debuff scan library that could be ripped out of both an used as a shared library.  That would be the only thing that I think might make sense.  If this is already being done, ignore me.

SpecialEvents-Aura-2.0. It still needs some optimization, but tekkup is hopefully working on it these days. I assume CorkFu-2 will also use it when available.

Dunno how high res it needs to be, but this probably looks more cloud'ish and definitely looks more Mokura'ish. But if it doesn't get used, meh.

Here's an icon file with the brighter Mok, haven't gotten to test this one out yet.

Just made a rather large update. No more wasted memory, higher performance, and everything else is better too.