possible to have cooldown counts displayed on the "macro" as well as quantity of item or is that a "per action bar mod" type of thing?
secondary request:
pop-ups (ie i have combat mana and major mana, i hold shift and the various options for that category pop up)
this sounds more like an actionbar thing tho
cooldown counts and quantity would rock tho
I have a feature request for you to consider. I had asked for this for Autobar but never got a reponse. Could you make an option to only use BG related items in BGs. I don't want to burn a Major Potion when I have the cheap BG stuff. As it is now, If I am going to run BG, I have to take all of my healing potions and put in bank.
I have a feature request for you to consider. I had asked for this for Autobar but never got a reponse. Could you make an option to only use BG related items in BGs. I don't want to burn a Major Potion when I have the cheap BG stuff. As it is now, If I am going to run BG, I have to take all of my healing potions and put in bank.
Autobar does this very well already.
But it doesn't prevent you from blowing a greater pot if you run out of AV pots, I think that's what he wants.
doesn't seem to pick up Alterac Mana Biscuit as food. Also should cBandageAll work? I'm not quite sure I'm doing this correctly. Got it to work for potions and I like what I see.
I have a feature request for you to consider. I had asked for this for Autobar but never got a reponse. Could you make an option to only use BG related items in BGs. I don't want to burn a Major Potion when I have the cheap BG stuff. As it is now, If I am going to run BG, I have to take all of my healing potions and put in bank.
Autobar does this very well already.
No Autobar doesn't. It will use the Major Potion first if the Health deficit is larger than a BG potion would heal for.. I don't want to waste a 1g+ potion in a BG ever.
No Autobar doesn't. It will use the Major Potion first if the Health deficit is larger than a BG potion would heal for.. I don't want to waste a 1g+ potion in a BG ever.
This will be added next, annoys the hell out of me. I will be adding an option that prevents any non-bg consumables from working if you are in battlegrounds possibly expanding the option later on.
Update: I found the problem with normal bandages getting selected over BG bandages is simply because they have the same "value" in Periodic Table, I will check to see if I can convince the PT maintainers to add an additional value to BG consumables.
Would be nice if the debug setting was saved between logins.
EDIT:
With bartender2, I get this error every time I press a key to triger an action button:
Interface\FrameXML\ActionButton.lua:445: attempt to index a nil value
The action goes through (i.e. I eat the food) however. Clicking causes no error, and the counts etc. work fine. To clarify I get this error for *all* actions, not just the consumer macros.
Would be nice if the debug setting was saved between logins.
EDIT:
With bartender2, I get this error every time I press a key to triger an action button:
Interface\FrameXML\ActionButton.lua:445: attempt to index a nil value
The action goes through (i.e. I eat the food) however. Clicking causes no error, and the counts etc. work fine. To clarify I get this error for *all* actions, not just the consumer macros.
Same :(
EDIT#1: updated this morning all sames to be ok now.
EDIT#2: getting different error now from KC_Items when I rollover the macro button that is empty (red)...
File: KC_Items\tooltip\tooltip.lua
Line: 122
Error: Usage: GetContainerItemLine(index,slot)
EDIT#3: Last edit of the day :) where can i find a list of all the acceptable macronames, I cant find a list of the catagories in the periocic table :/ thanks.
I really wanted Consumer to be BG aware, so I played around with it this morning until I got something that works. Haven't tested this extensively but it seems to be working well so far.
I just defined a validate function to pass in to periodicTable:GetBest(). I also defined a compare function (which has nothing to do with BGs, but selects smaller stacks when item values are equal, just to empty bag slots quicker). I put this code above your Consumer:GetConsumable(id) function declaration:
local validatefunc = function(bag, slot, val)
local bg = nil
local link = GetContainerItemLink(bag, slot)
local bgsets = {"bandagesalterac", "bandagesarathi", "bandageswarsong", "potionhealalterac", "potionmanaalterac"}
local value, set = periodicTable:ItemInSet(link, bgsets)
if (MiniMapBattlefieldFrame.status == "active") then
bg = GetRealZoneText()
end
if bg then
if value then
if string.find(set, "potion") or
(bg == "Alterac Valley" and set == "bandagesalterac") or
(bg == "Arathi Basin" and set == "bandagesarathi") or
(bg == "Warsong Gulch" and set == "bandageswarsong") then
return true
else
return false
end
end
elseif value then
return false
end
return true
end
local comparefunc = function(abag, aslot, aval, bbag, bslot, bval)
if aval == bval then
local acount = 0
local bcount = 0
_, acount, _, _, _ = GetContainerItemInfo(abag, aslot)
_, bcount, _, _, _ = GetContainerItemInfo(bbag, bslot)
return acount < bcount
end
return aval > bval
end
Then, in GetConsumable, replace this:
local bagID, bagSlot, _ = periodicTable:GetBest(set)
with this:
local bagID, bagSlot, _ = periodicTable:GetBest(set, comparefunc, validatefunc)
I just signed up on the boards here and am not too knowledgable about SVN (or lua for that matter)... and I didn't want to step on your code. But I thought I'd post this just as an example, and maybe help others get this functionality before it's officially there. :)
I really wanted Consumer to be BG aware, so I played around with it this morning until I got something that works. Haven't tested this extensively but it seems to be working well so far.
This is one of those essentials that I wish I'd come across sooner :P Great stuff!!
Just a few notes- I get an error if I mouse over a consumer action button where there are no items for it present. The error is:
[2006/09/19 16:39:21-144]: tooltip\tooltip.lua:122: Usage: GetContainerItemLink(index, slot)
<in C code>: in function `GetContainerItemLink'
tooltip\tooltip.lua:122: in function <Interface\AddOns\KC_Items\tooltip\tooltip.lua:119>
<unknown>:
Consumer\core.lua:62: in function <Interface\AddOns\Consumer\core.lua:56>
<unknown>:
<string>:"MultiBarRightButton6:OnEnter":2: in main chunk
---
Looks to be a conflict with KCI's tooltip/inventory handling. Anything that can be done about this?
Thanks!
PS: With that latest commit Rabbit, it doesn't detect Babble at all for some reason, and breaks alot of addons that depend on it...it's weird.
Sadly I've got too much IRL work on my hands at the moment to work on this mod right now, I'd really appriciate if someone branched it out and resumed work on it.
secondary request:
pop-ups (ie i have combat mana and major mana, i hold shift and the various options for that category pop up)
this sounds more like an actionbar thing tho
cooldown counts and quantity would rock tho
Autobar does this very well already.
But it doesn't prevent you from blowing a greater pot if you run out of AV pots, I think that's what he wants.
No Autobar doesn't. It will use the Major Potion first if the Health deficit is larger than a BG potion would heal for.. I don't want to waste a 1g+ potion in a BG ever.
How would I go about adding Alterac Mana Biscuits to PT?
This will be added next, annoys the hell out of me. I will be adding an option that prevents any non-bg consumables from working if you are in battlegrounds possibly expanding the option later on.
Update: I found the problem with normal bandages getting selected over BG bandages is simply because they have the same "value" in Periodic Table, I will check to see if I can convince the PT maintainers to add an additional value to BG consumables.
The anchoring system and empty-slots-hiding management of AutoBar are really useful.
I'll consider using Consumer if it ever works the same way, slot-wise :]
//ui.worldofwar.net/ui.php?id=1580">SmartMedic" target="" data-ensure-absolute>http://ui.worldofwar.net/ui.php?id=1580">SmartMedic
I't still works, but has some isues with usingen Conjured items first, you might find that code helpfull
EDIT:
With bartender2, I get this error every time I press a key to triger an action button:
The action goes through (i.e. I eat the food) however. Clicking causes no error, and the counts etc. work fine. To clarify I get this error for *all* actions, not just the consumer macros.
qft! Separate movable bar frame is the way AutoBar attracts people :) I wish Consumer to have this soon! :)
Same :(
EDIT#1: updated this morning all sames to be ok now.
EDIT#2: getting different error now from KC_Items when I rollover the macro button that is empty (red)...
File: KC_Items\tooltip\tooltip.lua
Line: 122
Error: Usage: GetContainerItemLine(index,slot)
EDIT#3: Last edit of the day :) where can i find a list of all the acceptable macronames, I cant find a list of the catagories in the periocic table :/ thanks.
I really wanted Consumer to be BG aware, so I played around with it this morning until I got something that works. Haven't tested this extensively but it seems to be working well so far.
I just defined a validate function to pass in to periodicTable:GetBest(). I also defined a compare function (which has nothing to do with BGs, but selects smaller stacks when item values are equal, just to empty bag slots quicker). I put this code above your Consumer:GetConsumable(id) function declaration:
Then, in GetConsumable, replace this:
with this:
I just signed up on the boards here and am not too knowledgable about SVN (or lua for that matter)... and I didn't want to step on your code. But I thought I'd post this just as an example, and maybe help others get this functionality before it's officially there. :)
-Pingbo
You rock. I committed your code here, slightly modified with Babble-Zone and a bit updated from the original Consumer:
http://svn.wowace.com/root/branches/Consumer/Pingbo/
Just a few notes- I get an error if I mouse over a consumer action button where there are no items for it present. The error is:
Looks to be a conflict with KCI's tooltip/inventory handling. Anything that can be done about this?
Thanks!
PS: With that latest commit Rabbit, it doesn't detect Babble at all for some reason, and breaks alot of addons that depend on it...it's weird.