would like to point on this very nice addon who appear recently on the svn.
support lock, mages, priest atm and is in heavy dev according to author's notes.
i create this topic to publish also an error correction i do for addon display his data on TBC (not tested on live)
replace function
function DrDamage:SpellCrit()
if ManualDmg then
local crit = GetSpellCritChanceFromIntellect() + DrDamage.db.profile.ItemCrit * 100
return crit
else
local crit = GetSpellCritChanceFromIntellect() + GetCombatRatingBonus(11)
return crit
end
end
by :
function DrDamage:SpellCrit()
local holySchool = 2;
local minCrit = GetSpellCritChance(holySchool);
local spellCrit;
this.spellCrit = {};
this.spellCrit[holySchool] = minCrit;
for i=(holySchool+1), 7 do
spellCrit = GetSpellCritChance(i);
minCrit = min(minCrit, spellCrit);
this.spellCrit[i] = spellCrit;
end
if ManualDmg then
local crit = minCrit + DrDamage.db.profile.ItemCrit * 100
return crit
else
local crit = minCrit + GetCombatRatingBonus(11)
return crit
end
end
found on wowwiki, dunno if it is the most accurate but that works and data seams realistics
Loving the mod.
Quick issue I noticed right away. With my mage (Arcane spec), the mod is not adding the 3% crit from "Arcane Instability".
Also, dunno if you plan do, but Arcane Power should show the new values (good for checking damage outputs and see which spec could work the best)
Loving the mod.
Quick issue I noticed right away. With my mage (Arcane spec), the mod is not adding the 3% crit from "Arcane Instability".
Also, dunno if you plan do, but Arcane Power should show the new values (good for checking damage outputs and see which spec could work the best)
Alright. Apparently the WoW API isn't adding that crit percentage to the character screen. I've got to add it manually. It'll be fixed in the next release.
I'll also add Arcane Power detection. Please tell me if it works.
would like to point on this very nice addon who appear recently on the svn.
support lock, mages, priest atm and is in heavy dev according to author's notes.
i create this topic to publish also an error correction i do for addon display his data on TBC (not tested on live)
replace function
function DrDamage:SpellCrit()
if ManualDmg then
local crit = GetSpellCritChanceFromIntellect() + DrDamage.db.profile.ItemCrit * 100
return crit
else
local crit = GetSpellCritChanceFromIntellect() + GetCombatRatingBonus(11)
return crit
end
end
by :
function DrDamage:SpellCrit()
local holySchool = 2;
local minCrit = GetSpellCritChance(holySchool);
local spellCrit;
this.spellCrit = {};
this.spellCrit[holySchool] = minCrit;
for i=(holySchool+1), 7 do
spellCrit = GetSpellCritChance(i);
minCrit = min(minCrit, spellCrit);
this.spellCrit[i] = spellCrit;
end
if ManualDmg then
local crit = minCrit + DrDamage.db.profile.ItemCrit * 100
return crit
else
local crit = minCrit + GetCombatRatingBonus(11)
return crit
end
end
found on wowwiki, dunno if it is the most accurate but that works and data seams realistics
Well, the version I use currently works better on live (well, on my warlock at least) then grabbing crit by spellschool which is also possible. Talents aren't being applied properly so it's better to just grab base crit from your intelligence (by the new 2.0 API command) + crit from items and then manually add all talents to make sure.
If the API has changed in TBC, and that spellcrit by school actually works I will update when needed :)
Alright. Apparently the WoW API isn't adding that crit percentage to the character screen. I've got to add it manually. It'll be fixed in the next release.
I'll also add Arcane Power detection. Please tell me if it works.
The character sheet shows the crit, which for me was 15.6, untalented would be 12.6 which is the number DrD was showing. I'll try the updated version and hope it all works :)
With the introduction of new macro functionality in 2.0, I'm finding I'm using macros for most of my heal/dispel/buff spells. Specifically, with Grid, I'm using this format for my macros:
/cast [target=mouseover,nodead] NameOfSpell
Is it possible for DrDamage to overlay on the button the amount of average healing a heal will do when using macros similar to the above format?
Bug
Priest spell Holy Nova: only damage is being displayed on a button (healing is not displayed). This is unique to this spell, as it's the only spell that does damage and heals at the same time. Perhaps go with a "DMG/HEAL" display or the option to display one or the other?
With the introduction of new macro functionality in 2.0, I'm finding I'm using macros for most of my heal/dispel/buff spells. Specifically, with Grid, I'm using this format for my macros:
/cast [target=mouseover,nodead] NameOfSpell
Is it possible for DrDamage to overlay on the button the amount of average healing a heal will do when using macros similar to the above format?
Bug
Priest spell Holy Nova: only damage is being displayed on a button (healing is not displayed). This is unique to this spell, as it's the only spell that does damage and heals at the same time. Perhaps go with a "DMG/HEAL" display or the option to display one or the other?
I'm aware of the holy nova situtation, but since there's still a lot more important stuff to do I'll postpone the work on that. Making new functionality for single spells is a bit pointless right now. Will think of a solution later for sure.
And on the macro front.. I might be able to do something like, if you name the macro Spell(rank) it would display the data. But I need to postpone on work that for a few days, will let you know.
on line 1091, "BuffData" needs to be "buffData" (lowercase b)
I started patching in Druid stuff: Gift of Nature and Improved Rejuvenation are additive, NOT multiplicative. Is there a way to signify this?
Thanks for noticing that upper case case typo (fixed another one too).
Stuff that affects the final coefficient of the spell as in here are automatically assumed additive (since all that I know of works that way). There's no need to signify it.
You list the theoretical benefits of +10 spell damage and +1% crit, can you do the same for 1% spell hit as well?
Sure. But I'd need to write some kind of basis for the evaluation, which will of course depend on what level of mobs you are fighting. What do you suggest, target level, user settable, or assume level 63?
Stuff that affects the final coefficient of the spell as in here are automatically assumed additive (since all that I know of works that way). There's no need to signify it.
Then something else is wrong. DrD is saying my Rejuv would heal for 2536, but it actually heals for 2479. I will wait for you to officially put in Druid spells/talents before I start complaining though =p
Stuff that affects the final coefficient of the spell as in here are automatically assumed additive (since all that I know of works that way). There's no need to signify it.
Then something else is wrong. DrD is saying my Rejuv would heal for 2536, but it actually heals for 2479. I will wait for you to officially put in Druid spells/talents before I start complaining though =p
If I'd have to suspect something then I'd suspect the base heal range you've entered. It's pretty weird now. The base heal of a spell actually increases when you level up until you get the next rank so unless the spell is learned at level 60 then thottbott values will be slightly wrong. And on the other hand if you use in-game tooltip values, it will be wrong because the tooltip damage/heal range has some talents added to it.
I'm currently working on the formula for increase in base damage/heal on leveling, then thottbott values will be correct.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
support lock, mages, priest atm and is in heavy dev according to author's notes.
i create this topic to publish also an error correction i do for addon display his data on TBC (not tested on live)
replace function
by :
function DrDamage:SpellCrit() local holySchool = 2; local minCrit = GetSpellCritChance(holySchool); local spellCrit; this.spellCrit = {}; this.spellCrit[holySchool] = minCrit; for i=(holySchool+1), 7 do spellCrit = GetSpellCritChance(i); minCrit = min(minCrit, spellCrit); this.spellCrit[i] = spellCrit; end if ManualDmg then local crit = minCrit + DrDamage.db.profile.ItemCrit * 100 return crit else local crit = minCrit + GetCombatRatingBonus(11) return crit end endfound on wowwiki, dunno if it is the most accurate but that works and data seams realistics
i create a bug report http://www.wowace.com/trac/ticket/43# on trac
TC users (mainly casters :> ) give it a try
Doesnt really need a screenshot
It simply changes the standard values of the spells to the damage you are doing with your current gear and talents.
e.g. Frostbolt rank 11 does like 400-500 dmg standard then with +700 Spell Damage and Frostspec it displays 1100ish-1200ish
And i guess as with TC you can display crit values, avg. crit damage etc. etc. aswell
and u could also show dps/hpm etc on bouton like a learntocount display
I'll remember to get the latest build of this so i can test it while I stinkyqueue AV tommarow.
TC2: http://www.curse-gaming.com/en/files/details/5360/theorycraft-2/ ;)
Quick issue I noticed right away. With my mage (Arcane spec), the mod is not adding the 3% crit from "Arcane Instability".
Also, dunno if you plan do, but Arcane Power should show the new values (good for checking damage outputs and see which spec could work the best)
Alright. Apparently the WoW API isn't adding that crit percentage to the character screen. I've got to add it manually. It'll be fixed in the next release.
I'll also add Arcane Power detection. Please tell me if it works.
http://www.wowace.com/wiki/DrDamage
I'm trying to keep that relatively updated with the functions.
Well, the version I use currently works better on live (well, on my warlock at least) then grabbing crit by spellschool which is also possible. Talents aren't being applied properly so it's better to just grab base crit from your intelligence (by the new 2.0 API command) + crit from items and then manually add all talents to make sure.
If the API has changed in TBC, and that spellcrit by school actually works I will update when needed :)
The character sheet shows the crit, which for me was 15.6, untalented would be 12.6 which is the number DrD was showing. I'll try the updated version and hope it all works :)
/cast [target=mouseover,nodead] NameOfSpell
Is it possible for DrDamage to overlay on the button the amount of average healing a heal will do when using macros similar to the above format?
Bug
Priest spell Holy Nova: only damage is being displayed on a button (healing is not displayed). This is unique to this spell, as it's the only spell that does damage and heals at the same time. Perhaps go with a "DMG/HEAL" display or the option to display one or the other?
I started patching in Druid stuff: Gift of Nature and Improved Rejuvenation are additive, NOT multiplicative. Is there a way to signify this?
I'm aware of the holy nova situtation, but since there's still a lot more important stuff to do I'll postpone the work on that. Making new functionality for single spells is a bit pointless right now. Will think of a solution later for sure.
And on the macro front.. I might be able to do something like, if you name the macro Spell(rank) it would display the data. But I need to postpone on work that for a few days, will let you know.
Thanks for noticing that upper case case typo (fixed another one too).
Stuff that affects the final coefficient of the spell as in here are automatically assumed additive (since all that I know of works that way). There's no need to signify it.
Sure. But I'd need to write some kind of basis for the evaluation, which will of course depend on what level of mobs you are fighting. What do you suggest, target level, user settable, or assume level 63?
Then something else is wrong. DrD is saying my Rejuv would heal for 2536, but it actually heals for 2479. I will wait for you to officially put in Druid spells/talents before I start complaining though =p
If I'd have to suspect something then I'd suspect the base heal range you've entered. It's pretty weird now. The base heal of a spell actually increases when you level up until you get the next rank so unless the spell is learned at level 60 then thottbott values will be slightly wrong. And on the other hand if you use in-game tooltip values, it will be wrong because the tooltip damage/heal range has some talents added to it.
I'm currently working on the formula for increase in base damage/heal on leveling, then thottbott values will be correct.