Joshwill, I've been thinking about adding a solo mode too, but mainly for debug reasons. Are you planning to replace all your unit frames by Squishy? Or do you happen to use unit frames that don't support clickcasting?
As for friendly ungrouped targets: there is no real way to scan them and keep them in the roster. Doubt I'll add that soon. Still trying to find remaining bugs, optimize the code, make localizations possible and release a 1.0. Then we'll see what is next - it partly depends on the general feedback. :)
Using this in MC atm. I really like overall looking, that handy CTRA intergration, AceHeal code works perfect, but one thing I dont get.... WHY I cant target players by clicking on their name/hpbar??? This is the only thing that made me to swith back to Emonitor :|
edit: I also have a request. Can you please an option to remove background frame or change its alpha?
1) It might be nice to be able to move the alert frame. A friend of mine I've converted to Squishy found that the alerts were over his ToT frame. He used DART to move the alert frame, but there needs to be a better way. The fact that Squishy use CT_RA_WarningFrame if it exists complicated the matter though. Does CTRA have a way to move its alert frame already?
2) The green "H" to indicate someone getting healed is pretty cool. It would be nice to have some indicator as to which of those (if any) is my heal though.
3) The new frame reuse feature is great. Not having units jumping around is really nice. However it would still be very nice to have an indicator as to which unit currently has the highest priority. Color coding bars based on priority rather than health (as I believe it currently works) might also help.
4) Working in solo mode and maybe party pet support might be nice...
i use minigroup 2 for my regular party frames, but i dont use click casting on them. i pretty much use them for the default blizzard functions (changing party loot type, selecting targets, etc). i just use them instead of default blizzard frames because of how clean they are.
anyway, i currently use needylist for all my buffing/click cast healing needs. i'm looking for replacements for needylist because of how fat it has become in ui memory usage.
so to answer your question, yeah i'm hoping to use squishy as my unit frames when it comes to healing, that's why i was hoping to see a solo mode implemented.
Hey maia, I've had a few people requesting range checking similar to Squishy's for CorkFu... and I had an idea. Why don't you convert the range checking into an embeddable library? That'll remove duplicate code and such :) The mod would simply need to poll the embed to find out if the unit is in range, or maybe that time of the last action seen from the unit or something. I'm gonna skim your range code later, but I think a shared embed might be a great thing :)
I want a Raid Unit Frame that uses range check similar to Squishy's. Raid Frames that sorts by class and shows defecit. with Squishy's range check would be superb. Unfortunately I don't like the xRaid's range check. You have to have a heal selected on your tooltip for it to update. which doesn't work at all if your using click casting:/
Hmm, current SVN version seems to get confused sometimes - it APPEARS that occasionally not all units are being displayed that should be. I'm trying to track down whether this is even happening, and if so, why. :-(
1. problem with click targetting / uaxli: hmm, of course you should be able to target a unit by clicking on it. Is it possible another addon is interfering? Or that another frame (maybe hidden) is on top of the Squishy frame? My xml knowledge is very limited, but I've had a similar problem once with a frame that was hidden on top of another frame, so the frame below didn't see my clicks. Can you try to move Squishy to somewhere else on the screen and see what happenes?
2. hiding border / uaxli: as for the background, this is on my to do list. I just don't know how to do it at the moment, as the border/background is a parent of the unit frames, so hiding/alphaing the border will also hide/alpha the units. Still hoping for someone with ui knowledge to help with the code.
3. alert frame / codayus: actually my plan was to move the alerts being displayed in the alert frame to the bottom area of the emergency monitor and get rid of the emergency frame. does that sound like a good idea?
4. priority display / codayus: the bars are colored by health percentage. I'm not sure if coloring them by priority would help, but it's worth a try. An alternative could be to add a <<< next to the unit with the highest priority, a << next to the second unit and a < to the third unit. Or any other decent and small graphic. I have never used .tga files nor know how to place them somewhere though. Yet. :)
5. solo mode / codayus: guess adding a solo mode option isn't that much work. I'll add it sooner or later.
6. range check library / tekkub: that sounds like a great idea. My code does two things at the moment: watch various events (UNIT_HEALTH, combat,...) as people with a distance >50-60yrds don't trigger events, and a scheduled (once per sec) interact check (28yrds, the follow distance). Feel free to rip that code and convert it to an embeddable library. It would definetly reduce redundant code and motivate people to optimize the range code.
7. target function / rulan: yeah, you're right. I rarely use that function myself. I'll try to fix it and also add some functionality that will check if all spells on your spell bar are in range, and if not, skip to the next person on the list. Or maybe a: GetFirstUnitInRange(spell)?
EDIT2: uploaded a possible fix, please test it. TargetSquishyUnitByPriority(1) should target the unit with the highest priority, no matter which frame the unit is being displayed in, and TargetSquishyUnitByPosition(1) should target the first frame, no matter which priority the unit has. These two functions replaced TargetSquishyUnit() and are usable for a range 1-10.
8. possible priority bug / codayus: right now the code does the following:
- build a priority list based on various modifiers (see first post in thread)
- build a list of units which currently are being displayed in the frame
- update these units
- remove all other frames
- fill these now unused frames with people on the priority list until we have a max of 10 units again.
For debugging you could enable lines 882-886 in core.lua to display the priority numbers next to each unit - you should always have a complete list 1-10, no number should be skipped. If a number is skipped, then we have a problem in UpdatePriorityFrames(). You could also loop through TargetSquishyUnitByPriority(pri) and see if all 10 units are visible on the frame via a small function.
I won't have much time until monday, so whoever finds a bug and is able to fix it, please simply commit it to the SVN. Any help is appreciated. At the moment I don't even have time to launch wow at all.
1. problem with click targetting / uaxli: hmm, of course you should be able to target a unit by clicking on it. Is it possible another addon is interfering? Or that another frame (maybe hidden) is on top of the Squishy frame? My xml knowledge is very limited, but I've had a similar problem once with a frame that was hidden on top of another frame, so the frame below didn't see my clicks. Can you try to move Squishy to somewhere else on the screen and see what happenes?
tried everywhere, addon working perfect, but click targeting not :((
uaxli, are you able to move the frame by dragging it when clicked on its header? If yes, then at least we know that there's no hidden layer on top. On the other hand, this will make it even stranger. Are you using WatchDog or AceHeal? Any other addons that hook mouse clicking in any kind?
uaxli, are you able to move the frame by dragging it when clicked on its header? If yes, then at least we know that there's no hidden layer on top. On the other hand, this will make it even stranger. Are you using WatchDog or AceHeal? Any other addons that hook mouse clicking in any kind?
Yes Im able to move the frame wherever I want to, as I said all works perfect. Im using AceHeal (have only binded Alt_LeftClick=Renew, Alt_RightClick=Shield) - all works with Squishy, using code posted above. When I move cursor over any Squishy HP bars - they are highlighted, which I think is supposed to be, but clicking on them does nothing, I mean it does not select this person. Very wired. Cant even imagine what addon can cause this, AH is the only one hooking into mouse. *Sigh*, I guess ill try the worst test - turning off all addons one-by-one :) But dunno if I will have enough time this week
uaxli, are you able to move the frame by dragging it when clicked on its header? If yes, then at least we know that there's no hidden layer on top. On the other hand, this will make it even stranger. Are you using WatchDog or AceHeal? Any other addons that hook mouse clicking in any kind?
Yes Im able to move the frame wherever I want to, as I said all works perfect. Im using AceHeal (have only binded Alt_LeftClick=Renew, Alt_RightClick=Shield) - all works with Squishy, using code posted above. When I move cursor over any Squishy HP bars - they are highlighted, which I think is supposed to be, but clicking on them does nothing, I mean it does not select this person. Very wired. Cant even imagine what addon can cause this, AH is the only one hooking into mouse. *Sigh*, I guess ill try the worst test - turning off all addons one-by-one :) But dunno if I will have enough time this week
uaxli, pls disable AceHeal and see what happenes then. I never used AceHeal myself, but I guess as it's hooking the other clicks besides left-click you might have to bind LeftClick to TargetUnit()? If even the bars are highlighted when hovering the mouse above then I'd say that Squishy is working fine and it must be something else. Hm.
3. alert frame / codayus: actually my plan was to move the alerts being displayed in the alert frame to the bottom area of the emergency monitor and get rid of the emergency frame. does that sound like a good idea?
Now this is what I call a service. Mod author knows what I'm about to suggest before I even manage to hit the boards ;).
uaxli, are you able to move the frame by dragging it when clicked on its header? If yes, then at least we know that there's no hidden layer on top. On the other hand, this will make it even stranger. Are you using WatchDog or AceHeal? Any other addons that hook mouse clicking in any kind?
Yes Im able to move the frame wherever I want to, as I said all works perfect. Im using AceHeal (have only binded Alt_LeftClick=Renew, Alt_RightClick=Shield) - all works with Squishy, using code posted above. When I move cursor over any Squishy HP bars - they are highlighted, which I think is supposed to be, but clicking on them does nothing, I mean it does not select this person. Very wired. Cant even imagine what addon can cause this, AH is the only one hooking into mouse. *Sigh*, I guess ill try the worst test - turning off all addons one-by-one :) But dunno if I will have enough time this week
uaxli, pls disable AceHeal and see what happenes then. I never used AceHeal myself, but I guess as it's hooking the other clicks besides left-click you might have to bind LeftClick to TargetUnit()? If even the bars are highlighted when hovering the mouse above then I'd say that Squishy is working fine and it must be something else. Hm.
kk Ill try this at home today. If its AH - then I suppose that AceHealSquishy code need to be rewriten if it prevents from clicktargeting
Seems as if Codayus is right. Not all people who need a heal are displayed properly, some frames will stay empty. I havent figured out why though. If anyone has some time and coding experience, stare at UpdatePriorityFrames(), there must be a bug within these 50 lines of code.
FWIW clicking once just highlights the person's name on the list but doesn't change target always. I've gotten into the habbit of double clicking the unit in the frame, which does indeed change targets. I'm not using aceheal or anything like that.
FryGuy, are you using the latest SVN version? The behaviour you described sounds very strange to me, as there is no function that highlights on click - on click targets a unit, and next time the frames are updated the code will check each units name and compare it with the name of your target - and highlight the unit, if the names match. So not targetting someone but highlighting, that seems to be impossible.
Rollback Post to RevisionRollBack
To post a comment, please login or register a new account.
As for friendly ungrouped targets: there is no real way to scan them and keep them in the roster. Doubt I'll add that soon. Still trying to find remaining bugs, optimize the code, make localizations possible and release a 1.0. Then we'll see what is next - it partly depends on the general feedback. :)
edit: I also have a request. Can you please an option to remove background frame or change its alpha?
Thoughts:
1) It might be nice to be able to move the alert frame. A friend of mine I've converted to Squishy found that the alerts were over his ToT frame. He used DART to move the alert frame, but there needs to be a better way. The fact that Squishy use CT_RA_WarningFrame if it exists complicated the matter though. Does CTRA have a way to move its alert frame already?
2) The green "H" to indicate someone getting healed is pretty cool. It would be nice to have some indicator as to which of those (if any) is my heal though.
3) The new frame reuse feature is great. Not having units jumping around is really nice. However it would still be very nice to have an indicator as to which unit currently has the highest priority. Color coding bars based on priority rather than health (as I believe it currently works) might also help.
4) Working in solo mode and maybe party pet support might be nice...
5) Didn't see any bugs.
anyway, i currently use needylist for all my buffing/click cast healing needs. i'm looking for replacements for needylist because of how fat it has become in ui memory usage.
so to answer your question, yeah i'm hoping to use squishy as my unit frames when it comes to healing, that's why i was hoping to see a solo mode implemented.
2. hiding border / uaxli: as for the background, this is on my to do list. I just don't know how to do it at the moment, as the border/background is a parent of the unit frames, so hiding/alphaing the border will also hide/alpha the units. Still hoping for someone with ui knowledge to help with the code.
3. alert frame / codayus: actually my plan was to move the alerts being displayed in the alert frame to the bottom area of the emergency monitor and get rid of the emergency frame. does that sound like a good idea?
4. priority display / codayus: the bars are colored by health percentage. I'm not sure if coloring them by priority would help, but it's worth a try. An alternative could be to add a <<< next to the unit with the highest priority, a << next to the second unit and a < to the third unit. Or any other decent and small graphic. I have never used .tga files nor know how to place them somewhere though. Yet. :)
5. solo mode / codayus: guess adding a solo mode option isn't that much work. I'll add it sooner or later.
6. range check library / tekkub: that sounds like a great idea. My code does two things at the moment: watch various events (UNIT_HEALTH, combat,...) as people with a distance >50-60yrds don't trigger events, and a scheduled (once per sec) interact check (28yrds, the follow distance). Feel free to rip that code and convert it to an embeddable library. It would definetly reduce redundant code and motivate people to optimize the range code.
7. target function / rulan: yeah, you're right. I rarely use that function myself. I'll try to fix it and also add some functionality that will check if all spells on your spell bar are in range, and if not, skip to the next person on the list. Or maybe a: GetFirstUnitInRange(spell)?
EDIT2: uploaded a possible fix, please test it. TargetSquishyUnitByPriority(1) should target the unit with the highest priority, no matter which frame the unit is being displayed in, and TargetSquishyUnitByPosition(1) should target the first frame, no matter which priority the unit has. These two functions replaced TargetSquishyUnit() and are usable for a range 1-10.
8. possible priority bug / codayus: right now the code does the following:
- build a priority list based on various modifiers (see first post in thread)
- build a list of units which currently are being displayed in the frame
- update these units
- remove all other frames
- fill these now unused frames with people on the priority list until we have a max of 10 units again.
For debugging you could enable lines 882-886 in core.lua to display the priority numbers next to each unit - you should always have a complete list 1-10, no number should be skipped. If a number is skipped, then we have a problem in UpdatePriorityFrames(). You could also loop through TargetSquishyUnitByPriority(pri) and see if all 10 units are visible on the frame via a small function.
I won't have much time until monday, so whoever finds a bug and is able to fix it, please simply commit it to the SVN. Any help is appreciated. At the moment I don't even have time to launch wow at all.
tried everywhere, addon working perfect, but click targeting not :((
Yes Im able to move the frame wherever I want to, as I said all works perfect. Im using AceHeal (have only binded Alt_LeftClick=Renew, Alt_RightClick=Shield) - all works with Squishy, using code posted above. When I move cursor over any Squishy HP bars - they are highlighted, which I think is supposed to be, but clicking on them does nothing, I mean it does not select this person. Very wired. Cant even imagine what addon can cause this, AH is the only one hooking into mouse. *Sigh*, I guess ill try the worst test - turning off all addons one-by-one :) But dunno if I will have enough time this week
uaxli, pls disable AceHeal and see what happenes then. I never used AceHeal myself, but I guess as it's hooking the other clicks besides left-click you might have to bind LeftClick to TargetUnit()? If even the bars are highlighted when hovering the mouse above then I'd say that Squishy is working fine and it must be something else. Hm.
Now this is what I call a service. Mod author knows what I'm about to suggest before I even manage to hit the boards ;).
kk Ill try this at home today. If its AH - then I suppose that AceHealSquishy code need to be rewriten if it prevents from clicktargeting