Is this all that is needed to get clique to register plus healing with bonus scanner installed?
Second, in reference to the emergencyHeal function...
It seems that when I use this and it attempts to cast on a lower level target (using regrowth o na 56 druid and the target was a 42 rogue) it would reject the spell because the target was too low a level.
I don't really consider the second as a bug because the code as written is working as it should (casting the best rank spell to cover the highest posible damage to the unit). I could simply bind a secondary click to use max rank of regrowth. That and in a real sense, you would not be grouping with characters that low of a level (I consider this function more of an end level ability).
just wanted to bring that up as part of my on-going testing :D
Yeah, I've considered removing Regrowth, its the only spell that also has level requirements, buyt I could just fix the HS code too. I'll see what I can do.
I didn't see anything on the wowinterface.com introduction page or FAQ regarding the use of Clique with PerfectRaid, Squishy, and oRA_MainTankFrames. When I ctrl+right click nothing happens. (I set alt, ctrl, and shift right click to renew/flash/greater heal)
Is there something I missed? I like the idea of being able to maintain my target on the maintank while casting a heal on another raid member if necceary via PerfectRaid, Squishy, or another tank on the oRA_MainTankFrames.
I didn't see anything on the wowinterface.com introduction page or FAQ regarding the use of Clique with PerfectRaid, Squishy, and oRA_MainTankFrames. When I ctrl+right click nothing happens. (I set alt, ctrl, and shift right click to renew/flash/greater heal)
Is there something I missed? I like the idea of being able to maintain my target on the maintank while casting a heal on another raid member if necceary via PerfectRaid, Squishy, or another tank on the oRA_MainTankFrames.
Thank you.
They all work just fine. Scroll to your load messages and verify that Clique is loading, and loading the plugins for those addons
Just wanted to say up front Clique is great and a wonderful next step in click casting.
I have made a few tweaks the code however. Mostly very minor stuff.
1. Most unit frame addons that have custom menus like say oUF check for thier default keybinding. In the case of oUF the click event looks for alt-right mousebutton I belive. Since it's oUF that I'm currently using I addined the below line to the Plugin:Enable of Clique_oUF.lua
Clique:RegisterCustomFunction("oUF.dew:Open(oUF.frames[Clique.unit])", "oUF.dew:Open(oUF.frames[Clique.unit])", "Open the oUF Options menu.")
This makes it very easy to rebind the config menu of oUF to my button binding. IMHO a good option for any UnitFrame that has a custom menu done like oUF.
2. I was a bit confused when trying to bind custom events in Clique_HealSelect. Dumb me didn't realise that you aborted casting the heal if the unit was at full health. On top of that I choose to bind to alt-right mouse and the config menu for oUF was poping up so it looked to me like my binding wasn't working when testing it on myself sitting in the inn. Thus the next change. Down around line 185 I changed the if deficit == 0 then block to
if deficit == 0 then
self:LevelDebug(1, "Not casting %s Heal. %s is at full health.",type , UnitName(unit))
return true
end
This way I always get a message that the heal was aborted due to the unit being at full heal and changed the return from nil to true so the default unit frame action doesn't happen. After all I don't want config menus poping up in the middle of a fight cause I clicked on someone with full health by mistake, say someone else just hit them with a full heal.
3. Next I added a check for free many buffs at line 195 I change to
if entry.mana <= cur_mana and not Clique:IsBuffActive("Inner Focus", "player") then
Note this is totaly untested at this point and probably not the best way to do this but you get the idea. If the spell isn't going to cost any mana than you can bypass the mana check.
4. Cause I'l very forgetful I also add the below to the onEnable event.
Clique:RegisterCustomFunction("Clique:EfficientHeal()", "Clique:EfficientHeal()", "Cast Efficient Heal the unit you clicked on.")
Clique:RegisterCustomFunction("Clique:EmergencyHeal()", "Clique:EmergencyHeal()", "Cast Emergency Heal the unit you clicked on.")
I know you stated you are unsure if you wanted to make accesing these so easy but hey while I was there I did it for myself :) That way I don't need to open the code back up every time I forget the exact sytax of the functions.
1. Most unit frame addons that have custom menus like say oUF check for thier default keybinding. In the case of oUF the click event looks for alt-right mousebutton I belive. Since it's oUF that I'm currently using I addined the below line to the Plugin:Enable of Clique_oUF.lua
Clique:RegisterCustomFunction("oUF.dew:Open(oUF.frames[Clique.unit])", "oUF.dew:Open(oUF.frames[Clique.unit])", "Open the oUF Options menu.")
This makes it very easy to rebind the config menu of oUF to my button binding. IMHO a good option for any UnitFrame that has a custom menu done like oUF.
I like this, and if you want to commit it to the svn i'll gladly take it. Unfortunately I don't use all unit frames, and I can't hunt for all the menus.. but this is definitely the best way to make this work.
2. I was a bit confused when trying to bind custom events in Clique_HealSelect. Dumb me didn't realise that you aborted casting the heal if the unit was at full health. On top of that I choose to bind to alt-right mouse and the config menu for oUF was poping up so it looked to me like my binding wasn't working when testing it on myself sitting in the inn. Thus the next change. Down around line 185 I changed the if deficit == 0 then block to
if deficit == 0 then
self:LevelDebug(1, "Not casting %s Heal. %s is at full health.",type , UnitName(unit))
return true
end
This way I always get a message that the heal was aborted due to the unit being at full heal and changed the return from nil to true so the default unit frame action doesn't happen. After all I don't want config menus poping up in the middle of a fight cause I clicked on someone with full health by mistake, say someone else just hit them with a full heal.
This is consistent with how Clique should operate, and I realized that it probably needs to be updated for BestRank() and NewSpell() to return true if it gets to that point (since the user has made a decision to click-cast instead of take a default action). Again, if you want to commit I'd appreciate it.
3. Next I added a check for free many buffs at line 195 I change to
if entry.mana <= cur_mana and not Clique:IsBuffActive("Inner Focus", "player") then
Note this is totaly untested at this point and probably not the best way to do this but you get the idea. If the spell isn't going to cost any mana than you can bypass the mana check.
Yeah, I forgot about Inner Focus, and that makes sense. Again I don't use HealSelect so I'd miss stuff like this =). If we localise "Inner Focus" and "Clearcasting" then I think that would cover these, and is probably a good addition. Again if you want to make the changes you can, just let me know.
4. Cause I'l very forgetful I also add the below to the onEnable event.
Clique:RegisterCustomFunction("Clique:EfficientHeal()", "Clique:EfficientHeal()", "Cast Efficient Heal the unit you clicked on.")
Clique:RegisterCustomFunction("Clique:EmergencyHeal()", "Clique:EmergencyHeal()", "Cast Emergency Heal the unit you clicked on.")
I know you stated you are unsure if you wanted to make accesing these so easy but hey while I was there I did it for myself :) That way I don't need to open the code back up every time I forget the exact sytax of the functions.
Ok, I'll relent and let these in here.
I've only got a few minor changes before CLique is going gold.
a.) There will be a way to add headers to dewdrop, so it'll show the plugin specific things under specific headers
b.) I need to figure out how to get tooltips working for the dewdrop menus, anyone have any ideas for this? When you mouseover an item the context help in the tooltip should show up.
c.) Figure out how I'm going to package it, and get some memory benchmarks
Thanks for looking at it. As you know well, maintaining the plugins is a HUGE pain in the ass, but I'm trying to convert as many authors as possible over to the CTRA click-function style.
Clad that's great to hear about the heal right click menu functions, I had already added those to my own version and am glad I won't have to always worry about adding them.
Thank you also for Target and Assist in the menu!
I had also added FollowUnit, I think from Clique, but it might have been WatchDog.
Any hope for a bandage function before going gold? Thats the only bit of functionality I'm still using from Watchdog.
great mod :)
the newest x-perl versions (1.7.0 or newer) require a little change made to the xperl plugin, since X-Perl's author changed the CustomClickFunction
Line 28 from:
Perl_CustomClickFunction = self.OnClick
to:
Perl_Custom_ClickFunction = self.OnClick
and line 35 from:
Perl_CustomClickFunction = nil
to:
Perl_Custom_ClickFunction = nil
Just wanted to wrap up that clique has been working for me on my druid withut a single error and without lag ot memory usage climbing too high (still a tad, only a tad however, high on memory usage but it does so much I am not complaining!!)
Efficient and emergency heal work flawlessly and the code Kyahx "discovered" for bonus scanner make +healing work as well.
Discord, ctra, squishy and the default frames all work without a hitch.
hostile click casting works great (I so love this)
Targeting on ToT no longer forces switching of targets. Using a selfcast mod will however sometimesdo this but THAT IS NOT CLIQUE'S FAULT.
the self output for casting with efficent and emergency healing are exactly what I hoped. Hopefully the "debug 1" line will be removed on release, if not it does not matter.
Aside from Regrowth, "use max rank" works perfectly on all levels.
I am actually starting to like the wizard bunny :P
So all in all, I would say this is ready for "prime time" from a druid standpoint ;)
One last thing I either need to test or request is when using cureany that it reports on the casting spell and who it is casting on. Going to check that today (would need validation that the cure function is working)
Rasapian: The debug messages (as well as the load spam) will be off by default in the first "release" candidate of Clique. I assume there will be an option (most likely a slash command, as most people won't touch it) to turn the debugging messages back on for people who love chat-spam from the HealSelect.
lol I like the spam from healselect, lets me know what rank I am casting. Just wondered ifthe word "debug" will be in the release on the healselect code is all.
First, Kyahx, in your example for declaring the variable for plus healing:
This is my code in a custom binding:
Is this all that is needed to get clique to register plus healing with bonus scanner installed?
Second, in reference to the emergencyHeal function...
It seems that when I use this and it attempts to cast on a lower level target (using regrowth o na 56 druid and the target was a 42 rogue) it would reject the spell because the target was too low a level.
I don't really consider the second as a bug because the code as written is working as it should (casting the best rank spell to cover the highest posible damage to the unit). I could simply bind a secondary click to use max rank of regrowth. That and in a real sense, you would not be grouping with characters that low of a level (I consider this function more of an end level ability).
just wanted to bring that up as part of my on-going testing :D
Yep, that should be all you have to do. :)
I love this mod :D
MarsRaid Bug
It's using latest from SVN.
Is there something I missed? I like the idea of being able to maintain my target on the maintank while casting a heal on another raid member if necceary via PerfectRaid, Squishy, or another tank on the oRA_MainTankFrames.
Thank you.
They all work just fine. Scroll to your load messages and verify that Clique is loading, and loading the plugins for those addons
Just wanted to say up front Clique is great and a wonderful next step in click casting.
I have made a few tweaks the code however. Mostly very minor stuff.
1. Most unit frame addons that have custom menus like say oUF check for thier default keybinding. In the case of oUF the click event looks for alt-right mousebutton I belive. Since it's oUF that I'm currently using I addined the below line to the Plugin:Enable of Clique_oUF.lua
Clique:RegisterCustomFunction("oUF.dew:Open(oUF.frames[Clique.unit])", "oUF.dew:Open(oUF.frames[Clique.unit])", "Open the oUF Options menu.")This makes it very easy to rebind the config menu of oUF to my button binding. IMHO a good option for any UnitFrame that has a custom menu done like oUF.2. I was a bit confused when trying to bind custom events in Clique_HealSelect. Dumb me didn't realise that you aborted casting the heal if the unit was at full health. On top of that I choose to bind to alt-right mouse and the config menu for oUF was poping up so it looked to me like my binding wasn't working when testing it on myself sitting in the inn. Thus the next change. Down around line 185 I changed the if deficit == 0 then block to
if deficit == 0 then self:LevelDebug(1, "Not casting %s Heal. %s is at full health.",type , UnitName(unit)) return true endThis way I always get a message that the heal was aborted due to the unit being at full heal and changed the return from nil to true so the default unit frame action doesn't happen. After all I don't want config menus poping up in the middle of a fight cause I clicked on someone with full health by mistake, say someone else just hit them with a full heal.3. Next I added a check for free many buffs at line 195 I change to
if entry.mana <= cur_mana and not Clique:IsBuffActive("Inner Focus", "player") thenNote this is totaly untested at this point and probably not the best way to do this but you get the idea. If the spell isn't going to cost any mana than you can bypass the mana check.4. Cause I'l very forgetful I also add the below to the onEnable event.
Clique:RegisterCustomFunction("Clique:EfficientHeal()", "Clique:EfficientHeal()", "Cast Efficient Heal the unit you clicked on.") Clique:RegisterCustomFunction("Clique:EmergencyHeal()", "Clique:EmergencyHeal()", "Cast Emergency Heal the unit you clicked on.")I know you stated you are unsure if you wanted to make accesing these so easy but hey while I was there I did it for myself :) That way I don't need to open the code back up every time I forget the exact sytax of the functions.Is there a way to go around it?
I like this, and if you want to commit it to the svn i'll gladly take it. Unfortunately I don't use all unit frames, and I can't hunt for all the menus.. but this is definitely the best way to make this work.
This is consistent with how Clique should operate, and I realized that it probably needs to be updated for BestRank() and NewSpell() to return true if it gets to that point (since the user has made a decision to click-cast instead of take a default action). Again, if you want to commit I'd appreciate it.
Yeah, I forgot about Inner Focus, and that makes sense. Again I don't use HealSelect so I'd miss stuff like this =). If we localise "Inner Focus" and "Clearcasting" then I think that would cover these, and is probably a good addition. Again if you want to make the changes you can, just let me know.
Ok, I'll relent and let these in here.
I've only got a few minor changes before CLique is going gold.
a.) There will be a way to add headers to dewdrop, so it'll show the plugin specific things under specific headers
b.) I need to figure out how to get tooltips working for the dewdrop menus, anyone have any ideas for this? When you mouseover an item the context help in the tooltip should show up.
c.) Figure out how I'm going to package it, and get some memory benchmarks
Thanks for looking at it. As you know well, maintaining the plugins is a HUGE pain in the ass, but I'm trying to convert as many authors as possible over to the CTRA click-function style.
Thank you also for Target and Assist in the menu!
I had also added FollowUnit, I think from Clique, but it might have been WatchDog.
Any hope for a bandage function before going gold? Thats the only bit of functionality I'm still using from Watchdog.
the newest x-perl versions (1.7.0 or newer) require a little change made to the xperl plugin, since X-Perl's author changed the CustomClickFunction
Line 28 from:
Perl_CustomClickFunction = self.OnClick
to:
Perl_Custom_ClickFunction = self.OnClick
and line 35 from:
Perl_CustomClickFunction = nil
to:
Perl_Custom_ClickFunction = nil
A happy clique user :)
Efficient and emergency heal work flawlessly and the code Kyahx "discovered" for bonus scanner make +healing work as well.
Discord, ctra, squishy and the default frames all work without a hitch.
hostile click casting works great (I so love this)
Targeting on ToT no longer forces switching of targets. Using a selfcast mod will however sometimesdo this but THAT IS NOT CLIQUE'S FAULT.
the self output for casting with efficent and emergency healing are exactly what I hoped. Hopefully the "debug 1" line will be removed on release, if not it does not matter.
Aside from Regrowth, "use max rank" works perfectly on all levels.
I am actually starting to like the wizard bunny :P
So all in all, I would say this is ready for "prime time" from a druid standpoint ;)
One last thing I either need to test or request is when using cureany that it reports on the casting spell and who it is casting on. Going to check that today (would need validation that the cure function is working)