to remove the diminishing return from the tooltip you just have to change the text in the lua-file.
the other problem is: honor is still calculated by the glory-lib, which still calculates
with the diminishing return.
Right, but only when the honor gain is being printed I believe. The tooltip and fubar honor value is taken directly from your actual honor total as reflected on the pvp character sheet. That's an api function Blizz added in 2.4. To change how glory works is an entirely different project I don't want to mess with. I will however try removing that info from the lua file.
EDIT: Upon further testing, I got honorfuplus and Mendeleev working together. I am at a loss to explain why it works fine on one computer, and not on another. :( *makes note to test further*
Sorry to bother you with spurious bug reports ><
Spy
*peeks his head in*
Hey all... I hate popping in with such a bizzare issue. But I hope someone in here can offer some insight. I use both honorfuplus and an addon called Mendeleev. After an evening of turning each of my addons on and off in turn, I finally nailed down a bug I am having, in Mendeleev. Disabling Honorfuplus returns everything to perfect working order.
http://www.wowace.com/forums/index.php?topic=13270.0 That's the thread in which I outline the Mendeleev issue. In short, the problem is that Mendeleev hooks a tooltip with extra info about materials. When Honorfu is disabled, everything works perfectly. When enabled, Mendeleev starts adding a linebreak where it shouldn't. I have no idea why that happens... I've stared at the code, but i'm not a good coder at all... Totally lost as to where this bug crawls in.
The steps to reproduce were simple, run HonorFu + Mendeleev. Happened every time, as in the attached screenshot.
Hope someone can give an idea, I would hate doing without either of these wonderful addons :)
Love this mod, just one small request, could you have it display the estimated arena points? Would be realy handy :)
I can look at it, but that one might be way over my head. In the meantime, there is a nice non-Ace mod I can suggest called ArenaCalculator. You can download it from Curse.
I looked and hopefully didn't just miss the option, but could we have an option to show specific marks on the bar? Like something like [markicon] (number on character/in bank)
I looked and hopefully didn't just miss the option, but could we have an option to show specific marks on the bar? Like something like [markicon] (number on character/in bank)
If I can adapt it into HonorFuPlus at some point I will give it a try. Until then, try MarkofHonorFu.
Seems like the Kills-Deaths part isn't working. When I die it's never updated. So right now(according to HonorFuPlus) I have a flawless record of kills-deaths: 143-0(100%)
Seems like the Kills-Deaths part isn't working. When I die it's never updated. So right now(according to HonorFuPlus) I have a flawless record of kills-deaths: 143-0(100%)
I will have to look at the code, that and the recorded losses seems to be an issue. If anyone else sees the problem, feel free to post the fix and I will add it to the code.
In the meantime, putting a new build up that includes French localization. Thank you to Sanka for the help.
Seems like the Kills-Deaths part isn't working. When I die it's never updated. So right now(according to HonorFuPlus) I have a flawless record of kills-deaths: 143-0(100%)
With the upcoming changes to the Wowace repository, I am starting to update HonorFuPlus on CurseForge as well. New build went up today. You can now toggle showing the various Marks of Honor totals on the FuBar. I hope to make them colorful using Crayon, but it is taking me some time to figure it out. Till then, enjoy.
Can you please add a "X horde vs. Y ally" info to tooltip?
Errors after update today, deDE client:
[2008/07/24 22:57:18-1638-x1]: FuBar_HonorFuPlus-2.0\HonorFuPlusLocale-deDE.lua:3: AceLocale(FuBar_HonorFuPlus): Can only accept true as a value on the base locale. "enUS" is the base locale, "deDE" is not.
[2008/07/24 22:57:18-1638-x1]: FuBar_HonorFuPlus-2.0.79057\HonorFuPlus.lua:340: AceConsole-2.0: args.WSGMarks: "desc" must be a string
[2008/07/24 22:57:18-1638-x1]: FuBar_HonorFuPlus-2.0.79057\HonorFuPlus.lua:185: AceEvent-2.0: Cannot register event "PLAYER_DEAD" to method "PLAYER_DEAD", it does not exist
Also, what are you looking for? How many are playing on each side?
Yes please put this in and an option to show it in the FuBar and or Tooltip
I play on a RP-PvP realm with a 2:1 Horde Ally Ration an often in the BG there are 15 Horde and only 4 Ally in so with this I can see with one look that Ally have no chance.
the other problem is: honor is still calculated by the glory-lib, which still calculates
with the diminishing return.
Right, but only when the honor gain is being printed I believe. The tooltip and fubar honor value is taken directly from your actual honor total as reflected on the pvp character sheet. That's an api function Blizz added in 2.4. To change how glory works is an entirely different project I don't want to mess with. I will however try removing that info from the lua file.
Sorry to bother you with spurious bug reports ><
Spy
*peeks his head in*
Hey all... I hate popping in with such a bizzare issue. But I hope someone in here can offer some insight. I use both honorfuplus and an addon called Mendeleev. After an evening of turning each of my addons on and off in turn, I finally nailed down a bug I am having, in Mendeleev. Disabling Honorfuplus returns everything to perfect working order.
http://www.wowace.com/forums/index.php?topic=13270.0 That's the thread in which I outline the Mendeleev issue. In short, the problem is that Mendeleev hooks a tooltip with extra info about materials. When Honorfu is disabled, everything works perfectly. When enabled, Mendeleev starts adding a linebreak where it shouldn't. I have no idea why that happens... I've stared at the code, but i'm not a good coder at all... Totally lost as to where this bug crawls in.
The steps to reproduce were simple, run HonorFu + Mendeleev. Happened every time, as in the attached screenshot.
Hope someone can give an idea, I would hate doing without either of these wonderful addons :)
Spy
I can look at it, but that one might be way over my head. In the meantime, there is a nice non-Ace mod I can suggest called ArenaCalculator. You can download it from Curse.
If I can adapt it into HonorFuPlus at some point I will give it a try. Until then, try MarkofHonorFu.
I will have to look at the code, that and the recorded losses seems to be an issue. If anyone else sees the problem, feel free to post the fix and I will add it to the code.
In the meantime, putting a new build up that includes French localization. Thank you to Sanka for the help.
Fixed in GloryLib r78468. Please update.
Awesome.
Can you please add a "X horde vs. Y ally" info to tooltip?
Errors after update today, deDE client:
Also, what are you looking for? How many are playing on each side?
Yes :D
Yes please put this in and an option to show it in the FuBar and or Tooltip
I play on a RP-PvP realm with a 2:1 Horde Ally Ration an often in the BG there are 15 Horde and only 4 Ally in so with this I can see with one look that Ally have no chance.