Authors CurseForge

Hey y'all. This isn't a complete rewrite or anything. The addon is completely ckknight's code with some slight additions. Included are:

* honor calculates dynamically and gives you an exact total as currency
* arena points display in the mouseover tooltip
* Battleground Marks of Honor display on mouseover including banked totals
* added toggle to show arena points on the fubar
* Added ability to toggle character pvp frame on click

You can get the latest version from the WoWAceUpdater and the SVN.

Honor total on the bar isn't getting updated when you spend honor.

Otherwise, nicely tweaked :)

Quote from Tenz »

Honor total on the bar isn't getting updated when you spend honor.

Otherwise, nicely tweaked :)

Hrmm. Figured it would update like it does in Battlegrounds. I will look at it.

Is this supposed to require Fubar_HonorFu enabled? It doesn't do anything for me unless I enable that as well.

Quote from phosdex »

Is this supposed to require Fubar_HonorFu enabled? It doesn't do anything for me unless I enable that as well.

No this addon is standalone. Make sure you have it enabled in your Fubar settings.

Quote from krevlorn »

No this addon is standalone. Make sure you have it enabled in your Fubar settings.

That is not the issue. It is enabled, but has no tooltip and only has the standard "show icon, show text, etc" right-click menu. I just deleted everything to do with fubar_honorfu* and am still seeing this.

Just to make sure I just deleted them all again and it still has no tooltip and gives the standard fubar right-click options.

Quote from phosdex »

That is not the issue. It is enabled, but has no tooltip and only has the standard "show icon, show text, etc" right-click menu. I just deleted everything to do with fubar_honorfu* and am still seeing this.

Just to make sure I just deleted them all again and it still has no tooltip and gives the standard fubar right-click options.

I'm not sure what's wrong then. Mine is working ok and my guildmates aren't having any issue like that. Any idea if you are getting some kind of lua error?

The download is missing required libraries (it has none). Separately installing LibBabble-Class-3.0 got it working for me. There might be others required, which I happen to have loading in other mods already, so those aren't erroring out on me.

When that's fixed it'll be great, I hated using both HonorFu and PvpFu when they should have been one mod already! Figure out a way to get the essential features of BattlegroundFu and ReportAfkFu in there and more cheers for you!

I did a German translation and some small tweaks to make it work on other languages as well:

first change line 591 to 609 in the HonorFuPlus.lua to this:

cat:AddLine(
		'text', L["Arathi Basin Marks:"],
		'text2', GetItemCount(L["Arathi Basin Mark of Honor"], true)
	)
	
	cat:AddLine(
		'text', L["Alterac Valley Marks:"],
		'text2', GetItemCount(L["Alterac Valley Mark of Honor"], true)
	)
	
	cat:AddLine(
		'text', L["Eye of the Storm Marks:"],
		'text2', GetItemCount(L["Eye of the Storm Mark of Honor"], true)
	)
	
	cat:AddLine(
		'text', L["Warsong Gulch Marks:"],
		'text2', GetItemCount(L["Warsong Gulch Mark of Honor"], true)
	)

then add the following lines to the HonorFuPlusLocale-enUS.lua:

["Arathi Basin Mark of Honor"] = true,
["Alterac Valley Mark of Honor"] = true,
["Eye of the Storm Mark of Honor"] = true,
["Warsong Gulch Mark of Honor"] = true

and finally put the attached file into the Fubar_HonorFuPlus folder.

Quote from AgentRocket »

I did a German translation and some small tweaks to make it work on other languages as well:

first change line 591 to 609 in the HonorFuPlus.lua to this:

cat:AddLine(
		'text', L["Arathi Basin Marks:"],
		'text2', GetItemCount(L["Arathi Basin Mark of Honor"], true)
	)
	
	cat:AddLine(
		'text', L["Alterac Valley Marks:"],
		'text2', GetItemCount(L["Alterac Valley Mark of Honor"], true)
	)
	
	cat:AddLine(
		'text', L["Eye of the Storm Marks:"],
		'text2', GetItemCount(L["Eye of the Storm Mark of Honor"], true)
	)
	
	cat:AddLine(
		'text', L["Warsong Gulch Marks:"],
		'text2', GetItemCount(L["Warsong Gulch Mark of Honor"], true)
	)

then add the following lines to the HonorFuPlusLocale-enUS.lua:

["Arathi Basin Mark of Honor"] = true,
["Alterac Valley Mark of Honor"] = true,
["Eye of the Storm Mark of Honor"] = true,
["Warsong Gulch Mark of Honor"] = true

and finally put the attached file into the Fubar_HonorFuPlus folder.

Thanks! I will add that to the next build. I also need to get my head around adding the libraries too, sorry bout that, I'm a noob to the SVN.

Couple changes:

-fixed honor updating after purchases
-added code referenced above to make it play nice with other languages

Quote from krevlorn »

Couple changes:

-fixed honor updating after purchases
-added code referenced above to make it play nice with other languages

..
I fixed your externals. among other things.

Quote from break19 »

..
I fixed your externals. among other things.

Thanks, what was I doing wrong?

You mean besides not ever editing them? heh

you never set any externals for SVN..
http://www.wowace.com/wiki/SVN_For_Idiots#How_to_set_externals

That link provides ways of how to set up externals.

Just placing them into the .toc file does -nothing- for the files.wowace.com package generator... that operates purely on the SVN properties.

placing the embeds into the .toc file only allows supporting updaters to properly select and download the libraries that the addon needs to run properly.

Also, only place actual addon names into X-Embeds and OptDeps.. oh, and be sure to -only- put the things the addon needs to function into X-Embeds and Dependencies. FuBar plugins, contrary to what some think, actually -do- work without fubar.

OptDeps are for optional addons, libs that should be loaded (IF they exist) to allow the addon to access their features, but the addon will run without them (the exception to this rule is that anything in X-Embeds should also be in optDeps, so they'll be sure to be loaded when the addon needs them.

break19

Ok even with Break19's changes, it still does not work for me unless FuBar_HonorFu is enabled as well.

So I went through these files in HonorFuPlus:
embeds.xml - changed to exactly the same as HonorFu
FuBar_HonorFu.toc - changed OptionalDeps and X-Embeds to exactly the same as HonorFu.

I then went into the libs folder and made that exactly the same as HonorFu.

It now works.

Quote from break19 »

You mean besides not ever editing them? heh

you never set any externals for SVN..
http://www.wowace.com/wiki/SVN_For_Idiots#How_to_set_externals

That link provides ways of how to set up externals.

Just placing them into the .toc file does -nothing- for the files.wowace.com package generator... that operates purely on the SVN properties.

placing the embeds into the .toc file only allows supporting updaters to properly select and download the libraries that the addon needs to run properly.

Also, only place actual addon names into X-Embeds and OptDeps.. oh, and be sure to -only- put the things the addon needs to function into X-Embeds and Dependencies. FuBar plugins, contrary to what some think, actually -do- work without fubar.

OptDeps are for optional addons, libs that should be loaded (IF they exist) to allow the addon to access their features, but the addon will run without them (the exception to this rule is that anything in X-Embeds should also be in optDeps, so they'll be sure to be loaded when the addon needs them.

break19

Thanks for the help, break19. I appreciate it. Now work on your constructive criticism. I am a beginner at working with the SVN and your superior knowledge doesn't give you the right to belittle. Most of what I was working with was existing code aside from a few additions. If there was anything added or incorrect, it resided in the original coding of the addon.

Anyways, I still appreciate the help.

Quote from Sai »

The download is missing required libraries (it has none). Separately installing LibBabble-Class-3.0 got it working for me. There might be others required, which I happen to have loading in other mods already, so those aren't erroring out on me.

When that's fixed it'll be great, I hated using both HonorFu and PvpFu when they should have been one mod already! Figure out a way to get the essential features of BattlegroundFu and ReportAfkFu in there and more cheers for you!

Thanks to break19 for pointing out and editing my errors, libraries should be working correctly.

I will take a glance at BattlegroundFu and ReporttAfkFu and see what I can do.

While you're playing around, if you could make HonorFuPlus show the team sizes on the FuBar it would put a big grin on my face :D

"superior knowledge" ? Uhh.. dude? I've written a total of 3 small addons.. 2 of which were simple fubar plugins..

the difference is, I guess, I took the time to read the svn for idiots thing before I began using it. heh

now, as far as my manner goes? I dont give a rats behind about "political correct" BS.. I guess it's the "no bullshit truck driver" thing... i say whats on my mind. I have no intentions to insult anyone...

however, if your mental constitution is such that reading words on a website forum hurts your feelings, you have other, more pressing issues to deal with.

break19

you forgot to include the HonorFuPlusLocale-deDE.lua in the toc-file.
please add it, so that it will work on German Clients