I (and many others) run disembedded. I already have ItemSync (and KCI), yet I had to download ItemPrice-1.0 as it's listed as required. Otherwise, I would not have it running on my system with other mods that do the same thing.
I have nothing against ItemPrice. No one here does. But the fact of the matter is that there are already other mods out there that do this function. I'm not saying that one is better than the other, but there it is. And GarbageFu supported them. And GarbageFu didn't require that prices be known for the items you were dropping as garbage. For some features of GarbageFu, yes, it's necessary to know an item price. But if you choose to use those features, then at least use what's already installed in your client. Added ItemPrice support is great - but forcing it to be the only option and forcing it be installed isn't so great.
I get this error when I log in:
[2007/07/21 20:25:56-30-x1]: FuBar_GarbageFu-2.0.44433\GarbageFu_Vendor.lua:282: attempt to index field '?' (a nil value)
<in C code>: ?
AceEvent-2.0-40601 (Ace2):329: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:310>
After the recent update, I found out that there are locale files while there are no traditional chinese support. I can't help with those huge translation and could somebody who can? I have to use the older version since the newest doesn't sell items anymore after the error caused.
I have to agree with the others here that the use of ItemPrice should not be forced and only included as on optionaldep. Not quite sure what the problem is/was with the getsellvalue api code, I have been running perfect with it on mine and several other guild members' PCs ever since I posted the change.
Every single attempt at adding GetSellValue API or ItemPrice support to this addon has resulted in people getting errors (but not all). The problem is that there are implicit assumptions in the existing code (i.e. it is poorly written), that leads to problems in some cases when the user already has a set of saved variables. A specific example is the function GarbageFu:InitVendorAddonOrder(), where the saved list of vendor price addons order is traversed in a complex way together with the new hardcoded list of supported addons. When a new vendor price addon is added to the list, a potential nil indexing to an array happens, depending on what addons the user currently has saved in the vendor price addons order list.
There are only two ways to fix this:
1) Someone fixes this code. I believe there are other places in the code with similar problems.
2) The user deletes the saved variables file for this addon, effectively wiping out all settings, including the vendor price addons order list, causing the problems.
Having used this mod for quite some time, I was quite pleased when I updated it the other day and it not only had an update, but for the first time ever GarbageFu did not try selling BC quest items and gave an accurate total for what was sold. Now, today, I load up WoW with all my addons turned on to check and make sure the one I'm writing isn't conflicting with anything, and this starts throwing errors. Normally, it wouldn't bother me as much, but coffee isn't quite cutting it today.
I understand why the change was made; the change log makes it pretty apparent. What I don't understand, though, is why people were complaining about being "required" to use itemprice.
As you can see:
r44366 | xbeeps | 2007-07-20 18:09:27 -0400 (Fri, 20 Jul 2007) | 2 lines
Changed paths:
M /trunk/FuBar_GarbageFu
M /trunk/FuBar_GarbageFu/FuBar_GarbageFu.toc
M /trunk/FuBar_GarbageFu/GarbageFu.lua
M /trunk/FuBar_GarbageFu/GarbageFu_Vendor.lua
FuBar_GarbageFu:
- Integrated ItemPrice-1.0 as an external, and removed support for external vendor price addons (deprecated). This change has been announced in the wowace forum. For continued support for external vendor price addons, stick to revision 43120.
I mean, really. I did notice some people were having issues with 43120 - I didn't notice any, but you know, you can always revert to 36604 (found here: http://files.wowace.com/FuBar_GarbageFu/), which is effectively what everyone's been using for months. Normally, I wouldn't say anything about something like this, but crankysaurus rex is me.
Both this and tradeskillinfo (great addons, btw) were written by the same guy. I have nothing against him, but the way he wrote both of these addons is... possibly not the most optimal way they could have been written. I mean, it may make perfect sense to him and be 100% crystal clear, but I'm kinda dense.
So, if this is anything like TSI, I'm sure updating this isn't exactly the easiest thing - that might explain why there hasn't been a meaningful update (ie, other than toc changes, library updates, or other cosmetic, superficial changes) in several months. I'm rambling now.
I originally was going to come to this thread to suggest someone add the following(so the fubar plugin could be hidden without turning it off),
Will deleting the saved vars for GarbageFu fix it? I don't have that many settings in my profiles, so "starting over" isn't that big a deal for me -- if that solves the problem.
Will deleting the saved vars for GarbageFu fix it? I don't have that many settings in my profiles, so "starting over" isn't that big a deal for me -- if that solves the problem.
That worked for me. Disregard my initial crankiness. Mornings > Me.
Deleting saved vars for GarbageFu got rid of error.
But, now there are no profiles in GarbageFu??? When did that happen? I don't want all my chars to have the same keep lists. Different professions, weapons, skills, etc. all means to me that different chars should be dropping different things.
@Samala: profiles? nothing has changed in that department. Compared 36604 i've only added an entry to a table, a helper function and added ItemPrice-1.0 and ItemPriceToolTip as an optional dependency. Because of the weird way people want this addon to work, every single addon that will use ItemPrice-1.0 in the future has to be added to the list of optional dependencies for proper operation. Huzzah!
Thanks for updating this one xbeeps. Have you considered forking the orginal version you made? I'm guessing GarbageFU takes up less mem without support for external vendor addons.
While the option for profiles may not exist on the dewdrop menu, it does still save settings per character... since I've had to continually disable "show text" on various alts.
Just a quick question, why do all the addons that use ItemPrice need to be optionaldeps when ItemPrice is providing the GetSellValue function.
Because ItemPrice needs to be loaded before GarbageFu. There's an optional dependency for ItemPrice-1.0, but that will only be in effect if the user has ItemPrice-1.0 as a standalone library (which you cannot assume by any means). ItemPriceTooltip is then also included as an optional dep, because that embeds ItemPrice-1.0, and effectively forcing ItemPriceTooltip to load before GarbageFu will also force ItemPrice-1.0 to load first. However, if the user has ItemPrice-1.0 only embedded in an arbitrary addon, let's call it XYZ, then GarbageFu must list XYZ as an optional dependency to force XYZ to load first, and in turn load ItemPrice.
Libraries like ItemPrice-1.0 are not meant to be used the way GarbageFu uses them currently, but this is the way it has to be, because freedom must be preserved.
Libraries like ItemPrice-1.0 are not meant to be used the way GarbageFu uses them currently, but this is the way it has to be, because freedom must be preserved.
My question is this, I personally use Itemprice and Itempricetooltip, but if alot of people are so upset about the changes that was made, can you not just rename this to something else, give the original author credit and then continue down the path you was headed and let those that didn't like the changes use the original GarbageFU and those of us that are indifferent or liked the changes to use your version?
Because I really don't care what the name is or who the author is, if you change the name and continue updating your version, then I will use yours...if in the future something better is released then I will use it...simple as that.
My question is this, I personally use Itemprice and Itempricetooltip, but if alot of people are so upset about the changes that was made, can you not just rename this to something else, give the original author credit and then continue down the path you was headed and let those that didn't like the changes use the original GarbageFU and those of us that are indifferent or liked the changes to use your version?
Because I really don't care what the name is or who the author is, if you change the name and continue updating your version, then I will use yours...if in the future something better is released then I will use it...simple as that.
Long sorry,
I agree. I liked the new ItemPrice version and as such will not update GarbageFu now because that change has been reverted. If this method can't co-exist with the former implementation, then I believe it warrants its own separate addOn.
I did a full rename before reverting earlier (to Fubar_TrashFu), which is the version i use myself. I have been hesitant to upload it because i don't want to further develop it or provide support for it (i got enough work already). I'll consider putting it on SVN anyway.
-
View User Profile
-
View Posts
-
Send Message
Curse PremiumI have nothing against ItemPrice. No one here does. But the fact of the matter is that there are already other mods out there that do this function. I'm not saying that one is better than the other, but there it is. And GarbageFu supported them. And GarbageFu didn't require that prices be known for the items you were dropping as garbage. For some features of GarbageFu, yes, it's necessary to know an item price. But if you choose to use those features, then at least use what's already installed in your client. Added ItemPrice support is great - but forcing it to be the only option and forcing it be installed isn't so great.
[2007/07/21 20:25:56-30-x1]: FuBar_GarbageFu-2.0.44433\GarbageFu_Vendor.lua:282: attempt to index field '?' (a nil value)
<in C code>: ?
AceEvent-2.0-40601 (Ace2):329: in function <Interface\AddOns\Ace2\AceEvent-2.0\AceEvent-2.0.lua:310>
---
Ivan
There are only two ways to fix this:
1) Someone fixes this code. I believe there are other places in the code with similar problems.
2) The user deletes the saved variables file for this addon, effectively wiping out all settings, including the vendor price addons order list, causing the problems.
I understand why the change was made; the change log makes it pretty apparent. What I don't understand, though, is why people were complaining about being "required" to use itemprice.
As you can see:
I mean, really. I did notice some people were having issues with 43120 - I didn't notice any, but you know, you can always revert to 36604 (found here: http://files.wowace.com/FuBar_GarbageFu/), which is effectively what everyone's been using for months. Normally, I wouldn't say anything about something like this, but crankysaurus rex is me.
Both this and tradeskillinfo (great addons, btw) were written by the same guy. I have nothing against him, but the way he wrote both of these addons is... possibly not the most optimal way they could have been written. I mean, it may make perfect sense to him and be 100% crystal clear, but I'm kinda dense.
So, if this is anything like TSI, I'm sure updating this isn't exactly the easiest thing - that might explain why there hasn't been a meaningful update (ie, other than toc changes, library updates, or other cosmetic, superficial changes) in several months. I'm rambling now.
I originally was going to come to this thread to suggest someone add the following(so the fubar plugin could be hidden without turning it off),
but all this other stuff got me crankier.
What do I have to do to get rid of the error?
Will deleting the saved vars for GarbageFu fix it? I don't have that many settings in my profiles, so "starting over" isn't that big a deal for me -- if that solves the problem.
That worked for me. Disregard my initial crankiness. Mornings > Me.
But, now there are no profiles in GarbageFu??? When did that happen? I don't want all my chars to have the same keep lists. Different professions, weapons, skills, etc. all means to me that different chars should be dropping different things.
Is it just me or is profiles gone?
I don't see Profiles on the GarbageFu options. Attached screenshot.
Looking at my old saved vars profiles were definitely there at some point as I have some in there. Attached old saved vars.
Ivan
Because ItemPrice needs to be loaded before GarbageFu. There's an optional dependency for ItemPrice-1.0, but that will only be in effect if the user has ItemPrice-1.0 as a standalone library (which you cannot assume by any means). ItemPriceTooltip is then also included as an optional dep, because that embeds ItemPrice-1.0, and effectively forcing ItemPriceTooltip to load before GarbageFu will also force ItemPrice-1.0 to load first. However, if the user has ItemPrice-1.0 only embedded in an arbitrary addon, let's call it XYZ, then GarbageFu must list XYZ as an optional dependency to force XYZ to load first, and in turn load ItemPrice.
Libraries like ItemPrice-1.0 are not meant to be used the way GarbageFu uses them currently, but this is the way it has to be, because freedom must be preserved.
A flaw in the embedded libs system? Scandalous!
Because I really don't care what the name is or who the author is, if you change the name and continue updating your version, then I will use yours...if in the future something better is released then I will use it...simple as that.
Long sorry,
I agree. I liked the new ItemPrice version and as such will not update GarbageFu now because that change has been reverted. If this method can't co-exist with the former implementation, then I believe it warrants its own separate addOn.
Cheers for all the work so far. :)
- show total garbage value on FuBar
- hide lowest value item on FuBar
The default behaviour is identical to that from before this change.